Commit Graph

24 Commits

Author SHA1 Message Date
Stig Bjørlykke c00e12fd9d Corrected include guard in packet_list_store.h
svn path=/trunk/; revision=31083
2009-11-26 08:52:44 +00:00
Anders Broman 5fa3b703a9 Use a "String pool" in the new packet list to reduce memory usage.
svn path=/trunk/; revision=30400
2009-10-08 13:57:19 +00:00
Kovarththanan Rajaratnam 4662b8c326 Rename packet_list_dissect_and_cache => packet_list_dissect_and_cache_iter
svn path=/trunk/; revision=29781
2009-09-07 19:50:19 +00:00
Kovarththanan Rajaratnam ff7fda0df5 Track how many const strings we're storing. This is guarded by NEW_PACKET_LIST_STATISTICS
svn path=/trunk/; revision=29775
2009-09-07 17:09:09 +00:00
Kovarththanan Rajaratnam 4fbc99e411 Auto resize non frame_data based columns
svn path=/trunk/; revision=29766
2009-09-07 13:10:59 +00:00
Kovarththanan Rajaratnam 0e5a101815 Fix target of assignment not really an lvalue error
svn path=/trunk/; revision=29743
2009-09-06 12:27:32 +00:00
Kovarththanan Rajaratnam 2ab0685d8a Make sure that we can enable/disable color filtering.
Fixes http://wiki.wireshark.org/Development/OptimizePacketList?action=diff&rev1=11&rev2=12

svn path=/trunk/; revision=29728
2009-09-06 05:49:00 +00:00
Kovarththanan Rajaratnam f493e75db6 Dissect-on-the-fly when we have columns that are empty, i.e. columns containing strings (COL_INFO + friends). This allows us to sort on _all_ columns now.
svn path=/trunk/; revision=29718
2009-09-05 16:35:05 +00:00
Kovarththanan Rajaratnam e1eaab161d Move new_packet_list_dissect() to packet_list_store.c. We need to have it there in order to dissect columns on the fly when we have to sort
svn path=/trunk/; revision=29717
2009-09-05 15:46:47 +00:00
Kovarththanan Rajaratnam fcf25fe42b Get rid of row_data_t
svn path=/trunk/; revision=29711
2009-09-05 13:27:34 +00:00
Kovarththanan Rajaratnam 2d5a1323e1 Make sure that we can resort with an active display filter
svn path=/trunk/; revision=29710
2009-09-05 13:24:16 +00:00
Kovarththanan Rajaratnam 95ddec4d07 Get rid off GtkTreeModelFilter because the time to sort becomes unbearable when combined with GtkTreeSortable. This means that we now track which frames are visible in the our own packet list store. To do so, we now distinguish between physical and visible rows. All frames are added as physical rows. Only those that passes the display filter are marked as visible.
svn path=/trunk/; revision=29705
2009-09-05 10:36:29 +00:00
Kovarththanan Rajaratnam 314b693828 Rename new_packet_list_reset_dissected to packet_list_reset_dissected
svn path=/trunk/; revision=29699
2009-09-04 17:42:03 +00:00
Kovarththanan Rajaratnam 5a8df08491 Add packet_list_visible_record() to avoid poking PacketListRecord in new_packet_list.c
svn path=/trunk/; revision=29689
2009-09-03 17:39:42 +00:00
Kovarththanan Rajaratnam 8a33ec23bb Allocate and use an extra column at the end of the column list to indicate the 'magic' column which contains the _entire_ PacketListRecord
svn path=/trunk/; revision=29688
2009-09-03 17:00:17 +00:00
Anders Broman cdd2959aa5 Adding new color rules should work now.
svn path=/trunk/; revision=29671
2009-09-02 17:51:48 +00:00
Kovarththanan Rajaratnam 5b3f74f9d5 We no longer store the column text in our record, so don't ever dereference the record column text pointer. In fact, remove it completely. This could cause a crash.
While there, throw in a few g_assert()'s.

svn path=/trunk/; revision=29653
2009-09-01 16:00:56 +00:00
Anders Broman 1108352f00 Use col_text in frame data.
- colum-utils needs more work, based on
 Didier Gautherons optimizations patch http://wiki.wireshark.org/Development/Optimization

svn path=/trunk/; revision=29489
2009-08-21 10:12:47 +00:00
Kovarththanan Rajaratnam c28b654f20 Switch over to using GPtrArray instead of manually g_renew'ing. This switch has some benefits:
1) We don't have to manually resize
2) GPtrArray uses a sligtly more efficient allocation scheme. It increases the size of the array exponentially which reduces the amount of memcpy's we have to do when we resize the array

svn path=/trunk/; revision=29439
2009-08-16 04:08:00 +00:00
Anders Broman ca335d25cb From Kovarththanan Rajaratnam:
- Compute and cache color/custom filters dynamically.
- Delay column construction.

svn path=/trunk/; revision=29370
2009-08-10 20:52:56 +00:00
Anders Broman 3bbe2106c5 From Kovarththanan Rajaratnam:
- Don't issue a row_inserted signal. Rely on our caller to have  
disconnected the model from the view.

-  Removing col_fmt from row_data. It wasn't being used. If we need to store
the column format in the future that should probably be placed in the
PacketList instead of the PacketListRecord
2) Remove double allocation of col_text. Now we allocate it in
new_packet_list_append() and pass it on to packet_list_append_record()
3) Use se_alloc instead of se_alloc0 because we explictly set all the
parameters we use.

svn path=/trunk/; revision=29199
2009-07-26 22:11:46 +00:00
Anders Broman 5fbc5d6f58 From Kovarththanan Rajaratnam:
Only clear packet list store if we need to redissect.

svn path=/trunk/; revision=29195
2009-07-26 10:34:07 +00:00
Anders Broman 052a2b965a Some small fixes from Jakub Zawadzki joined with my efforts
to only store the used columns.

svn path=/trunk/; revision=29065
2009-07-12 09:05:03 +00:00
Stephen Fisher e6d0686f7b Introduce experimental new feature: GTK2 tree view based packet list
To use the GTK2 based packet list, define NEW_PACKET_LIST when compiling.
To do this with gcc, set the environment variable CPPFLAGS to
"-DNEW_PACKET_LIST" and re-run configure.

Many features do not yet work.  This work began with prototypes by Ulf
quite a while back.  I've put quite a bit of work into this so far and
as discussed with a few of the core team members at Sharkfest09 and it was
decided that it would be best to commit what I have so far to allow others to
help work on this.


svn path=/trunk/; revision=28892
2009-06-30 18:05:04 +00:00