Commit graph

134 commits

Author SHA1 Message Date
Stig Bjørlykke
56bf2afc04 Never print x axis values outside the graph (we now have "view as time of day").
Fixed calculating first_interval (the scrollbar issue in bug 1763).

svn path=/trunk/; revision=23989
2008-01-03 01:17:47 +00:00
Stig Bjørlykke
ddac83a322 Initialize io->view_as_time.
svn path=/trunk/; revision=23988
2008-01-02 20:09:20 +00:00
Stig Bjørlykke
cb1448416f Fix a cut'n'paste error for GTK_VERSION < 2 in last commit.
Fixed some indentation.

svn path=/trunk/; revision=23975
2007-12-29 23:20:14 +00:00
Stig Bjørlykke
1776029a7c Add an option to view the X axis as time of day instead of seconds since
start of capture.

svn path=/trunk/; revision=23974
2007-12-29 20:57:15 +00:00
Stig Bjørlykke
69be72052c Add a warning in the IO Graph if too many elements.
svn path=/trunk/; revision=23973
2007-12-29 20:53:10 +00:00
Stig Bjørlykke
74c6f15a03 Do not use calc_field unless in advanced y axis (bug 1763).
Register new tap listener (new filter) when going from advanced y axis.
Add parantheses to the filters to ensure they are correct when concatenated.

svn path=/trunk/; revision=23844
2007-12-12 09:31:02 +00:00
Stig Bjørlykke
1b7aed33ca - Added three more y axis scale values to be able to draw time values
up to 2000 seconds (maximum when using guint32).
- Combined some common code to draw the y axis values.

svn path=/trunk/; revision=23732
2007-12-04 01:28:38 +00:00
Stig Bjørlykke
b20e64d4f9 Simplified y-positions for FBAR and DOT to ensure out-of-graph values are
drawn as they should be.  I hope this is the last fix this time...

svn path=/trunk/; revision=23729
2007-12-04 00:36:39 +00:00
Stig Bjørlykke
96586ead65 Use same notation for all y axis time labels, so we don't end up having one
in seconds, one in milliseconds and one in microseconds.

svn path=/trunk/; revision=23722
2007-12-03 22:11:06 +00:00
Guy Harris
ae459b483f Parenthesize the operand of the cast, to make it clearer that we're
casting the result of the entire computation.

svn path=/trunk/; revision=23714
2007-12-03 21:35:54 +00:00
Anders Broman
ea19a489e1 Add another cast.
svn path=/trunk/; revision=23712
2007-12-03 20:53:26 +00:00
Stig Bjørlykke
e9090e24bc Add some casts to get the windows compiler happy.
svn path=/trunk/; revision=23711
2007-12-03 20:43:30 +00:00
Stig Bjørlykke
96e82fb78f Added two more y axis scale values to be able to draw time values up to
200 seconds.

svn path=/trunk/; revision=23710
2007-12-03 20:17:31 +00:00
Stig Bjørlykke
4efc9ba371 Ensure we don't wrap the values when calculating advanced time values.
With default window size the limit for this wrap is ~27 seconds when having
0-50 seconds on the y axis, and decreases greatly on higher window size.  

svn path=/trunk/; revision=23708
2007-12-03 19:44:27 +00:00
Stig Bjørlykke
8745da6ed0 - Added Tick interval 1 min and 10 min.
- Draw an empty graph if no items in given tick interval.
- Initialize interval_delta so we don't get overlaping x-scale labels.
- Some whitespace cleanup.

svn path=/trunk/; revision=22992
2007-09-26 22:50:53 +00:00
Stig Bjørlykke
d106d8eadc Added "Dot" as new style in IO Graph.
svn path=/trunk/; revision=22666
2007-08-26 14:02:59 +00:00
Anders Broman
5abff6b3a4 Cast as (gfloat)
io->scrollbar_adjustment->value=(gfloat)first_interval;

svn path=/trunk/; revision=22653
2007-08-25 08:20:59 +00:00
Stig Bjørlykke
e5850628b0 The code for resizing the scrollbar page_size was a bit strange and did
some strange justifications when having high "tick values" in the graph.

Simplified this to fix a problem with scrolling to X Axis zero and a
problem with interval values printed in the wrong time position.

svn path=/trunk/; revision=22645
2007-08-24 21:38:10 +00:00
Stig Bjørlykke
d46fcba723 Print the first interval in the graph.
Print zero label string in the X Axis (not centered).
Always start the graph with the first interval, not at zero x value.

svn path=/trunk/; revision=22644
2007-08-24 21:23:34 +00:00
Stig Bjørlykke
5040aa1613 Fixed drawing of X Axis decimal values: "0. 50" -> "0.050"
svn path=/trunk/; revision=22610
2007-08-23 21:51:36 +00:00
Stephen Fisher
1f786cac31 Updates to initial check-in of pixmap saving feature:
- Bump minimum GTK version from 2.4 to 2.6 in code and users manual
 - Free some strings after we're done with them 
 

svn path=/trunk/; revision=22170
2007-06-23 05:58:01 +00:00
Stephen Fisher
0ba44094e6 Fix enhancement bug #1337: Export IO Graphs
This new code adds a save button to the Statistics IO Graphs window and
is also reusable by any other code that uses GDK Pixmaps to draw graphs.
The Gdk-pixbuf library included in GTK is used for this save function.


svn path=/trunk/; revision=22166
2007-06-22 22:22:10 +00:00
Sebastien Tandel
76729e5d0f From David Howells :
Fix compilation failures when building wireshark-0.99.6-SVN-21916 on an
x86_64-unknown-linux-gnu target with gcc version 4.1.2 20070403 (Red Hat
4.1.2-8).

The failures fall into two categories:
  (1) Casts between pointers and 32-bit integers without an intermediary cast
via 'long' or 'unsigned long'.  This results in a compiler warning complaining
about casts between a pointer and an integer of a different size.
  (2) Passing values to "%lld" or similar printf-style format options that the
compiler thinks are a different size.  Such values need to be cast to 'long
long' or 'unsigned long long'.

svn path=/trunk/; revision=21975
2007-05-29 02:43:18 +00:00
Stephen Fisher
1909b97d4d Remove all warnings under Unix for the gtk/ directory.
svn path=/trunk/; revision=21160
2007-03-24 00:45:11 +00:00
Ulf Lamping
407d0aeab0 fix all warnings in gtk dir & set the "treat all warnings as errors" MSVC flag
svn path=/trunk/; revision=21080
2007-03-21 03:26:26 +00:00
Stephen Fisher
7389b3fabd Add a "Bits/Tick" option to the IO Stats dialog to complement the
"Bytes/Tick" option.


svn path=/trunk/; revision=20997
2007-03-07 23:39:45 +00:00
Martin Mathieson
997e5415f9 Add separate union entries to fvalue.value for signed and unsigned
32-bit numbers.  Separate signed and unsigned accessors have been
added and used where appropriate.

Definitely not for 0.99.5.

svn path=/trunk/; revision=20472
2007-01-18 11:02:26 +00:00
Anders Broman
05448fcc3d Ethereal->Wireshark
svn path=/trunk/; revision=18232
2006-05-28 17:19:08 +00:00
Guy Harris
92552c2d76 Get rid of a bunch of "Ethereal"s and "ethereal"s in comments, GUI
strings, and function names.

svn path=/trunk/; revision=18205
2006-05-22 07:29:40 +00:00
Ronnie Sahlberg
89f022b12b name change
svn path=/trunk/; revision=18197
2006-05-21 05:12:17 +00:00
Luis Ontanon
fcf7b3789c add an userdata argument to register_stat_cmd_arg() and its callback to use the callback for multiple registrations.
svn path=/trunk/; revision=17252
2006-02-11 13:05:24 +00:00
Ronnie Sahlberg
14e0012a3b from Bill Meyer
fix for bug 714


svn path=/trunk/; revision=17140
2006-02-01 08:59:59 +00:00
Ulf Lamping
b4471e0195 fix #152
set the read filter dialog modal and transient to the parent window if requested. This way, it will receive input signals (solving problems with GTK2's gtk_file_chooser).

To do this, add another construct_args flag, so it will be modal only if really needed ...

svn path=/trunk/; revision=16926
2005-12-31 17:09:27 +00:00
Guy Harris
6ed8c9a07b Make the processing of "-z" arguments in the Tethereal I/O stat tap more
like that of the Ethereal I/O stat tap.  Improve error messages in both
taps.

Use nstime() routines and structure assignment to do operations on
nstime_t values.

svn path=/trunk/; revision=16346
2005-10-27 19:42:24 +00:00
Guy Harris
f34e1a97c6 Have cf_retap_packets() take an argument that indicates whether to
generate columns; use cf_retap_packets instead of cf_redissect_packets()
when running taps (the general flow graph stat uses the Info column).

svn path=/trunk/; revision=15793
2005-09-14 08:59:41 +00:00
Ulf Lamping
6f43fbb2f0 EVERYTHING IN THE BUILDBOT IS GOING TO BE RED!!! Sorry!
I've done more than a day to change the timestamp resolution from microseconds to nanoseconds. As I really don't want to loose those changes, I'm going to check in the changes I've done so far. Hopefully someone else will give me a helping hand with the things left ...

What's done: I've changed the timestamp resolution from usec to nsec in almost any place in the sources. I've changed parts of the implementation in nstime.s/.h and a lot of places elsewhere.

As I don't understand the editcap source (well, I'm maybe just too tired right now), hopefully someone else might be able to fix this soon.

Doing all those changes, we get native nanosecond timestamp resolution in Ethereal. After fixing all the remaining issues, I'll take a look how to display this in a convenient way...

As I've also changed the wiretap timestamp resolution from usec to nsec we might want to change the wiretap version number...

svn path=/trunk/; revision=15520
2005-08-24 21:31:56 +00:00
Guy Harris
13e0b409cf As per a suggestion by Ulf Lamping, rename gtk_*.[ch] to gui_*.[ch], so
that it doesn't appear to be part of GTK+.

svn path=/trunk/; revision=15501
2005-08-21 19:24:11 +00:00
Guy Harris
a0e68da918 Add a "register_dfilter_stat()", to register stats that take a display
filter as an argument on the command line and have a dialog box to enter
the display filter through the GUI.  Use it for all stats using
"gtk_tap_dfilter_dlg_cb()".

Add a top-level "stat_menu.h" file to declare "REGISTER_STAT_GROUP_E"
for the benefit of the declaration of "register_dfilter_stat()" in the
top-level "tap_dfilter_dlg.h".  Rename the "stat_menu.h" in the gtk
directory to "gtk_stat_menu.h", so as not to have two headers with the
same name.

Get rid of headers not declaring any functions not being used in the
module.

svn path=/trunk/; revision=15493
2005-08-21 09:48:27 +00:00
Guy Harris
50d77b113c Rename epan/stat.[ch] to epan/stat_cmd_args.[ch] - it only deals with
implementing the "-z" command-line arguments, it doesn't deal with *all*
issues for stats.

svn path=/trunk/; revision=15483
2005-08-20 20:06:05 +00:00
Ulf Lamping
eafbbbcabb renamed ui_util.c/.h to gui_utils.c/.h to prevent confusion with identical named ui_util.h in / dir
svn path=/trunk/; revision=15465
2005-08-20 12:09:48 +00:00
Guy Harris
4ddd504bb4 Move the stats.[ch] stuff into epan, so plugins can use it.
svn path=/trunk/; revision=15429
2005-08-19 10:00:14 +00:00
Guy Harris
b2807e2ab6 Move the APIs for registering and processing "-z" command-line arguments
and "Statistics" menu items into "stat.h" and "stat.c", to separate them
from the core tapping APIs.  A tap could conceivably not register as a
"-z" command-line argument or "Statistics" menu item, and a stat could
conceivably not be implemented as a tap, and dissectors that implement
tapping points don't need the UI-related stuff from "stat.h", they just
want the tap-related stuff in <epan/tap.h>.

svn path=/trunk/; revision=15427
2005-08-19 09:29:41 +00:00
Ulf Lamping
75970c09e2 strdup -> g_strdup and alike
svn path=/trunk/; revision=15392
2005-08-17 21:52:16 +00:00
Jörg Mayer
62b7cc3043 Last set of char -> const char trivial warning fixes.
svn path=/trunk/; revision=15244
2005-08-06 14:03:14 +00:00
Guy Harris
5fb6e97fb4 Squelch more const warnings (and fix some memory leaks that found).
_U_-ify some unused arguments, rather than assigning them to themselves.

Un-constify one variable that gets assigned a mallocated pointer.

Clean up indentation.

svn path=/trunk/; revision=15236
2005-08-06 03:44:55 +00:00
Ronnie Sahlberg
c3467685d5 make io-stat able to do SUM(*) for FT_RELATIVE_TIME fields
Example:   SUM(tcp.analysis.rto)
so one can plot the total amount of time that TCP sessions were idle due to waiting for a retransmission to occur.



svn path=/trunk/; revision=14920
2005-07-15 08:29:26 +00:00
Ronnie Sahlberg
6658493b2f increase the length of the field field from 30 to 50 characters so that hopefully all long named fields can fit in the textbox for iorapgs/advanced
svn path=/trunk/; revision=14146
2005-04-20 08:58:49 +00:00
Guy Harris
80c1907a36 Rename "register_ethereal_tap()" to "register_tap_listener_cmd_arg()" as
it's used to register a callback for a tap listener invoked if the
specified command line argument is specified to the "-z" flag.

Move it, along with routines to:

	look up a "-z" argument in the table constructed by
	"register_tap_listener_cmd_arg()" and either save the full
	argument to "-z" and the corresponding listener if it's found or
	return a failure indication if it isn't;

	list the available tap listeners;

	call the "init" routines for the tap listeners saved in the
	table above;

and have Ethereal and Tethereal use those routines.

svn path=/trunk/; revision=13993
2005-04-01 09:08:27 +00:00
Ulf Lamping
0861927ce3 huge cleanup of capture file API (functions in file.c/file.h).
This includes: all functions in file.h now have a cf_ prefix, will have doxygen tags, will have the capture_file *cf as the first parameter and I tried to generalize the return values for non trivial functions.

Hopefully, I didn't introduced any new bugs, as I had to change a lot of files...

svn path=/trunk/; revision=13289
2005-02-04 18:44:44 +00:00
Ulf Lamping
66ce7f3623 add some more online help functionality and help buttons at various dialog boxes, if a help page *is* available. However, the new help system needs a lot more work before completed.
svn path=/trunk/; revision=13152
2005-01-20 23:17:23 +00:00