osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity
37,762 Commits 23 Branches 0 Tags 1.3 GiB
Commit Graph

98 Commits

Author SHA1 Message Date
Gerald Combs 5520a452b5 The MSDN page for ZeroMemory recommends using SecureZeroMemory instead, 
so do so. Add ZeroMemory to checkAPIs.pl.

svn path=/trunk/; revision=38584
 2011-08-17 16:54:24 +00:00
Jörg Mayer 91ad1c8086 Using gtk_tree_view_column_get_cell_renderers is an error now. 
svn path=/trunk/; revision=38357
 2011-08-05 10:40:45 +00:00
Anders Broman 3e446c629c Update comments. 
svn path=/trunk/; revision=38202
 2011-07-25 15:55:27 +00:00
Guy Harris 494f9820fb Use gtk_widget_get_has_window() as a wrapper around 
GTK_WIDGET_NO_WINDOW() in pre-2.18 versions of GTK+.  Treat calls to
GTK_WIDGET_NO_WINDOW() as an error in checkAPIs.pl.

svn path=/trunk/; revision=38197
 2011-07-25 06:40:01 +00:00
Anders Broman a5efd9b3b2 Fix a couple of typos and 'E'' mark functions mapped in old-gtk-compat.h 
svn path=/trunk/; revision=38196
 2011-07-25 04:13:46 +00:00
Anders Broman 1c09e4a694 Replace deprecated functions. 
Udate comments in CheckAPIs

svn path=/trunk/; revision=38185
 2011-07-24 16:50:55 +00:00
Anders Broman 6814cd03ee Replace deprecated gdk_pixmap_unref() with g_object_unref(). 
Update checkAPIs.

svn path=/trunk/; revision=38013
 2011-07-14 08:11:16 +00:00
Anders Broman 1f923105f8 Fix more tooltips, mark gtk_tooltips_new with 'E' in checkapi. 
svn path=/trunk/; revision=37976
 2011-07-11 20:01:28 +00:00
Stig Bjørlykke 8443bbbf75 Replace all strerror() with g_strerror(). 
Remove our local strerror implementation.
Mark strerror as locale unsafe API.

This fixes bug 5715.

svn path=/trunk/; revision=37812
 2011-06-28 09:00:11 +00:00
Anders Broman ca9bb67aa6 Add GDK deprecated functions. 
svn path=/trunk/; revision=37765
 2011-06-23 13:04:19 +00:00
Jeff Morriss 8ce306faa0 Inspired by one of the changes from r37406 and bug 2794: detect hf abbreviations 
with two or more periods in a row.  Fix one case of that.

svn path=/trunk/; revision=37407
 2011-05-26 13:32:04 +00:00
Anders Broman 73c91d6fa0 "Upgrade" gtk_combo to 'E'. 
svn path=/trunk/; revision=36746
 2011-04-21 06:05:55 +00:00
Jeff Morriss 892d734975 Prohibit (memory-unsafe) g_sprintf() and g_vsprintf(). 
svn path=/trunk/; revision=36390
 2011-03-29 01:27:20 +00:00
Anders Broman 49ac7b9759 W -> E for g_clist funktions. 
svn path=/trunk/; revision=36171
 2011-03-08 19:55:22 +00:00
Jeff Morriss 1e425a1d66 As suggested by Anders: when we detect non-ASCII characters, print the line 
number on which we found them.

svn path=/trunk/; revision=36122
 2011-03-02 17:18:34 +00:00
Jeff Morriss 2620f18569 There is a better (and faster) way to see if all the members of one list are 
in another list: convert the 2nd list to a hash.  This speeds checking for ett_
variables up considerably.

Store the pattern to match ett_ variable names in a variable (since it's used 3
times).

Only match ett_ variable declarations that start on their own line (hopefully to
speed things up a bit).

svn path=/trunk/; revision=35929
 2011-02-12 03:53:29 +00:00
Jeff Morriss e13389a2b7 Add a function to verify that ett_ variables are registered (or at least 
stored in an array which will hopefully be registered).

This is a work-in-progress, so the function is not called.

It is also EXTREMELY slow on big files.  (Or maybe it's looping...
I haven't yet had the patience to let it finish processing packet-rrc.c .)

svn path=/trunk/; revision=35923
 2011-02-11 22:44:29 +00:00
Jeff Morriss d8659693ef Check for places where tvb_bytes_to_str() or tvb_get_bytes_to_str_punct() 
should be used (instead of the non-tvb functions with a call to tvb_get_ptr()).

Use those functions in a bunch of places.

svn path=/trunk/; revision=35911
 2011-02-11 02:43:07 +00:00
Jeff Morriss 8d03f63e17 Oops, put a comma back 
svn path=/trunk/; revision=35910
 2011-02-11 02:29:45 +00:00
Jeff Morriss 1a0287a486 Clean up indentation 
svn path=/trunk/; revision=35909
 2011-02-11 02:27:33 +00:00
Jeff Morriss 7be63e199b Add (commented-out for now) code to check certain function calls for embedded 
(in the argument list) calls to tvb_get_ptr().

svn path=/trunk/; revision=35906
 2011-02-10 22:53:48 +00:00
Anders Broman 6f598e72e1 White space changes. 
svn path=/trunk/; revision=35825
 2011-02-04 16:22:37 +00:00
Anders Broman 583d2776f5 Add GTK 2.22 deprecated functions 
svn path=/trunk/; revision=35759
 2011-02-02 17:11:26 +00:00
Jeff Morriss f09b22e600 Revert 35447 and 35364: remove comments and strings in one regex (so it doesn't get confused by things like /* inside a string). And don't remove comments+strings before checking the hf's. 
svn path=/trunk/; revision=35453
 2011-01-10 14:43:29 +00:00
Jeff Morriss d6393bba6e Remove the comments and strings separately so that we can check the hf's when the comments are gone but the strings are not. 
svn path=/trunk/; revision=35447
 2011-01-10 03:04:26 +00:00
Jeff Morriss b0beaec6a1 Prohibit strtoull(): Windows doesn't have it. (Putting this in just saves waiting for the buildbot to complain.) 
svn path=/trunk/; revision=35410
 2011-01-06 23:23:28 +00:00
Guy Harris e3e9007f28 Let's discourage the use of g_warning in dissectors. Either use one of 
the dissector-bug macros, or try your best to dissect a packet that's
"wrong".

svn path=/trunk/; revision=35409
 2011-01-06 23:04:48 +00:00
Jeff Morriss 7a5c44beed Check hf entries *after* removing comments (in case there are commented-out entries). 
svn path=/trunk/; revision=35364
 2011-01-04 18:48:26 +00:00
Jeff Morriss c18d15f9f7 Detect (and error on) NULL or empty abbreviations. Wireshark aborts on the former and warns on the latter. 
svn path=/trunk/; revision=35363
 2011-01-04 18:43:24 +00:00
Jeff Morriss 67aba31f94 Deprecate dissector_add(), dissector_change(), dissector_delete(), 
dissector_get_port_handle(), dissector_reset(), dissector_try_port(),
dissector_try_port_new(), and next_tvb_add_port().

Re-tabify the file.

svn path=/trunk/; revision=35229
 2010-12-20 16:39:09 +00:00
Jeff Morriss 9dcabb82c9 Make the hf_ checks errors (they've been running clean for a while now anyway). 
svn path=/trunk/; revision=34711
 2010-10-30 13:23:58 +00:00
Jeff Morriss 052825d8e6 Fix the blurb regexp (sigh) 
svn path=/trunk/; revision=34418
 2010-10-08 00:29:17 +00:00
Jeff Morriss 390252fa29 Escape the pipe (alternation) in the display regexp. 
svn path=/trunk/; revision=34406
 2010-10-07 16:51:25 +00:00
Jeff Morriss 77327f1b6f Tighten the blurb regexp. Check for leading/trailing white space in blurbs. Check for any white space in the abbreviation. 
svn path=/trunk/; revision=34405
 2010-10-07 16:40:22 +00:00
Jeff Morriss 8947fc6a89 Enable hf checks by default. Add a check to see if the abbreviation is equal to the hf_variable_name. 
svn path=/trunk/; revision=34398
 2010-10-06 21:54:01 +00:00
Jeff Morriss 4dc93213e3 Don't use a regexp to compare the name to the blurb, just convert them both to lower case before doing the comparison. 
svn path=/trunk/; revision=34324
 2010-10-02 01:47:16 +00:00
Jeff Morriss c39f840519 When checking hf, do a case-insensitive comparison between the name and the blurb. 
svn path=/trunk/; revision=34323
 2010-10-02 01:34:31 +00:00
Jeff Morriss d7b10fbe55 Inspired by https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3548 : 
Add the option to check hf entries for various problems.  This is disabled by
default for the moment as it's quite noisy.

The regexps may need some additional fine tuning (or maybe simplification),
but they seem to work pretty well.

Arguably this might make more sense in checkhf.pl but it was easier to integrate
into this script.

svn path=/trunk/; revision=34240
 2010-09-24 20:26:29 +00:00
Jeff Morriss 2b52159449 Follow up to bug 5209 and rev 34115: 
%hh is C99 so remove it from packet-ssl-utils and add it to the banned list
(similar to %ll) in checkAPIs.pl .


svn path=/trunk/; revision=34120
 2010-09-15 14:10:25 +00:00
Bill Meier df29b59def All use of deprecated GtkOptionMenu functions fixed: Error if any usage found. 
Warn instead of Error for several deprecated GTK functions used recently
 in Wireshark source (1 GtkCombo function and 2 GtkItemFactory functions).
 (ToDo: replace remaining use of GtkCombo and all use of GtkItemFactory).

svn path=/trunk/; revision=33598
 2010-07-20 23:58:56 +00:00
Bill Meier eb232c3954 Add a few deprecated GObject fcns; 
Fix some typos and capitalization.

svn path=/trunk/; revision=33254
 2010-06-18 22:17:43 +00:00
Bill Meier 459eb4eed7 Add deprecated from GLib 2.24 
svn path=/trunk/; revision=33247
 2010-06-17 18:12:46 +00:00
Bill Meier e636286b3c Add GTK deprecated from GTK 2.20. 
svn path=/trunk/; revision=33246
 2010-06-17 17:51:52 +00:00
Jeff Morriss ca2a2b6298 Fix the value_string regexp so it doesn't match value_string_ext (which we don't have to check for NULL termination and the like) 
svn path=/trunk/; revision=32937
 2010-05-24 22:31:51 +00:00
Anders Broman fc0932168f Run deprecated-gtk-todoon all files in the gtk dir. 
svn path=/trunk/; revision=32638
 2010-05-02 21:42:53 +00:00
Bill Meier 264d162f8d (Minor): Improve an output message. 
svn path=/trunk/; revision=32277
 2010-03-25 18:50:31 +00:00
Bill Meier e3fc8e195c gtk_entry_append_text no longer used by Wireshark: Mark as deprecated-gtk ('W" => 'E') 
svn path=/trunk/; revision=31387
 2009-12-29 19:30:02 +00:00
Bill Meier 06a1aa808c gtk_progress_bar_update no longer used by Wireshark: Mark as deprecated ('W" => 'E'). 
svn path=/trunk/; revision=31385
 2009-12-29 17:50:03 +00:00
Bill Meier 1b15280a40 Mark certain GTK functions now unused by Wireshark as deprecated ("W" ==> 'E'); 
Rework usage() text slightly;
Clean up whitespace (untabify & etc).

svn path=/trunk/; revision=31381
 2009-12-29 15:35:20 +00:00
Bill Meier 5ae2550311 Update GLib/GTK deprecated lists to match current stable Glib/GTK; 
Various other minor changes ....

svn path=/trunk/; revision=31374
 2009-12-28 20:54:20 +00:00