Commit Graph

82548 Commits

Author SHA1 Message Date
João Valverde a3fe5c6162 MSYS2/CMake: Fix asciidoctor invocation
CMake does not use any shell to run execute_process(). When
running asciidoctor we must use the batch file. Put that before
"asciidoctor" (a ruby script) so CMake uses that instead.
2021-11-07 22:07:14 +00:00
Richard Sharpe 09f020b3f3 ieee802.11: Start adding support for 802.11be.
This is the extra high throughput spec.
2021-11-07 20:30:15 +00:00
Jaap Keuter 93eceb1991 IPv6: List all extension headers, or why they're not treated as such 2021-11-07 17:42:47 +00:00
Gerald Combs 8570fb47e8 [Automatic update for 2021-11-07]
Update manuf, services enterprise numbers, translations, and other items.
2021-11-07 16:40:28 +00:00
bzdula efc6ee9e85 spice: Added variables for proper protocol dissection 2021-11-07 13:40:06 +00:00
Justin Iurman 41b8f813c2 ipv6: dissector: ioam: improve checks
Improve checks on nodelen, remlen and trace_type.

Signed-off-by: Justin Iurman <>
2021-11-06 15:03:29 +00:00
João Valverde 146a840ad1 dfilter: Move a constructor to the grammar file 2021-11-06 11:45:21 +00:00
João Valverde 6823073f7e dfilter: Fix corner case with matches
Previously a chained expression like "a == b matches c" would be
considered syntactically valid. Fix that to be a syntax error.
Only math-like comparisons can be chained.

This also disallows chaining contains expressions.
2021-11-06 11:45:21 +00:00
João Valverde 2d45cb0881 dfilter: Improve some error messages 2021-11-06 11:45:21 +00:00
João Valverde fb490eb172 dfilter: Move regex creation to semcheck 2021-11-06 11:45:21 +00:00
Colin Finck c034d33ef9 omron-fins: Don't check the Gateway Count byte.
While analyzing the network traffic between an OMRON NS8-TV01B-V2 HMI
and an OMRON CJ2M PLC, I discovered that all requests from the HMI have
their Gateway Count byte set to 0x07. Responses from the PLC still have
a Gateway Count byte set to 0x02.
This conflicts with the (20-year-old) protocol documentation by OMRON,
but happens nevertheless.

With this check removed, all bytes can be successfully parsed to an
OMRON FINS message.
2021-11-05 20:26:39 +00:00
Okan Palaz d72af75157 ieee1905: Correct RSSI fields to RCPI
- The RSSI fields in "(Un)Asssociated STA Link Metrics" and "Steering
  Policy" TLVs are not defined as RSSI but RCPI in released versions of
  the Multi-AP/EasyMesh specs. It's defined as an unsigned value in
  range 0 - 220.
- Changed "RCPI reporting threshold" type to UINT8 in "Metric Reporing
  Policy TLV".
2021-11-05 20:12:37 +00:00
Arkady Gilinsky a592c0d84f oampdu: Add OAM D-ONU leaves description
Signed-off-by: Arkady Gilinsky <>
2021-11-05 21:15:25 +02:00
Gerald Combs 5a9978e7b5 GitHub: Move the lockdown workflow to the proper directory.
Workflows need to be in .github/workflows.
2021-11-05 10:11:02 -07:00
Justin Iurman dd0ecf8623 Fix loop inside the IOAM Trace data dissection
This patch is a quick fix to the infinite loop during dissection of the
IOAM Trace data list, introduced by merge request !4962

Fixes #17709
Closes #17709

Signed-off-by: Justin Iurman <>
2021-11-05 15:51:31 +01:00
João Valverde 1fc621e38d epan: Fix crash with upper-case protocol filter names
Registering a preference module for a protocol filter name with
upper case letters aborts the program. Relax this restriction to
conform with the rules for protocols. The recommendation is still
to use all lower-case letters.

Fixes 070aeddf76.
2021-11-04 16:29:34 +00:00
João Valverde 01f234571f epan: Optimize heuristic name validity check
Do the name check in one pass only, instead of two passes, one
for all letters and a second one to exclude upper case letters.
2021-11-04 14:03:37 +00:00
Martin Mathieson 826e850c00 someip: make a function static 2021-11-04 09:20:47 +00:00
Роман Донченко a83c815184 Fix a duplicate author name
I have discovered that my name is listed twice in `AUTHORS`, and the second
occurrence is next to an unrelated contributor's email.

As far as I can see, the real name of that contributor has never been
established, so just use the local part of their email address instead.
2021-11-04 05:44:50 +00:00
John Thacker dc22cb1b89 RTP: Strengthen heuristics
Strengthen the heuristics according to Appendix A.1 of RFC 3550:

Reject if the packet isn't long enough to fit the fixed header, including
the CSRCs if present.
Reject if the packet isn't long enough to fit the extension header.
Reject if the packet isn't long enough to fit the padding, if we have
all the packet.
Reject the payload types reserved for RTCP conflict.

Most of these lead to malformed packet error if dissected anyway,
which can still be done via other methods (SDP, Decode As, etc.)
2021-11-04 05:29:02 +00:00
Moshe Kaplan 0b13ad6d95 Qt: Debounce View -> Internals -> Supported Protocols "Search" to improve UX
As searching the list of protocols takes a noticeable amount
of time and so would introduce significant lag while typing a string
into the Search box, we instead debounce the call to
updateSearchLineEdit(), so that it doesn't run until a set amount of
time has elapsed with no updates to the Search field.
If the user types something before the timer elapses, the timer restarts
the countdown.
2021-11-04 05:12:50 +00:00
Triton Circonflexe 734851fc72 [Thrift] Limit depth of nested types using p_set_proto_depth
Use a nested_type_depth preference to allow customization (default 25).
Fix incorrect display of 8 to 14 list & set lengths as negative values
when displaying internal Thrift fields of compact PDU in sub-dissector.
2021-11-04 04:58:12 +00:00
Justin Iurman c92bb35bcf ipv6: dissector for the IOAM Trace data list
Add support for the IOAM Trace data list dissection

Signed-off-by: Justin Iurman <>
2021-11-03 21:58:05 +00:00
Justin Iurman 8d071fde54 ipv6: dissector for the IOAM Trace option
Add support for the IOAM Trace option dissection

Signed-off-by: Justin Iurman <>
2021-11-03 21:58:05 +00:00
Justin Iurman c82123acea ipv6: dissector for the IOAM option
Add support for the IOAM option dissection

Signed-off-by: Justin Iurman <>
2021-11-03 21:58:05 +00:00
Stig Bjørlykke e5eadbe34f dtls: Add preferences for client/server CID length
Add preferences for default client and server Connection ID length
to be used when Client Hello and Server Hello is missing.

Allocate buffer for AAD in packet scope to remove the need for
buffers with the size of DTLS_MAX_CID_LENGTH.

Fixes #17701.
2021-11-03 21:08:59 +00:00
Zoran Bošnjak 1427a25cd1 asterix: update script adjusted
Asterix update script is modified, to support automatic operation
(weekly updates).
2021-11-03 19:01:34 +00:00
Peter Wu e84acd86eb CMake: fix macOS build without Asciidoctor
Fix an error when running cmake on macOS without Asciidoctor:

    The dependency target "manpages" of target "wireshark" does not exist.

Fixes: 44bd3a7d79 ("CMake+Docs: Update our man page targets.")
2021-11-03 16:04:46 +00:00
Alexis La Goutte 46e08f0f67 TLS: Update Code Point for Hello Extension
- transparency_info (52): draft-ietf-trans-rfc6962-bis-41
- external_id_hash/external_session_id (55/56): RFC 8844
- ticket_request (58): draft-ietf-tls-ticketrequests-07
- dnssec_chain (59): RFC 9102
2021-11-03 14:22:39 +00:00
Alexis La Goutte edf6de76ec QUIC(datagram): Fix update link 2021-11-03 14:22:39 +00:00
Anders Broman 767115558f NR-RRC: Access more messages trough dissector handles. 2021-11-03 14:04:57 +01:00
Anders Broman fa687143b8 LTE-RRC: Make more ASN1 structures available trough dissector handles. 2021-11-03 05:33:15 +00:00
Gerald Combs 83ed035f16 ErlDP: Don't overrun a buffer.
Convert a custom character array to a wmem_strbuf. Fixes #17706.
2021-11-03 05:18:40 +00:00
Anders Broman 94b28aa79a Ericsson ENB log reader: Check the whole line for the magic string. 2021-11-03 05:04:38 +00:00
John Thacker 5bb521aa52 RTP/RTCP: Update comments
Update comments about even/odd port numbers to reflect support for
RFC 5761 (multiplexing RTP and RTCP onto a single port), and add
a reference to RFC 5506 for RTCP non-compound packets
2021-11-02 21:06:51 +00:00
Gerald Combs 85b99c18d9 Tools: make-pci-ids fixups.
Add ID count sanity checks and make sure we don't update pci-ids.c
unless the checks pass. Fix a bunch of Pylint warnings. Strip leading
whitespace from our output strings.
2021-11-02 17:20:24 +00:00
Gerald Combs 51c714bfb5 Tools: Fetch IANA data over HTTPS. 2021-11-02 16:46:18 +00:00
João Valverde 070aeddf76 Lift restriction on upper case protocol display filter names
Unlike other header fields in filter expressions protocol names
cannot contain upper-case letters. Remove that restriction. This
should make start-up slightly faster as it remove an extra loop
for each protocol filter name.

This was added in 9ead15a6eb but
I don't see a reason to have different rules for protocols and
fields, it seems the README.developer was just being vague and

The recommendation for lower case is a style recommendation,
and it's a good one, but it should be applied uniformly. As
long as we are not enforcing this for all field filter values
there is no point in enforcing it just for protocol names and
actually it is detrimental, e.g:


It's weird and unexpected to have this difference and there is
no technical reason to require it. What we should probably do
is not include the protocol name in the FIELDFILTERNAME and
have the registration mechanism append it to the PROTOFILTERNAME.

Also disallow leading '-' everywhere in filter names, not just
protocol filter names. It's a universal requirement.
2021-11-02 08:35:24 +00:00
João Valverde e63857aa4e CMake: Make -Wmaybe-uninitialized non-fatal 2021-11-01 21:46:19 +00:00
Guy Harris 1cf1684504 README.developer: put items about Windows together.
Move the item about MinGW-w64 up after the earlier item about Windows
portability in general.
2021-11-01 13:38:36 -07:00
João Valverde 4ff22025e8 README.developer: Add note about portability on Windows 2021-11-01 20:01:11 +00:00
Gerald Combs 72ad7d9cdd IPPUSB: Add a pointer check.
Fixes #17705.
2021-11-01 18:55:12 +00:00
Gerald Combs bb41b66192 Modbus: Add null pointer checks.
Fixes #17703.
2021-11-01 18:40:18 +00:00
Gerald Combs 5d1345b6dc RTPS: Enable a memory allocation limit.
Enable a limit so that we don't try to allocate an off-the-wire size.
Fixes #17702.
2021-11-01 18:22:24 +00:00
Gerald Combs 0b473c01ab 802.11 Radio: Add null pointer checks.
Fixes #17704.
2021-11-01 10:57:16 -07:00
Gerald Combs 274a29f389 Tools: Fixup our fuzz test error header.
Move the error header output to a group command.
2021-11-01 17:02:52 +00:00
Stig Bjørlykke 48986d34ff tls: Omit Connection ID when length is 0
Having Connection ID length 0 indicates support for sending CID
but does not want to send one, so having an entry with <MISSING>
is misleading information.

Related to #17695
2021-11-01 15:30:49 +01:00
Stig Bjørlykke a38c02ad6c tls: Fix DTLS heuristics when having connection_id
The DTLS heuristics must lookup the cid_length from the session
when checking record lengths in dissect_dtls_heur().

Related to #17695

Signed-off-by: Stig Bjørlykke <>
2021-11-01 13:06:15 +00:00
Stig Bjørlykke 313f85d362 tls: Update DTLS 1.2 Connection ID extension
Update DTLS 1.2 Connection ID extension support to final version.
Keep backward compability with the deprecated extention type (53)
from draft-ietf-tls-dtls-connection-id-07.

Closes #17695
2021-11-01 12:51:11 +00:00
João Valverde 353beb6c6d dfilter: Fixup a null return value 2021-11-01 10:46:53 +00:00