Previously a chained expression like "a == b matches c" would be
considered syntactically valid. Fix that to be a syntax error.
Only math-like comparisons can be chained.
This also disallows chaining contains expressions.
While analyzing the network traffic between an OMRON NS8-TV01B-V2 HMI
and an OMRON CJ2M PLC, I discovered that all requests from the HMI have
their Gateway Count byte set to 0x07. Responses from the PLC still have
a Gateway Count byte set to 0x02.
This conflicts with the (20-year-old) protocol documentation by OMRON,
but happens nevertheless.
With this check removed, all bytes can be successfully parsed to an
OMRON FINS message.
- The RSSI fields in "(Un)Asssociated STA Link Metrics" and "Steering
Policy" TLVs are not defined as RSSI but RCPI in released versions of
the Multi-AP/EasyMesh specs. It's defined as an unsigned value in
range 0 - 220.
- Changed "RCPI reporting threshold" type to UINT8 in "Metric Reporing
This patch is a quick fix to the infinite loop during dissection of the
IOAM Trace data list, introduced by merge request !4962Fixes#17709Closes#17709
Signed-off-by: Justin Iurman <email@example.com>
Registering a preference module for a protocol filter name with
upper case letters aborts the program. Relax this restriction to
conform with the rules for protocols. The recommendation is still
to use all lower-case letters.
I have discovered that my name is listed twice in `AUTHORS`, and the second
occurrence is next to an unrelated contributor's email.
As far as I can see, the real name of that contributor has never been
established, so just use the local part of their email address instead.
Strengthen the heuristics according to Appendix A.1 of RFC 3550:
Reject if the packet isn't long enough to fit the fixed header, including
the CSRCs if present.
Reject if the packet isn't long enough to fit the extension header.
Reject if the packet isn't long enough to fit the padding, if we have
all the packet.
Reject the payload types reserved for RTCP conflict.
Most of these lead to malformed packet error if dissected anyway,
which can still be done via other methods (SDP, Decode As, etc.)
As searching the list of protocols takes a noticeable amount
of time and so would introduce significant lag while typing a string
into the Search box, we instead debounce the call to
updateSearchLineEdit(), so that it doesn't run until a set amount of
time has elapsed with no updates to the Search field.
If the user types something before the timer elapses, the timer restarts
Use a nested_type_depth preference to allow customization (default 25).
Fix incorrect display of 8 to 14 list & set lengths as negative values
when displaying internal Thrift fields of compact PDU in sub-dissector.
Add preferences for default client and server Connection ID length
to be used when Client Hello and Server Hello is missing.
Allocate buffer for AAD in packet scope to remove the need for
buffers with the size of DTLS_MAX_CID_LENGTH.
Unlike other header fields in filter expressions protocol names
cannot contain upper-case letters. Remove that restriction. This
should make start-up slightly faster as it remove an extra loop
for each protocol filter name.
This was added in 9ead15a6eb but
I don't see a reason to have different rules for protocols and
fields, it seems the README.developer was just being vague and
conflating PROTOABBREV with PROTOFILTERNAME.
The recommendation for lower case is a style recommendation,
and it's a good one, but it should be applied uniformly. As
long as we are not enforcing this for all field filter values
there is no point in enforcing it just for protocol names and
actually it is detrimental, e.g:
It's weird and unexpected to have this difference and there is
no technical reason to require it. What we should probably do
is not include the protocol name in the FIELDFILTERNAME and
have the registration mechanism append it to the PROTOFILTERNAME.
Also disallow leading '-' everywhere in filter names, not just
protocol filter names. It's a universal requirement.