a37493fe16
Fix bug #5189 : Wireshark crashes when cancelling a large sort operation.
...
Essentially: Don't try to sort if the pre-requisite "columnization" step is stopped
via the progressbar dialog window before the step completes.
Also: Fix a (very) minor bug wherein the sort-indicator not always cleared on the
"previous column" when "No Sorting" was selected from a column context menu.
Also: Do minor code, comments & whitespace cleanup.
svn path=/trunk/; revision=36180
2011-03-12 19:02:24 +00:00
d3cff4643b
Use TRUE/FALSE for encoding_info to make it build.
...
Added packet-mndp.c to Makefile build.
svn path=/trunk/; revision=36179
2011-03-12 12:09:52 +00:00
a8a7de17ea
Improve r36177 per Guy's suggestion at bug #5746 to always call the
...
PPP-over-HDLC dissector since it will do the check for us to see if
the HDLC framing is present or not.
svn path=/trunk/; revision=36178
2011-03-12 02:06:25 +00:00
ebe492525f
Handle PPP in HDLC framing. Fixes bug 5746.
...
svn path=/trunk/; revision=36177
2011-03-12 01:32:35 +00:00
a96eed7007
Add emem_tree_lookup32_array_le. Resolves bug 5744.
...
svn path=/trunk/; revision=36176
2011-03-09 17:20:29 +00:00
df9543e3a1
Update/correct some TLVs
...
svn path=/trunk/; revision=36175
2011-03-09 13:27:13 +00:00
ff6cd61a00
Check that imported private key is RSA; Prevents a crash.
...
Fixes Bug #5662
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5662
svn path=/trunk/; revision=36174
2011-03-09 00:43:49 +00:00
41c433856f
Display a console warning instead of a simple_dialog for invalid color filters.
...
svn path=/trunk/; revision=36173
2011-03-08 21:21:48 +00:00
a96e3dbe3b
A little more old packet list cleanup
...
svn path=/trunk/; revision=36172
2011-03-08 20:23:48 +00:00
49ac7b9759
W -> E for g_clist funktions.
...
svn path=/trunk/; revision=36171
2011-03-08 19:55:22 +00:00
3fc5ee8f53
Add support for Mikrotiks Neigbor Discovery Protocol (MNDP).
...
Sample capture at
http://wiki.wireshark.org/SampleCaptures?action=AttachFile&do=get&target=mndp.pcap
svn path=/trunk/; revision=36170
2011-03-08 19:10:46 +00:00
2cc88f04a1
Don't bother creating/finding conversations if we're encapsulated within an
...
error packet, such as an ICMP destination unreachable. Prior to this change,
I had captures that showed such encapsulated requests with responses indicated
in other frames, which obviously can't be true.
svn path=/trunk/; revision=36169
2011-03-08 18:52:12 +00:00
4d20bdd60d
Conversation tracking must be handled whether "tree" is NULL or not.
...
svn path=/trunk/; revision=36168
2011-03-08 18:33:45 +00:00
cf8c877d0d
Add support for the pre-rfc DAE port 1700
...
svn path=/trunk/; revision=36167
2011-03-08 18:29:30 +00:00
ac6ae6dbd3
Allow <variance> to be successfully sscanf'd no matter the locale for the
...
decimal symbol. Same change and reason as for revision 36160.
svn path=/trunk/; revision=36166
2011-03-08 14:57:38 +00:00
dbc7c80782
Remove the 'NEW_PACKET_LIST' defines & etc (since the code no longer supports the old packet list)
...
svn path=/trunk/; revision=36165
2011-03-08 14:55:07 +00:00
ec75406c30
Remove the --enable-new-packet-list option (since the code no longer supports the old packet list)
...
svn path=/trunk/; revision=36164
2011-03-08 14:41:12 +00:00
d9beb8fcb0
From Martin Kaiser: initialize hdr_tag with NO_TAG
...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5654
svn path=/trunk/; revision=36163
2011-03-08 13:52:16 +00:00
f28084f772
Fix for bug 5743 : tshark incorrectly calculates tcp stream for SYN packets when port numbers are re-used
...
svn path=/trunk/; revision=36162
2011-03-08 11:26:34 +00:00
307c0d70fb
Removal of the old packet-list in favor of the new packet list.
...
It compiles with "./configure without options" on my Mac. Let's see what the buildbots have to say about it :-)
svn path=/trunk/; revision=36161
2011-03-08 01:52:25 +00:00
4f8edc81e6
Allow <interval> to be successfully sscanf'd no matter the locale for the
...
decimal symbol. Similar to the fix made to tap-iostat.c to resolve bug 2880.
Motivated by the discussion started from this thread on the user list:
http://www.wireshark.org/lists/wireshark-users/201103/msg00018.html
svn path=/trunk/; revision=36160
2011-03-07 21:58:30 +00:00
e6ce1793e2
Don't pass retransmitted chunks to subdissectors. Instead just mark them as
...
retranmissions (in COL_INFO). (Obviously this only works if TSN analysis is
enabled.)
This should make it more obvious to users which chunks are retransmissions and
will help avoid confusing the subdissector(s).
svn path=/trunk/; revision=36159
2011-03-07 19:23:55 +00:00
aac7fca686
From Alexis La Goutte:
...
enhance tag Power Constraint/Capability, TPC Request/Report, Supported Channel, csa
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5660
svn path=/trunk/; revision=36158
2011-03-07 17:46:30 +00:00
664916ad64
Squelch compiler warning:
...
packet-dvbci.c: In function 'dissect_dvbci_lpdu':
packet-dvbci.c:1153: warning: 'hdr_tag' may be used uninitialized in this function
packet-dvbci.c:1153: note: 'hdr_tag' was declared here
By setting hdr_tag = 0, but see question on bug #5654 on whether 0 is a
good default value or not.
svn path=/trunk/; revision=36157
2011-03-07 17:01:55 +00:00
523d4d1cbe
From Stefan Metzmacher: smb2 multi-credit / large mtu support
...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5729
From me: Update a comment re the "epoch" field: It's now called "credit charge".
svn path=/trunk/; revision=36156
2011-03-07 16:43:55 +00:00
24133413b9
Remove a no longer needed struct.
...
svn path=/trunk/; revision=36155
2011-03-07 12:31:49 +00:00
840b816f05
Remove more obsolete code.
...
svn path=/trunk/; revision=36154
2011-03-07 11:56:21 +00:00
6c47c809ef
Fix packet-bssgp.c:125: warning: 'hf_bssgp_tmsi_ptmsi' defined but not used
...
svn path=/trunk/; revision=36153
2011-03-07 10:01:24 +00:00
a7e379499d
Remove the old code.
...
svn path=/trunk/; revision=36152
2011-03-07 09:36:24 +00:00
3e92ea5c2f
Fix compiler error on Windows 64: cast strlen() to (int);
...
Also: Apparently the length of an address of type AT_STRINGZ must include the NULL.
svn path=/trunk/; revision=36151
2011-03-07 03:10:51 +00:00
b71ec510e1
Set properties
...
svn path=/trunk/; revision=36150
2011-03-07 02:44:38 +00:00
16b528aaf1
From Martin Kaiser: dissector for DVB-CI (Common Interface)
...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5654
From me:
- Entry for DVBCI added to wtap.c encap_table_base[];
- Some code simplification with respect to the use of col_...() for COL_INFO;
- Certain tests for "enough bytes available" not really needed;
- (Other minor tweaks);
- #include<stdio.h> not req'd;
- Minor reformatting and whitespace cleanup;
svn path=/trunk/; revision=36149
2011-03-07 02:22:48 +00:00
4d3d029e09
Remove some instances of _U_ where the parameter is now used.
...
svn path=/trunk/; revision=36148
2011-03-06 23:10:28 +00:00
d36178cd5d
Improve expert info output when detect Scheduling Request 'state machine' problem.
...
svn path=/trunk/; revision=36147
2011-03-06 22:52:33 +00:00
3e261511ab
Mark value_string_ext bssgp_cause_vals_ext as WS_VAR_IMPORT.
...
svn path=/trunk/; revision=36144
2011-03-06 16:37:21 +00:00
c7990056c2
[Automatic manuf, services and enterprise-numbers update for 2011-03-06]
...
svn path=/trunk/; revision=36143
2011-03-06 16:03:46 +00:00
b4941ca580
Prepare to remove old bssgp code by changing exports.
...
svn path=/trunk/; revision=36142
2011-03-06 09:42:41 +00:00
9a7ad380af
From Alexis La Goutte:
...
Enhance tag fh_hopping_.., tclas, tspec, challenge_text...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5660
svn path=/trunk/; revision=36141
2011-03-04 17:40:32 +00:00
f7be370643
From Stefan Metzmacher: Patch that fixes false positives and allows large smb1/2 pdus
...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4914
svn path=/trunk/; revision=36140
2011-03-04 15:09:29 +00:00
0b9c645150
Fix warning
...
svn path=/trunk/; revision=36139
2011-03-04 14:36:27 +00:00
3f8b9e87a9
Check only first 14 digits of GeneralizedTime which are fixed, next parts are optional
...
svn path=/trunk/; revision=36138
2011-03-04 14:01:57 +00:00
7e17176c39
All messages converted to the "GSM style" dissection.
...
svn path=/trunk/; revision=36137
2011-03-04 12:57:55 +00:00
eec3e70821
Change descriptions of NTP Reference Identifier Codes for stratum 1
...
servers to match IANA assignment / RFC 5905. A number of codes already
in Wireshark that aren't assigned were left intact.
svn path=/trunk/; revision=36136
2011-03-04 00:25:56 +00:00
47b9a1235e
Correct the usage of tvb_memeql() after r35558: it doesn't return true
...
if the values are the same; we have to check for "== 0" to see if they
are the same.
svn path=/trunk/; revision=36135
2011-03-04 00:17:01 +00:00
ed9de27ba1
Change "Reference Clock ID" to "Reference ID" to match RFC5905 (also
...
mention this RFC in the comments).
svn path=/trunk/; revision=36134
2011-03-03 23:48:56 +00:00
4c6e0d3604
Clarify / add explanations for the fields
...
svn path=/trunk/; revision=36133
2011-03-03 23:47:05 +00:00
62edb47987
Add more duplicate fragment tests.
...
svn path=/trunk/; revision=36132
2011-03-03 23:28:32 +00:00
4ed0e07ef0
When reassembling fragments, don't stop looking at fragments just because the
...
current fragment pushes us past the reassembled size: it may be that the
current fragment is a duplicate/retransmission and will be ignored.
Also, if we detect a conflict between a previous and the current fragment,
flag the current (conflicting) fragment as FD_OVERLAPCONFLICT. Do *not* flag
the fragment that got us into the reassembly routine (probably the final
fragment): it is not (may not be) the guilty fragment.
Clean up some spacing.
Also add reassembly tests for duplicate/retransmitted fragments.
svn path=/trunk/; revision=36131
2011-03-03 20:22:45 +00:00
675d79871e
Export SONtransferRequestContaine, SONtransferResponseContainerand and Global-ENB-ID
...
svn path=/trunk/; revision=36130
2011-03-03 07:20:34 +00:00
2ea51a7ad2
There's no need to pass the result of tvb_get_ptr() as the 'value' in
...
proto_tree_add_*(): just use proto_tree_add_item().
Use tvb_ether_to_str().
Remove some unnecessary includes.
svn path=/trunk/; revision=36129
2011-03-03 03:28:38 +00:00
Bill Meier