Commit Graph

200 Commits

Author SHA1 Message Date
Anders Broman 34ea886454 [-Wunused-but-set-variable]
svn path=/trunk/; revision=39829
2011-11-14 17:35:04 +00:00
Anders Broman fa7ea2ea34 fix [-Wunused-but-set-variable]
svn path=/trunk/; revision=39803
2011-11-12 12:37:38 +00:00
Bill Meier 794757ae8f For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.
Also: remove trailing whitespace for a number of files.

svn path=/trunk/; revision=39503
2011-10-21 02:10:19 +00:00
Jeff Morriss cf012d27b1 Build the ASN.1 dissectors directly into epan/dissectors (rather than building
them and then copying them over).  The "all" target to builds these dissectors
now (instead of "generate_files" and/or "copy_files").

asn2wrs's "-O" option now means "the dissector goes in this directory" (rather
than "all output goes in this directory"); it also means that the "-s" (single
output file) option is now required.

Fix things up so that it's possible to build all of the ASN.1 dissectors in
one shot.

Fix building of conformance files when doing out-of-source-tree builds.


Unfortunately "make all" in the asn1 directory always builds something--I think
because of circular depedencies.

svn path=/trunk/; revision=39333
2011-10-10 02:31:11 +00:00
Jeff Morriss f3f9f2697f Make TVBs opaque for most users.
Convert TVB_RAW_OFFSET() and TVB_GET_DS_TVB() into functions.

svn path=/trunk/; revision=37422
2011-05-27 03:06:50 +00:00
Guy Harris a8bc4a0d13 Rename the routines that handle dissector tables with unsigned integer
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys.  (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)

svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
Bill Meier b1554fc198 Use value_string_ext fcns to access certain value_string arrays;
Whitespace cleanup.

svn path=/trunk/; revision=34882
2010-11-15 19:08:12 +00:00
Bill Meier ed7105e21b Update package_name_vals[] value_string array:
- Add new entries based on: http://www.iana.org/assignments/megaco-h248 last updated 2010-10-01;
- Fix a typo (incorrect value for an entry);
- Switch values between two entries to match the IANA list;
- Switch two entries so list is in ascending order by value.

svn path=/trunk/; revision=34881
2010-11-15 19:00:16 +00:00
Anders Broman eb136e00d8 From Alex Lindberg:
resolves all h248V1 differences and provides dissection of V1
instances of Packets, Events, Signals, and Properties.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3999

svn path=/trunk/; revision=31597
2010-01-21 06:39:25 +00:00
Anders Broman a255c08b66 Get rid of check_col();
svn path=/trunk/; revision=31546
2010-01-17 12:46:00 +00:00
Kovarththanan Rajaratnam 7ab993bee7 Remove unused NEED_PACKET_PROTO_H variable
svn path=/trunk/; revision=30409
2009-10-08 17:26:57 +00:00
Kovarththanan Rajaratnam a9ed97b344 From Gerasimos Dimitriadis via. bug 4104:
When dissecting a h248 message, col_set_str is called with a string from the ephemeral pool and an assertion fails.

svn path=/trunk/; revision=30398
2009-10-08 13:17:51 +00:00
Stig Bjørlykke e2d6320d75 Only include config.h in C files, to avoid multiple inclusion.
svn path=/trunk/; revision=30182
2009-09-28 17:58:47 +00:00
Anders Broman 8a23b29c91 From Alex Lindberg:
Add H248V1 suport.
(H248 dissector fails on poorly formed AuditReply packet from Media Gateway)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3953

svn path=/trunk/; revision=29835
2009-09-10 05:57:30 +00:00
Anders Broman 3d2e307ae6 From Alex Lindberg:
Update to h248v3.asn

Applied the change from the Amendment 1 by hand.

svn path=/trunk/; revision=29787
2009-09-08 09:11:21 +00:00
Kovarththanan Rajaratnam c19f7978db Sanitize epan includes
svn path=/trunk/; revision=29500
2009-08-21 20:32:50 +00:00
Kovarththanan Rajaratnam e971354a54 Don't guard col_set_str (COL_PROTOCOL) with col_check
svn path=/trunk/; revision=29340
2009-08-09 06:26:46 +00:00
Anders Broman 9b9880a25a From yin sun:
h248 term wildcard enhancement

svn path=/trunk/; revision=28861
2009-06-27 13:37:03 +00:00
Stig Bjørlykke e3ef20f3ea From Kovarththanan Rajaratnam:
Clean up header field info in asn1/*-template.c files.

From me:
Fixed a few typos in the patch.

svn path=/trunk/; revision=28817
2009-06-23 06:02:12 +00:00
Anders Broman 7afd67fd94 Update value strings.
svn path=/trunk/; revision=27916
2009-03-31 18:52:36 +00:00
Bill Meier a8f30cbca1 Fix some typos and spelling (mostly in text strings)
svn path=/trunk/; revision=27037
2008-12-17 17:23:37 +00:00
Bill Meier 7280c469a3 Fix some spelling/typos
svn path=/trunk/; revision=27024
2008-12-16 14:18:55 +00:00
Bill Meier 5e4758e5e0 Move prefs processing from registered init fcn to proto_reg_handoff fcn
svn path=/trunk/; revision=26695
2008-11-04 21:48:25 +00:00
Gerald Combs 09868c5db5 Fix some checkAPIs warnings.
svn path=/trunk/; revision=25617
2008-06-27 16:07:21 +00:00
Anders Broman aa81806094 Update package name from IANA's list.
svn path=/trunk/; revision=24078
2008-01-13 17:03:06 +00:00
Anders Broman 02c27c89f0 transactionId wasn't processed for:
SegmentReply/transactionId
TransactionReply/transactionId
TransactionPending/transactionId
Fixes bug http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2165

svn path=/trunk/; revision=24077
2008-01-13 16:07:52 +00:00
Anders Broman de16039c51 Get rid of dissect_ber_boolean_value() and change the signature of
dissect_ber_boolean() to return a value and update asn2wrs to generate the new signature.
Regenerate all BER dissectors.

svn path=/trunk/; revision=24015
2008-01-04 16:21:07 +00:00
Anders Broman 73fee653de Get rid of ber_last_created_item(). (Final?)
svn path=/trunk/; revision=24010
2008-01-04 13:39:24 +00:00
Anders Broman bf7150a834 Get rid of ber_last_created_item().
svn path=/trunk/; revision=24009
2008-01-04 12:53:29 +00:00
Jörg Mayer 3d22aa561b asn1/*/Makefile.nmake were not part of the source package.
Spotted by Tomas Kukosa.

svn path=/trunk/; revision=23921
2007-12-19 10:02:50 +00:00
Tomas Kukosa 1e794fc494 ANSI TCAP regenerated and tested with -T -X asn2wrs options
asn2wrs has -T (tagged types support) and -X (new BER sttructures) default behavior
remove all -T and -X usage

svn path=/trunk/; revision=23823
2007-12-10 08:35:41 +00:00
Anders Broman 079e1446f9 Update to use the -X and -T asn2wrs flags.
svn path=/trunk/; revision=23394
2007-11-07 21:22:25 +00:00
Anders Broman ce2a32dc6f Update to use the -X and -T asn2wrs flags.
svn path=/trunk/; revision=23390
2007-11-07 17:55:57 +00:00
Jörg Mayer 0e0bed500d - Remove -e option if the generated -exp.cnf file isn't used.
- Add EXPORT_FILES to all files that still contain -e.

svn path=/trunk/; revision=23145
2007-10-11 05:27:27 +00:00
Jörg Mayer 61cde0d09e - Change Makefiles to include preinc
- Add missing new directories to asn1/Makefile.nmake

svn path=/trunk/; revision=23141
2007-10-10 19:03:24 +00:00
Jörg Mayer 077819f008 convert to new Makefile structure
svn path=/trunk/; revision=23085
2007-10-07 21:07:33 +00:00
Stig Bjørlykke 8f19616ae8 Modified some ASN1 Makefiles to compile on unix.
Added some clean targets.
Removed asn1/x501 directory.

svn path=/trunk/; revision=22886
2007-09-17 11:53:33 +00:00
Guy Harris 5a43799a17 Use G_GINT64_MODIFIER, rather than the PRI[douxX]64 macros, for GLib
routines and routines using those routines.  GLib might use different
modifiers for 64-bit quantities than the platform's C library does.

svn path=/trunk/; revision=21990
2007-05-29 18:52:42 +00:00
Anders Broman f08cd1e5e3 actx in the rest of dissect_ber..()l
svn path=/trunk/; revision=21773
2007-05-15 05:49:43 +00:00
Anders Broman c01f382974 Second step in introducing asn context to BER dissectors just like in PER.
svn path=/trunk/; revision=21753
2007-05-13 20:58:29 +00:00
Luis Ontanon 55507800aa extraInfo was not propperly tagged causing ber decoding errors.
Fixes Bug 1554


svn path=/trunk/; revision=21557
2007-04-24 19:28:12 +00:00
Luis Ontanon 06a52917ad Have the h248term handle evaluated as late as possible.
svn path=/trunk/; revision=21413
2007-04-13 17:46:54 +00:00
Luis Ontanon 8c6ad121d8 megaco
- replace #pragma for #include
- move register function and remove prototype

h248
- have dissector being called through megaco instead of registering to the same sctp.ppi


svn path=/trunk/; revision=21234
2007-03-27 22:56:07 +00:00
Luis Ontanon 296a77efdc migrate packet-megaco.c from plugins/megaco to epan/dissectors
svn path=/trunk/; revision=21191
2007-03-25 21:59:16 +00:00
Luis Ontanon 753ac01760 Remove the context tracing from packet-h248.c ( migrated to <epan/gcp.c> )
svn path=/trunk/; revision=21188
2007-03-25 21:39:40 +00:00
Luis Ontanon 7a7e743627 add a tap to h248
svn path=/trunk/; revision=21054
2007-03-18 21:54:07 +00:00
Luis Ontanon 306309b94d make sure curr_info.sig is not-NULL before derreferencing it.
similar to  Bug 1451

svn path=/trunk/; revision=21050
2007-03-18 14:56:58 +00:00
Luis Ontanon 92ad3144da make sure curr_info.evt is not-NULL before derreferencing it.
fixes Bug 1451

svn path=/trunk/; revision=21048
2007-03-18 13:53:07 +00:00
Luis Ontanon bed442b167 dissect H.248 over TPKT over TCP
svn path=/trunk/; revision=21046
2007-03-17 21:43:34 +00:00
Luis Ontanon 37802e5e21 Pubate Satienpoch keeps finding typos and incongruences in H.248 packages:
- for Q.1950 I used the value_string for GB events as the value_string for the parameters of BNC change.

> In observed event descriptor, it is called “eventName”, but in event descriptor,
> it is called “pkgdName”. It should be “eventName” in both cases.

svn path=/trunk/; revision=20986
2007-03-06 22:13:12 +00:00
Luis Ontanon b874efb47d - have the signal name to be in the right subtree
svn path=/trunk/; revision=20966
2007-03-03 23:33:56 +00:00
Luis Ontanon 76518e6d1b + improve dissection of PkdName
+ complete H.248.1 E.1 Generic Package

svn path=/trunk/; revision=20965
2007-03-03 16:36:19 +00:00
Luis Ontanon 679cf729d3 + some cosmetic changes to package dissection.
+ add more Q.1950 packages and parameters

svn path=/trunk/; revision=20920
2007-02-25 10:13:49 +00:00
Luis Ontanon 4211d0dba2 fix some bugs introduced in the latest releases and add value_strings for param, evt, sig and stat ids s well as "sub-parameters".
svn path=/trunk/; revision=20908
2007-02-23 20:57:22 +00:00
Luis Ontanon da3cc2efa8 + add some more packages from 3GPP TS 29.232
- fix http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1385


svn path=/trunk/; revision=20885
2007-02-21 00:00:49 +00:00
Anders Broman 5541864c73 Extend the events valuestring with Bearer Modification Support Event.
svn path=/trunk/; revision=20657
2007-01-31 22:59:41 +00:00
Luis Ontanon 5ea201cacf Merge Anders' and my own fixes to some bugs
- most paramaters have data set to NULL, have them added to the tree
- avoid the context tracing mecanism bailing out if a ContextList appears in the packet.
- in q9150 do not attempt to dissect sdp unless we believe it is sdp
    (BTW we need heuristics for sdp and other potential payloads of this parameter..)


svn path=/trunk/; revision=20649
2007-01-31 09:30:08 +00:00
Anders Broman c9ea62712c Fix bug 1328 and related bugs found when examining the trace.
svn path=/trunk/; revision=20634
2007-01-30 22:52:09 +00:00
Anders Broman 695a2bddd6 Update value strings.
svn path=/trunk/; revision=20612
2007-01-29 21:30:06 +00:00
Luis Ontanon 41bf0f37ea the widcards: Choose and All were inverted (again?)
svn path=/trunk/; revision=20314
2007-01-04 22:44:17 +00:00
Bill Meier 444602bf97 Oops: wireshark.com --> wireshark.org
Also: 1 additional Ethereal --> Wireshark

svn path=/trunk/; revision=20272
2007-01-02 17:19:25 +00:00
Bill Meier 739eb43c3a More ethereal --> wireshark
svn path=/trunk/; revision=20270
2007-01-02 14:11:35 +00:00
Guy Harris 04ca66dfb1 Ehtereal[sic] -> Wireshark. :-)
Give a little more detail in the comment in the H.248 dissector about
"MEGACO" vs. "H.248".

svn path=/trunk/; revision=20262
2007-01-02 09:20:27 +00:00
Anders Broman 28e73ca8d2 Sorry that should have been static int. Corrcted now.
svn path=/trunk/; revision=19869
2006-11-08 21:28:03 +00:00
Jörg Mayer c0d26bccb9 Make Wireshark build on my system (gcc 4.1.0) again
svn path=/trunk/; revision=19868
2006-11-08 13:59:46 +00:00
Anders Broman 3f1b8044d0 Use h248v3.asn.
svn path=/trunk/; revision=19867
2006-11-08 06:57:29 +00:00
Jörg Mayer 5bd45dfdb9 Make things build on my system again
svn path=/trunk/; revision=19866
2006-11-08 00:10:09 +00:00
Anders Broman 8d8af34ba4 Fix bug http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1206
MEGACO message cannot be decoded correctly for ServiceChange Command
And decoding of serviceChangeReason.

svn path=/trunk/; revision=19861
2006-11-07 19:25:59 +00:00
Jaap Keuter cf9adce9be Fix bug 1207, simple swap of the two text strings.
svn path=/trunk/; revision=19819
2006-11-06 12:19:26 +00:00
Ulf Lamping 647533a5ef put every python script name into "" so the call won't fail on Win32 native python.
The problem is the slash in e.g.:

 @$(PYTHON) ../../tools/make-dissector-reg.py

is interpreted as an option instead of being part of the path.

I didn't wanted to use backslashes as this might introduce new problems with cygwin's python port.

svn path=/trunk/; revision=19730
2006-10-29 17:19:52 +00:00
Gerald Combs 28d32a420f Add more paranoid pointer checks. Fixes CID 219.
svn path=/trunk/; revision=19684
2006-10-25 17:00:33 +00:00
Anders Broman dc10ba22e6 Fix Event dissection which was broken when going to V3.
and add a few parameters.

svn path=/trunk/; revision=19544
2006-10-15 22:11:26 +00:00
Anders Broman 6c0254b1cb Upadte to H.248 V3 and add some annex E parameters.
svn path=/trunk/; revision=19543
2006-10-15 16:06:02 +00:00
Guy Harris 51a426a4ca Clean up some compiler warnings.
svn path=/trunk/; revision=19473
2006-10-10 08:10:42 +00:00
Anders Broman 60068a047e Add ASN1 for H248 v3. The aim is to replace the current asn1 file after some more testing.
svn path=/trunk/; revision=19463
2006-10-09 20:22:31 +00:00
Anders Broman ed0cf1e0bb H248:
Lost a line in last commit.

ISUP Export a value string.

svn path=/trunk/; revision=19454
2006-10-08 20:57:20 +00:00
Anders Broman 1785428d4c Add a few packages and fix dissecton of a_codecs and handle the case when
hf_param = -1.

svn path=/trunk/; revision=19445
2006-10-06 19:48:00 +00:00
Anders Broman 1677b21838 Added the possibillity of Statistic pkg as well.
svn path=/trunk/; revision=19436
2006-10-04 22:43:38 +00:00
Anders Broman 7817c0a610 Put back the bugfixes froim Revision 19190/19356
Fix bug http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1091

"h248_handle was declared localy, udp port was not added at register.

Added a few more packagenames."

svn path=/trunk/; revision=19434
2006-10-04 21:52:35 +00:00
Luis Ontanon c284a7f9ab more cleanup... almost there...
svn path=/trunk/; revision=19426
2006-10-04 15:31:31 +00:00
Luis Ontanon 8f737d2587 Get it to compile...
svn path=/trunk/; revision=19412
2006-10-03 18:38:04 +00:00
Luis Ontanon 5d40bae072 MSVCC does not like mixing code and variable declarations
svn path=/trunk/; revision=19409
2006-10-03 18:07:31 +00:00
Luis Ontanon a4d7156808 H.248 packages...
few things to be fixed:
- // comments,
- not every hf_xxx used might be registered

some packages from the current h248 dissector are still missing.



svn path=/trunk/; revision=19407
2006-10-03 17:24:28 +00:00
Anders Broman 216cb9eec0 Add some more package names.
svn path=/trunk/; revision=19356
2006-09-29 05:52:41 +00:00
Anders Broman 96c13a1000 Fix bug http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1091
h248_handle was declared localy, udp port was not added at register.

Added a few more packagenames.

svn path=/trunk/; revision=19190
2006-09-11 20:35:24 +00:00
Guy Harris ee7166aff1 Declare "dissect_h248_Name()" and "dissect_h248_Value()" before they're
used.

svn path=/trunk/; revision=19141
2006-09-04 23:20:52 +00:00
Anders Broman 316453598a From Oleg Kostenko:
This patch will add the following functionality to the H.248
 dissector:

 1. Dissection of properties from Annex C.11 SDP equivalents.

 2. Dissection of EventNames and SignalNames from Annex E Basic
Packages.

 3. Dissection of event and signal parameters from Annex E.9 Analog
 Line Supervision Package.

 4. Dissection of statistics from Annex E.11 Network Package and
 Annex E.12 RTP Package.

svn path=/trunk/; revision=19136
2006-09-04 18:10:14 +00:00
Ronnie Sahlberg 8ce8e719e0 rename some structures and defines from the se_tree to the emem_tree prefix
svn path=/trunk/; revision=18894
2006-08-14 08:29:29 +00:00
Anders Broman c72d4e8f2e From Albert Chin:
Fix some C++ comments in C source files and fixes some non-constant initializations.

svn path=/trunk/; revision=18521
2006-06-20 05:57:29 +00:00
Tomas Kukosa 55600fb60a Ethereal -> Wireshark
asn2eth -> asn2wrs

svn path=/trunk/; revision=18214
2006-05-23 15:17:14 +00:00
Tomas Kukosa 62da958bd9 - asn2eth renamed to asn2wrs
- remove obsolete -X option from makefiles
- not generate enumerated map table for BER

dissector will be regenerated later

svn path=/trunk/; revision=18199
2006-05-21 14:36:05 +00:00
Ronnie Sahlberg 89f022b12b name change
svn path=/trunk/; revision=18197
2006-05-21 05:12:17 +00:00
Anders Broman 9aa7db0042 From LEGO fix "Dissector bug, Protocol H248"
svn path=/trunk/; revision=18093
2006-05-04 18:25:43 +00:00
Guy Harris a6930fe4ae Add distclean and maintainerclean rules.
svn path=/trunk/; revision=17999
2006-04-25 18:45:08 +00:00
Ronnie Sahlberg 27de4cfd39 give se_trees names so that it is easier to debug and to log how often certain trees are accessed
svn path=/trunk/; revision=17587
2006-03-11 13:02:41 +00:00
Ronnie Sahlberg 76a2df4a58 dont declare variables in the middle of a code block. many compilers do not like that.
svn path=/trunk/; revision=17573
2006-03-11 00:58:16 +00:00
Luis Ontanon 4e1ca8f2c3 fix coverity CIDs 113 and 114.
while at it change the h248 context analysis to use se_trees instead of GHashTables


svn path=/trunk/; revision=17571
2006-03-10 22:01:10 +00:00
Anders Broman 4e13ea2982 Add parsertab.pyc in clean target
svn path=/trunk/; revision=17386
2006-02-23 20:05:05 +00:00
Luis Ontanon a2f7c569e0 H.248 over UDP
svn path=/trunk/; revision=17163
2006-02-05 04:24:51 +00:00
Gerald Combs faef737b31 Before we begin dissection, NULLify some global variables that might
contain ep_alloc()ed data from a previous dissection.  Correctly fixes
bug 651 (the previous fix was incorrect).

svn path=/trunk/; revision=17015
2006-01-12 02:06:34 +00:00