* add SUA to the "VoIP Calls" tap.
* propagate changes to packet-sccp.h to other dissectors
From Neil Piercy:
* add SLR, DLR and CAUSE to COL_INFO
svn path=/trunk/; revision=21126
- instead of wrongly using the h248 call counter use tapinfo's counter
graph_analysis.c:
- beautify the code (I was trying to the bug that got fixed by bzeroing m3ua tap data however this looks better!).
svn path=/trunk/; revision=21063
Create two new files (ws_strsplit.[ch]) that use GTK2 code to override
the buggy g_strsplit() function when compiling for GTK1. Include this
work-around function (ws_strsplit) in libwireshark.def. Add notes on usage
to README.developer. Include epan/ws_strsplit.h in all files that use
g_strsplit().
svn path=/trunk/; revision=20804
Find attached a patch for this bug. The problem was actually in the "Voip Calls" logic, when the first RTP packet was after the last signaling packet (e.g. a call connected and the release not captured), that caused the RTP to not be added to the graph list and therefor to the player.
svn path=/trunk/; revision=19667
In tests for whether we're built with the RTP player, test
HAVE_LIBPORTAUDIO first - hopefully we can eventually get rid of the
test for the GTK+ version number.
svn path=/trunk/; revision=19641
player, so that we get declartions of rtp_player_init() and
add_rtp_packet().
Constify the first argument to add_rtp_packet(), as it's passed a
pointer to a const value.
svn path=/trunk/; revision=19272
- Change the "listen_rtp" to "rtp_player"
- Change from a plugin to be part of the core
- By default it will not compile with the rtp_player. In order to
compile it is necessary to:
+ For windows: uncomment the line
"PORTAUDIO_DIR=$(WIRESHARK_LIBS)\portaudio_v18_1" in config.nmake
+ For linux: using the "--with-portaudio=yes"
svn path=/trunk/; revision=19094
I'm not sure if this will help with the problems that Keith French is
seeing, but when I loaded some of my old H.323 traces, one of them would
assert/abort. This patch fixes that assertion (looks like it was obviously
asserting on the wrong pointer variable).
svn path=/trunk/; revision=18791
Mike Oliveras has indicated that for MGCP voip calls, 2 seconds may be a
better timeout for still matching DLCX requests to a hung-up endpoint,
as in this patch.
svn path=/trunk/; revision=18662
this is actually a false positive in coverity and can not trigger since htis pointer can not be null here
but verifying this before the varialbe is dereferenced does not hurt in case
the file is changed and this contract is broken.
checking the
svn path=/trunk/; revision=18542
Fix the part where the DeleteConnection messages and
responses were not being included in the graphs.
There is a test that allows messages such as these for 1 second after
the call has been hung up, but the time calculation was wrong.
svn path=/trunk/; revision=18479
From Cvetan Ivanov:
voip_calls.c
It seems to me that in gtk/voip_calls.c tmp_h323info->guid is pointer itself, therefore:
memcmp(&tmp_h323info->guid
should in fact read:
memcmp(tmp_h323info->guid
svn path=/trunk/; revision=18424
H225.cnf
I noticed is that the voip call flow graph does not have a label for the setupAck packet. I traced this to the empty frame_label.
voip_calls.c
It seems to me that in gtk/voip_calls.c tmp_h323info->guid is pointer itself, therefore:
memcmp(&tmp_h323info->guid
should in fact read:
memcmp(tmp_h323info->guid
svn path=/trunk/; revision=18304
of 16 bytes. Use "sizeof" for the size of e_guid_t's, and use structure
assignment to copy GUID values.
Make functions such as append_h225ras_call() and new_h225ras_call() take
pointers to e_guid_t's as arguments.
Define GUID_LEN in epan/guid-utils.h and use it as the length of a GUID
in a packet. (Note that "sizeof e_guid_t" is not guaranteed to be 16,
although it is guaranteed to be the size of an e_guid_t.)
When constructing a display filter that matches a GUID, use
guid_to_str() to construct the string for the GUID.
svn path=/trunk/; revision=17676
a patch for the VoipCalls to fix a couple of issues:
- a problem with the RTP Events (RFC2833) not been handle correctly
- Display the RTP stream in time order when the setup frame is after the
RTP stream.
- fix a init issue that caused the H245 packet to not been displayed
correctly.
svn path=/trunk/; revision=17383
Find attached a couple of changes for t38:
- Use the dissector to reassemble t30 frames
- Dissect t30 protocol
- Move the "Fax t38 analysis" to the "VoIP Calls". Now when selecting
"Statistics"->"Fax t38 analysis" option, there is a message that
redirect the user to use the "Voip calls" instead. We may keep this
option for one release, and then remove it ?
- Added in the "Voip calls" the ability to detect a t38 call if there
are not signaling associated with it. For example, when using "Decode
as.." to dissect t38 packets, it is possible to use the "Voip calls" to analyze that call.
- Display "SDP (t38)" in the "Voip calls graph" for SDP t38 sessions.
Regards
Alejandro Vaquero
svn path=/trunk/; revision=17033
New "Fax T38 Analysis" added to the "Statistics" menu to:
- Reassemble the HDLC t30 frames and dissect the header.
- Analyze the UPDTLPacket seq num for packet lost
- Stats of V.x Data:
- Count the Data bytes
- Duration
- Wrong seq num
- Max Burst of packet lost
svn path=/trunk/; revision=16073
directory to the epan directory. Some of them should perhaps ultimately
be moved to epan/dissectors, if they pertain only to stuff exported by a
particular dissector.
Fix Gerald's e-mail address in files we're moving.
svn path=/trunk/; revision=15844
I've done more than a day to change the timestamp resolution from microseconds to nanoseconds. As I really don't want to loose those changes, I'm going to check in the changes I've done so far. Hopefully someone else will give me a helping hand with the things left ...
What's done: I've changed the timestamp resolution from usec to nsec in almost any place in the sources. I've changed parts of the implementation in nstime.s/.h and a lot of places elsewhere.
As I don't understand the editcap source (well, I'm maybe just too tired right now), hopefully someone else might be able to fix this soon.
Doing all those changes, we get native nanosecond timestamp resolution in Ethereal. After fixing all the remaining issues, I'll take a look how to display this in a convenient way...
As I've also changed the wiretap timestamp resolution from usec to nsec we might want to change the wiretap version number...
svn path=/trunk/; revision=15520
- Add plugins_dlg.h
- Include .h files in their respective .c files
- Include .h and remove extern declarations in .c files
- set eol-style and keywords on gui_utils.[hc]
svn path=/trunk/; revision=15471
- avoid the clist of the calls dlg to be refreshed multiple times when
first appear.
- destroy the Graph window when the data is not valid anymore.
- fixes an H245 packet count error
- resizing the Graph windows when is displayed (up to 5 columns).
With a change to leave static voip_calls_tapinfo_t the_tapinfo_struct =
{0, NULL, 0, NULL, 0, 0, 0, 0, NULL, 0, 0, 0, 0, 0, 0, 0, 0, 0};
alone.
svn path=/trunk/; revision=14852
new dissector for the AudioCodes trunk trace protocol.
This protocol is used to debug the trunk protocol in AudioCodes
gateways. It currently supports ISDN PRI and CAS (MFCR2, WinkStart,
etc...) trunk protocols. It also add these protocols in the "Voip Calls
Graph..."
svn path=/trunk/; revision=14789
all of it correctly, and as if you don't initialize all of it you get a
compiler warning.
Add an assignment to squelch a compiler warning.
svn path=/trunk/; revision=14317
This patch fixes the slightly broken logic in the loop which searches
for establisted call in isup_calls_packet.
The problem is that (right_pair) is set to false if we see call on the
same CIC as existing conversation, but with different opc/dpc pair:
at this point dpc/opc pair is not checked, so any call with the same
CIC matches:
voip_call.c:851
else{
right_pair = FALSE;
}
and then the correct conversation is never found, because right_pair is
never reset for this packet, which leads to total confusion of the call
tracking logic
Fixed by initializing right_pair = TRUE for every loop iteration
svn path=/trunk/; revision=14269