Commit graph

5819 commits

Author SHA1 Message Date
Michael Tüxen
d00e6fe59e Fix from Stephen Fisher for bug 2028.
svn path=/trunk/; revision=23621
2007-11-27 17:46:55 +00:00
Jeff Morriss
7b5c60314c Don't attach to any TCP/UDP ports if we weren't able to load the database--and thus the hf_ entries (which are required for dissection).
svn path=/trunk/; revision=23620
2007-11-27 16:08:24 +00:00
Guy Harris
7a4eb3eb35 Check for AVPs with a list of values and a type that's not a 32-bit or
shorter integral type.  Fixes bug 2027.

Rename the "bytes" pointer to "octetstring", and initialize it in a
fashion that makes it clearer that it points to the first of the basic
types, to make it clearer that it's for OctetString.

svn path=/trunk/; revision=23615
2007-11-27 01:41:42 +00:00
Gerald Combs
7731b882f2 From Tuomas Maattanen: Fix a .11e QBSS IE endian error.
svn path=/trunk/; revision=23614
2007-11-27 01:02:03 +00:00
Gerald Combs
1064a1df35 Make sure we fully initialize a struct. Fixes bug 2021.
svn path=/trunk/; revision=23613
2007-11-27 00:36:41 +00:00
Jeff Morriss
1cd46ec7be Get rid of the global data structures populated by wiretap/mpeg-audio but
used by the mpeg-audio dissector: instead keep the data inside the wiretap
module and add accessor functions.  I think this should fix
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1677 and anyway it's
cleaner.

svn path=/trunk/; revision=23612
2007-11-26 23:06:07 +00:00
Jeff Morriss
309f7503e5 Get rid of C++/C99 style comments--not all compilers support them
svn path=/trunk/; revision=23608
2007-11-26 18:55:17 +00:00
Stig Bjørlykke
86f278dda7 Use the offset and length for the interesting data.
svn path=/trunk/; revision=23607
2007-11-26 18:51:24 +00:00
Jeff Morriss
dd0a4750b0 s/stat/eth_stat/ and s/unlink/eth_unlink/ to avoid non-ASCII filename problems on Windows.
svn path=/trunk/; revision=23605
2007-11-26 18:35:37 +00:00
Jeff Morriss
c5ab162b37 gcc-4.1.1 thinks 'retval' might not get set inside the TRY(). Initialize it.
svn path=/trunk/; revision=23603
2007-11-26 17:28:12 +00:00
Stig Bjørlykke
a26ea5739a Use correct offset for subtree in dissect_spoolss_relstr.
svn path=/trunk/; revision=23602
2007-11-26 17:03:12 +00:00
Stig Bjørlykke
e5461f3307 From Kai Blin:
Dissect the PRINTER_INFO structure in the SpoolssEnumPrinters call.

From me:
Add the level info to COL_INFO.

svn path=/trunk/; revision=23600
2007-11-26 16:38:26 +00:00
Sebastien Tandel
d580971f07 Update error handling of UDP Light Illegal Checksum value 0
* change expert group from PI_MALFORMED to PI_CHECKSUM (as it should be!!!).
  * set item hf_udp_checksum_[good|bad] as generated


svn path=/trunk/; revision=23599
2007-11-26 14:42:38 +00:00
Sebastien Tandel
6c4f9f0479 iUpdate error handling of UDP Light Illegal Checksum value 0
* Adding PI_MALFORMED expert field for this case.
  * Adding an error string in COL_INFO.


svn path=/trunk/; revision=23598
2007-11-26 14:30:40 +00:00
Gerald Combs
3697704b62 Fix bug 2019: The SMB dissector was dereferencing a NULL pointer.
svn path=/trunk/; revision=23593
2007-11-25 23:08:09 +00:00
Stig Bjørlykke
4e9892cbfd Added checksum.good and checksum.bad items.
svn path=/trunk/; revision=23590
2007-11-25 21:30:57 +00:00
Stig Bjørlykke
a2b5cf9528 Added checksum.good and checksum.bad items.
svn path=/trunk/; revision=23589
2007-11-25 21:30:33 +00:00
Jaap Keuter
054ed14e67 Header field array and whitespace cleanup.
svn path=/trunk/; revision=23588
2007-11-25 19:20:32 +00:00
Sake Blok
9f829f4ba2 Bug 1997 From Timo Teras:
Patch to do the following:
1) Dissect CIE Lists in NHRP Extensions
2) Dissect original NHRP packet in Error Indication
3) Support for Cisco NAT extensions
4) Support for Cisco NHRP Traffic Indication packet


svn path=/trunk/; revision=23587
2007-11-25 18:10:01 +00:00
Graeme Lunt
a7dec11ce6 Changes suggested/provided by Anders so that fewer changes are required to the ASN modules.
Also includes the MSAccessProtocol.asn to generate defines for the operation numbers.


svn path=/trunk/; revision=23586
2007-11-25 17:46:42 +00:00
Jaap Keuter
f4054ad148 Based on suggestion from Stig Bjørlykke. Add CRC tree even when CRC is missing.
svn path=/trunk/; revision=23584
2007-11-25 15:36:38 +00:00
Stig Bjørlykke
6f1ab30f2f From Joe Eykholt:
Show content even if the trailer is missing.

From me:
Add proto_tree_set_appendix for the checksum and EOF.

svn path=/trunk/; revision=23581
2007-11-25 12:15:02 +00:00
Stig Bjørlykke
82041ad3b6 Set an initial value to make gcc 4.1.3 20070929 (prerelease) on Ubuntu happy.
svn path=/trunk/; revision=23580
2007-11-25 02:20:41 +00:00
Stig Bjørlykke
6341d80f07 From Graham Bloice:
Show correct TCP segment data (and length) when multiple pdus.

svn path=/trunk/; revision=23572
2007-11-24 23:04:49 +00:00
Stig Bjørlykke
0cb8d7e554 From Alex Burlyga:
It looks like in dissect_nfs_open_claim_delegate_cur4() instead of dissection
stateid we are doing something wierd and dissecting uint64 instead(remnants of 
rfc3010 where stateid was 64 bit number?). We already have function for
dissecting stateids, so just a matter of making a different call. 

From me:
Also deleted the hf_nfs_stateid4_delegate_stateid entry.

svn path=/trunk/; revision=23571
2007-11-24 22:45:57 +00:00
Stig Bjørlykke
6c090a68bf From J. Bruce Fields:
Add basic support for NFSv4.1, as of about draft 13 of the current spec.
The protocol is not completely finished yet, and future patches will be
needed to bring it up to date.

From me:
- Add a check for valid pointers in nfsv4_operation_ett
- Always increase offset when calling dissect_nfs_devices4
- Added a default case in dissect_rpc_secparms4

svn path=/trunk/; revision=23570
2007-11-24 22:09:01 +00:00
Gerald Combs
7d5b4af5d0 Make sure h225_pi is never NULL.
svn path=/trunk/; revision=23568
2007-11-24 19:13:54 +00:00
Jeff Morriss
330c9d0b4b Fix crash reported in http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2014 : when adding fragments to the linked list of end fragments, don't check the TSN of the begin fragment--it may not be there. Looks like a cut-n-pasteo.
svn path=/trunk/; revision=23567
2007-11-24 17:56:46 +00:00
Anders Broman
0d92db6781 Export classes from ROS - hopfully without breaking stuff.
svn path=/trunk/; revision=23566
2007-11-24 17:39:31 +00:00
Jeff Morriss
29cb0d329b Fix bug http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2011 : check SSN in both Called and Calling addresses even when we know the direction of the messages
svn path=/trunk/; revision=23564
2007-11-24 15:43:39 +00:00
Jeff Morriss
8058db81b9 Fix http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2006 : use 0xffffff (reserved value) for unset xLRs
svn path=/trunk/; revision=23563
2007-11-24 15:38:19 +00:00
Gerald Combs
118f23a08a Catch a bad bLength, which may cause a loop. Fixes bug 2012.
svn path=/trunk/; revision=23557
2007-11-23 23:31:21 +00:00
Gerald Combs
4510d63626 Fix bug 2007 (a loop in IPv6).
svn path=/trunk/; revision=23555
2007-11-23 20:15:28 +00:00
Guy Harris
38ab1b8e7a Set the usual properties on packet-wps.[ch].
svn path=/trunk/; revision=23553
2007-11-23 18:48:49 +00:00
Stig Bjørlykke
2ad24805fe No $Id:$ in new files?
svn path=/trunk/; revision=23551
2007-11-23 18:29:00 +00:00
Guy Harris
5586f6764a Include packet-wps.h, so it's part of the source tarball.
svn path=/trunk/; revision=23550
2007-11-23 18:25:39 +00:00
Stig Bjørlykke
d6f0b0c2af From Jens Braeuer:
Added support for Wifi Simple Config aka Wifi Protected Setup

From me:
Added standard copyright header to packet-wps

svn path=/trunk/; revision=23549
2007-11-23 17:48:28 +00:00
Stig Bjørlykke
5e1ffde520 Moved check for empty choice to make it work correctly.
svn path=/trunk/; revision=23548
2007-11-23 12:22:22 +00:00
Stephen Fisher
3b46983e9f Make previously removed ethertype preference obsolete. For inclusion in
0.99.7 release.


svn path=/trunk/; revision=23545
2007-11-22 19:02:31 +00:00
Stig Bjørlykke
92682d51de Added handling of octet-aligned data according to direct_reference.
Implemented handling of ber_callback for tagged type octet-aligned
and arbitrary.  Renamed some functions.

svn path=/trunk/; revision=23539
2007-11-21 23:33:13 +00:00
Sake Blok
ceaeb1f977 Bug 1994: From Keith Mercer :
This bugfix is focused only in the Sender ID TLV segment of code.  This was to
address the possibility that the Sender ID TLV may not have a Management
Address Domain, and/or a Management Address.  This bug was discovered when
testing the dissector using CFM-enabled Netopia modems.


svn path=/trunk/; revision=23534
2007-11-21 20:33:50 +00:00
Gerald Combs
f3fdef83d6 Don't try to overwrite read-only memory. Fixes bug 2001.
svn path=/trunk/; revision=23529
2007-11-21 17:00:24 +00:00
Tomas Kukosa
7c48c9ab80 more SSL debug info concerning conversation and ssl_session
svn path=/trunk/; revision=23528
2007-11-21 14:10:55 +00:00
Michael Tüxen
928bebeb01 Update to draft-ietf-rserpool-common-param-15.txt. (Will
be published soon...)

svn path=/trunk/; revision=23520
2007-11-20 21:21:56 +00:00
Gerald Combs
13a01fef37 Add a bounds check in order to try to fix bug #1998.
svn path=/trunk/; revision=23517
2007-11-20 19:17:19 +00:00
Jeff Morriss
be81aa150e Reindent some to improve readability
svn path=/trunk/; revision=23510
2007-11-20 16:51:14 +00:00
Tomas Kukosa
7eb5048da9 fix tag handling inside snmp trap
svn path=/trunk/; revision=23508
2007-11-20 13:55:39 +00:00
Stephen Fisher
1ab4398a47 Introduce use of the new FT_EBCDIC field type as a second display of
text fields (data & sqlstatement).  Also fix the options on the FT_STRINGZ
items - change them to FT_STRING and change BASE_DEC to BASE_NONE.


svn path=/trunk/; revision=23505
2007-11-19 21:28:17 +00:00
Jeff Morriss
53faa469bd Detect reneged acks or at least retransmissions after an ack was seen. Mark
them with an expert info (PI_WARN).

Change "Duplicate TSN" expert info to "Retransmitted TSN" and make it PI_NOTE
instead of PI_WARN.

Change "More than 100 TSNs gap-acked" expert info to PI_WARN (from PI_NOTE).

Frame numbers (and count of retransmissions) are unsigned, display them that way.

svn path=/trunk/; revision=23502
2007-11-19 20:34:57 +00:00
Stig Bjørlykke
8fc83d2cf3 Improved "BER Error" messages to be more uniform.
svn path=/trunk/; revision=23501
2007-11-19 20:23:49 +00:00