Commit Graph

48808 Commits

Author SHA1 Message Date
Michael Mann 239971eca9 Fix some expert filter field names (one of which was illegal)
svn path=/trunk/; revision=51763
2013-09-05 02:52:08 +00:00
Michael Mann dd4b03512f Remove commented out expert_add_info_format
svn path=/trunk/; revision=51762
2013-09-05 01:42:11 +00:00
Michael Mann 0c49b4d872 Add filterable expert info to dissect_802_3() and clean up the shrapnel.
svn path=/trunk/; revision=51761
2013-09-05 01:39:35 +00:00
Michael Mann e65df7f453 Batch of filterable expert info.
Some of the FT_NONE hf_ variables were removed in favor of proto_tree_add_expert. It may also be possible to remove some of the booleans surrounding the expert info.

New expert display filters may need to be double-checked to make sure they make sense.

svn path=/trunk/; revision=51760
2013-09-05 01:05:16 +00:00
Gerald Combs 03fd39d7f0 Throughput graph updates.
GTK+: Fix what appears to be an off-by-one error in the MA period (21
segments instead of 20). Throw away our initial segment length instead
of subtracting it from the moving sum, which skews the sum.

Qt: Add the througput graph. Use bits/s for the throughput y axis. Let
the user switch between graph types. The dialog hangs when doing this. I
haven't been able to track down the cause. Remove some unused code.

Both: Tell the user that we're using a 20 segment moving average. Move
more routines to tap-tcp-stream.[ch].

svn path=/trunk/; revision=51759
2013-09-04 23:15:59 +00:00
Martin Kaiser 1abd5a5965 dissect some more items of the smart card descriptor
svn path=/trunk/; revision=51758
2013-09-04 22:00:41 +00:00
Evan Huus 14d589a0a7 Remove some emem functions that have now been completely replaced by wmem.
Finally...

svn path=/trunk/; revision=51757
2013-09-04 21:24:51 +00:00
Evan Huus cad50146e3 Remove what appear to be the last two instances of pe_tree. Could this be the
first emem API to die?

svn path=/trunk/; revision=51756
2013-09-04 21:14:55 +00:00
Michael Tüxen 90ac3f129f Improve the display of AUTH related parameters.
Only use IANA registered values for HMAC ids.

svn path=/trunk/; revision=51755
2013-09-04 21:07:09 +00:00
Evan Huus 48089ba4ca Use epan-scoped memory for building more of the diameter table stuff.
svn path=/trunk/; revision=51754
2013-09-04 21:06:56 +00:00
Evan Huus 4fade3bc2d Convert GCP to wmem. It is only called from dissectors in the proper scope
already (yay!).

svn path=/trunk/; revision=51753
2013-09-04 20:42:12 +00:00
Anders Broman f5b85d81d0 From Katrina Zhang:
Fix QoS dissection.

svn path=/trunk/; revision=51752
2013-09-04 18:11:21 +00:00
Anders Broman 3813c0b72d From Katrina Zhang:
Add Grouped AVP:s

svn path=/trunk/; revision=51751
2013-09-04 18:10:33 +00:00
Anders Broman a53b483969 From Katrina Zhang:
Change to tfs_enabled_disabled.

svn path=/trunk/; revision=51750
2013-09-04 18:10:00 +00:00
Anders Broman 10f7f95d09 From Katrina Zhang:
637 UAR-Flags dissection.

svn path=/trunk/; revision=51749
2013-09-04 18:08:08 +00:00
Martin Mathieson 86656b31d2 Another small step towards modelling and reporting upon DRX state in
MAC.

svn path=/trunk/; revision=51748
2013-09-04 16:56:37 +00:00
Evan Huus 8eb0bfdc5b Fix one small memory leak.
svn path=/trunk/; revision=51747
2013-09-04 12:01:09 +00:00
Evan Huus d11c7d5480 Always initialize the hash when dissecting nfsv3 file handle. Fixes the recent
valgrind fuzz failure.

svn path=/trunk/; revision=51746
2013-09-04 11:46:01 +00:00
Anders Broman 55f7519fc2 From Tyson Key:
Update the InListPassiveTarget Response handler to dissect the ISO 14443-A ATQA, and UID values from InnoVision/Broadcom Topaz cards/tags.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9096

svn path=/trunk/; revision=51745
2013-09-04 04:47:38 +00:00
Pascal Quantin a59b5388a9 From Andreas Urke via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9091 :
Add support for CFM R-APS/G.8032 version 2

From me: convert a few value_string to true_false_string

svn path=/trunk/; revision=51744
2013-09-03 22:05:22 +00:00
Pascal Quantin 69dfcffbc0 Remove obsolete code
svn path=/trunk/; revision=51743
2013-09-03 21:25:16 +00:00
Chris Maynard 6fc009baac Similar to the IPv4 dissector's hf_ip_dst_host, hf_ip_src_host and hf_ip_host fields, add to the Ethernet dissector:
hf_eth_dst_resolved
hf_eth_src_resolved
hf_eth_addr_resolved

and add to the IEEE802.11 dissector:

hf_ieee80211_addr_da_resolved
hf_ieee80211_addr_sa_resolved
hf_ieee80211_addr_ra_resolved
hf_ieee80211_addr_ta_resolved
hf_ieee80211_addr_bssid_resolved
hf_ieee80211_addr_resolved

Change motivated by:
http://ask.wireshark.org/questions/24314/possible-to-use-the-mac-info-in-the-wireshark-manuf-file-as-part-of-display-filter

svn path=/trunk/; revision=51742
2013-09-03 21:20:59 +00:00
Pascal Quantin a65045ec3f Code cleanup:
- remove some useless trees
- prettify the dissection of a few IEs
- use ELEM_MAND_VV_SHORT macro where applicable

svn path=/trunk/; revision=51741
2013-09-03 21:10:05 +00:00
Anders Broman 79352919a6 Fix "malformed packet" and tidy up a bit.
svn path=/trunk/; revision=51740
2013-09-03 19:04:13 +00:00
Gerald Combs b5e4fd5a01 Document the current state of naming in ui/qt. Say it's OK to use C++
comments in C++ code.

svn path=/trunk/; revision=51739
2013-09-03 18:50:17 +00:00
Anders Broman 4a226911da Protect agains infinite loop.
svn path=/trunk/; revision=51738
2013-09-03 18:47:44 +00:00
Alexis La Goutte dc1477b79b Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=51737
2013-09-03 18:44:42 +00:00
Alexis La Goutte 5098965030 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=51736
2013-09-03 18:44:16 +00:00
Alexis La Goutte 6ac93da7f9 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=51735
2013-09-03 18:43:50 +00:00
Alexis La Goutte b4a4a768dc Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=51734
2013-09-03 18:43:29 +00:00
Alexis La Goutte 154d793f1e Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=51733
2013-09-03 18:43:11 +00:00
Alexis La Goutte 6934553230 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=51732
2013-09-03 18:42:49 +00:00
Alexis La Goutte 7ecb6b1d7d Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=51731
2013-09-03 18:42:01 +00:00
Pascal Quantin 637d5990b9 Add missing svn properties
svn path=/trunk/; revision=51730
2013-09-03 18:35:49 +00:00
Pascal Quantin 9de7a12476 Fix "Tones off" value typo introduced in r51613
svn path=/trunk/; revision=51729
2013-09-03 18:29:34 +00:00
Michael Tüxen cc96a45c9a Fix a syntax error in a FreeBSD specific code part.
svn path=/trunk/; revision=51728
2013-09-03 17:54:23 +00:00
Michael Mann 20227036fc Add MACSEC dissector
From Allan W. Nielsen, bug 9094 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9094)

svn path=/trunk/; revision=51727
2013-09-03 17:35:00 +00:00
Evan Huus feb39701c5 Decompress gzipped Kafka messages.
svn path=/trunk/; revision=51726
2013-09-03 16:43:08 +00:00
Gerald Combs dc002f2524 Add a note about making the behavior more native on Windows and OS X.
svn path=/trunk/; revision=51725
2013-09-03 16:30:38 +00:00
Gerald Combs 3331d6d4e9 Use more consistent naming.
svn path=/trunk/; revision=51724
2013-09-03 16:14:38 +00:00
Evan Huus 259ebc5269 Respect the other layout preference in qtshark: which pane goes in which spot.
svn path=/trunk/; revision=51723
2013-09-03 16:06:20 +00:00
Jörg Mayer 7cd3ff3a8e Fix for
QWidget::setWindowModified: The window title does not contain a '[*]' placeholder

a) Add [*] to the window title.
b) Also set the window title before calling setWindowModified

Not really understanding what I'm doing here, just following the hints
given in http://qt-project.org/forums/viewthread/2108

Original logmessages when closing Wireshark while running a capture.

17:23:39.652 Capture Msg  Capture stopped!
17:23:39.653 Main Dbg  Callback: capture update finished
QWidget::setWindowModified: The window title does not contain a '[*]' placeholder
FIX: packet list heading menu sensitivity
17:23:39.653  Dbg  FIX: capture_info_ui_destroy
17:23:39.653 Main Dbg  Callback: Closing
FIX: packet list heading menu sensitivity
17:23:39.655 Main Dbg  Callback: Closed


svn path=/trunk/; revision=51722
2013-09-03 15:35:32 +00:00
Jörg Mayer ee8719e2e1 Fix typo: =+ ---> +=
svn path=/trunk/; revision=51721
2013-09-03 13:49:48 +00:00
Evan Huus a795048300 Correctly update the pane layout whenever the preferences are changed, you no
longer need to restart for that to take effect. Hopefully I got all the slot
ordering right.

svn path=/trunk/; revision=51720
2013-09-03 13:29:09 +00:00
Evan Huus 78529b2038 Separate window creation from the laying out of the list/tree/byte panes. This
more-or-less restores the correct splash behaviour on startup.

svn path=/trunk/; revision=51719
2013-09-03 12:53:32 +00:00
Evan Huus 16cbf7d4cf Parent the list, tree and byte panes from the main UI rather than the
splitters they're actually layed out in. This should let us reorganize the
splitters at will (when the prefs change) without reconstructing the panes.

svn path=/trunk/; revision=51718
2013-09-03 12:21:14 +00:00
Alexis La Goutte 3c08741cae Enhance DNS Dissector Remove bad_rr goto !
Code is fuzzed (9 Pass with more of 400 DNS files)

svn path=/trunk/; revision=51717
2013-09-03 06:36:43 +00:00
Alexis La Goutte 6f4225a6f4 Enhance NSEC3,NSEC3PARAM TLSA type visibility
svn path=/trunk/; revision=51716
2013-09-03 06:36:33 +00:00
Alexis La Goutte 29d07267df Add dissection of EUI Family (draft-jabley-dnsext-eui48-eui64-rrtypes) DNS Rcode (EUI48, EUI64)
svn path=/trunk/; revision=51715
2013-09-03 06:36:23 +00:00
Alexis La Goutte 3f3a394932 Add Dissection of ILNP (RFC6742) DNS Rcode (NID, L32, L64, LP)
svn path=/trunk/; revision=51714
2013-09-03 06:36:12 +00:00