Commit Graph

43 Commits

Author SHA1 Message Date
Chris Maynard dbc48efbe8 Wrap assoc_tree within #if 0 ... #endif. Fixes Coverity CID 1049.
svn path=/trunk/; revision=37089
2011-05-12 17:25:43 +00:00
Gerald Combs aaeca955a5 Try to fix more Clang scan-build warnings.
svn path=/trunk/; revision=36005
2011-02-18 21:44:06 +00:00
Stig Bjørlykke 17485dbd86 Fixed no_sua_assoc init.
svn path=/trunk/; revision=35980
2011-02-17 11:00:54 +00:00
Anders Broman 31f1c264fb - Introduce association tracking(might not work well with multihoming).
- prefix hf variables with sua ( hf_sua...)

svn path=/trunk/; revision=35979
2011-02-17 10:13:05 +00:00
Jeff Morriss a167206685 Introduce, and start using, tvb_ip_to_str() and tvb_ip6_to_str(). These
do the same as the non-tvb equivalents but take a TVB and an offset instead
of a pointer to an array of bytes.

Their purpose is to prevent (many) dissectors from doing:
ip_to_str(tvb_get_ptr(...)).

(About the names and the location: I like the names as they are but the names
imply that they should live in tvbuff.c.  That would make some sense but
I didn't want to pull to_str.h into tvbuff.c...)

svn path=/trunk/; revision=35519
2011-01-13 15:53:30 +00:00
Jeff Morriss 5efa40982a Don't pass the result of tvb_get_ptr() into a %s format string: the string may
not be NULL terminated.  Use tvb_get_ephemeral_string() instead.

svn path=/trunk/; revision=35376
2011-01-05 15:18:54 +00:00
Guy Harris a8bc4a0d13 Rename the routines that handle dissector tables with unsigned integer
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys.  (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)

svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
Jeff Morriss 967caad77c Use a gboolean to store a boolean and change the plurality on the preference name
svn path=/trunk/; revision=33096
2010-06-04 20:48:45 +00:00
Jeff Morriss 6534b8ce4f Add a preference that allows the user to decide if they want the source and
destination address PC or GT (depending on the RI) put in the (pinfo) source and
destination (and thus into the source and destination columns).

This may help (if the IP addresses change but the PC or GT do not) or hurt (if
the PC, GT, or RI change but the IP addresses do not) TCAP's ability to identify
which messages belong to which TCAP "session."

svn path=/trunk/; revision=33094
2010-06-04 20:36:43 +00:00
Jeff Morriss 673a9de331 Set the (pinfo) address if a PC is present (for now: regardless of whether routing is on GT or not).
svn path=/trunk/; revision=33076
2010-06-03 18:57:25 +00:00
Guy Harris 1b444c55fd Refer to the endianness arguments as "encoding" rather than
"representation" - we already use "representation" to refer to the text
representation of fields.

Change some routines with an endianness argument to make it a
representation argument instead; 

svn path=/trunk/; revision=32929
2010-05-24 06:06:17 +00:00
Guy Harris 998677339e Create a new REP_NA value for fields where there are no representations
from which to choose; use that for protocol fields in some protocols
(modify the CORBA generator to use it, and manually update the generated
CORBA dissectors accordingly).

svn path=/trunk/; revision=32777
2010-05-13 00:20:40 +00:00
Guy Harris 308bb550da Instead of using private #defines for the last argument to
proto_tree_add_item(), use the new REP_BIG_ENDIAN and REP_LITTLE_ENDIAN
values.

Use those #defines in variables that represent the byte order, as well.

svn path=/trunk/; revision=32776
2010-05-12 23:45:16 +00:00
Jeff Morriss 508fd83368 Show spare bits in decimal, not as booleans.
svn path=/trunk/; revision=31537
2010-01-15 19:28:28 +00:00
Kovarththanan Rajaratnam b97cfa22fd offset_from_real_beginning() is only called with 0 as second argument, so remove the argument completely. It seems that the second argument only acts as an accumulator allowing offset_from_real_beginning() to call itself recursively. To be consistent offset_from_real_beginning() is renamed to tvb_offset_from_real_beginning().
svn path=/trunk/; revision=29844
2009-09-10 16:54:02 +00:00
Kovarththanan Rajaratnam 8b515e9340 Switch a bunch of dissectors over to using tvb_new_subset_remaining()
svn path=/trunk/; revision=29446
2009-08-16 12:36:22 +00:00
Kovarththanan Rajaratnam 0a5b014cec Don't guard col_clear with col_check
svn path=/trunk/; revision=29344
2009-08-09 07:36:13 +00:00
Stig Bjørlykke b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Jeff Morriss 05322d40f1 Decode SCCP cause values in SUA (using value_strings exported from the SCCP
dissector).

svn path=/trunk/; revision=28599
2009-06-02 15:34:17 +00:00
Bill Meier 6f92b028aa Use some default true_false_string's.
svn path=/trunk/; revision=27983
2009-04-07 12:20:41 +00:00
Bill Meier c0e92cbc04 Fix various typos and spelling errors (mostly in text strings)
svn path=/trunk/; revision=27065
2008-12-20 00:09:02 +00:00
Bill Meier c544c20956 Fix various typos and spelling errors (mostly in text strings)
svn path=/trunk/; revision=27050
2008-12-18 19:08:49 +00:00
Bill Meier a8f30cbca1 Fix some typos and spelling (mostly in text strings)
svn path=/trunk/; revision=27037
2008-12-17 17:23:37 +00:00
Stig Bjørlykke e6a22e689e Fix some "format not a string literal and no format arguments" warnings.
svn path=/trunk/; revision=26648
2008-10-31 15:34:00 +00:00
Bill Meier aa30dcd129 Minor proto_reg_handoff cleanup: use find_dissector when appropriate.
svn path=/trunk/; revision=26308
2008-09-30 14:49:44 +00:00
Jeff Morriss ba3f1eaa5a Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2848 :
Decode SUA GT digits.  This removes the (undecoded, raw BCD) FT_BYTES field
sua.global_title_signals and adds an FT_STRING field sua.global_title_digits
(like in SCCP).

svn path=/trunk/; revision=26262
2008-09-24 13:41:47 +00:00
Jeff Morriss 0b1c118f92 A couple of trivial indentation fixes
svn path=/trunk/; revision=26225
2008-09-17 15:54:55 +00:00
Jeff Morriss 740a53095c Put Data dissection (if no subdissector is found) on the toplevel tree instead of within the SUA tree.
svn path=/trunk/; revision=26211
2008-09-15 20:35:02 +00:00
Luis Ontanon fc9e7b97ba remove debugging printouts.
svn path=/trunk/; revision=21236
2007-03-27 23:06:24 +00:00
Luis Ontanon 9dbe9adf50 Another iteration over sctp calls (RANAP/BSSAP) a step towards TCAP/(MAP/IMAP/CAMEL)
- Fix SUA calls (I would need some more traces to test this)


svn path=/trunk/; revision=21235
2007-03-27 23:00:55 +00:00
Luis Ontanon 7f3e4fea48 Mine:
* add SUA to the "VoIP Calls" tap.
* propagate changes to packet-sccp.h to other dissectors

From Neil Piercy:
* add SLR, DLR and CAUSE to COL_INFO

svn path=/trunk/; revision=21126
2007-03-22 22:59:20 +00:00
Michael Tüxen fe5f26af7b Register the dissector.
svn path=/trunk/; revision=19609
2006-10-19 17:25:13 +00:00
Anders Broman 18c69d17b0 Add a heuristic table to SUA (SUA and SCCP should share the same table) to heuristically
dissect RANAP ower SUA.

svn path=/trunk/; revision=18616
2006-06-29 20:39:53 +00:00
Ronnie Sahlberg feab79e328 change a whole bunch of ethereal into wireshark
svn path=/trunk/; revision=18196
2006-05-21 04:49:01 +00:00
Jörg Mayer f9a57f08d1 Bill Meier:
Spelling fixes.

svn path=/trunk/; revision=16956
2006-01-05 13:01:08 +00:00
Anders Broman 8d05164bec Get rid of duplicted dissector tables for MTP3 Service indicator and SCCP ssn:s
svn path=/trunk/; revision=16815
2005-12-16 07:05:50 +00:00
Guy Harris b7b80d94be Move a pile of protocol-related headers from the top-level source
directory to the epan directory.  Some of them should perhaps ultimately
be moved to epan/dissectors, if they pertain only to stuff exported by a
particular dissector.

Fix Gerald's e-mail address in files we're moving.

svn path=/trunk/; revision=15844
2005-09-17 00:02:31 +00:00
Michael Tüxen 95ddff547d From Jeff Morris: Display PC structured.
svn path=/trunk/; revision=13802
2005-03-18 19:50:17 +00:00
Michael Tüxen db21ed4e2d From Jeff Morris: display protocol class at parameter level.
svn path=/trunk/; revision=13800
2005-03-18 14:32:41 +00:00
Ulf Lamping 5bcad85d01 Again, some warnings removed.
svn path=/trunk/; revision=12842
2004-12-27 13:17:20 +00:00
Michael Tüxen 28a6169ff7 - Added support for version 08 of the ID (expired).
- Updated support for latest version to RFC 3868.

svn path=/trunk/; revision=12138
2004-09-29 18:08:18 +00:00
Guy Harris bbe7f89742 Move prefs.c and prefs.h into the epan subdirectory.
svn path=/trunk/; revision=12115
2004-09-27 22:55:15 +00:00
Gilbert Ramirez 669db206cb Move dissectors to epan/dissectors directory.
Also move ncp222.py, x11-fields, process-x11-fields.pl,
make-reg-dotc, and make-reg-dotc.py.

Adjust #include lines in files that include packet-*.h
files.

svn path=/trunk/; revision=11410
2004-07-18 18:06:47 +00:00