Extract the payload from I-blocks and support reassembly of APDUs that
are encapsulated in I-blocks. ISO14443 assumes that the fragments arrive
in order and no fragments are missing.
For now, we pass the reassembled APDU to the data dissector.
Change-Id: I526f6e6d699b2a1dfc4593536154bc9b58dea96e
Reviewed-on: https://code.wireshark.org/review/23506
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Bring up an expert info instead of throwing an exception. Point to the
item that contains the invalid offset. Exit normally, returning the
number of bytes we consumed so far.
Change-Id: I97826a41c6713a97404ca437b9be60c77e009918
Reviewed-on: https://code.wireshark.org/review/23507
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
SequenceDialog no longer emits goToPacket as of g7fe45cc0ec. Don't try
to connect it in MainWindow.
Change-Id: I0f3e47a3cf7c1e29a64da7462c85179e29828c49
Reviewed-on: https://code.wireshark.org/review/23501
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Change-Id: Ib2b3e2116ea806c8198b99a2d5e992b24907b684
Reviewed-on: https://code.wireshark.org/review/23491
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Obviate allocation on every call to get_plugins_pers_dir().
Change-Id: I089ae499f93739d490d4552f59b5db5996f7d26f
Reviewed-on: https://code.wireshark.org/review/23495
Petri-Dish: João Valverde <j@v6e.pt>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Reviewed-by: João Valverde <j@v6e.pt>
Change-Id: I7926baf5e0b7d50ca6ab5c3c1af5fba7e906202d
Reviewed-on: https://code.wireshark.org/review/23492
Petri-Dish: Michael Mann <mmann78@netscape.net>
Reviewed-by: Michael Mann <mmann78@netscape.net>
This allows for less "skipping" when processing the list
Bug: 13784
Change-Id: I40fb5d5a82e51238751dd6785502ea259de9bc03
Reviewed-on: https://code.wireshark.org/review/23445
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Otherwise in case of frames containing multiple BTATT packets at
different levels of encapsulation, we can retrieve the wrong structure
and start using the union with a wrong opcode based type
Bug: 14049
Change-Id: Ica5d8af8e84161d6f9daebbb90334f20082c5fa4
Reviewed-on: https://code.wireshark.org/review/23470
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Add support for dissecting new TLS 1.3 Signature Algorithms (like
RSASSA-PSS) and add the text to the tree item to prevent expanding the
item. The field names are preserved for backwards compatibility.
Change-Id: Ieb8c7a86f6e19b8d6c89590d87d59a01d9bb1351
Ping-Bug: 12779
Reviewed-on: https://code.wireshark.org/review/23474
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Diameter dynamically create the SRT entries during runtime.
Delay the SRT table addition to the end of dissection to properly handle
this use case.
Bug: 13442
Change-Id: Id498f8d9bb4a1d7c632c9a556239bf74d0530f2a
Reviewed-on: https://code.wireshark.org/review/23443
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Change-Id: I34d631ac913620dbc661b9d56d4e34502c9b7d35
Reviewed-on: https://code.wireshark.org/review/23459
Petri-Dish: Michael Mann <mmann78@netscape.net>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Change-Id: I8bd9e76e44254c45be26c616bf22f712bcf50881
Reviewed-on: https://code.wireshark.org/review/23456
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Decrypted TLS records must be stored in a single SslPacketInfo or else
plaintext will go missing (in Follow SSL or when subdissectors need
reassembly). As this structure is currently keyed by the layer number
(pinfo->curr_layer_num) which is changed by call_dissector, it must be
copied and propagated before calling subdissectors.
Change-Id: Ic42ba6c0854154272058f9bf9796e06ad7f94bfd
Fixes: v2.3.0rc0-3740-ge1f84f985e ("Fix Decode As for protocols that may use tunneling.")
Bug: 13885
Reviewed-on: https://code.wireshark.org/review/23190
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
It avoids leaking memory in case an exception is thrown during
dissection
Change-Id: Ib25c6a82b90ca541db121a79515a087d8d2c332f
Reviewed-on: https://code.wireshark.org/review/23468
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
It avoids leaking memory in case an exception is thrown during
dissection
Change-Id: Ic1ce27800e699b01492f1d40ce720fc82416cfbc
Reviewed-on: https://code.wireshark.org/review/23467
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>
It avoids leaking memory in case an exception is thrown during
dissection
Change-Id: Ic63a8ad7923c81c7c7d7f0c471e304d8a5224212
Reviewed-on: https://code.wireshark.org/review/23465
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>
It avoids leaking memory in case an exception is thrown during
dissection
Change-Id: Iab72bcb4cc1ac56e7ce5ff2693e3111aead03e7d
Reviewed-on: https://code.wireshark.org/review/23464
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>
It avoids leaking memory in case an exception is thrown during
dissection
Bug: 14050
Change-Id: Ia17855646774ffa7bd93e0c8d578fa30f4df1394
Reviewed-on: https://code.wireshark.org/review/23463
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Notify payload according to RFC 5996.
Also fixed a bug where the dissection of the previously
added support for the SIGNATURE_HASH_ALGORITHMS Notify payload would not work properly.
Change-Id: I54ffe6b0d8b52189af3dc2e879e6665739fc36a4
Reviewed-on: https://code.wireshark.org/review/23439
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Remove the RSA UAT completely when built without GnuTLS,
because we require GnuTLS for parsing PEM and PKCS #12 keys.
RSA encrypted packets can still be decoded if they are using the
standard OTServ RSA key, which is hard-coded.
Bug: 13959
Change-Id: I6bfc2bebaf8a49933d55fb5c3fcb8efbf58f1e6e
Fixes: g62c9a8a865
Reviewed-on: https://code.wireshark.org/review/23453
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Joakim Karlsson <oakimk@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Bug: 13998
Change-Id: Idd369e364bd2464b278fb4abcc1e77a0f8892641
Reviewed-on: https://code.wireshark.org/review/23452
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
The first pass and other passes with NULL proto_tree caused a malformed packet
exception. This was due to an outdated if (tree) check that is now removed.
While we are at it, adjust documentation to reflect the actual maximum version
supported: 11.00 and add the new (yet unused) version traits.
Bug: 13959
Fixes: g62c9a8a865
Change-Id: If3e1093c881c0eb5070fefc9877cf5f0c61a7572
Reviewed-on: https://code.wireshark.org/review/23446
Petri-Dish: Michael Mann <mmann78@netscape.net>
Reviewed-by: Michael Mann <mmann78@netscape.net>
1. Remove packet-zep.h and incorporate into packet-zep.c
2. Use proto_tree_add_item_ret_uint to get fields that are used to populate
columns and appended items.
3. Intermix tree and column logic for more straightforward logic.
Change-Id: If0f050307ece51260d43e5e98867b0f914492c12
Reviewed-on: https://code.wireshark.org/review/23442
Petri-Dish: Michael Mann <mmann78@netscape.net>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Otherwise _U_ is not defined.
Change-Id: I221f64c7d89c221e5a63a573e06457699d0a177e
Reviewed-on: https://code.wireshark.org/review/23440
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Bug: 13826
Change-Id: I01674d5a31281508686bc06e222d6a87926d1c83
Reviewed-on: https://code.wireshark.org/review/23436
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Bug: 14039
Change-Id: Ic19c77bb091cd8ee8f824b82463d8b4bae37f625
Reviewed-on: https://code.wireshark.org/review/23437
Reviewed-by: Michael Mann <mmann78@netscape.net>
Ping-Bug: 6694
Change-Id: If11e96fce56c5dc92c92765b4fd5632de53060cd
Reviewed-on: https://code.wireshark.org/review/23430
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
* Decoding of Allocation/Retention Priority (ARP)
* Fix order of ARP in GTPv2
Change-Id: Ica24877f3518b5e0b6883ba535ffe09be8f446c2
Reviewed-on: https://code.wireshark.org/review/23431
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
