Commit Graph

37980 Commits

Author SHA1 Message Date
Guy Harris 9dc26776e4 Add support for writing WTAP_ENCAP_PER_PACKET files; they are written
out in version 2.1 of the file format (the minimum version to support
that).

Change some data types to avoid having file offsets that are before the
beginning of the file.

Clean up some other data types and some comments.

svn path=/trunk/; revision=39898
2011-11-17 09:03:09 +00:00
Anders Broman befe8805a6 Add a missing IE number.
svn path=/trunk/; revision=39897
2011-11-17 06:46:34 +00:00
Guy Harris f3a88d4084 Return *some* error if we end up trying to seek before the beginning of
the file, so you don't get weird random errors.  EINVAL is as good as
anything.

svn path=/trunk/; revision=39896
2011-11-17 06:36:32 +00:00
Guy Harris eacdf1d46f Put back the check for dates that can be represented in DOS format the
way it was *supposed* to be done, rather than backwards.

svn path=/trunk/; revision=39895
2011-11-17 02:29:26 +00:00
Chris Maynard 6f2dc712b9 Revert part of r39883 to avoid dereferencing a NULL pointer. Thanks Clang.
svn path=/trunk/; revision=39894
2011-11-17 02:17:57 +00:00
Gerald Combs 3a2b8d4425 Don't clobber release information for now.
svn path=/trunk/; revision=39893
2011-11-17 01:37:14 +00:00
Gerald Combs 5624924e4a Create/update svnversion.h unless we're only running with --get-*.
svn path=/trunk/; revision=39892
2011-11-17 00:48:21 +00:00
Gerald Combs 3f12c48ace Add an SVN_REVISION variable to config.nmake. This can be used to
retrieve our SVN revision in releases.

Use make-version.pl to set all version information. Be more explicit
about the tasks it performs:

  - Fetching the SVN revision which corresponds to our code. The
    revision can be fetched via "svn info", "git svn info", SubWCRev",
    config.nmake, or by prodding .svn.

  - Setting the version numbers (the "major.minor.micro" triplet).

  - Setting the release information (revision/build number, local build
    identifier)

Remove the "is_release" configuration option and dist-hook target.

When run with a "--set-*" option or no options make sure we leave a
valid svnversion.h behind.


svn path=/trunk/; revision=39891
2011-11-17 00:19:03 +00:00
Chris Maynard 8a630d8e37 Avoid using "POINT" as it causes compiler errors on some systems. Add modelines that match the current file's format. This dissector is now ready to be spiceistributed.
svn path=/trunk/; revision=39890
2011-11-16 21:27:30 +00:00
Chris Maynard 356c6ab416 Don't assign the return value of proto_tree_add_item to a variable if it isn't going to be used. Fixes Coverity CID 1327.
svn path=/trunk/; revision=39889
2011-11-16 20:18:51 +00:00
Chris Maynard 934c2ce1a2 Move FI_RESET_FLAG and PROTO_ITEM_SET_VISIBLE macros to proto.h and fix the FI_RESET_FLAG macro, being sure to use the 1's complement operator, '~', instead of the logical negation operator, '!'. (Fixes Coverity CID 1326).
svn path=/trunk/; revision=39888
2011-11-16 20:09:49 +00:00
Anders Broman 6328122ba3 Dissect national Opcode.
svn path=/trunk/; revision=39887
2011-11-16 19:52:00 +00:00
Guy Harris 8281a7d28e Support nanosecond-resolution time for NetMon 2.x format (it's only
100-nanosecond resolution, but that's still better than microsecond
resolution).

For NetMon 1.x format, only claim to support millisecond resolution, as
that's all you get.

Fix handling of negative time deltas in NetMon 2.x format.

When writing a NetMon file, trim the time of the first packet to
millisecond precision to get the capture start time, so that the start
time written to the file (which has millisecond precision) is the same
as the start time used to calculate the deltas written to the packet
headers.

svn path=/trunk/; revision=39886
2011-11-16 17:54:44 +00:00
Guy Harris 234d0b9614 OK, this should do it.
svn path=/trunk/; revision=39885
2011-11-16 17:13:37 +00:00
Guy Harris 8be474f776 Fix build on Windows.
svn path=/trunk/; revision=39884
2011-11-16 17:12:47 +00:00
Guy Harris 163edbb507 Another place where we have to protect against MSVC's time-conversion
routines blowing up if handed a too-large time_t.

While we're at it, also check for dates that can't be represented in DOS
format (pre-1980 dates).

svn path=/trunk/; revision=39883
2011-11-16 17:08:00 +00:00
Guy Harris 5ceeb22529 Another place where we have to protect against MSVC's time-conversion
routines blowing up if handed a too-large time_t.

svn path=/trunk/; revision=39882
2011-11-16 16:48:02 +00:00
Martin Mathieson 43bf2f8ba6 Show more sequence numbers in info column, and in root nodes.
svn path=/trunk/; revision=39881
2011-11-16 16:32:40 +00:00
Tomas Kukosa bc5301e114 Fix handling of empty OpenType at the end of PDU
svn path=/trunk/; revision=39880
2011-11-16 08:55:02 +00:00
Anders Broman f3c5620c3b - Resorted the IEs in numerical order for easier comparison with the list of constants.
- Added two missing IEs

Solves LPPa embedded payloads not shown within LCS-AP
 https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6478

svn path=/trunk/; revision=39879
2011-11-16 05:54:44 +00:00
Guy Harris 741432d483 Handle ctime() and localtime() returning NULL and localtime() on Windows
blowing up when handed a bad value.

svn path=/trunk/; revision=39878
2011-11-16 03:13:02 +00:00
Guy Harris c73c44cf4b Get rid of unnecessary assignment (the code below it always assigns a
value to the variable).  Praise be to Clang Cat.

svn path=/trunk/; revision=39877
2011-11-16 02:43:58 +00:00
Guy Harris 46575653fd Don't set variables if we don't look at them later. All praise Clang
Cat.

svn path=/trunk/; revision=39876
2011-11-16 02:18:30 +00:00
Bill Meier b7b3df505c Add Jakob Hirsch; Fix bad formatting which screwed up AUTHORS display.
svn path=/trunk/; revision=39875
2011-11-16 02:13:56 +00:00
Bill Meier 1941fd1680 Cleanup & reformatting: whitespace & long-lines.
svn path=/trunk/; revision=39874
2011-11-16 01:59:15 +00:00
Guy Harris 017c9eff05 Thou shalt not use proto_tree_add_string() with an FT_BYTES field.
svn path=/trunk/; revision=39873
2011-11-16 01:56:58 +00:00
Chris Maynard 28e5ff6098 Delete pointless orig_offset variable, initialize speech_data_len[], use tvb_reported_length() instead of tvb_length(), and protect against a possible buffer overflow. This should fix the Clang warning, "packet-evrc.c:364:41: warning: The right operand of '>=' is a garbage value", among other things.
svn path=/trunk/; revision=39872
2011-11-16 01:37:32 +00:00
Guy Harris 225d9b98ef Fix indentation.
svn path=/trunk/; revision=39871
2011-11-16 01:25:49 +00:00
Bill Meier 2103e7f38a tvb_[reported_]length_remaining can return -1
svn path=/trunk/; revision=39870
2011-11-15 21:22:01 +00:00
Bill Meier 3b387d1b8e Remove unneeded #include
svn path=/trunk/; revision=39869
2011-11-15 21:07:37 +00:00
Bill Meier c8a2b19e2b (Trivial) Reformat some long lines & do some whitespace cleanup.
svn path=/trunk/; revision=39868
2011-11-15 20:49:40 +00:00
Anders Broman 8921bb17b5 Check the return value of dissect_sip_name_addr_or_addr_spec()
Should fix the recent fuzz failures.
Thanks Chris for isolating the offending packet.

svn path=/trunk/; revision=39867
2011-11-15 20:14:51 +00:00
Guy Harris 519b219ae8 Squelch a warning. (This code probably needs a review; we really need a
better general framework for parsing text-based protocols.)

svn path=/trunk/; revision=39866
2011-11-15 19:44:24 +00:00
Chris Maynard e7e9d3d8b7 Rename channel_type enums to avoid possible naming conflicts.
svn path=/trunk/; revision=39865
2011-11-15 19:37:16 +00:00
Guy Harris 6dd27d049e More indentation cleanup.
svn path=/trunk/; revision=39864
2011-11-15 19:35:13 +00:00
Guy Harris e102876289 Clean up indentation.
svn path=/trunk/; revision=39863
2011-11-15 19:33:14 +00:00
Anders Broman a586241e06 packet-sip.c:1469: warning: unused variable 'contact_param_end_offset'
svn path=/trunk/; revision=39862
2011-11-15 19:25:17 +00:00
Anders Broman f6f12af894 Restore dissection of contact parameters.
svn path=/trunk/; revision=39861
2011-11-15 19:03:39 +00:00
Bill Meier 36be9da221 Remove unneeded #includes;
Move proto_reg_handoff...() to the end of the file as per convention.

svn path=/trunk/; revision=39860
2011-11-15 19:00:08 +00:00
Bill Meier 199850a52b Move proto_reg_handoff...() to the end of the file as per convention;
Do other minor reformatting and cleanup.

svn path=/trunk/; revision=39859
2011-11-15 18:31:11 +00:00
Bill Meier 02c8228bd2 Add svn:executable to props
svn path=/trunk/; revision=39858
2011-11-15 17:44:14 +00:00
Bill Meier f6e8556a68 Set svn:mime-type to image/png
svn path=/trunk/; revision=39857
2011-11-15 17:41:41 +00:00
Bill Meier 9eba576d23 Set svn:mime-type to image/png
svn path=/trunk/; revision=39856
2011-11-15 17:33:59 +00:00
Bill Meier 804aa453c7 Set svn:mime-type to image/png
svn path=/trunk/; revision=39855
2011-11-15 17:29:27 +00:00
Bill Meier 4987cfd8d5 Set svn:mime-type to image/png
svn path=/trunk/; revision=39854
2011-11-15 17:26:04 +00:00
Bill Meier 1f54861260 Set svn:mime-type to image/png
svn path=/trunk/; revision=39853
2011-11-15 17:18:21 +00:00
Martin Mathieson ed5ac34224 Append important details from LI and SURI trees to root item.
Show some SNs in the info column.

svn path=/trunk/; revision=39852
2011-11-15 15:36:39 +00:00
Bill Meier 47b290c7f5 Fix some props
svn path=/trunk/; revision=39851
2011-11-15 15:28:20 +00:00
Bill Meier 49a47e9745 Fix some svn properties
svn path=/trunk/; revision=39850
2011-11-15 15:16:37 +00:00
Bill Meier 58d87a7230 Fix svn:keywords prop: 'svn:eol-style'->'Id'
svn path=/trunk/; revision=39849
2011-11-15 15:11:35 +00:00