Commit graph

109 commits

Author SHA1 Message Date
Bill Meier
794757ae8f For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.
Also: remove trailing whitespace for a number of files.

svn path=/trunk/; revision=39503
2011-10-21 02:10:19 +00:00
Bill Meier
126aa85393 Convert proto_tree_add_item() 'encoding' arg for field types FT_STRING, FT_STRINGZ, FT_UINT_STRING as follows:
1. If there's no character encoding (ENC_ASCII, ...) specified
    then use ENC_ASCII.
 2. For all but FT_UINT_STRING, always use ENC_NA
    (replacing any existing True/1/FALSE/0
    /ENC_BIG_ENDIAN/ENC_LITTLE_ENDIAN).



svn path=/trunk/; revision=39426
2011-10-15 18:46:26 +00:00
Martin Mathieson
c3d27315ed Avoid longjmp warning by making adding volatile.
svn path=/trunk/; revision=39364
2011-10-11 18:06:01 +00:00
Anders Broman
eeff694c87 - Put a TRY/CATCH block around dissect_h264_nal_unit() in case
a bogus nal unit was sent.
- Delete an unused hf entry.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6407

svn path=/trunk/; revision=39305
2011-10-07 16:42:52 +00:00
Bill Meier
94f36ca4ff Use ENC_NA as encoding for proto_tree_add_item() calls which directly reference an hf item (in hf[] with types:
FT_NONE
   FT_BYTES
   FT_IPV6
   FT_IPXNET
   FT_OID

Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN

svn path=/trunk/; revision=39260
2011-10-04 22:44:31 +00:00
Bill Meier
d2269ce7d5 Fix gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings.
svn path=/trunk/; revision=37716
2011-06-19 18:47:35 +00:00
Bill Meier
a2b58f051d Add #include <stdlib.h> to files which reference fcns declared in stdlib.h;
(In many cases I previously incorrectly removed the #include <stdlib.h>).

svn path=/trunk/; revision=37334
2011-05-20 19:00:09 +00:00
Stephen Fisher
ef5823c210 Put back in one of the includes removed in r36606: ctype.h for isdigit()
function.


svn path=/trunk/; revision=36607
2011-04-12 20:29:42 +00:00
Bill Meier
c85689f108 Don't assign to a proto_item * if the value won't be used: Coverity 1034;
Comment out two calls to tvb_)get_ephemeral_string since the result is never used: Coverity 1035;
Also:
 Remove some unneeded #includes;
 Use consistent indentation.

svn path=/trunk/; revision=36606
2011-04-12 20:19:10 +00:00
Martin Mathieson
473b578880 Remove static that was added to appease Coverity 753. 2016 bytes isn't too much to put on the stack.
svn path=/trunk/; revision=36285
2011-03-23 10:12:35 +00:00
Martin Mathieson
034820599a Make a struct static to avoid growing the stack too much.
Coverity CID 753.

svn path=/trunk/; revision=36255
2011-03-22 17:46:59 +00:00
Guy Harris
a8bc4a0d13 Rename the routines that handle dissector tables with unsigned integer
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys.  (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)

svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
Bill Meier
03b57df5a0 Fix various typos and spelling errors.
svn path=/trunk/; revision=35126
2010-12-06 01:34:58 +00:00
Anders Broman
cab0cef11d Use value_string_ext for RTP payload types.
svn path=/trunk/; revision=34804
2010-11-08 14:43:59 +00:00
Jaap Keuter
12b574e628 Fix for bug 5220:
- Don't list codecs which are deleted by using port 0.
- Use real concatenation i.s.o. reprint, which seems to fail in some circumstances.

svn path=/trunk/; revision=34154
2010-09-18 13:12:03 +00:00
Anders Broman
b1568cb247 Update the comment.
svn path=/trunk/; revision=33777
2010-08-11 21:52:35 +00:00
Anders Broman
ccf8787370 Add a warning message if H264 profile-level-id parameter wasn't
posible to parse.

svn path=/trunk/; revision=33776
2010-08-11 21:39:22 +00:00
Stig Bjørlykke
894f256912 Added check for valid tvb before calling tvb_length().
svn path=/trunk/; revision=33774
2010-08-11 21:27:35 +00:00
Anders Broman
4b9747a74d Add a komment about the format of the MSRP path parameter.
svn path=/trunk/; revision=33764
2010-08-11 11:33:40 +00:00
Anders Broman
326ec92f7c Fix: Malformed packet if port is missing from path.
svn path=/trunk/; revision=33209
2010-06-11 11:49:01 +00:00
Jeff Morriss
47e2d75820 Move some code (including the optional objects) into libwsutil
svn path=/trunk/; revision=33012
2010-05-28 20:19:55 +00:00
Bill Meier
10ffd14b8f Indentation & whitespace cleanup (including: "4 space tabs" ==> spaces)
svn path=/trunk/; revision=32735
2010-05-10 15:54:57 +00:00
Jeff Morriss
67b7737481 Fix the build
svn path=/trunk/; revision=32467
2010-04-14 21:38:08 +00:00
Anders Broman
83ce037aa9 Use the sample rate from SDP info in RTP stream analysis.
svn path=/trunk/; revision=32466
2010-04-14 20:48:37 +00:00
Anders Broman
0424d1716c Extract encoding name and sample rate
i.e "AMR/8000"
This string can then be put in the hastable, extracted by
packet-rtp.c and split into "AMR" and "8000"
sample rate can then be a part of rtp_info and get rid of the
clock rate maping.
(I have some problem splitting the string, help apreciated) :-)

svn path=/trunk/; revision=32455
2010-04-13 19:27:14 +00:00
Anders Broman
25af78517e Make tvb_pbrk_guint8() return the found needle.
svn path=/trunk/; revision=32144
2010-03-08 20:45:13 +00:00
Bill Meier
1a4283ccf8 Fixes for gcc -Wshadow warnings; Fix indentation and do other minor cleanup in a few cases.
svn path=/trunk/; revision=31617
2010-01-22 13:56:19 +00:00
Anders Broman
440c3f9261 From Didier Gautheron:
check_col.diff
Remove redundant calls to check_col() if it guards only one columns function with one parameter after the column type.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4394

svn path=/trunk/; revision=31519
2010-01-13 20:32:01 +00:00
Stig Bjørlykke
d577ca0fa7 Guard #include <sys/types.h> with HAVE_SYS_TYPES_H.
svn path=/trunk/; revision=31053
2009-11-23 18:47:52 +00:00
Gerald Combs
cf8126a808 Instead of initializing the Media Format name to NULL, set it to
"Unknown".  This keeps us from crashing on some platforms if we have an
unknown media format ID.

svn path=/trunk/; revision=31011
2009-11-19 01:50:44 +00:00
Anders Broman
bc9a809b65 From Didier Gautheron:
ep memory can't be used for tvbs defined as data_source.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4054

svn path=/trunk/; revision=30376
2009-10-06 19:15:58 +00:00
Kovarththanan Rajaratnam
00810ff199 * Prefer col_append_str instead of col_append_fstr for constant strings
* Remove check_col guards

svn path=/trunk/; revision=30127
2009-09-24 20:21:23 +00:00
Bill Meier
94f28dd8f9 (FWIW) One step towards including stdio.h & stdlib.h only when req'd.
svn path=/trunk/; revision=29568
2009-08-26 19:27:49 +00:00
Kovarththanan Rajaratnam
17c9803cac Sanitize epan includes
svn path=/trunk/; revision=29499
2009-08-21 20:25:24 +00:00
Kovarththanan Rajaratnam
8b515e9340 Switch a bunch of dissectors over to using tvb_new_subset_remaining()
svn path=/trunk/; revision=29446
2009-08-16 12:36:22 +00:00
Stig Bjørlykke
b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Anders Broman
3a11073d6b Get info about media type(Video or not) a first step towards usage in rtp statistics.
svn path=/trunk/; revision=28415
2009-05-19 18:42:33 +00:00
Anders Broman
c91a384702 Apply some of the patches from:
http://wiki.wireshark.org/Development/Optimization

svn path=/trunk/; revision=28356
2009-05-13 19:46:11 +00:00
Bill Meier
b45c3cb272 Change to prevent "off-the-end" array access if invalid payload-type/media-format;
Prevents crash as reported in bug 3373:
  https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3373)

svn path=/trunk/; revision=27917
2009-03-31 21:47:58 +00:00
Bill Meier
808a4e2c3c Define certain fcns as static (if not used externally).
Also: whiule we're at it: 
 - fix hf[] blurbs as appropriate to use NULL;
 - fix some indentation

svn path=/trunk/; revision=27890
2009-03-29 22:16:26 +00:00
Anders Broman
f77b5f8d77 Handle the case when FMTP parameters are "out-of-order".
-  - Use NULL instead of repeated text in blurb in hf[];

svn path=/trunk/; revision=27889
2009-03-29 21:59:28 +00:00
Anders Broman
e0171e1a79 More size_t casts.
svn path=/trunk/; revision=27880
2009-03-29 13:47:15 +00:00
Anders Broman
8611ec5f5e More size_t casts.
svn path=/trunk/; revision=27879
2009-03-29 12:07:30 +00:00
Bill Meier
09d097e7a7 #include <conversation.h> not req'd ....
svn path=/trunk/; revision=27389
2009-02-06 20:33:53 +00:00
Anders Broman
821deda3ec Set item generated.
svn path=/trunk/; revision=27352
2009-02-02 18:26:26 +00:00
Anders Broman
2b607d7ce7 Dissect H263-1998/2000 Level
svn path=/trunk/; revision=27267
2009-01-19 20:35:52 +00:00
Anders Broman
360d9f94c7 Accept leading space, payload type name is case insensitive.
svn path=/trunk/; revision=26938
2008-12-08 21:31:37 +00:00
Anders Broman
93b9635a41 Dissect part ofconfiguration parameter in SDP for MP4V-ES.
svn path=/trunk/; revision=26754
2008-11-11 20:42:47 +00:00
Anders Broman
2b9d63a4b5 Move common code to base64.c
svn path=/trunk/; revision=25908
2008-08-03 14:27:22 +00:00
Anders Broman
fec43e2350 Update mimetype_and_clock_map and ad samle rate to sdp.
svn path=/trunk/; revision=25860
2008-07-29 15:58:43 +00:00