Commit Graph

47938 Commits

Author SHA1 Message Date
Anders Broman 266e577aee Update to handle version 9.
svn path=/trunk/; revision=50981
2013-07-28 19:25:14 +00:00
Pascal Quantin deee570058 From David Richards via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8870 :
Add Windows specific items to .gitignore

svn path=/trunk/; revision=50979
2013-07-28 16:26:29 +00:00
Jörg Mayer cb3d6a9eda Looks like cfilter_combo_utils.c got removed.
svn path=/trunk/; revision=50978
2013-07-28 15:48:34 +00:00
Graham Bloice 2f6ee944d8 Added more build artefacts to the clean target
svn path=/trunk/; revision=50977
2013-07-28 14:40:56 +00:00
Pascal Quantin e533453ee4 Align info column for UM MCCH/MTCH PDUs
svn path=/trunk/; revision=50976
2013-07-28 14:35:42 +00:00
Gerald Combs 12e86ee2cd [Automatic manuf, services and enterprise-numbers update for 2013-07-28]
svn path=/trunk/; revision=50973
2013-07-28 14:03:35 +00:00
Graham Bloice 71921ced57 clean target misses some build artefacts; capinfos.lib and editcap.lib
svn path=/trunk/; revision=50972
2013-07-28 13:57:12 +00:00
Evan Huus a9bccc8dc8 Don't force the allocator choice in the data-structure tests, we want to be able
to override that to simple for valgrinding (we still force the allocator in the
allocator and timing tests, of course).

svn path=/trunk/; revision=50971
2013-07-28 12:55:37 +00:00
Evan Huus b43996c8ab Fix a bug in the gc routine discovered while formally working out parts of the
algorithm.

Also add a test case to excercise it for future.

svn path=/trunk/; revision=50970
2013-07-28 12:46:44 +00:00
Pascal Quantin 23d40bcfcf Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8841 :
Fix PER normally small non-negative whole number dissection when it is greater than or equal to 64

svn path=/trunk/; revision=50969
2013-07-28 12:36:48 +00:00
Pascal Quantin eddc421d85 From Michal Labedzki via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8948 :
Bluetooth: add missing PSM strings

svn path=/trunk/; revision=50968
2013-07-28 11:32:06 +00:00
Jakub Zawadzki 5b15390b3a Store protocol fields in single linked list, saves about 1 MB of memory.
svn path=/trunk/; revision=50967
2013-07-28 10:47:31 +00:00
Graham Bloice 243a76b04f Improved info column with multiple pdu's in a frame
svn path=/trunk/; revision=50966
2013-07-28 09:57:52 +00:00
Guy Harris 51047d02a1 Get rid of some unused variables.
Register those hf[] arrays that weren't getting registered.

Reformat all hf[] array initializations.

svn path=/trunk/; revision=50965
2013-07-28 09:36:31 +00:00
Jakub Zawadzki d6f249633a dfilter: move convertion to byte to seperate function
svn path=/trunk/; revision=50964
2013-07-28 08:41:26 +00:00
Michael Mann f3dac73d38 Fix compile error that resulted from whitespace cleanup.
svn path=/trunk/; revision=50963
2013-07-28 00:11:30 +00:00
Michael Mann a87f47c02c Make many items filterable for Vines dissectors.
Add support for FT_VINES type.

svn path=/trunk/; revision=50962
2013-07-28 00:07:49 +00:00
Evan Huus b9870c0969 Little optimizations.
Move a few assignments around to avoid one extra subtraction. I suspect having
the two if statements next to each other is friendly to the compiler's optimizer
as well.

Shaves ~1.3% off my timing tests, bringing the new design *very* close to the
old one in raw allocation speed.

svn path=/trunk/; revision=50961
2013-07-28 00:00:37 +00:00
Evan Huus e7dfea82f3 Little things make big differences: somehow while I was experimenting this
unobtrusive if statement got dropped. Without it the allocator exhibits the old
bad behaviour of 3x memory usage and heavy fragmentation.

We want it back, thank you very much.

svn path=/trunk/; revision=50960
2013-07-27 23:35:59 +00:00
Evan Huus 9b9467cb79 Small optimization: conjoin two mutually exclusive ifs with an else.
svn path=/trunk/; revision=50959
2013-07-27 23:01:24 +00:00
Evan Huus 720cce4102 Simplify out an addition that happened a lot by performing it once on the
variable it affected, since that variable wasn't used for any other purpose.

svn path=/trunk/; revision=50958
2013-07-27 22:51:27 +00:00
Guy Harris 210507cc76 Have separate lists of recent capture filters for all interfaces, in
addition to a "global" list.  Store all of those lists in the recent
file.  Maintain the lists in ui/recent.c, rather than attaching them to
widgets; have the code that populates the combo boxes get the lists from
the ui/recent.c code.

This makes a little more of the code GUI-toolkit-independent, and should
fix bug 7278.

#BACKPORT 1.10, 1.8

svn path=/trunk/; revision=50956
2013-07-27 22:37:26 +00:00
Evan Huus 3663498a8b Redesign of the wmem block allocator.
What was becoming apparent as more dissectors started using wmem was that the
old block allocator design had issues with memory fragmentation. This keeps the
same underlying memory layout, but completely changes how free blocks are kept.
It runs about 3% slower in my tests (still an order of magnitude faster than
g_malloc) but uses about 1/3 the memory.

I suspect some simple optimizations could reclaim that 3% as well - the design
is fast, but I did not code particularly for speed.

Thoroughly tested with the existing test suite (which caught half a dozen bugs
in my first draft) so it should actually work!

svn path=/trunk/; revision=50955
2013-07-27 22:27:28 +00:00
Evan Huus a076d6332e Use a #define, tweak a comment.
svn path=/trunk/; revision=50954
2013-07-27 21:56:43 +00:00
Guy Harris b50424fad8 Clean up indentation.
svn path=/trunk/; revision=50953
2013-07-27 21:23:19 +00:00
Jakub Zawadzki 0d414ac0fd make some variables static
svn path=/trunk/; revision=50952
2013-07-27 20:57:58 +00:00
Jakub Zawadzki 73aa1e7807 Support drange for functions
last think from bug #8979
+ fix semcheck.c:875: warning: signed and unsigned type in conditional expression

svn path=/trunk/; revision=50951
2013-07-27 19:14:34 +00:00
Jakub Zawadzki 1f4d76a6ca Some more work related to bug #8979 and previous commit
- Make http.location[0:4] == lower(http.location) behave the same as lower(http.location) == http.location[0:4]
- fix compiler errors + comments

svn path=/trunk/; revision=50950
2013-07-27 18:55:05 +00:00
Jakub Zawadzki da170f1d04 Fix bug #8979: Comparing function call and a range in the filter crashes Wireshark
store whole node, don't assume it's always STTYPE_FIELD

svn path=/trunk/; revision=50949
2013-07-27 17:17:15 +00:00
Martin Kaiser 9e33a6bade if we capture on multiple interfaces, the output file will be pcapn-ng
even if we enforce pcap ouput format via -P
    
in such a case, we *can* write a capture comment to the output file

svn path=/trunk/; revision=50948
2013-07-27 16:48:06 +00:00
Martin Kaiser 834b464844 add --capture-comment to dumpcap's manpage
svn path=/trunk/; revision=50947
2013-07-27 16:39:10 +00:00
Martin Kaiser 8905991b67 only one --capture-comment option may be given to dumpcap
svn path=/trunk/; revision=50946
2013-07-27 16:28:03 +00:00
Martin Kaiser 82ea635aa6 command line option --capture-comment for dumpcap
svn path=/trunk/; revision=50945
2013-07-27 16:25:08 +00:00
Martin Kaiser a585b45343 use capture_comment from the capture_options structure
when we write the SHB

svn path=/trunk/; revision=50944
2013-07-27 16:16:57 +00:00
Martin Kaiser e04a12af8c add capture_comment to the capture_options structure
svn path=/trunk/; revision=50943
2013-07-27 16:13:29 +00:00
Evan Huus 234cd8dac4 Add the proper license header and attribution to Balint's git-compare-abis script.
svn path=/trunk/; revision=50942
2013-07-27 13:50:52 +00:00
Evan Huus 5ede3bcde0 Follow-up to r50935: add support for 64-bit value strings in more places that
need it, I think this is all of them.

svn path=/trunk/; revision=50941
2013-07-26 23:51:00 +00:00
Evan Huus d22919194a Switch on field length for the length_min/max fields of IPFix. Like several
other nearby fields, they are different lengths in different versions of the
spec.

Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8918

svn path=/trunk/; revision=50940
2013-07-26 23:16:16 +00:00
Evan Huus c0cac8611e Squelch MSVC warnings. It doesn't know that DISSECTOR_ASSERT_NOT_REACHED doesn't
return.

svn path=/trunk/; revision=50939
2013-07-26 22:52:34 +00:00
Evan Huus 6e3a30794e Add 64-bit value strings and the appropriate tooling (including yet another
overloaded use of the DISPLAY field). Thanks to Jakub for pointing out I'd done
this wrong the first time (months ago in r49357).

Fixes severity display for collectd protocol, originally filed at:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8472

svn path=/trunk/; revision=50935
2013-07-26 21:51:39 +00:00
Guy Harris 6580abbbc3 Give more detailed diagnostics for errors.
Actually *check* for errors when reading.

svn path=/trunk/; revision=50934
2013-07-26 21:49:42 +00:00
Guy Harris 9df4d49905 Send error messages to the standard error, and include the program name
in the error message.

svn path=/trunk/; revision=50928
2013-07-26 21:25:33 +00:00
Guy Harris 8d81fe9a0e The descriptive name for a field is the field full name; the name used
in packet-matching expressions and TShark's -e flag and... is the
field's abbreviated name.

svn path=/trunk/; revision=50927
2013-07-26 21:06:38 +00:00
Michael Mann 2675472389 Add support for common FT_ETHER cases.
Bugfix gauging where the "field text" argument when parsing the proto_tree_add_text call.

svn path=/trunk/; revision=50925
2013-07-26 18:30:10 +00:00
Michael Mann a7a2d51fae Add display filters courtesy of convert_proto_tree_add_text.pl
svn path=/trunk/; revision=50924
2013-07-26 18:27:38 +00:00
Jakub Zawadzki 2c85a33442 Fix bug #8980 - IO graph/advanced, max/min/summ error on frames with multiple Diameter messages
tap_iostat_packet() was fetching only first item for FT_RELATIVE_TIME.

svn path=/trunk/; revision=50923
2013-07-26 18:10:55 +00:00
Pascal Quantin 6b07d33130 Fix Frame Indicator analysis logic
svn path=/trunk/; revision=50920
2013-07-26 17:07:57 +00:00
Evan Huus c693d9c951 whitespace
svn path=/trunk/; revision=50919
2013-07-26 16:42:06 +00:00
Alexis La Goutte f15a20c9f0 Enhance BGP Update (Path Attribute)
Step 2 ! Make Path Attribute field filterable...

svn path=/trunk/; revision=50918
2013-07-26 16:26:29 +00:00
Alexis La Goutte 54fc4025e6 Enhance BGP Update
First step ! Remove ugly double switch(bgpa_type)... (use proto_item_append_text)

svn path=/trunk/; revision=50917
2013-07-26 16:26:21 +00:00