Commit Graph

41 Commits

Author SHA1 Message Date
Anders Broman 6b3c0cd4f8 Remove now unused variables.
svn path=/trunk/; revision=41319
2012-03-02 11:25:17 +00:00
Alexis La Goutte c1ff84a632 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=41296
2012-03-02 10:57:48 +00:00
Anders Broman e1d434ee6a From Mike Morrin:
Add dissectors for GSM and UMTS Cell Broadcast protocols.
( - the patch for gsmtap )

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6770

svn path=/trunk/; revision=40735
2012-01-26 19:51:48 +00:00
Anders Broman 512e379901 Wireshark crashes in gsm_map dissector
For now use Jeff's fix:
"The REAL problem is that the GSM_MAP dissector is using this value_string_ext
in the hf without BASE_EXT_STRING:

    { &hf_gsm_old_localValue,
      { "localValue", "gsm_old.localValue",
        FT_INT32, BASE_DEC, &gsm_old_GSMMAPOperationLocalvalue_vals_ext, 0,
        "OperationLocalvalue", HFILL }},

This, in turn, appears to be caused because OperationLocalValue is an alias
for/of GSMMAPOperationLocalValue and only the latter is defined with
.USE_VALS_EXT.

I can fix it by doing:

Index: asn1/gsm_map/gsm_map.cnf
===================================================================
--- asn1/gsm_map/gsm_map.cnf    (revision 39628)
+++ asn1/gsm_map/gsm_map.cnf    (working copy)
@@ -54,6 +54,7 @@

 #.USE_VALS_EXT
 GSMMAPOperationLocalvalue
+OperationLocalvalue

 #.EXPORTS
 AddressString


But it seems to be that asn2wrs should arguably be figuring this out on its
own."

svn path=/trunk/; revision=40033
2011-11-29 07:03:31 +00:00
Anders Broman 7669c6affd Export NAEA-CIC to be used by Camel.
svn path=/trunk/; revision=39711
2011-11-02 06:38:46 +00:00
Jeff Morriss b21b495f9f Don't generate the conformance file for exported types when building the
dissector; instead built it only when the separate target (generate_export)
is built.

Built generate_export when building "all".

This prevents the exp_*.cnf files from being regenerated each time another one
of the exp_*.cnf files (which the current dissector depends on) has changed
(despite the fact that the exported types does not depe

Also fix the CLEANFILES definition so it actually cleans things.

svn path=/trunk/; revision=39421
2011-10-14 10:22:01 +00:00
Anders Broman 59a363da40 Update the Camel and MAP ASN.1 files.
svn path=/trunk/; revision=39386
2011-10-12 16:41:42 +00:00
Jeff Morriss cf012d27b1 Build the ASN.1 dissectors directly into epan/dissectors (rather than building
them and then copying them over).  The "all" target to builds these dissectors
now (instead of "generate_files" and/or "copy_files").

asn2wrs's "-O" option now means "the dissector goes in this directory" (rather
than "all output goes in this directory"); it also means that the "-s" (single
output file) option is now required.

Fix things up so that it's possible to build all of the ASN.1 dissectors in
one shot.

Fix building of conformance files when doing out-of-source-tree builds.


Unfortunately "make all" in the asn1 directory always builds something--I think
because of circular depedencies.

svn path=/trunk/; revision=39333
2011-10-10 02:31:11 +00:00
Bill Meier 6142dd287b Convert 'encoding' parameter of certain proto_tree_add_item() calls in asn1/*:
Specifically:  Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as
  the encoding parameter for proto_tree_add_item() calls which directly reference
  an item in hf[] which has a type of:
     FT_BOOLEAN
     FT_IPv4
     FT_EUI64
     FT_GUID
     FT_UINT_STRING

 Also: For type FT_IPv6 use ENC_NA. (This was missed in SVN #39260)

svn path=/trunk/; revision=39332
2011-10-10 01:38:20 +00:00
Anders Broman 83b98f5e2c Add exports
svn path=/trunk/; revision=39296
2011-10-06 18:46:47 +00:00
Bill Meier e2996ceabe Convert 'encoding' parameter of certain proto_tree_add_item() calls in asn1 dissectors:
Specifically:  Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as
 the encoding parameter for proto_tree_add_item() calls which directly reference
 an item in hf[] which has a type of:
    FT_UINT8
    FT_UINT16
    FT_UINT24
    FT_UINT32
    FT_UINT64
    FT_INT8
    FT_INT16
    FT_INT24
    FT_INT32
    FT_INT64
    FT_FLOAT
    FT_DOUBLE


svn path=/trunk/; revision=39294
2011-10-06 16:50:13 +00:00
Anders Broman 0007775464 Make it possible to dissect proprietarry Opcodes.
svn path=/trunk/; revision=39183
2011-09-29 15:23:23 +00:00
Anders Broman a5839116d3 Pretyfy APN display and make it filterable as a string.
svn path=/trunk/; revision=37731
2011-06-20 10:29:46 +00:00
Jeff Morriss 7ad71a2d78 Treat TVBs as opaque: use the accessor functions instead of accessing the fields
directly.

svn path=/trunk/; revision=37420
2011-05-27 01:57:33 +00:00
Anders Broman 8d6ca293dc Change the signature of elem_fcn():ns to include pinfo.
svn path=/trunk/; revision=36443
2011-04-04 14:37:25 +00:00
Anders Broman e645e3c4d0 -Whitespace fix in gsm_map-template(no need to regenerate).
- Fix dissection of extensions in INAP it should now be possible to add
an "OID dissector" for extensions.
Should fix BUG
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5799

svn path=/trunk/; revision=36435
2011-04-02 09:18:18 +00:00
Anders Broman 129f07a949 Added FALLTHRU comment to avoid a "missing break" warning.
svn path=/trunk/; revision=36365
2011-03-27 14:02:42 +00:00
Anders Broman 23e6582724 Add miisng file from
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=36079

svn path=/trunk/; revision=36085
2011-02-27 19:41:34 +00:00
Anders Broman 527942b05a Add exports.
svn path=/trunk/; revision=36049
2011-02-24 15:06:16 +00:00
Anders Broman 553cf70a68 Dissect V1 version , found in trace from:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5637

svn path=/trunk/; revision=35843
2011-02-07 17:44:34 +00:00
Anders Broman 6d4964bb49 Export more functions.
svn path=/trunk/; revision=35757
2011-02-02 17:09:05 +00:00
Anders Broman 568605ae13 r35546 Replace some tvb_get_ptr()s with tvb_get_ephemeral_string()s to ensure the
return string is NULL terminated.
Make the change also in the .cnf file

svn path=/trunk/; revision=35551
2011-01-16 08:24:11 +00:00
Anders Broman 8326aa2db7 Use value_string_ext in a couple of places.
svn path=/trunk/; revision=35501
2011-01-12 07:36:55 +00:00
Anders Broman 5ebd7cb133 TCAP- Application context name not been decoded correctly
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5573

svn path=/trunk/; revision=35498
2011-01-12 07:18:57 +00:00
Jeff Morriss fc2b1606cf Remove unreached statement.
svn path=/trunk/; revision=35387
2011-01-05 22:20:39 +00:00
Guy Harris a8bc4a0d13 Rename the routines that handle dissector tables with unsigned integer
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys.  (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)

svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
Bill Meier 03b57df5a0 Fix various typos and spelling errors.
svn path=/trunk/; revision=35126
2010-12-06 01:34:58 +00:00
Anders Broman 2fb8971136 Update to 3GPP TS 29.002 V9.3.0 (2010-09)
svn path=/trunk/; revision=34814
2010-11-08 23:15:16 +00:00
Anders Broman 687eb5a2a6 Fix for Bug Packet details have errors when decode MAP V2 PRN_ACK msg
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5076

Use:
/*
 * Dissect Multiple Choice Message
 * This function is used to decode a message, when several encoding may be used.
 * For exemple, in the last MAP version, the Cancel Location is defined like this:
 * CancelLocationArg ::= [3] IMPLICIT SEQUENCE
 * But in the previous MAP version, it was a CHOICE between a SEQUENCE and an IMSI
 * As ASN1 encoders (or software) still uses the old encoding, this function allows
 * the decoding of both versions.
 * Moreover, some optimizations (or bad practice ?) in ASN1 encoder, removes the
 * SEQUENCE tag, when only one parameter is present in the SEQUENCE.
 * This explain why the function expects 3 parameters:
 * - a [3] SEQUENCE corresponding the recent ASN1 MAP encoding
 * - a SEQUENCE for old style
 * - and a single parameter, for old version or optimizations
 *
 * The analyze of the first ASN1 tag, indicate what kind of decoding should be used,
 * if the decoding function is provided (so not a NULL function)
 */

svn path=/trunk/; revision=34001
2010-08-29 17:34:44 +00:00
Anders Broman 456777d004 Update to V9.1.0 (2010-03).
svn path=/trunk/; revision=32509
2010-04-19 05:58:01 +00:00
Bill Meier f8b92f8d0b #include <stdio.h> not needed.
svn path=/trunk/; revision=32405
2010-04-06 17:01:14 +00:00
Gerasimos Dimitriadis dfde72f247 Fix for Bug 4588:
RANAP and friends want the MNC encoded in big endian form.

svn path=/trunk/; revision=32257
2010-03-20 23:53:22 +00:00
Guy Harris b395a98305 Squelch a bunch of compiler warnings.
svn path=/trunk/; revision=31961
2010-02-23 04:35:23 +00:00
Gerasimos Dimitriadis ba32bc6d54 Fix for Bug 3116
wrong decoding IMSI with GSM MAP protocol

svn path=/trunk/; revision=31764
2010-02-01 21:19:56 +00:00
Anders Broman a255c08b66 Get rid of check_col();
svn path=/trunk/; revision=31546
2010-01-17 12:46:00 +00:00
Anders Broman 0aabfbf3f8 Update to V9.0.0 (2009-12)
svn path=/trunk/; revision=31413
2010-01-02 22:12:14 +00:00
Anders Broman e356fd0faa Update to V9.0.0 (2009-12)
svn path=/trunk/; revision=31404
2010-01-01 22:29:28 +00:00
Guy Harris 68cf37f81b Replace gsm_sms_char_ascii_decode() with gsm_sms_chars_to_utf8(), which
returns an ep_allocated string (and whose name reflects that what you
get out is UTF-8, not just ASCII).

svn path=/trunk/; revision=31376
2009-12-28 21:58:43 +00:00
Gerasimos Dimitriadis b7261fe2e4 Expert info when E.212 MCC/MNC contain non-decimal digits
svn path=/trunk/; revision=31102
2009-11-27 22:57:50 +00:00
Stig Bjørlykke 6d1dae6f28 Make all proto_* values static.
svn path=/trunk/; revision=30516
2009-10-11 16:24:29 +00:00
Kovarththanan Rajaratnam cdcd98e0bb gsmmap -> gsm_map to make directory name consistent with filenames
svn path=/trunk/; revision=30470
2009-10-10 12:37:56 +00:00