Commit graph

69 commits

Author SHA1 Message Date
Pascal Quantin
a9ced211ac Do not display payload twice when using uncompressed profile
svn path=/trunk/; revision=49407
2013-05-18 11:41:44 +00:00
Pascal Quantin
a20d3ddf8b Add partial dissection of IR packet with IP profile
svn path=/trunk/; revision=49331
2013-05-16 15:02:55 +00:00
Anders Broman
85a8e304dd Add the posibillity to use a key for per-packet-data.
svn path=/trunk/; revision=49259
2013-05-12 18:11:02 +00:00
Pascal Quantin
b3da159427 Enhance dissection of feedback
svn path=/trunk/; revision=49032
2013-04-25 15:21:48 +00:00
Anders Broman
ae747e4c4b From beroset:
remove C++ incompatibilities 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48430
2013-03-19 22:03:00 +00:00
Pascal Quantin
8ed55b8eef Fix dissection of feedback with large CID
svn path=/trunk/; revision=47955
2013-02-28 22:22:52 +00:00
Pascal Quantin
0037adc30e Dissect more feedback options
svn path=/trunk/; revision=47887
2013-02-25 22:36:24 +00:00
Pascal Quantin
1c9c5621c8 Fix display type
svn path=/trunk/; revision=47870
2013-02-24 22:39:46 +00:00
Pascal Quantin
959e3e3e2c Various enhancements to ROHC dissector:
- fix dissection of type 0 packets with large CID
- add dissection of type 1 and 2 packets (extension 3 dissection to be done)
- add dissection of UDP checksum

svn path=/trunk/; revision=47869
2013-02-24 22:06:53 +00:00
Pascal Quantin
622bd16abf Add dissection of uncompressed IP-ID
svn path=/trunk/; revision=47844
2013-02-23 22:26:29 +00:00
Pascal Quantin
3d854528ce Enhance dissection of uncompressed profile and type 0 packets.
Always restore saved private data when returning from dissector.

svn path=/trunk/; revision=47840
2013-02-23 18:45:14 +00:00
Pascal Quantin
13729e9c11 When dissecting a feedback, if no context info is present use private data if available
svn path=/trunk/; revision=47826
2013-02-22 17:34:56 +00:00
Pascal Quantin
a3fca22472 Dissect Feedback type 1/2 packets for UDP and Uncompressed profiles
svn path=/trunk/; revision=47806
2013-02-21 19:18:29 +00:00
Bill Meier
d3a7f4b817 Use '#if 0 ... #endif' rather than /** ... **/ to comment out
unused hf[] entries (which I should have done in the first place).

svn path=/trunk/; revision=47390
2013-01-31 18:31:28 +00:00
Bill Meier
0960e508e4 Comment out cases of unused hf array entries found by checkhf.
svn path=/trunk/; revision=47302
2013-01-26 18:54:53 +00:00
Jeff Morriss
2552c750e5 We always HAVE_CONFIG_H so don't bother checking whether we have it or not.
svn path=/trunk/; revision=45017
2012-09-20 02:03:38 +00:00
Jakub Zawadzki
9f92dc93c5 Add data parameter to call_dissector_only.
svn path=/trunk/; revision=44872
2012-09-11 08:28:07 +00:00
Pascal Quantin
0e79405e0d Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7679:
Do not try to set IR header length when the profile is unknown

svn path=/trunk/; revision=44700
2012-08-30 12:08:53 +00:00
Bill Meier
638d74d43f Use val_to_str_const() where appropriate;
Also (for a few files):
- create/use some extended value strings;
- remove unneeded #include files;
- remove unneeded variable initialization;
- re-order fcns slightly so prefs_reg_handoff...() at end, etc

svn path=/trunk/; revision=44438
2012-08-10 22:55:02 +00:00
Jakub Zawadzki
bf81b42e1e Update Free Software Foundation address.
(COPYING will be updated in next commit)

svn path=/trunk/; revision=43536
2012-06-28 22:56:06 +00:00
pascal
736627bb97 Attempt to fix clang warnings (dead assignment and dereference of null pointer)
svn path=/trunk/; revision=42389
2012-05-02 20:40:49 +00:00
Jakub Zawadzki
68ec58d385 Fix some: 'cast discards qualifiers from pointer target type' warnings
- Add const qualifier
- Remove some strange casts

svn path=/trunk/; revision=42131
2012-04-18 12:35:36 +00:00
Martin Mathieson
2b13fcbb2c Set the extent of IR, IR-DYN and feedback packet types.
Make some fields display and HEX and DEC.

svn path=/trunk/; revision=41881
2012-04-01 14:55:40 +00:00
Bill Meier
01154ebca4 proto_reg_handoff...() doesn't need 'if(!Initialized)';
Also: Do some whitespace cleanup.

svn path=/trunk/; revision=41088
2012-02-20 22:00:50 +00:00
Michael Tüxen
7b368e3895 Remove redundant ().
svn path=/trunk/; revision=40719
2012-01-25 16:43:04 +00:00
Anders Broman
4caa84610d Restructure the code abit.
svn path=/trunk/; revision=40700
2012-01-24 19:16:32 +00:00
Jeff Morriss
dc0ad2aac7 Revert 40675 and set 'protocol' appropriately when IPv6 is used.
Initialize it to something other than UDP if we can't determine the protocol.

Reindent parts of the subject function.
Replace tabs with spaces (for consistency).
Remove trailing white space.

svn path=/trunk/; revision=40677
2012-01-23 22:37:53 +00:00
Jeff Morriss
4e7f5c2e8f Initialize 'protocol' to something, at least until it can be properly assigned in the IPv6 and default cases.
svn path=/trunk/; revision=40675
2012-01-23 22:20:15 +00:00
Anders Broman
4e30aece3a Only continue dissection if protocol is UDP.
svn path=/trunk/; revision=40673
2012-01-23 21:13:10 +00:00
Anders Broman
088723a512 From Pascal Quantin:
Use the private data if available, call the data dissector for data.

svn path=/trunk/; revision=40663
2012-01-23 19:10:50 +00:00
Chris Maynard
0733183dc2 Fix Coverity CID 1370: UNREACHABLE by deleting erroneous break;
svn path=/trunk/; revision=40608
2012-01-20 18:35:56 +00:00
Jörg Mayer
64ddaef37b Fix:
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-rohc.c: In function ‘dissect_rohc_ir_rtp_profile_dynamic’:
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-rohc.c:775:21: error: variable ‘cc’ set but not used [-Werror=unused-but-set-variable]
cc1: all warnings being treated as errors



svn path=/trunk/; revision=40593
2012-01-19 22:18:06 +00:00
Anders Broman
61b3c117a1 Update comments and dissection of comptessed lists
svn path=/trunk/; revision=40589
2012-01-19 19:43:02 +00:00
Anders Broman
0299bdbc62 Add more to dissect_compressed_list()
svn path=/trunk/; revision=40560
2012-01-17 21:27:48 +00:00
Jörg Mayer
2428b75969 Fix warning about a variable that is written to only.
svn path=/trunk/; revision=40559
2012-01-17 18:27:01 +00:00
Martin Mathieson
914f06e618 Mark a couple of unused parameters as such.
svn path=/trunk/; revision=40558
2012-01-17 18:23:11 +00:00
Anders Broman
32c759745a Enhance dissection of compressed lists.
svn path=/trunk/; revision=40557
2012-01-17 17:57:52 +00:00
Martin Mathieson
30d4a0dc7e Simplify key for cid->context hash table. Copy more details between contexts when updating.
svn path=/trunk/; revision=40403
2012-01-07 02:50:37 +00:00
Jörg Mayer
b7356ab3cd Fix: packet-rohc.c:439:20: error: variable ‘PS’ set but not used [-Werror=unused-but-set-variable]
svn path=/trunk/; revision=40394
2012-01-06 10:11:30 +00:00
Chris Maynard
95ff0e0999 Fix Coverity CID's 1348-1349: UNUSED_VALUE and CID 1344: CONSTANT_EXPRESSION_RESULT.
svn path=/trunk/; revision=40391
2012-01-05 19:14:54 +00:00
Martin Mathieson
21a7e5cc13 - Add the beginning of compressed list handling.
- Will at least skip the single byte if there is nothing in the list.
    - Checks that the intended encoding type (ET) is found
    - Need to call from lots of places
- Pass correct subtree for feedback items (was passing NULL so items weren't there)
- show SNs as decimal
- remove a few stray tabs
- fix a typo

Still need to port some parts from packet-pdcp-lte.c that aren't handled (e.g. UO_0).  And the context lookup seems broken (at least for IxCatapult logs).

svn path=/trunk/; revision=40388
2012-01-05 17:40:41 +00:00
Anders Broman
1b98cbfe97 Use a hash table to gather information from IR packets and store it in per-packet-data.
svn path=/trunk/; revision=40362
2012-01-03 22:08:13 +00:00
Chris Maynard
ec24a7f89b Fix Coverity CID's 1339 and 1340: UNUSED_VALUE.
svn path=/trunk/; revision=40241
2011-12-18 16:38:31 +00:00
Anders Broman
a106a9047a Call the rohc dissector directly, the code will be cleaned up
in the next weeks or so.

svn path=/trunk/; revision=40213
2011-12-15 20:22:54 +00:00
Anders Broman
b2678b43d1 From Per Liedberg:
RoHC dissection improvment.

svn path=/trunk/; revision=40210
2011-12-15 17:28:43 +00:00
Bill Meier
63c71a7090 Use consistent indentation.
svn path=/trunk/; revision=40191
2011-12-13 23:47:47 +00:00
Martin Mathieson
70e2a50ad1 Initialise 'sub_tree' to NULL, to avoid warnings about possibly using
uninitialised.  The warnings are bogus, but could have been avoided, as the test
to see if we're using a compression profile is redundant/will always be TRUE
in those functions...

Also removed some unnecessary braces from switch cases (no local variables were defined).

svn path=/trunk/; revision=40181
2011-12-13 19:46:24 +00:00
Anders Broman
d47335b133 From Per Liedberg:
RoHC dissection improvment.

svn path=/trunk/; revision=40177
2011-12-13 17:13:50 +00:00
Anders Broman
9d0fa5cfcb - Change the tree layout to mimic packet-pdcp-lte.c
- Add IPv6 static chain dissectoin
- Part of IPv6 dynamic chain dissectoin

svn path=/trunk/; revision=40156
2011-12-12 06:58:37 +00:00
Anders Broman
86117b6a9f 607: warning: unused variable 'd'
svn path=/trunk/; revision=40148
2011-12-10 13:09:17 +00:00