osmith/wireshark
1
0
Fork 0
forked from osmocom/wireshark
Code Pull requests Releases Wiki Activity
47583 commits 23 branches 0 tags 1.3 GiB
Commit graph

207 commits

Author SHA1 Message Date
Anders Broman
c6af00a977 From jamie Neufeld: 
Add an option to selct if payload is to be dissected as SYNC.

svn path=/trunk/; revision=49595
 2013-05-27 16:27:50 +00:00
Anders Broman
b8618947bd Add missing element NSAP to IE Evolved Allocation/Retention Priority II. 
svn path=/trunk/; revision=49474
 2013-05-21 05:08:50 +00:00
Anders Broman
68f0af8b03 Set pinfo->link_dir per message not in the IE dissection. 
svn path=/trunk/; revision=48873
 2013-04-16 05:42:17 +00:00
Evan Huus
37600a157b Rename value string (and similar) functions to use a consistent pattern. This 
was done using textual search+replace, not anything syntax-aware, so presumably
it got most comments as well (except where there were typos).

Use a consistent coding style, and make proper use of the WS_DLL_* defines.

Group the functions appropriately in the header.

I ended up getting rid of most of the explanatory comments since many of them
duplicated what was in the value_string.c file (and were out of sync with the
recent updates I made to those in r48633). Presumably most of the comments
should be in the .h file not the .c file, but there's enough churn ahead that
it's not worth fixing yet.

Part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8467

svn path=/trunk/; revision=48634
 2013-03-29 00:26:23 +00:00
Anders Broman
6bde918078 From beroset: 
remove C++ incompatibilities 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48426
 2013-03-19 20:00:52 +00:00
Guy Harris
9bfeb4963f Make the GTP and GTP' dissectors new-style dissectors, so that they can 
reject packets that don't look enough like GTP/GTP' packets.  This fixes
bug 1706, and fixes some other cases where non-GTP/GTP' packets are
being dissected as GTP/GTP'.

svn path=/trunk/; revision=48118
 2013-03-06 00:02:18 +00:00
Guy Harris
9b01892eca Use hf_gtp_ext_hdr_next for all "next header" fields, and get rid of 
hf_gtp_next.

Don't do "dummy" dissection of extension headers that we don't actually
dissect - we label them by next extension header type, and dissect them
in the default case, which should suffice (until somebody adds
dissection for those types).

svn path=/trunk/; revision=48075
 2013-03-05 00:17:56 +00:00
Guy Harris
958574da78 If the length value is bad, an exception will be thrown; we don't need 
the item for the length, as we aren't explicitly checking it and
attaching expert info items to it.

svn path=/trunk/; revision=48070
 2013-03-04 22:01:29 +00:00
Guy Harris
029c5bdbac Give 3GPP TS numbers for GTP v0, GTP v1, and GTP'. 
Give URLs for the 3gpp.org pages for all those specs.

Add #defines for all the GTP v1 extension header types we handle.

"gtp_prime" is a Boolean; make it a gboolean.

Dissect the first 4 octets of the header one field at a time, so that if
the packet is cut short by a snapshot length we at least dissect what's
there.

32.295 isn't entirely clear on what the 20-byte header for GTP' v0 is;
assume it's the same as the header for GTP v0.

Once we've fetched the length field from the fixed-length portion of the
header, set the length of the tvbuff to the sum of the offset past the
fixed-length portion and the length field, to catch running past that
value.

Use GTP_E_MASK|GTP_S_MASK|GTP_PN_MASK as the mask for testing for the
presence of those fields, to make it a bit clearer what's being checked
for.

Don't actually add those fields to the protocol tree unless the flag for
the field is set.

We only need one chunk of code to handle extension headers.

Make that chunk a loop, and put the header in as an FT_NONE item, with
the length, header data, and next header under it.  Put the initial next
header field in as well.  (We treat this like IPv6 extension headers,
with the next header field being part of the previous header, rather
than like a set of TLVs, with the next header field being the type value
of its header.)

Fail if the extension header length is zero.

Use the reported length when processing IEs or T-PDU payload.

svn path=/trunk/; revision=48068
 2013-03-04 21:40:36 +00:00
Pascal Quantin
240af26981 Fix a copy/paste error and factorize dissection of extension header length and next extension header 
svn path=/trunk/; revision=48007
 2013-03-02 13:12:24 +00:00
Anders Broman
599d2e8a9c From Lakshmi Narayana Madala : 
GTP dissector enhanced to support UDP Port extension header.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8418

svn path=/trunk/; revision=48004
 2013-03-02 11:33:46 +00:00
Anders Broman
e2d3294617 From Katrina Zhang sligtly modified. 
- Add dissection of Selected PLMN ID.
- Put enterpice id in the tree
- Filter for UTRAN Transparent Field.

svn path=/trunk/; revision=47252
 2013-01-24 09:59:06 +00:00
Pascal Quantin
ccbff26e80 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8196 : 
Add dissection of IPv4v6 type to End User Address IE

svn path=/trunk/; revision=47047
 2013-01-13 11:04:46 +00:00
Pascal Quantin
d4cf9ce69a Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8193 : 
Add dissection of Dual Address Bearer Flag bit in Common Flags IE

svn path=/trunk/; revision=47036
 2013-01-11 20:18:32 +00:00
Anders Broman
433d9c198d Only the private extension IE value part should go in the tvb. 
svn path=/trunk/; revision=46996
 2013-01-08 09:57:10 +00:00
Anders Broman
be1ff84f48 From Katrina Zhang:Pretify dissection if a dissector exists for the private extension 
svn path=/trunk/; revision=46857
 2012-12-30 09:35:27 +00:00
Anders Broman
39c816931c Copy-paste error. 
svn path=/trunk/; revision=46538
 2012-12-14 11:54:35 +00:00
Anders Broman
eba8fb9328 From Martin Isaksson: 
- Initiiate GTP header to zero.
- Dont' load TEID unconditionaly, it might not be present.

svn path=/trunk/; revision=46537
 2012-12-14 11:27:38 +00:00
Anders Broman
2f827154f8 Bug 3974 - wrong decoding of gtp.target identification. 
Use the IE description from 3GPP TS 29.060 version 10.4.0 Release 10.
- Fix bugs with RAI and LAC in other parts of the code.

svn path=/trunk/; revision=46439
 2012-12-07 12:06:40 +00:00
Anders Broman
49307fcedc High light bytes including the first lenght byte in the APN name. 
svn path=/trunk/; revision=45856
 2012-11-01 08:24:08 +00:00
Anders Broman
0c24f376ca The GTP dissector can't handle long APN names, max is 100. 
Bug https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7932

svn path=/trunk/; revision=45852
 2012-10-31 16:53:39 +00:00
Anders Broman
d0c2bc2232 From Martin Isaksson: 
Preparattions for GTP tap.

svn path=/trunk/; revision=45377
 2012-10-08 08:41:34 +00:00
Jeff Morriss
2552c750e5 We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 
svn path=/trunk/; revision=45017
 2012-09-20 02:03:38 +00:00
Jakub Zawadzki
5a8783f5b1 Initial commit to support yet another method of passing data between dissectors. 
Add new parameter 'data' to heur_dissector_t and new_dissector_t, for now it's always NULL

svn path=/trunk/; revision=44860
 2012-09-10 21:40:21 +00:00
Pascal Quantin
1c2f498a82 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7697 : 
Fix dissection of release 98 and release 99 QoS profiles (bug introduced in r43312)

svn path=/trunk/; revision=44792
 2012-09-06 20:58:32 +00:00
Bill Meier
c591c6dd56 Comment out all but first value_string array entries with dup values: 
kept: first dup since that's the one which would
       be found with a linear search.

svn path=/trunk/; revision=44642
 2012-08-23 17:30:42 +00:00
Michael Mann
1741731384 remove unnecessary underscores from display filters 
svn path=/trunk/; revision=44181
 2012-08-01 02:59:17 +00:00
Pascal Quantin
f4e322cd56 Fix inverted dissection of Pre-emption Capability and Pre-emption Vulnerability 
svn path=/trunk/; revision=44091
 2012-07-28 13:40:11 +00:00
Pascal Quantin
ba376235da Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7474 : 
Dissect LTE RADIUS AVP 3GPP-User-Location-Info

svn path=/trunk/; revision=43700
 2012-07-13 21:18:35 +00:00
Bill Meier
859affc2bd Don't call subdissectors / expert...() / col...() under 'if (tree)' 
Also:
 Remove some uneeded initializers;
 Do some whitespace cleanup and re-formatting.

svn path=/trunk/; revision=43681
 2012-07-12 17:22:47 +00:00
Anders Broman
eedc186e94 Dissect Release 8 CDR:s 
svn path=/trunk/; revision=43624
 2012-07-09 14:09:59 +00:00
Jakub Zawadzki
b18e880040 Update FSF address - part II. 
svn path=/trunk/; revision=43538
 2012-06-28 23:18:38 +00:00
Pascal Quantin
28e925a381 Allow future forward compatibility 
svn path=/trunk/; revision=43312
 2012-06-17 16:08:43 +00:00
Pascal Quantin
d57552df5d Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7371 : 
Add dissection of Release 8 or higher P-GW QoS profile

svn path=/trunk/; revision=43280
 2012-06-16 13:09:51 +00:00
pascal
f400e647b8 From Pontus Andersson via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7259 : 
GTP Extension headers are dissected incorrectly

svn path=/trunk/; revision=42663
 2012-05-16 20:59:56 +00:00
Bill Meier
c055ca8c7e General minor cleanup including: 
- remove unneeded #includes;
- use val_to_str_const() as appropriate;
- reformat hf[] entries;
- reformat long lines;
- use #if 0/#endif to coment out code instead of /* ... */;
- remove boilerplate comments;
- whitespace & indentation


svn path=/trunk/; revision=42487
 2012-05-07 22:11:34 +00:00
Anders Broman
fbecf576d1 From David Wei: 
Change GTP and GTPv2 dissectors for pre-Rel7 UEs that do not support bitrates higher than 16 Mbps.

svn path=/trunk/; revision=42381
 2012-05-02 07:23:32 +00:00
pascal
4f415d93c5 Fix some clang warnings (dead assignment/increment, assigned value is garbage or undefined) 
svn path=/trunk/; revision=42344
 2012-04-30 09:00:05 +00:00
Anders Broman
2cc15fd9c6 Fully dissect more IEs 
svn path=/trunk/; revision=42259
 2012-04-26 13:23:16 +00:00
Anders Broman
25c3a2b236 Get rid of a few more of the explicitly defined ett:s 
svn path=/trunk/; revision=42234
 2012-04-25 15:33:06 +00:00
Bill Meier
d43f0fc80a Fix a crash caused by an "off by one" define 
svn path=/trunk/; revision=42199
 2012-04-22 20:50:34 +00:00
Anders Broman
dad5036fb2 Basic IE dissectoon for more IE:s 
svn path=/trunk/; revision=42198
 2012-04-22 19:28:21 +00:00
Anders Broman
974014275d Add basic IE dissection for new IE:s 
svn path=/trunk/; revision=42158
 2012-04-20 12:32:17 +00:00
Ronnie Sahlberg
4479fa14b4 compile warning/error. flag unused argument with _U_ 
svn path=/trunk/; revision=42152
 2012-04-20 07:01:50 +00:00
Anders Broman
5d0ffcc606 Add the basic code to dissect IE APN Aggregate Maximum Bit Rate (APN-AMBR) 
svn path=/trunk/; revision=42151
 2012-04-20 05:47:02 +00:00
Anders Broman
514092549c Cosmetic changes 
svn path=/trunk/; revision=42066
 2012-04-14 12:17:06 +00:00
Anders Broman
6968651735 Refactor to use dissect_gsm_map_msisdn(). 
svn path=/trunk/; revision=42036
 2012-04-12 14:34:52 +00:00
Anders Broman
869b54e3b5 Dissect IE Type = 106 fully. 
svn path=/trunk/; revision=42023
 2012-04-11 15:52:14 +00:00
pascal
14d362a018 As suggested by Jakub, always update the digit value when the nibble is outside [0;9] range 
svn path=/trunk/; revision=41984
 2012-04-08 16:03:21 +00:00
pascal
e599abd268 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7042 : 
Handle properly filler and do not remove last digit

svn path=/trunk/; revision=41979
 2012-04-08 13:10:45 +00:00