Commit graph

14 commits

Author SHA1 Message Date
Evan Huus
37600a157b Rename value string (and similar) functions to use a consistent pattern. This
was done using textual search+replace, not anything syntax-aware, so presumably
it got most comments as well (except where there were typos).

Use a consistent coding style, and make proper use of the WS_DLL_* defines.

Group the functions appropriately in the header.

I ended up getting rid of most of the explanatory comments since many of them
duplicated what was in the value_string.c file (and were out of sync with the
recent updates I made to those in r48633). Presumably most of the comments
should be in the .h file not the .c file, but there's enough churn ahead that
it's not worth fixing yet.

Part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8467

svn path=/trunk/; revision=48634
2013-03-29 00:26:23 +00:00
Pascal Quantin
86eda54fe6 As suggested by Evan Huus, use extended value_strings
svn path=/trunk/; revision=48407
2013-03-18 22:21:53 +00:00
Evan Huus
e8c305fd3b From Sylvain Munaut via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8487
Use enum values instead of manual constants in value_strings. This was
introduced by r47218, which was designed to fix r47209, which would have been
correct in the first place if the value_strings hadn't been full of hacks.

I think everything is correct now. Perhaps it may be worth using extended
value_strings though, since most of the tables seem to be consecutive in order?

svn path=/trunk/; revision=48345
2013-03-16 20:46:19 +00:00
Pascal Quantin
ae61fe0158 Try to fix dissection of GSM protocol family broken by r47209.
Using val_to_str seemed to be a good idea, but most value_string arrays were not properly filled or were using hacks.
(I hope I got everything right...)


svn path=/trunk/; revision=47218
2013-01-22 23:25:44 +00:00
Pascal Quantin
aae3c27307 Include packet-gsm_sms.h and remove extern declarations
svn path=/trunk/; revision=46686
2012-12-21 21:01:45 +00:00
Jeff Morriss
2552c750e5 We always HAVE_CONFIG_H so don't bother checking whether we have it or not.
svn path=/trunk/; revision=45017
2012-09-20 02:03:38 +00:00
Pascal Quantin
6c12a7ffdc From Sylvain Munaut via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7664 :
packet-gmr1_rr: Add support for "Assignment Command 1" messages

svn path=/trunk/; revision=44672
2012-08-25 21:16:08 +00:00
Michael Mann
95d14df10a effectively revert r44161, having the display filters favor '.' over '_'
svn path=/trunk/; revision=44661
2012-08-24 23:27:24 +00:00
Pascal Quantin
51fd116d6d Do not register fields twice
svn path=/trunk/; revision=44195
2012-08-01 19:22:59 +00:00
Pascal Quantin
ecf26166fa Follow-up of r44161: GMR-1 RR dissector is not used only on Common Control CHannels but also on Dedicated Control CHannels; update protocol name and filters accordingly
svn path=/trunk/; revision=44193
2012-08-01 19:01:26 +00:00
Michael Mann
7f3703de34 update GMR-1 protocols display filers
svn path=/trunk/; revision=44161
2012-07-31 17:19:32 +00:00
Jakub Zawadzki
bf81b42e1e Update Free Software Foundation address.
(COPYING will be updated in next commit)

svn path=/trunk/; revision=43536
2012-06-28 22:56:06 +00:00
Alexis La Goutte
b60c478326 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=41471
2012-03-10 17:51:18 +00:00
Anders Broman
017351556b From Sylvain Munaut:
packet-gmr1_rr: Add dissector for GMR-1 RR elements and CCCH messages (Step 2).

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6921

svn path=/trunk/; revision=41448
2012-03-09 12:15:08 +00:00