99d0404b73
replaced decode_enumerated_bitfield calls with itemized filters
...
svn path=/trunk/; revision=45176
2012-09-27 16:49:31 +00:00
d003cdf66e
Allow dissection of partial jpegs by a modification of the heuristics.
...
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6230
#BACKPORT(1.8, 1.6)
svn path=/trunk/; revision=45174
2012-09-27 14:02:37 +00:00
a23c3aae3c
Fix duplicated field: nmpi.name_flags
...
svn path=/trunk/; revision=45170
2012-09-27 10:42:03 +00:00
65ef9e9d6b
replaced decode_numeric_bitfield calls with filterable item or removed it if it didn't mathematically do anything.
...
svn path=/trunk/; revision=45166
2012-09-27 04:36:40 +00:00
0063cc00c8
remove decode_numeric_bitfield + cleanup.
...
I wanted to just remove the decode_numeric_bitfield calls, but the dissector needs some MAJOR work. Cleaned up some with the power of value_strings, but I just got overwhelmed. There has got to be existing APIs to make this dissection simpler (besides being more filterable).
svn path=/trunk/; revision=45165
2012-09-27 04:05:01 +00:00
9636d1655d
Put the individual property flags under the properties item, rather than
...
at the top level.
svn path=/trunk/; revision=45159
2012-09-26 20:43:58 +00:00
141200fa86
Show the PID field of the transport feedback NACK as "RTCP Transport
...
Feedback NACK PID", not just as "RTCP Transport Feedback NACK", and give
the field a name for that.
Use it in the protocol tree for the bits of the BLP field, rather than
making it a hidden field there.
Clean up the tags appended to the BLP field.
svn path=/trunk/; revision=45157
2012-09-26 20:19:20 +00:00
0ac06207ce
Just append the ": " to the generic NACK BLP item, don't replace its
...
text.
Don't put empty items into the bitfield tree.
Show the BLP field as hex, as it's a bitfield.
(What should *really* happen is that it should display each 1 bit in the
usual fashion, with the ".... ...1 .... ...." display, but have that bit
be an *integral* field with the appropriate PID for the NACKed packet -
i.e., display hf_rtcp_rtpfb_nack_pid, with the value
rtcp_rtpfb_nack_pid + i + 1, and with the bitfield stuff in the
displayed representation.)
svn path=/trunk/; revision=45155
2012-09-26 19:23:33 +00:00
97c808c75c
replaced decode_boolean_bitfield calls with itemized filters
...
svn path=/trunk/; revision=45152
2012-09-26 18:10:29 +00:00
2edc3c1822
minor endian bugfix
...
svn path=/trunk/; revision=45151
2012-09-26 18:09:04 +00:00
60626e8fd2
In get_unicode_or_ascii_string(), check if the length is odd/even, not the offset. Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5778 - Volume label field ... is not displayed correctly ...
...
#BACKPORT(1.8, 1.6)
svn path=/trunk/; revision=45150
2012-09-26 16:48:20 +00:00
0b194f98ad
Control the heuristic dissector with a preference. It is only a 7-bit
...
CRC, so was firing too readily...
svn path=/trunk/; revision=45147
2012-09-26 10:10:27 +00:00
be0a9dcfa2
Note that it's a smart card standard.
...
svn path=/trunk/; revision=45141
2012-09-25 21:00:10 +00:00
82f78f6ed6
trival: replaced tabs with spaces, added modelines
...
svn path=/trunk/; revision=45138
2012-09-25 19:57:10 +00:00
7da8dfc0b8
From Michal Labedzki
...
make ISO 7816 Answer To Reset (ATR) a separate dissector
call it from Bluetooth SAP
from me
- change protocol name to iso7816.atr to be consistent with existing
filter names
- subtree for atr
- always call atr dissector via handle
- reject the packet if it has no valid init char
- don't use boolean data parameter, fill the info column with the data
required by Bluetooth SAP
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7715
svn path=/trunk/; revision=45137
2012-09-25 19:46:10 +00:00
5cb75e808d
replaced decode_boolean_bitfield, decode_numeric_bitfield, and decode_enumerated_bitfield calls with itemized filters
...
svn path=/trunk/; revision=45135
2012-09-25 18:41:41 +00:00
edf882913e
Decode some more elements.
...
svn path=/trunk/; revision=45119
2012-09-25 01:21:19 +00:00
4f9707469d
replaced decode_boolean_bitfield calls with itemized filters
...
added tfs_no_yes to tfs.[ch]
svn path=/trunk/; revision=45115
2012-09-25 01:00:41 +00:00
3f16280e9b
From Steve Magnani via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7753 :
...
Fix display of WRITE BUFFER and SEND DIAGNOSTIC fields in SCSI dissector
svn path=/trunk/; revision=45111
2012-09-24 19:42:12 +00:00
7a9d27c33f
Regenerate asn.1 dissectors.
...
svn path=/trunk/; revision=45110
2012-09-24 19:38:46 +00:00
8499871d96
Beginnings of the Foundry Discovery Protocol (FDP) dissector.
...
While FDP is (mostly) deprecated, it is still in use.
svn path=/trunk/; revision=45103
2012-09-24 16:20:31 +00:00
0bbd6d4616
Try to passify the buildbots by:
...
- Using G_GINT64_CONSTANT for 64 bit constants.
- Using guint64 and G_GINT64_MODIFIER where apropriate
- set individual struct members.
- cast time_t to guint i two places.
svn path=/trunk/; revision=45101
2012-09-24 13:54:45 +00:00
44e5ddb9c9
packet-btavctp.c:107: warning: 'number_of_packets' may be used uninitialized in this function
...
packet-btavctp.c:105: warning: 'pid' may be used uninitialized in this function
svn path=/trunk/; revision=45100
2012-09-24 12:51:34 +00:00
3bc8e5ff68
From Michal Labedzki:
...
Add Bluetooth Profile AVRCP. Supported version: 1.5.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7740
svn path=/trunk/; revision=45099
2012-09-24 12:46:30 +00:00
577dec01c5
From Michal Labedzki:
...
Add Bluetooth Protocol AVCTP. Supported version: 1.4.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7675
svn path=/trunk/; revision=45097
2012-09-24 12:30:30 +00:00
516f0c6e5c
Also avoid some unnecessary calls to strcmp() here, where the release
...
number at the end isn't important to know.
svn path=/trunk/; revision=45092
2012-09-24 10:34:27 +00:00
ef4ecaa38b
Use proto_tree_add_item() and value_strings in a couple of more places.
...
svn path=/trunk/; revision=45087
2012-09-24 08:38:45 +00:00
88ee7291cf
replaced decode_boolean_bitfield calls with itemized filters
...
svn path=/trunk/; revision=45082
2012-09-24 01:59:34 +00:00
69905db57c
Move potential dereference until *after* the null-check.
...
Caught by cppcheck.
svn path=/trunk/; revision=45081
2012-09-23 21:02:32 +00:00
7dd916459e
Let's be consistent and display lte_rrc root for all LTE RRC messages
...
svn path=/trunk/; revision=45080
2012-09-23 21:01:05 +00:00
c4d449cbff
expert_add...() shouldn't be called under 'if (tree)'.
...
svn path=/trunk/; revision=45072
2012-09-23 18:15:09 +00:00
72ca9d0e61
Store pointers to previously displayed and captured packet, not nstime_t deltas.
...
This commit reduces size (from 144B to 128B on AMD64) of frame_data structure.
Part of bug 5821: Reduce per-packet memory requirements.
svn path=/trunk/; revision=45071
2012-09-23 16:25:28 +00:00
a9bb9186dd
Fix some unused variable warnings from GCC.
...
svn path=/trunk/; revision=45064
2012-09-23 12:45:03 +00:00
b89a06a3e1
replaced decode_boolean_bitfield calls with itemized filters
...
svn path=/trunk/; revision=45059
2012-09-23 00:12:14 +00:00
6b3b90bde7
Fixup vlan_flags bug introduced with r45054
...
svn path=/trunk/; revision=45055
2012-09-22 18:47:11 +00:00
6516edc022
replaced decode_boolean_bitfield calls with itemized filters
...
svn path=/trunk/; revision=45054
2012-09-22 17:41:07 +00:00
ad32e468bf
Note that Banyan don't exist any more, so you can't order a dead-tree
...
version of the VINES documentation from them. However, there appear to
be online versions available; give the URLs for them.
svn path=/trunk/; revision=45052
2012-09-22 10:28:21 +00:00
a5d1394953
Remove incorrect extra hf_vines_ip_length - what's being constructed
...
there is the Transport Control field and subfields thereof, not the
packet length field.
Update some URLs.
svn path=/trunk/; revision=45051
2012-09-22 10:21:05 +00:00
006f022fea
Upgrade PDCP LTE dissector to v11.0.0
...
svn path=/trunk/; revision=45049
2012-09-21 20:12:32 +00:00
a8f9cd6593
Upgrade MAC LTE dissector to v11.0.0
...
svn path=/trunk/; revision=45048
2012-09-21 20:11:11 +00:00
8b6bc1630a
Dissect Update UE Location Information message
...
svn path=/trunk/; revision=45047
2012-09-21 20:00:12 +00:00
6dedc6628b
Test Procedures messages should be also integrity protected
...
svn path=/trunk/; revision=45046
2012-09-21 19:58:34 +00:00
201380fd33
Detected typos in speech codec value.
...
- Refactored code to use proto_tree_add_item() and use a value string.
svn path=/trunk/; revision=45044
2012-09-21 13:36:07 +00:00
467976f37f
Assuming transport_protocol is a guint8.
...
svn path=/trunk/; revision=45042
2012-09-21 11:54:30 +00:00
ff1a7d93bf
From Michal Labedzki:
...
Bluetooth: Provide PSM for higher layers
This is needed by AVRCP, HCRP and AVDTP to recognize other substreams.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7740
svn path=/trunk/; revision=45041
2012-09-21 11:30:53 +00:00
1684c38d44
From Michal Labedzki:
...
Add SAP dissector
Add Bluetooth Profile SAP. Supported version: 1.1.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7715
svn path=/trunk/; revision=45040
2012-09-21 11:14:33 +00:00
aa3c9034f5
From Michal Labedzki:
...
Bluetooth: Cleanup headers
Remove redundant headers and sort existing to chosen convention.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7639
svn path=/trunk/; revision=45039
2012-09-21 10:49:44 +00:00
8974a27357
From Michal Labedzki:
...
FCS is not part of "Control" subtree so move it.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7639
svn path=/trunk/; revision=45038
2012-09-21 10:39:15 +00:00
0382e69331
From Michal Labedzki:
...
Bluetooth: Improve internal Decode By Channel for RFCOMM
Use UAT to allow user to force set top dissector per channel.
Only first found dissection for specified channel is used,
the rest can be used as well-known protocol on channel, but not for
current logs. Also user can turn on/off this dissection by one-click
preference.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7639
svn path=/trunk/; revision=45037
2012-09-21 08:52:45 +00:00
b36016fc1d
I guess the IETF is now keeping expired I-Ds around; alternic doesn't
...
have that one any more.
svn path=/trunk/; revision=45030
2012-09-20 20:17:53 +00:00
Michael Mann