AndersBroman
5fa267e870
REplace deprecated API tvb_length -> tvb_reported_length
...
Change-Id: I6090055a9c31f6787626b810de655d1cc71b99de
Reviewed-on: https://code.wireshark.org/review/8002
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-04-09 12:03:23 +00:00
Pascal Quantin
fd870e34e8
CMIP: get rid of some evil global variables
...
Fixes an ASAN failure reported by Alexis
Note that some global variables remain as I do not know enough on this protocol to safely remove them
Change-Id: If392a8f09ef2fc2f2d46871a71149e29fe5e292c
Reviewed-on: https://code.wireshark.org/review/7099
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-02-17 20:28:45 +00:00
Bill Meier
dd859eada4
asn1 generated dissectors: cleanup #include usage
...
Change-Id: I36b2731d67f9345d2fd0c23800bba7d2be94c387
Reviewed-on: https://code.wireshark.org/review/6008
Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-12-23 05:39:00 +00:00
Stig Bjørlykke
4e1b5ea866
ASN1: Register PDU-dissectors as NEW
...
Change-Id: I1a317b19d8076588c9305dae6287bb80cc14da64
Reviewed-on: https://code.wireshark.org/review/4494
Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
Tested-by: Stig Bjørlykke <stig@bjorlykke.org>
2014-10-13 11:24:07 +00:00
Michael Mann
cd02af56a1
Eliminate (almost all) proto_tree_add_text calls from ASN.1 dissectors.
...
This mostly involved adding expert info capabilities to many of the dissectors so that they could correctly flag error conditions.
Only remaining proto_tree_add_text calls are in H248.cnf, which has a convoluted way of using hf_ data to make its tree.
Change-Id: I6412150c2ec1977d7fa38f3f0ed416680bdfb141
Reviewed-on: https://code.wireshark.org/review/3500
Petri-Dish: Michael Mann <mmann78@netscape.net>
Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-08-09 01:57:08 +00:00
Evan Huus
5ed05dd747
batch of manual tvb_length conversions
...
Change-Id: Ib3a1ddc4342a7a8648d6ed8bfcb35aa229c56a27
Reviewed-on: https://code.wireshark.org/review/2445
Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-19 19:55:31 +00:00
Michael Mann
14824e6adf
Revert "Fixup: tvb_* -> tvb_captured"
...
https://www.wireshark.org/lists/wireshark-dev/201406/msg00131.html
This reverts commit 246fe2ca4c
.
Change-Id: Ib24bae0198c13a84bd7f731bf4af921212109a8f
Reviewed-on: https://code.wireshark.org/review/2430
Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-19 18:25:59 +00:00
Dario Lombardo
246fe2ca4c
Fixup: tvb_* -> tvb_captured
...
Change-Id: I9209c1271967405c34c1b6fa43e1726a4d3a5a3f
Reviewed-on: https://code.wireshark.org/review/2377
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-18 14:14:58 +00:00
Pascal Quantin
d6548f9301
Remove unused const variables errors seen with recent Clang version
...
Fixes bug 9886
Change-Id: I8624ef1c5874aea5521d21c998510fc29c838936
Reviewed-on: https://code.wireshark.org/review/657
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-03-15 17:52:16 +00:00
Bill Meier
1dff4e309d
Remove trailing whitespace from asn1 .cnf & template.[hc] files. Regenerate dissectors.
...
Change-Id: I0e779b2ac2f608356649c5bbfca438141070dea4
Reviewed-on: https://code.wireshark.org/review/412
Reviewed-by: Bill Meier <wmeier@newsguy.com>
Tested-by: Bill Meier <wmeier@newsguy.com>
2014-02-26 19:38:21 +00:00
Jeff Morriss
8c608e6e82
Remove $Id$ from the ASN.1 dissectors and regenerate them.
...
Change-Id: Ie476c6f82f318188b41ed922b92c6fec119ea954
Reviewed-on: https://code.wireshark.org/review/244
Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
Tested-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
2014-02-18 03:05:28 +00:00
Chris Maynard
231e52a9ea
Reject the packet if data is NULL without doing anything else.
...
svn path=/trunk/; revision=53737
2013-12-02 21:52:46 +00:00
Michael Mann
b6b78d69db
In an effort to reduce the use of pinfo->private_data (and some true global variables), I converted the ASN.1 dissectors that use pinfo->private_data to exchange a SESSION_DATA_STRUCTURE to instead only exchange it in the context of ASN.1. This meant converting dissectors to the "new" style to pass the SESSION_DATA_STRUCTURE as well as providing a pointer to it in asn1_ctx_t.private_data. Yes, it's still "private data", but it's not used by all dissectors like pinfo->private data is.
...
svn path=/trunk/; revision=53090
2013-11-05 18:47:26 +00:00
Michael Mann
c0fcebb07a
Add a data parameter to call_ber_oid_callback to be able to pass data to subdissectors found with dissector_try_string_new.
...
The intention is to aid in the removal of pinfo->private_data use as well as static global variables in a dissector. For now, all calls to call_ber_oid_callback have the data parameter set to NULL.
svn path=/trunk/; revision=52994
2013-10-31 00:57:03 +00:00
Pascal Quantin
0ee4d0a00a
Postfix FT_NONE fields with "_element" string to reduce number of incompatible filters in ASN.1 dissectors
...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2402
svn path=/trunk/; revision=49599
2013-05-27 20:26:49 +00:00
Pascal Quantin
a37c044203
Update the ASN.1 based dissectors following the changes done in r48812
...
svn path=/trunk/; revision=48820
2013-04-11 18:14:53 +00:00
Anders Broman
20c17246d4
svn path=/trunk/; revision=48440
2013-03-20 06:50:56 +00:00
Jakub Zawadzki
7a9d27c33f
Regenerate asn.1 dissectors.
...
svn path=/trunk/; revision=45110
2012-09-24 19:38:46 +00:00
Jeff Morriss
2552c750e5
We always HAVE_CONFIG_H so don't bother checking whether we have it or not.
...
svn path=/trunk/; revision=45017
2012-09-20 02:03:38 +00:00
Jakub Zawadzki
bf81b42e1e
Update Free Software Foundation address.
...
(COPYING will be updated in next commit)
svn path=/trunk/; revision=43536
2012-06-28 22:56:06 +00:00
Bill Meier
794757ae8f
For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.
...
Also: remove trailing whitespace for a number of files.
svn path=/trunk/; revision=39503
2011-10-21 02:10:19 +00:00
Bill Meier
24cf0aad06
Update generated ASN1 *.[hc] files after recent work done by Jeff Morriss;
...
The only change in each file is in a comment showing the asn2wrs cmd used to build that file.
svn path=/trunk/; revision=39427
2011-10-15 19:27:27 +00:00
Stig Bjørlykke
a7c5d642d5
Regenerate ASN.1 dissectors to update the #line directive.
...
svn path=/trunk/; revision=37118
2011-05-13 08:12:27 +00:00
Stig Bjørlykke
1ba57f4c04
Added a dissector table for AttributeId localForm.
...
Use correct object identifier in ModificationList.
svn path=/trunk/; revision=35894
2011-02-10 10:11:38 +00:00
Jeff Morriss
a0c858efcd
Add a little more code to avoid not-very-useful blurbs:
...
- Change spaces in the name to underscores before comparing it to the blurb.
- Check if the type simply as T_ prepended to the name.
- Don't put in a blurb of "NULL".
and regenerate the dissectors.
svn path=/trunk/; revision=32748
2010-05-11 03:53:31 +00:00
Jeff Morriss
8f210cf4e0
Regenerate a few of the ASN.1 dissectors
...
svn path=/trunk/; revision=32742
2010-05-11 02:13:26 +00:00
Bill Meier
9ade30a7b1
#include <string.h> and/or #include <stdio.h> not needed.
...
svn path=/trunk/; revision=32417
2010-04-07 16:54:29 +00:00
Bill Meier
f8b92f8d0b
#include <stdio.h> not needed.
...
svn path=/trunk/; revision=32405
2010-04-06 17:01:14 +00:00
Stig Bjørlykke
8b42b795e8
Use correct opcode table for error values and regular values.
...
Removed check_col().
svn path=/trunk/; revision=30950
2009-11-13 12:33:33 +00:00
Stig Bjørlykke
6d1dae6f28
Make all proto_* values static.
...
svn path=/trunk/; revision=30516
2009-10-11 16:24:29 +00:00
Kovarththanan Rajaratnam
9490d1b74c
Regenerate asn1 dissectors (no change, only some line offset changes)
...
svn path=/trunk/; revision=30454
2009-10-09 21:34:49 +00:00
Stig Bjørlykke
8fce84f9e2
Fix a possible dereference of null pointer when having no tree.
...
svn path=/trunk/; revision=30174
2009-09-27 21:18:18 +00:00
Kovarththanan Rajaratnam
65c53fedb6
Don't guard col_append_str with check_col
...
svn path=/trunk/; revision=30125
2009-09-24 20:00:21 +00:00
Kovarththanan Rajaratnam
0a5b014cec
Don't guard col_clear with col_check
...
svn path=/trunk/; revision=29344
2009-08-09 07:36:13 +00:00
Kovarththanan Rajaratnam
e971354a54
Don't guard col_set_str (COL_PROTOCOL) with col_check
...
svn path=/trunk/; revision=29340
2009-08-09 06:26:46 +00:00
Gerald Combs
87c095780a
Rework an assignment to keep static analyzers from complaining.
...
svn path=/trunk/; revision=29287
2009-08-03 23:51:13 +00:00
Stig Bjørlykke
9733aadcfe
Re-generate asn1 dissectors after hf_register_info cleanup.
...
svn path=/trunk/; revision=28848
2009-06-26 03:59:01 +00:00
Stig Bjørlykke
b228488bc0
From Kovarththanan Rajaratnam via bug 3548:
...
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero
svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Stig Bjørlykke
c47e788c94
Regenerate all asn2wrs generated dissectors.
...
svn path=/trunk/; revision=28379
2009-05-16 22:07:03 +00:00
Bill Meier
35e5fa9bc1
#include <epan/conversation.h> and/or #include <epan/emem.h> not req'd ...
...
svn path=/trunk/; revision=27390
2009-02-07 14:33:47 +00:00
Anders Broman
e375c3990a
Regenerate all asn2wrs generated dissectors
...
svn path=/trunk/; revision=26670
2008-11-01 22:30:14 +00:00
Anders Broman
742ae8413d
Get rid of some unused code warnings.
...
svn path=/trunk/; revision=25791
2008-07-22 17:28:38 +00:00
Anders Broman
de16039c51
Get rid of dissect_ber_boolean_value() and change the signature of
...
dissect_ber_boolean() to return a value and update asn2wrs to generate the new signature.
Regenerate all BER dissectors.
svn path=/trunk/; revision=24015
2008-01-04 16:21:07 +00:00
Anders Broman
f7804d9899
Update do use the -X and -T asn2wrs flags.
...
svn path=/trunk/; revision=23356
2007-11-04 17:57:31 +00:00
Anders Broman
528ac73cfd
Use oid_add_from_string for adding names.
...
svn path=/trunk/; revision=23318
2007-10-31 08:26:52 +00:00
Luis Ontanon
00c5e48a17
get users of oid_resolv to use the new oids, rollout packet-snmp.c
...
svn path=/trunk/; revision=22651
2007-08-25 01:14:24 +00:00
Jörg Mayer
b312e64f6a
get_ber_length doesn't need the tree argument, get rid of it.
...
Rebuild asn1 dissectors.
svn path=/trunk/; revision=22627
2007-08-24 07:12:04 +00:00
Anders Broman
04138a1353
Correct a copy paste error and rename fields.
...
svn path=/trunk/; revision=22228
2007-07-02 09:20:19 +00:00
Anders Broman
42f17b2111
Try to fix defined but not used warnings and use the nice new table function to get the
...
list of Opcodes.
svn path=/trunk/; revision=22227
2007-07-01 18:48:15 +00:00
Anders Broman
32d0349b54
Try to fix the last defined but not used warnings(again).
...
svn path=/trunk/; revision=22204
2007-06-27 17:02:47 +00:00