Commit Graph

46362 Commits

Author SHA1 Message Date
Evan Huus c0c0b10f96 A few more doxygen fix-ups.
svn path=/trunk/; revision=49092
2013-04-30 00:55:03 +00:00
Gerald Combs 9120bf883e Move the contents of wsar_html/core to wsar_html. Create tag files for
core, epan, and ui, and link them to each other to varying degrees. This
seems to be the best way to organize our documentation. The alternative
is to switch to a single doxygen.cfg and manually add files to different
groups or sections.

Add a wireshark.dox file which contains markup for the main page. Add
.dox and .txt to svnadd. Clean up our tag files. Force wsar_html to
rebuild each time.

svn path=/trunk/; revision=49091
2013-04-30 00:27:02 +00:00
Gerald Combs 160af64058 State that we don't support U3 any more.
svn path=/trunk/; revision=49090
2013-04-29 23:08:31 +00:00
Gerald Combs b2e88f3d5e Darken and saturate the "trouble" backgrounds a bit.
svn path=/trunk/; revision=49084
2013-04-29 17:13:24 +00:00
Evan Huus c17d706c8c Specify to CppCheck that Wireshark code is C89, not the default C11.
svn path=/trunk/; revision=49083
2013-04-28 23:30:29 +00:00
Gerald Combs 6608eddd3d [Automatic manuf, services and enterprise-numbers update for 2013-04-28]
svn path=/trunk/; revision=49079
2013-04-28 14:03:34 +00:00
Guy Harris 2cd4b0f607 Fix suspected copy-and-pasteo.
svn path=/trunk/; revision=49078
2013-04-28 01:09:00 +00:00
Evan Huus b39cf04f14 Add CppCheck to the list of things to run before submitting code for review.
svn path=/trunk/; revision=49077
2013-04-27 23:11:06 +00:00
Evan Huus c17893650c Silence a false-positive warning from older GCCs:
'acetype4' may be used uninitialized in this function

svn path=/trunk/; revision=49076
2013-04-27 15:00:52 +00:00
Evan Huus 0a530b2a1f When fuzzing with valgrind and running without -T, run with -v so that the
argument string is non-empty. Perhaps this will fix the fuzz-bot which fails
to run with the empty argument string...

svn path=/trunk/; revision=49075
2013-04-27 14:03:45 +00:00
Evan Huus 132ee18259 From Cal Turney via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8605
Numerous improvements to NFS ACL/ACE dissection. For a complete list see
comment #11 of the bug.

From me:
- fix an infinite loop caught by fuzzing
- fix an out-of-bounds memory access caught by valgrind
- add missing {0,NULL} terminator to value_string array

svn path=/trunk/; revision=49074
2013-04-27 13:59:46 +00:00
Martin Kaiser 600e5ac301 remove unnecessary if (tree) checks
I hope this prevents bugs like the one fixed in r48917

svn path=/trunk/; revision=49073
2013-04-27 13:06:28 +00:00
Martin Kaiser 3beb9a36a3 free the linkname allocated by g_strdup()
set linkname to unknown for interfaces without a linkname (e.g.  pipes)
remove "this should not happen" warnings

svn path=/trunk/; revision=49072
2013-04-27 12:35:30 +00:00
Martin Kaiser e1bc174b39 when a named pipe is added to the interfaces list, it has no linktype
this triggered the g_assert(linktype) in create_and_fill_model()
    
the assert is not necessary as both gtk_list_store_set() and g_free()
can handle NULL parameters
    
remove the assert and add set linktype to "unknown" if the interface
has no linktype 

svn path=/trunk/; revision=49071
2013-04-27 09:55:46 +00:00
Guy Harris 2013b5ad31 Fix a comment (the "it worked but didn't pop up a window" conclusion
came from a bad test).

svn path=/trunk/; revision=49070
2013-04-27 03:51:40 +00:00
Guy Harris a36a0a7a84 Update comments.
svn path=/trunk/; revision=49069
2013-04-27 02:57:16 +00:00
Evan Huus 5deac1e6e1 Wmem string-buffer improvements:
- better tests
- fix a bug caught by the better tests
- implement append_c and append_unichar, with tests

Wmem string-buffers now have feature parity with their emem equivalents, so
remove them from the TODO list.

svn path=/trunk/; revision=49060
2013-04-26 21:30:24 +00:00
Gerald Combs 32352fb1a2 Update the capture start, stop, and restart icons and development badge
with enhanced versions from Elliott.

Switch the interface configuration icon to the "gear" version. This
matches the gear in the capture icon.

svn path=/trunk/; revision=49059
2013-04-26 21:10:35 +00:00
Jeff Morriss cbc09f6fc5 Set svn:mime-type
svn path=/trunk/; revision=49057
2013-04-26 20:30:04 +00:00
Gerald Combs b53b4becdd Try to determine the repository URL automatically.
svn path=/trunk/; revision=49056
2013-04-26 19:50:43 +00:00
Evan Huus 5b8a3df249 From me: only sign-extend BER integers if the field is actually signed
From Guy: override two fields in the GOOSE ASN.1 dissector to be unsigned

Together these fix
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8250


svn path=/trunk/; revision=49055
2013-04-26 19:23:36 +00:00
Evan Huus 63ef04ec84 Fix a whole bunch of doxygen warnings, mostly typos or renamed parameters.
svn path=/trunk/; revision=49053
2013-04-26 18:28:21 +00:00
Gerald Combs 098997e5fb Buildbot (via Twisted) sets a restrictive umask. Unset it before we run
Doxygen.

svn path=/trunk/; revision=49052
2013-04-26 18:23:05 +00:00
Gerald Combs ea5829c50b Add some Doxygen checks.
svn path=/trunk/; revision=49051
2013-04-26 17:49:00 +00:00
Jeff Morriss 32d6384725 Set svn:eol-style and svn:keywords
svn path=/trunk/; revision=49049
2013-04-26 15:28:30 +00:00
Jeff Morriss c1dbdee5a1 Fix up indentation
svn path=/trunk/; revision=49048
2013-04-26 13:53:53 +00:00
Guy Harris edfe2fc28c Work around a bug in a Microsoft security fix.
svn path=/trunk/; revision=49046
2013-04-26 04:42:20 +00:00
Guy Harris 889e2d6e5e Get rid of leftover debugging variable.
svn path=/trunk/; revision=49045
2013-04-26 01:01:32 +00:00
Guy Harris d3dc1bfd43 Check, for each of the standard handles, whether they need to be
redirected to a console.  Only if at least one of them needs to be
redirected to we create a console, and don't redirect them if they don't
need to be redirected.

This makes redirection of the standard output of, for example,
"wireshark -D" work; we don't redirect it out from under the shell.

svn path=/trunk/; revision=49044
2013-04-26 00:50:21 +00:00
Gerald Combs e6434ae19e Update the main, epan, and ui Doxygen configuration files. Change the
output directory to wsar_html (Wireshark API Reference HTML) to match
the Docbook naming convention. In each doxygen.cfg.in move the
doxygen_global.cfg to the top of the file so that our local definitions
don't get clobbered. Add makefile targets for wsar_html and wsar-zip.

svn path=/trunk/; revision=49043
2013-04-26 00:07:42 +00:00
Jörg Mayer c3d7f57f58 Add Qt5 build support with cmake. Just do cmake ... -DENABLE_QT5=ON ...
svn path=/trunk/; revision=49042
2013-04-25 23:04:19 +00:00
Evan Huus 7d2c6f3000 Annotate wmem functions for better compiler warnings and optimization.
svn path=/trunk/; revision=49041
2013-04-25 22:54:36 +00:00
Evan Huus e8fc503c21 Summarize the API listing in the wmem README. Doxygen in the header files will
be much easier to keep in sync with the actual code.

svn path=/trunk/; revision=49040
2013-04-25 22:29:48 +00:00
Jörg Mayer 9b87dc0afc Fix a warning: sparkline_delegate.h does not contain a Q_OBJECT
svn path=/trunk/; revision=49039
2013-04-25 22:11:40 +00:00
Jörg Mayer 52965244cd Add GTK3_DEFINITIONS to the compiler flag when building with gtk3
svn path=/trunk/; revision=49038
2013-04-25 21:35:54 +00:00
Jörg Mayer 540b4d5f2d Generating the realease notes is not yet done.
svn path=/trunk/; revision=49037
2013-04-25 21:34:22 +00:00
Gerald Combs d83d4accb0 Update QtShark.pro for Qt5, hopefully without breaking Qt4. Enable the
startup blur on OS X for Qt >= 5.

svn path=/trunk/; revision=49036
2013-04-25 21:08:56 +00:00
Martin Mathieson 74e15c70cc Flag as malformed expert info if we see padding subheaders at start and
end of subheader list.

svn path=/trunk/; revision=49035
2013-04-25 21:07:32 +00:00
Martin Kaiser 9264cc1137 From Mathias Guettler
correct value for "ATN Systems Management No Preference"

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8562

svn path=/trunk/; revision=49034
2013-04-25 20:54:56 +00:00
Anders Broman 54aa5c072f Add an AVP.
svn path=/trunk/; revision=49033
2013-04-25 17:21:34 +00:00
Pascal Quantin b3da159427 Enhance dissection of feedback
svn path=/trunk/; revision=49032
2013-04-25 15:21:48 +00:00
Evan Huus df0bbb4ffc Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8611
svn path=/trunk/; revision=49030
2013-04-25 13:57:02 +00:00
Jörg Mayer 557e7723e0 Note the removal of the left-handed settings and how to get the
behavior back via gtk-settings.

svn path=/trunk/; revision=49026
2013-04-25 08:15:22 +00:00
Guy Harris 39779a7bee Send the output of the -D and -L options to the standard output rather
than the standard error.

In Wireshark on Windows, create a console before doing so and destroy it
before exiting.  Don't do that in TShark or dumpcap, as those are
console-mode programs on Windows.

This should fix bug 8609 and still allow "wireshark -D" and "wireshark
-L" to work when the standard output isn't redirected.

svn path=/trunk/; revision=49025
2013-04-25 05:47:11 +00:00
Pascal Quantin 35d3fa75be Try to please the OSX buildbots
svn path=/trunk/; revision=49024
2013-04-25 05:24:07 +00:00
Michael Mann eba34e00e7 Convert a few proto_tree_add_text to proto_tree_add_items. The dissector was originally under the 50% mark that checkAPIs.pl like, but subsequent patches pushed it over the limit, so I thought I'd knock it back down.
svn path=/trunk/; revision=49023
2013-04-24 23:20:24 +00:00
Michael Mann a18e128b44 convert some proto_tree_add_texts into expert_add_info_format. Didn't quite make checkAPIs.pl happy, but given the nature of the dissector (mostly raw text), I'm not sure it can hit the 50% ratio.
svn path=/trunk/; revision=49022
2013-04-24 23:17:44 +00:00
Michael Mann 2d9a44e0fa Add a few IP filterable fields to make checkAPIs.pl happy. It appears that "enumerated filter fields" are necessary, but that allows them to shirk the check* tools to possibly find unused hfs.
svn path=/trunk/; revision=49021
2013-04-24 23:15:38 +00:00
Pascal Quantin 2dc27b8b85 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8610 :
Ensure that tap is called after full dissection, even in case of exception

svn path=/trunk/; revision=49019
2013-04-24 21:25:30 +00:00
Pascal Quantin fd13812247 Add China Telecom AVP:s to Windows installer
svn path=/trunk/; revision=49018
2013-04-24 18:04:33 +00:00