Commit Graph

1011 Commits

Author SHA1 Message Date
Guy Harris 9687947b5f From Lars Roland:
- added a pointer to raw rtp data to _rtp_info that can be used by
	  taps;

	- RTP packets are passed to the tap queue only if they are not
	  error packets (so that you don't need to filter out ICMP
	  packets)

	- use that pointer in rtp_stream, so it handles packets with
	  padding, and should handle RTP packets fragmented across
	  lower-level packets

	- moved rtp_stream from tap sources to normal files
	  (prevents on-start-up registration of the rtp_stream tap
	  listener)

	- rtp_stream tap gets registered/unregistered with the "RTP
	  Streams" dialog box
	  i.e. the tap is registered as long as the dialog box is open.
	  Alternatively, it is de-/registered on demand if RTP Analysis is
	  called directly on a packet.

	- rtp_stream tap listener no longer uses a filter in dissection
`	  and does not need to have a proto tree being built.
	  (performance increase)

	- fixed: RTP Streams list will get updated in real time if the
	  dialog box is open while a redissection takes place.

svn path=/trunk/; revision=9051
2003-11-20 23:34:31 +00:00
Guy Harris 81ff12e4aa Use "OK" for the "OK" button, as we do elsewhere.
svn path=/trunk/; revision=9025
2003-11-19 01:50:50 +00:00
Ulf Lamping 34dfb0b3d0 redraw supported_protos dialog, if GUI prefs changed
svn path=/trunk/; revision=9022
2003-11-19 00:10:25 +00:00
Ulf Lamping 007b97900c added supported_protos menu item
svn path=/trunk/; revision=9021
2003-11-19 00:04:15 +00:00
Ulf Lamping 3aad138c1b added supported_protos_dlg
svn path=/trunk/; revision=9020
2003-11-19 00:02:42 +00:00
Ulf Lamping 0d636117a1 added supported_protos_dlg.obj
svn path=/trunk/; revision=9019
2003-11-19 00:01:38 +00:00
Ulf Lamping afafa5fd36 seperated "supported protocols and protocol fields" dialog, coming from help_dlg.c/.h
svn path=/trunk/; revision=9018
2003-11-18 23:56:45 +00:00
Ulf Lamping 1aacb3f060 removed MSVC compiler warnings
svn path=/trunk/; revision=9010
2003-11-18 19:29:07 +00:00
Ulf Lamping 02b9fb53cc removed unused vars
svn path=/trunk/; revision=9008
2003-11-18 19:27:39 +00:00
Ulf Lamping 4d0f00fe32 removed MSVC warnings
svn path=/trunk/; revision=8996
2003-11-18 06:06:41 +00:00
Gerald Combs fee0d98c18 Check the environment variables SSH_CONNECTION, SSH_CLIENT, REMOTEHOST,
DISPLAY, and CLIENTNAME (in that order).  If any of them are set, create
a capture filter that excludes their traffic and set it as the default.
The longer filters should be efficient without being overly long; they
may need some tweaking.

svn path=/trunk/; revision=8994
2003-11-18 04:16:28 +00:00
Ulf Lamping 3b0e3efce4 removed some warnings
svn path=/trunk/; revision=8993
2003-11-18 00:46:40 +00:00
Guy Harris dc69087b0c Not all compilers allow array/structure/union members of automatic
variables to be initialized to non-constant values (C89 says that "All
the expressions in an initializer for an object that has static storage
duration or in an initializer list for an object that has aggregate or
union type shall be constant expressions"; presumably the intent of the
former was to avoid run-time initialization and of the latter was to let
the initialization be done by copying from a compile-time-created blob
of memory), so we have to initialize "info->counts" by hand.

svn path=/trunk/; revision=8984
2003-11-17 20:00:37 +00:00
Guy Harris 02a954efe3 "capture()" takes a "struct pcap_stat *" argument, so you need to
include <pcap.h> before including "capture.h".

Include "dlg_utils.h" to declare "dlg_set_cancel()".

svn path=/trunk/; revision=8981
2003-11-17 00:27:33 +00:00
Guy Harris 7bd2e232a9 Export "protocol_t" as an opaque type.
Make "proto_is_protocol_enabled()" and "proto_get_protocol_short_name()"
take a "protocol_t *" as an argument, so they don't have to look up the
"protocol_t" - this will probably speed them up considerably, and
they're called on almost every dissector handoff.

Get rid of a number of "proto_is_protocol_enabled()" calls that aren't
necessary (dissectors called through handles, including those called
through dissector tables, or called as heuristic dissectors, aren't even
called if their protocol isn't enabled).

Change some direct dissector calls to go through handles.

svn path=/trunk/; revision=8979
2003-11-16 23:17:27 +00:00
Ronnie Sahlberg 21313199e4 From Lars Roland Service Response times for H225 RAS
svn path=/trunk/; revision=8978
2003-11-16 23:11:20 +00:00
Guy Harris a8fc1d810d From Michael Lum: add <shift><control> hotkeys for Protocols and
Preferences.

svn path=/trunk/; revision=8975
2003-11-15 23:48:52 +00:00
Ulf Lamping 1a42ad1d50 GTK2 specific: use some Ethereal specific stock icons generated in toolbar.c
svn path=/trunk/; revision=8974
2003-11-15 11:46:09 +00:00
Ulf Lamping 0fe5eba745 handlebar removed,
GTK2 specific: generate some Ethereal specific stock icons and
use them in the toolbar

svn path=/trunk/; revision=8973
2003-11-15 11:44:10 +00:00
Ulf Lamping 63aa4a59c0 seperated capture dialog from capture.c and put into new gtk/capture_info_dlg.c,
added some tiny bars, that will indicate the percentage,
added ESC key handler and use of GTK_STOCK button

svn path=/trunk/; revision=8970
2003-11-15 08:53:56 +00:00
Ulf Lamping ee48f3052f added "#include <epan/packet.h>" to be able to include "capture.h"
svn path=/trunk/; revision=8969
2003-11-15 08:50:07 +00:00
Ulf Lamping bca18fcf68 seperated capture dialog from capture.c and put into new gtk/capture_info_dlg.c
svn path=/trunk/; revision=8968
2003-11-15 08:48:14 +00:00
Ulf Lamping 8064140631 completely redesigned print dialog layout, to be more obvious to the user
svn path=/trunk/; revision=8949
2003-11-12 19:04:58 +00:00
Ulf Lamping 27c8d04949 added some print dialog flags, to disable some unsupported print features
(e.g. selection of pages from X to Y)

svn path=/trunk/; revision=8938
2003-11-11 13:59:53 +00:00
Guy Harris c5fad03460 The user interface preference page has only 9 rows in the GTK+ 2.x
version.

svn path=/trunk/; revision=8933
2003-11-11 05:23:23 +00:00
Guy Harris 6108feb655 Create the last two items in the GUI preferences page's first column the
same way the other items are created - in order, going down the page,
and using "pos++" as the table position.

svn path=/trunk/; revision=8932
2003-11-11 05:09:03 +00:00
Ronnie Sahlberg 6073e3b265 Not all LDAP PDUs are aligned to the start of a TCP segment.
If we failed to dissect the GSS-SPNEGO blob it probably means that the segment
is somewhere in the middle of an LDAP PDU.

Just bail out and stop dissecting the PDU instead of aborting ethereal completely
using g_assert() since this is not really a pathological error, its just something that can and will happen normally.

svn path=/trunk/; revision=8925
2003-11-10 07:44:47 +00:00
Guy Harris ed66a067f5 Nothing here should require zlib.h, so we shouldn't need to do
"/I$(ZLIB_DIR)".

svn path=/trunk/; revision=8910
2003-11-07 23:26:15 +00:00
Guy Harris a37ef3e1e2 "File->Open" should be available whether or not we have a captue file
open.

The toolbar equivalent should *not* be available if we have an "Update
list of packets in real time" capture running.

The toolbar "Save" button should not be available if we don't have an
unsaved capture file.

svn path=/trunk/; revision=8902
2003-11-07 01:29:05 +00:00
Guy Harris 27b2678cca Make Shift+Control+S an accelerator for "Save As...", as per the GNOME
HIG.

svn path=/trunk/; revision=8901
2003-11-06 23:02:06 +00:00
Ronnie Sahlberg de20fa6a54 the LDAP service response time dialog
svn path=/trunk/; revision=8886
2003-11-05 09:04:51 +00:00
Ronnie Sahlberg f16f83b154 update for LDAP
measure the response time for some LDAP commands and
add a service response time dialog for it

svn path=/trunk/; revision=8885
2003-11-05 09:04:17 +00:00
Guy Harris 7089251f68 Skip the check for the module if a page doesn't have a module.
svn path=/trunk/; revision=8881
2003-11-04 20:33:13 +00:00
Guy Harris 343a178e33 Clean up the way we find the properties page for a given protocol
somewhat; this fixes a bug wherein we were assuming all modules
necessarily had preference pages (they won't, if the only preferences
for the module are obsolete preferences).

svn path=/trunk/; revision=8880
2003-11-04 20:22:21 +00:00
Guy Harris 85773d34c3 From Olivier Abad: Insert the GTK+ 2.2.4
"gtk_tree_view_expand_to_path()" when building with GTK+ 2.0[.x], so
that we can build with 2.0[.x].

svn path=/trunk/; revision=8871
2003-11-03 21:00:05 +00:00
Guy Harris c682c10915 From Lars Ruoff: fix a problem with wrong maximum delay calculation -
first or marked packets are now ignored when calculating maximum delay.

svn path=/trunk/; revision=8868
2003-11-03 20:45:25 +00:00
Guy Harris ce51c5c700 Don't try to get the list of link-layer header types for an interface if
the interface isn't in the list of known (local) interfaces - that way
we don't try to get entries if the user's in the middle of changing the
"Interface:" text, or if the interface is an rpcap: URL (getting the
link-layer header type list for a remote interface is currently
impossible, and even just getting its *default* interface type could
hang for a long time if the remote machine isn't responding).

Free the link-layer header type list when we're done with it.

Label the option menu for that list "Link-layer header type", as it
doesn't control the data link type of the interface in the only case I
know of where it's settable, namely 802.11 interfaces - it just controls
whether the packets you get from the interface have a fake Ethernet
header or a real 802.11 header.

svn path=/trunk/; revision=8867
2003-11-03 10:40:51 +00:00
Guy Harris c0f8032621 "g_list_first()" takes an arbitrary list entry as an argument; you don't
need to call it if you already have a pointer to the first entry in the
list, which is what "a pointer to the list" is.

svn path=/trunk/; revision=8866
2003-11-03 10:36:45 +00:00
Gerald Combs 2bdac88860 The recent link-layer type additions broke "-r". Make it work again.
svn path=/trunk/; revision=8857
2003-11-02 19:31:20 +00:00
Guy Harris 3c2706c338 Return FALSE from the configure event handler, so that anybody else
who's registered for it can get notified about it.

svn path=/trunk/; revision=8849
2003-11-01 03:03:25 +00:00
Guy Harris 219b6cefa2 Based on a patch from Brian Fundakowski Feldman, add support for setting
link-layer type when capturing, using the "pcap_set_datalink()" and
related APIs.

svn path=/trunk/; revision=8848
2003-11-01 02:30:18 +00:00
Guy Harris 3a6a79c3c9 From Lars Ruoff:
- fix missing detection of first packet when writing payload.
	- fix bug of erroneous handling of confort noise when writing payload.
	- fix bug of possible endless silence insertion on first packet when
	  writing payload.

svn path=/trunk/; revision=8846
2003-10-31 19:45:16 +00:00
Guy Harris b4bdaa5e9f Put quotes around values for FT_ABSOLUTE_TIME variables, and around
values with white space in them.

svn path=/trunk/; revision=8820
2003-10-29 23:15:35 +00:00
Guy Harris 5f01c7a082 Have the "edit display filters" button do the exact same thing as the
"Edit -> Display Filters..." menu item, as per Ulf Lamping - there's
apparently some problem wherein &args doesn't get passed properly to the
callback.

svn path=/trunk/; revision=8819
2003-10-29 22:39:49 +00:00
Guy Harris 1c5ed66f45 From Lars Roland: H.225 message and reason tag counter taps.
svn path=/trunk/; revision=8794
2003-10-28 00:31:17 +00:00
Guy Harris 0a7b08c9e9 Don't draw a Y-axis label if you haven't constructed the label string.
svn path=/trunk/; revision=8792
2003-10-27 23:12:53 +00:00
Richard Sharpe 7dc61c936d Add filter button support to FibreChannel stats and DCERPC stats.
svn path=/trunk/; revision=8785
2003-10-27 01:35:53 +00:00
Richard Sharpe cf1f6efdf6 Add Filter Button support for onc-rpc as well ...
svn path=/trunk/; revision=8784
2003-10-27 01:20:16 +00:00
Richard Sharpe e86c448e78 Make sure that Clicking OK in the filter creation dialog box does not act
as an OK to the dialog box it is called from.

svn path=/trunk/; revision=8783
2003-10-27 01:09:32 +00:00
Richard Sharpe a6a40da79d This changes the Filter: label in the SMB Service Response Time dialog box to
a button that brings up the Create Filter dialog box. While it works, the
problem is that it also acts as an Enter keypress as far as the start_stat
button is concerned.

Probably needs a small fix.

svn path=/trunk/; revision=8782
2003-10-27 00:54:02 +00:00