Commit graph

15710 commits

Author SHA1 Message Date
Luis Ontanon
95d60cc7ea in tvbparse:
- tvbparse_some now handles 0 items.
  - added accessors for a tt's offset and remaining length.

in packet-xml:
  - min_len=0 for tvbparse_chars() is soon going to mean zero instead of 1 change the 0s to 1s.
  - attribute names can have ':' even if it's namespaces isn't managed yet.
  - split the xml grammar in more elements so It can be actually read by a human being.


svn path=/trunk/; revision=16031
2005-09-27 22:57:07 +00:00
Luis Ontanon
ec0f669770 A "working" example of TPG...
svn path=/trunk/; revision=16030
2005-09-27 22:06:36 +00:00
Luis Ontanon
1407da9827 http_dissector_add doesn't belong here!
svn path=/trunk/; revision=16029
2005-09-27 21:56:14 +00:00
Luis Ontanon
230c36d360 now it starts to work...
svn path=/trunk/; revision=16028
2005-09-27 21:54:45 +00:00
Ulf Lamping
347398ee6f code cleanup: use the prefix packet_list_ for every function mentioned in packet_list.h
svn path=/trunk/; revision=16027
2005-09-27 21:51:08 +00:00
Jörg Mayer
74ca6adb4a Op Code 3 (Advertisement) dissection
svn path=/trunk/; revision=16026
2005-09-27 21:50:50 +00:00
Ulf Lamping
b9256380e7 mention "http://wiki.ethereal.com/CaptureSetup" in the error dialog, when the capture interface couldn't be opened
svn path=/trunk/; revision=16025
2005-09-27 21:48:17 +00:00
Ulf Lamping
cd64e4627b minor bugfix: call cf_callback_invoke() from cf_close() even if the file is already closed. Otherwise the GUI will remain in the wrong state if a capture couldn't be started (e.g. wrong interface).
svn path=/trunk/; revision=16024
2005-09-27 21:46:39 +00:00
Ulf Lamping
041a0ef304 add a new subsection "Code Requirements" and mention fuzz testing there
svn path=/trunk/; revision=16023
2005-09-27 21:44:46 +00:00
Anders Broman
b78ff2d761 Add a miniscule ericsson radius dictionary.
svn path=/trunk/; revision=16022
2005-09-27 21:04:59 +00:00
Luis Ontanon
72cbc6410b TPG TVB Parser Generator
Given a bnf-like grammar generate a set of helpers for a dissector

It's not working yet, however I need this checkin as a cheeckpoint

(I'll write the doc when it starts to be ready)


svn path=/trunk/; revision=16021
2005-09-27 20:48:48 +00:00
Tomas Kukosa
9a66525b71 new option whether tunnelled H.245 and tunnelled protocol are displayed inside H.225 tree or outside
svn path=/trunk/; revision=16020
2005-09-27 10:05:42 +00:00
Ronnie Sahlberg
70f17cd417 remove all strcpy from fcels
ito make it easier to read use doublespace to separate the items on the expansion line instead of ',' since so many of the strings contain spaces.

cleanup fc slightly and remove a redundant parameter


svn path=/trunk/; revision=16019
2005-09-27 08:03:13 +00:00
Tomas Kukosa
04fc893ad7 bug in dissect_per_object_identifier_str() fixed, wrong pointer was passed to oid_to_str()
svn path=/trunk/; revision=16018
2005-09-27 07:14:07 +00:00
Tomas Kukosa
0539569e1b get rid of warnings about qualifier discarding
svn path=/trunk/; revision=16017
2005-09-27 06:09:14 +00:00
Anders Broman
0f2584c4d2 - Make the reassemble TCP preference default TRUE.
- in dissect_tpkt_encap() only check the desegment flag passed in the function.


svn path=/trunk/; revision=16016
2005-09-27 05:39:58 +00:00
Guy Harris
13c7fec8f5 Give more details about too-short AVPs, give up immediately for AVPs
shorter than 2 bytes, and make the item for an AVP with a length < 2 a
generated item.

Put the top-level item for an AVP into the tree the same way regardless
of whether it's Vendor-Specific or not, and skip past the type and
length right after that, before we check for Vendor-Specific.  (This
means we no longer treat "vendor ID = 0" as an indication that this
isn't Vendor-Specific - nothing prevents a packet from getting onto the
wire with a vendor ID of 0; this fixes bug 485.)

Don't require a Vendor-Specific AVP to be at least 6 bytes long; it
might not be particularly useful to have one that has a vendor ID and
nothing else, but we might as well dissect the vendor ID portion.

Do some other cleanups.

svn path=/trunk/; revision=16015
2005-09-27 00:03:45 +00:00
Olivier Biot
122105370d Part 2 of the fix: also add the correct offset for non-WSP address records.
svn path=/trunk/; revision=16014
2005-09-26 20:49:33 +00:00
Guy Harris
92cc6da06c Make "REPORT_DISSECTOR_BUG()" (and the macros that use it) call
"abort()" if the ETHEREAL_ABORT_ON_DISSECTOR_BUG environment variable is
set; this is for debugging purposes, to make it easier to get a stack
trace of the offending call.

svn path=/trunk/; revision=16013
2005-09-26 20:34:13 +00:00
Olivier Biot
875fb98655 Fix WSP redirect and SIR address parsing:
- The incorrect number of octets were highlighted (bearer type and port number
   were disregarded).

 - In SIR version 1 content, correct the parsing (full WSP address length was
   not added to the offset for parsing the non-WSP contact points).

svn path=/trunk/; revision=16012
2005-09-26 20:00:37 +00:00
Ulf Lamping
d415c719ae fix #322, 2nd try: don't pass NULL to gtk_tree_iter_free(), this seems to cause an assert on some GTK versions
svn path=/trunk/; revision=16011
2005-09-26 19:24:06 +00:00
Anders Broman
510476e2ea Remove dependencies on asn1.c, stil endes to be included to define subid_t.
svn path=/trunk/; revision=16010
2005-09-26 18:18:06 +00:00
Ronnie Sahlberg
94df2dc3f4 remove all strcpy() from packet-fc.c
rewrite the functions to do proto_item_append_text() instead of building a string and then printing it.

The new function is functionally equivalent to the previous function except it does not print the values of the multi-bit fields to the expansion
(the expansion line is already a km wide as it is)



there are now only 202 strcpy() left in epan/dissectors  down from 300+ instances some weeks ago.



svn path=/trunk/; revision=16009
2005-09-26 10:11:38 +00:00
Guy Harris
a997ee591b Add a new "ipxnet" type for the RADIUS dictionary, for IPX network
numbers.  (Currently, we don't have any dictionary entries with that
type, although we have an attribute with special code to handle it that
uses that type.)

Specially handle Framed-IP-Address, Login-IP-Host, and
Framed-IPX-Network, so that the special values are displayed specially.

Clean up indentation.

Don't specify a number base for IPv4 or IPv6 addresses; the number base
is ignored.

svn path=/trunk/; revision=16008
2005-09-26 08:48:19 +00:00
Guy Harris
2b67057527 Use VENDOR_THE3GPP, rather than a hardcoded 10415, for the vendor ID for
the 3GPP.

svn path=/trunk/; revision=16007
2005-09-26 08:44:31 +00:00
Ulf Lamping
d3d18948b5 compiler warning removed
svn path=/trunk/; revision=16006
2005-09-26 07:08:42 +00:00
Anders Broman
25fe588f9f From Martin Mathieson:
stun -  add support for 3 extra Message Attributes as described in draft-ietf-behave-rfc3489bis-00

ymsg 
 - avoid looking beyond the tvb while looking for content item delimiters (causing most frames to be shown as malformed packet)
- makes content items (and their keys and values) filterable  (includes fix to bug 415)


svn path=/trunk/; revision=16005
2005-09-26 05:43:25 +00:00
Ulf Lamping
fa1647d9a6 fix #322: packet detail window -> Protocol Preferences: tree not expanded
also removed global notebook value

svn path=/trunk/; revision=16004
2005-09-25 22:46:49 +00:00
Gerald Combs
5135bf2ad5 Don't write before the beginning of a buffer. Add an item to the
release notes.

svn path=/trunk/; revision=16003
2005-09-25 22:19:57 +00:00
Guy Harris
0e17a773b9 A loop processing all the bytes in a tvbuff from a given offset to the
end of the data in the tvbuff should stop when the offset is >= the
total amount of data in the tvbuff, not when it's > the total amount in
the tvbuff following the starting offset.

In "unpack_digits()", return a null string, not a null pointer, if
there's nothing left in the tvbuff starting at the starting offset, so
that the caller doesn't have to check for a null pointer, and return an
ep_alloc()ed buffer, so the caller doesn't have to worry about freeing
the result.

If we see a filler digit, don't advance the offset in the string buffer;
we want to put the terminating '\0' right after the character we just
put into the string.

Fuzzed against some GSM captures.

svn path=/trunk/; revision=16002
2005-09-25 09:32:01 +00:00
Guy Harris
2d14a6f4ae Show unsigned quantities as such.
svn path=/trunk/; revision=16001
2005-09-25 09:07:41 +00:00
Guy Harris
d77101151a If "dissect_dcerpc_cn()" throws an exception when called by
"dissect_dcerpc_cn_bs_body()", it's because it recognized the packet as
a DCE RPC packet, but it ran out of data dissecting it as such;
increment the count of DCE RPC PDUs, so "dissect_dcerpc_cn_bs_body()"
returns TRUE, and its caller doesn't think nothing was dissected.

Fuzzed with some DCE RPC captures.

svn path=/trunk/; revision=16000
2005-09-25 09:06:48 +00:00
Luis Ontanon
35cfa4c11c test the avp_vsa_len not the avp_lenght!
svn path=/trunk/; revision=15999
2005-09-25 02:50:03 +00:00
Luis Ontanon
32c673552c Don't ASSERT if a VSA is too short, add an item reporting the error and leave.
svn path=/trunk/; revision=15998
2005-09-25 02:48:53 +00:00
Luis Ontanon
b88ef47be0 rating was defined twice
svn path=/trunk/; revision=15997
2005-09-25 02:44:37 +00:00
Ronnie Sahlberg
d160beec37 remove some redundant code that would always evaluate to true anyway.
svn path=/trunk/; revision=15996
2005-09-25 01:44:23 +00:00
Ronnie Sahlberg
b56bc5db31 prettify the previous patch
remove the remaining strcpy() from this dissector and make it decode the bitmap PROPERLY.


svn path=/trunk/; revision=15995
2005-09-24 23:25:38 +00:00
Ronnie Sahlberg
d2ac9b9b97 refactor the "dissector" for task management flags to dissect the bits properly
and get rid of the silly  strcpy() stuff.


there is a HUGE number of these kinds of very ugly bitmap dissection in all the fibre channel related dissectors and all need to be converted to proer dissection.



svn path=/trunk/; revision=15994
2005-09-24 22:43:15 +00:00
Ronnie Sahlberg
89a7e3e76c remove an array from the stack, remove some strcpy() and strcat() calls
svn path=/trunk/; revision=15993
2005-09-24 21:22:24 +00:00
Ronnie Sahlberg
44699e4082 get rid of one array from the stack and convert all strcpy() to pointers to literal strings.
svn path=/trunk/; revision=15992
2005-09-24 21:14:47 +00:00
Guy Harris
5e6d63a804 Squelch some compiler warnings.
svn path=/trunk/; revision=15991
2005-09-24 19:09:40 +00:00
Luis Ontanon
3cf75fd6bb get rid of most dtd leaks.
There's just one left I'm aware of (the doctype name).


svn path=/trunk/; revision=15990
2005-09-24 19:03:35 +00:00
Luis Ontanon
0f2e45a47a delete the xml plugin
svn path=/trunk/; revision=15989
2005-09-24 16:37:48 +00:00
Jörg Mayer
86e8646afd That code was never even compiled for testing
svn path=/trunk/; revision=15988
2005-09-24 15:52:42 +00:00
Jörg Mayer
32eccf1162 Shoichi Sakane:
Hi, I fixed some bugs to decoding IKEv2 payloads.  the following things
have been checked at the IPsec bake off in Toronto this week.

        - fixed decoding IP address in TS payload
        - fixed decoding IPv6 address in ID payload
        - fixed decoding IKEv2 Delete payload
        - SPI printing


svn path=/trunk/; revision=15987
2005-09-24 15:42:37 +00:00
Luis Ontanon
993e209b7f - There can be '/' in attribute names as well
- 140Kb of leaks less.


svn path=/trunk/; revision=15986
2005-09-24 15:07:38 +00:00
Ronnie Sahlberg
07f98b8fb7 From MartinM
IRC update and fix for bug 218


svn path=/trunk/; revision=15985
2005-09-23 21:33:02 +00:00
Jörg Mayer
d902c856e3 Add MANIFEST
svn path=/trunk/; revision=15984
2005-09-23 21:27:03 +00:00
Ronnie Sahlberg
f5c51aa470 From Kaul
One of the "unknown" fields are actually a digest.


svn path=/trunk/; revision=15983
2005-09-23 21:26:09 +00:00
Ronnie Sahlberg
44fb2d3d56 Dont decrement the length by 2 if it is already less than two
since then the length will wrap and become +4G or so.

This fixes bug 479


svn path=/trunk/; revision=15982
2005-09-23 20:51:09 +00:00