Commit Graph

38723 Commits

Author SHA1 Message Date
Chris Maynard 40252924b4 Fix some duplicate display filter names.
svn path=/trunk/; revision=40612
2012-01-20 19:40:13 +00:00
Chris Maynard fe7c04abf1 Fix some duplicate display filter names.
svn path=/trunk/; revision=40611
2012-01-20 19:18:41 +00:00
Chris Maynard 07ef77a875 Fix Coverity CID 1366: MISSING BREAK
svn path=/trunk/; revision=40610
2012-01-20 18:53:06 +00:00
Chris Maynard b6a18e9b28 Fix Coverity CID 1369: UNUSED_VALUE by deleting duplicate and unecessary line of code.
svn path=/trunk/; revision=40609
2012-01-20 18:41:10 +00:00
Chris Maynard 0733183dc2 Fix Coverity CID 1370: UNREACHABLE by deleting erroneous break;
svn path=/trunk/; revision=40608
2012-01-20 18:35:56 +00:00
Gerald Combs 463b3178e8 Add more configuration information to config.pri which lets us remove
more hard-coded definitions from QtShark.pro. Quote an error message to
fix a Qt Creator complaint.

Add ui\qt\config.pri to the top-level "all" nmake target.

Update README.qt.

svn path=/trunk/; revision=40607
2012-01-20 18:30:44 +00:00
Jörg Mayer dbf1be8944 As reported by hyphenated on #wireshark:
don't increase offset by 4 after two add_item(...,2 ,...) commands.
Increase by 2 after each add_item instead.

svn path=/trunk/; revision=40606
2012-01-20 16:12:24 +00:00
Jörg Mayer 5357769aca Manually revert the changes to CMakeLists.txt from commit 40602 - they should not be necessary/are wrong
svn path=/trunk/; revision=40605
2012-01-20 11:02:15 +00:00
Jaap Keuter 72ebaa39e3 From Pascal Quantin:
Some test equipments can send weird Protocol Configuration Options IE in the
Attach Accept message with an empty protocol identifier content. Wireshark 
will trigger an assert when dissecting those messages because it does not 
check the tvb length before calling the sub dissector.
With checking the protocol identifier length before calling the sub dissector,
the PCO is decoded correctly.

svn path=/trunk/; revision=40604
2012-01-20 07:49:12 +00:00
Bill Meier 1311f29800 Fix Fix "bt-dht [..] NOT registered properly" as reported in Bug #6571.
"bt-dht [...] should also be common dissectors while not only heuristic
ones. So we can use them with 'Decode As...' command."

Essentially:
 -Register dissector handle so the dissector can be accessed via "decode-as".

From me:
   1. Given that the current heuristic is much too weak and
      causes 'false positives':
        Add a preference to allow enabling/disabling of heuristic dissection.

      The default is 'disabled' since the current heuristic is quite weak.
      (For example: The heuristic incorrectly dissects about 40
       files in menagerie/public as being the BT-DHT protocol).
      Note: only heuristic dissection is disabled; 'decode-as' remains
            enabled.

Also:

1. Fix some bugs wherein bytes in the hex pane were not highlighted
   when a field was selected in the details pane.
2. Do some minor re-formatting of the source code.


svn path=/trunk/; revision=40603
2012-01-20 03:24:05 +00:00
Jeff Morriss 0a6eca4097 Bug 6448 says the embedded Python stuff does not really work.
And if I run Valgrind with Python enabled, I get pages of errors related to it.

So: disable Python by default.

svn path=/trunk/; revision=40602
2012-01-20 03:20:35 +00:00
Bill Meier b83e1b218f Add 'heur_dissector_set_enabled()' to allow a dissector to enable/disable heuristic dissection;
Rename some vars;
Do some minor re-indentation and whitespace changes.

svn path=/trunk/; revision=40601
2012-01-20 02:43:37 +00:00
Gerald Combs 0829150550 Try copying our plugins to an accessible directory. This assumes you've set
WIRESHARK_RUN_FROM_BUILD_DIRECTORY in your run environment.

On Windows, generate a QMake include file (config.pri) from config.nmake.

svn path=/trunk/; revision=40600
2012-01-20 01:10:40 +00:00
Gerald Combs 41c54f9e5d Remove or mark unused variables.
svn path=/trunk/; revision=40599
2012-01-20 00:01:53 +00:00
Jörg Mayer e1708e9edd Slightly more details on building the qt version on Linux.
svn path=/trunk/; revision=40598
2012-01-19 23:58:25 +00:00
Balint Reczey a84ed29e2b Update abi-compliance-checker options to be compatible with 1.96.1
svn path=/trunk/; revision=40597
2012-01-19 22:55:52 +00:00
Balint Reczey 42e55d4533 Update generated headers changed by last commit
svn path=/trunk/; revision=40596
2012-01-19 22:55:46 +00:00
Balint Reczey 26503be7dc fix compile errors found by dumpabi target
svn path=/trunk/; revision=40595
2012-01-19 22:55:37 +00:00
Jörg Mayer 7b97eb7de2 gtk moved to ui/ missed this file on checkin
svn path=/trunk/; revision=40594
2012-01-19 22:32:22 +00:00
Jörg Mayer 64ddaef37b Fix:
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-rohc.c: In function ‘dissect_rohc_ir_rtp_profile_dynamic’:
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-rohc.c:775:21: error: variable ‘cc’ set but not used [-Werror=unused-but-set-variable]
cc1: all warnings being treated as errors



svn path=/trunk/; revision=40593
2012-01-19 22:18:06 +00:00
Chris Maynard 436b44b99e Fix some duplicate display filter names.
svn path=/trunk/; revision=40592
2012-01-19 21:57:24 +00:00
Chris Maynard dea0a5d277 Fix some duplicate display filter names.
svn path=/trunk/; revision=40591
2012-01-19 21:01:52 +00:00
Chris Maynard cb8805e543 Fix some duplicate display filter names.
svn path=/trunk/; revision=40590
2012-01-19 20:19:28 +00:00
Anders Broman 61b3c117a1 Update comments and dissection of comptessed lists
svn path=/trunk/; revision=40589
2012-01-19 19:43:02 +00:00
Chris Maynard 8fdfa92ecb Update a couple of asn1-generated dissectors.
svn path=/trunk/; revision=40588
2012-01-19 19:33:21 +00:00
Chris Maynard efbb310223 Fix a duplicate display filter name.
svn path=/trunk/; revision=40587
2012-01-19 19:25:33 +00:00
Chris Maynard c2208aa172 Fix some duplicate display filter names.
svn path=/trunk/; revision=40586
2012-01-19 19:15:13 +00:00
Bill Meier 8e4aab0ed8 Localize a global variable; Do minor reformatting.
svn path=/trunk/; revision=40585
2012-01-19 17:42:28 +00:00
Bill Meier cffa41f052 Update list of deprecated GLib fcns;
Add comment about Wireshark build defines G_DISABLE_DEPRECATED.

svn path=/trunk/; revision=40584
2012-01-19 14:22:46 +00:00
Michael Tüxen cb470474ab Add icons for pipe interfaces. This allows for easier
testing the upcoming patch, which improves the
infrastructure to handle interfaces for capturing.
Obtained from Irene Ruengeler.

svn path=/trunk/; revision=40583
2012-01-19 13:02:32 +00:00
Martin Mathieson 96d0f00b52 Comment out hf and ett - there is no need to register them while they
are empty.

svn path=/trunk/; revision=40582
2012-01-19 03:46:02 +00:00
Martin Mathieson 6e43645bb7 Add casts and don't initialise empty hf array.
svn path=/trunk/; revision=40581
2012-01-19 03:27:41 +00:00
Martin Mathieson 1b33c5f3f5 Add a dissector "mac-lte-framed" that uses the same framing format as
the existing "mac-lte" UDP heuristic dissector. It is hoped that it will be
possible to register a DLT for use with this format.

svn path=/trunk/; revision=40580
2012-01-19 02:58:53 +00:00
Guy Harris 3dbb23f826 Get rid of no-longer-applicable comments.
svn path=/trunk/; revision=40579
2012-01-18 23:41:07 +00:00
Guy Harris 9f7e8bdb0d Get rid of some redeclarations, include "ui/recent_utils.h" to get those
declarations.

svn path=/trunk/; revision=40578
2012-01-18 23:40:04 +00:00
Guy Harris 78fb9ffd6c Another fix for the move of recent.h.
svn path=/trunk/; revision=40577
2012-01-18 23:37:50 +00:00
Guy Harris 9ca4193385 Line up #define values.
svn path=/trunk/; revision=40576
2012-01-18 22:05:47 +00:00
Guy Harris e13c87acc4 Tabs are not *ipso facto* 4 spaces.
svn path=/trunk/; revision=40575
2012-01-18 22:05:01 +00:00
Alexis La Goutte 5b2eb869c9 Following the move of recent.*
Fix : No rule to make target « ../gtk/recent.c », needed for « recent.c ». Stop.

Not need to copy recent.c in qt working directory and use the common recent.c file.

svn path=/trunk/; revision=40574
2012-01-18 22:00:18 +00:00
Alexis La Goutte aa5439a783 From Yaniv Kaul via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6743
[PATCH] Enhance the Spice dissector to deal with mini headers

Spice recently gained the ability to use smaller packet headers.
This patch adds support to it, along with small other fixes/enhancements - none of which really interesting.

From me :
Fix a Clang Warning :
packet-spice.c:1303:5: warning: Value stored to 'offset' is never read

svn path=/trunk/; revision=40573
2012-01-18 21:44:21 +00:00
Bill Meier 0908f1c81c Fix a typo; Remove a dup.
svn path=/trunk/; revision=40572
2012-01-18 21:37:55 +00:00
Alexis La Goutte cb6644ea4b From Tom Brezinski via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6746
Adding support for Network Instruments 802.11 wireless captures

Attaching very simple change to allow reading of Network Instruments Observer 802.11 wireless capture files.

svn path=/trunk/; revision=40571
2012-01-18 21:23:30 +00:00
Chris Maynard 86cbd0b559 #include <epan/crypt/crypt-*.h> => #include <epan/crypt/*.h>
svn path=/trunk/; revision=40570
2012-01-18 21:20:50 +00:00
Bill Meier 5940047af0 Update:
- Mark GDK functions which aren't used as 'E'
 - Add GTK functions deprecated after GTK 2.20
 - Add some comments about use of GTK_DISABLE_DEPRECATED
 - reformat
   ...

svn path=/trunk/; revision=40569
2012-01-18 21:08:18 +00:00
Chris Maynard e799efeed9 Fix some duplicate display filter names.
svn path=/trunk/; revision=40568
2012-01-18 21:07:53 +00:00
Guy Harris fe2d4368d9 New include file needs to be included.
svn path=/trunk/; revision=40567
2012-01-18 20:55:55 +00:00
Guy Harris 9465e9f0fa Another change for the recent changes (in both senses of "recent
changes" :-)).

svn path=/trunk/; revision=40566
2012-01-18 20:38:51 +00:00
Guy Harris 5263048b9b Reflect the move of recent.c from ui/gtk to the top-level directory.
svn path=/trunk/; revision=40565
2012-01-18 20:23:30 +00:00
Guy Harris 7f38dd5903 Another fix for the move of recent.h to the ui directory.
svn path=/trunk/; revision=40564
2012-01-18 20:11:06 +00:00
Guy Harris ee0089dfe7 Reflect the changes to make the recent-file code GUI-independent.
svn path=/trunk/; revision=40563
2012-01-18 19:59:13 +00:00