osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity
83,653 Commits 23 Branches 0 Tags 1.3 GiB
Commit Graph

83653 Commits

Author SHA1 Message Date
João Valverde b5d74c69a7 dfilter: Fix error message with non printable ASCII 
Before:
    Filter: http.user_agent == açaí
    dftest: "�" was unexpected in this context.

After:
    Filter: http.user_agent == açaí
    dftest: Non-printable ASCII characters may only appear inside double-quotes.

Related with #17770.
 2022-02-19 17:49:29 +00:00
Roman Volkov 30b9474aaa mpeg descriptor: fix Content Identifier Descriptor (0x76) 
There is a wrong tag (0x77 instead of 0x76) in a description
comment in packet-mpeg-descriptor.c.
 2022-02-19 16:40:19 +00:00
Roman Volkov 6bbddaa9c8 mpeg descriptor: add PDC Descriptor (0x69) 2022-02-19 15:20:48 +02:00
Uli Heilmeier 0824558af1 QT Proto Tree: Fix link to wiki for protocol ref 
The wiki pages for protocols are currently reachable via
https://gitlab.com/wireshark/wireshark/-/wikis/<proto_abbrev>

Fixes #17944
 2022-02-19 11:59:56 +00:00
Chuck Craft 0396c65d60 Qt: "Decode As..." tooltips misassigned 2022-02-19 11:48:21 +00:00
diego dupin 62bf6422b1 MySQL / MariaDB length encoded integer correction 2022-02-19 11:47:42 +00:00
John Thacker f7d8dd4938 DVB-S2-BB: Fix detection of adaptation field type 
Fix the check of which adaptation field type is found before a
Base Band Frame. Related to #17950.
 2022-02-18 23:00:29 -05:00
Gerald Combs fbf403de00 epan: Always set our proto_item_fill_label label. 
Make sure label_str is valid, and print a warning if it's NULL. Try to
fix

```
/builds/wireshark/wireshark/epan/dissectors/packet-diameter.c: 1174 in integer32_avp()
1168     	gint length = tvb_reported_length(tvb);
1169     	if (length == 4) {
1170     		if (c->tree) {
1171     			pi= proto_tree_add_item(c->tree, a->hf_value, tvb, 0, length, ENC_BIG_ENDIAN);
1172     			label = (char *)wmem_alloc(wmem_packet_scope(), ITEM_LABEL_LENGTH+1);
1173     			proto_item_fill_label(PITEM_FINFO(pi), label);
>>>     CID 1499506:  Memory - illegal accesses  (STRING_NULL)
>>>     Passing unterminated string "label" to "strstr", which expects a null-terminated string.
1174     			label = strstr(label,": ")+2;
1175     		}
1176     	}
1177     	else {
1178     		pi = proto_tree_add_bytes_format(c->tree, hf_diameter_avp_data_wrong_length,
1179     						 tvb, 0, length, NULL,

```
 2022-02-18 17:26:40 +00:00
John Thacker 4c90ca7ad2 file: Eliminate pointer subtraction 
Change some comparisons around so that comparisons are done without
subtraction, which should fix the 32 bit Windows build.
 2022-02-18 06:47:35 -05:00
Uli Heilmeier b3f8c10542 PFCP: Fix offset for hf_pfcp_flow_desc 
Fixes: #17951
 2022-02-18 08:43:19 +00:00
Martin Mathieson c9f8a427d7 RLC-NR: some trivial edits. 2022-02-18 00:26:40 +00:00
João Valverde 8608a432ee Epan: Add some missing reserved keywords 2022-02-17 20:50:30 +00:00
Alexis La Goutte 3a620f6f87 ieee802211: Add Model and Serial Fortinet Specific Vendor 2022-02-17 14:56:52 +00:00
John Thacker 9308f760a6 file: Optimize Find Packet 
Split the match functions in twain, one for case-sensitive and
one for case-insensitive, so we can use memchr to search for the
first byte in the case-sensitive version and ws_mempbrk for the
case-insensitive version. They are highly optimized on most systems
and considerably faster on large files.

Also fix a few issues regarding wide strings, such as false positives
and the length to highlight when matching. Fix #12908
 2022-02-17 12:06:57 +00:00
Martin Mathieson 4633621c3e Some spelling fixes 2022-02-17 10:28:45 +00:00
Anders Broman 58adcf1e7d RTPproxy: Handle preference range change. 2022-02-17 10:16:08 +01:00
Anders Broman 9ef6eaa539 RTPProxy: Make it possible to configure a range of UDP/TCP ports. 2022-02-16 14:59:41 +01:00
Uli Heilmeier 03afef0a56 TLS: Ignore GREASE values for JA3 
According to https://engineering.salesforce.com/tls-fingerprinting-with-ja3-and-ja3s-247362855967
JA3 ignores GREASE values completely.

Fixes #17942
 2022-02-16 11:27:50 +00:00
Trond Norbye 8cb519153c Couchbase: Print VBucket as vb:<num> 
This is the same format as Couchbase use in the log files.
 2022-02-15 17:17:34 +01:00
Trond Norbye bc168ca376 Couchbase: Add ifconfig command 
And move some commands so they all appear in in numerical order
to make it easier to see if we're missing commands
 2022-02-15 17:17:28 +01:00
Trond Norbye 1a83f3c43a Couchbase: Add missing status codes 
Update the list of status codes with the new status codes
in Couchbase
 2022-02-15 17:16:17 +01:00
João Valverde 8efad466c4 Tools: Fix fix-encoding-args.pl ASCII string validation 
Do not require a useless ENC_NA parameter for string encodings.
FT_STRING and FT_STRINGZ types don't have any ndianness.

Follow-up to 6ec429622c.
 2022-02-15 11:38:16 +00:00
João Valverde 8198dd51cd pre-commit: Add an exception to duplicate filter name check 2022-02-15 11:38:16 +00:00
Gerald Combs 8b526c61cb Tools: Improve update-tools-help's version handling. 2022-02-14 23:13:36 +00:00
Jim Young 371f98aec4 make-manuf.py: Remove HTML double quote entities 2022-02-14 23:12:56 +00:00
Chuck Craft f07ff72f90 WSDG/WSUG: add missing asciidoc admonition icons 
Closes #17474
 2022-02-14 18:24:17 +00:00
Jim Young 59b5c83e4c Qt: Refactor to avoid deprecation warning on Windows 2022-02-14 09:24:02 +00:00
Gerald Combs 79da670bd1 Packaging+GitLab CI: Move debian to the packaging directory. 
We keep our various packaging assets in the "packaging" directory. Move
the Debian assets there. dpkg-buildpackage doesn't seem appear to have a
"debian directory path" option, but symlinking worked in my test
container.
 2022-02-13 13:21:58 -08:00
Gerald Combs 4e3b2ec007 [Automatic update for 2022-02-13] 
Update manuf, services enterprise numbers, translations, and other items.
 2022-02-13 16:39:57 +00:00
Roman Volkov 7d171d3782 mpeg descriptor: add Short Smoothing Buffer Descriptor (0x61) 2022-02-13 11:01:08 +00:00
Alexis La Goutte 1212ec9d56 msrcp: Fix warnings about -Wmissing-prototypes 2022-02-13 10:47:45 +00:00
Alexis La Goutte 26d48b9464 ppp: Fix Dead Store found by Clang Analyzer 
packet-ppp.c:4901:13: warning: Value stored to 'offset' is never read [deadcode.DeadStores]
 2022-02-13 10:34:30 +00:00
Alexis La Goutte c115a2ae60 signal-pdu: fix DeadStore found by Clang Analyzer 
packet-signal-pdu.c:2265:17: warning: Value stored to 'ti' is never read [deadcode.DeadStores]
packet-signal-pdu.c:2268:17: warning: Value stored to 'ti' is never read [deadcode.DeadStores]
packet-signal-pdu.c:2271:17: warning: Value stored to 'ti' is never read [deadcode.DeadStores]
 2022-02-13 10:34:30 +00:00
Alexis La Goutte 3dee67b2a2 msrcp: Fix DeadStore found by Clang Analyzer 
packet-msrcp.c:135:17: warning: Value stored to 'msrcp_trans' is never read [deadcode.DeadStores]
 2022-02-13 10:34:30 +00:00
Alexis La Goutte a1be626264 text2pcap: Fix DeadStore found by Clang Analyzer 
text2pcap.c:476:13: warning: Value stored to 'pcap_link_type' is never read [deadcode.DeadStores]
 2022-02-13 10:34:30 +00:00
Alexis La Goutte 6d063e0190 EAP: fix Argument with 'nonnull' attribute passed null 2022-02-13 10:34:30 +00:00
Alexis La Goutte 38d5d79d74 bt-dht: Fix Argument with 'nonnull' attribute passed null 2022-02-13 10:34:29 +00:00
Alexis La Goutte 123a5f4e13 libpcap(wiretap): Fix unreachable-code 
libpcap.c:1007:19: warning: code will never be executed [-Wunreachable-code]
 2022-02-13 10:23:43 +00:00
Alexis La Goutte 0f86319543 follow_stream_dialog(qt): Fix Wunreachable-code 
follow_stream_dialog.cpp:591:29: warning: code will never be executed [-Wunreachable-code]
 2022-02-13 10:23:42 +00:00
Alexis La Goutte 13c42f5f83 help_url(ui) Fix Wunreachable-code 
help_url.c:308:15: warning: code will never be executed [-Wunreachable-code]
 2022-02-13 10:23:42 +00:00
Alexis La Goutte f5eceb4ad0 blf: fix Wunreachable-code 
blf.c:764:47: warning: code will never be executed [-Wunreachable-code]
 2022-02-13 10:23:42 +00:00
Roman Volkov d73752d228 mpeg descriptor: add XAIT Content Location Descriptor (0x7D) 2022-02-13 10:05:38 +00:00
Roman Volkov c73101601e mpeg descriptor: add Time Shifted Event Descriptor (0x4F) 2022-02-12 18:39:21 +00:00
Roman Volkov 2406588c64 mpeg descriptor: add Service Identifier Descriptor (0x71) 2022-02-12 12:33:06 +02:00
Dirk Ziegelmeier dc5cb69409 Profinet plugin: Decode more r/w indexes 2022-02-11 20:16:07 +00:00
Dirk Ziegelmeier a17037de4b Profinet plugin: Update several enums 
According to PN AL Protocol, Oct 2020
Indices, user structure identifier, channel error type, ext channel error types
 2022-02-11 20:16:07 +00:00
Roland Knall 699c3c051a Qt: Fix ASAN heap-use-after-free 2022-02-11 18:51:54 +00:00
John Thacker 52955b9c43 Qt: highlight when search result is in the current packet. 
Calling setCurrentIndex with QItemSelectionModel::ClearAndSelect clears
the currentIndex, but not the selection, so it doesn't trigger
selectionChanged. However, highlighting depends on the selectionChanged
signal, not currentChanged(), and it's not emitted if we're still on the
same packet/row as the current selection (which can occur if searching
for something that occurs in exactly one packet in a capture.)

Since packet_list_select_row_from_data() cares about where the data
is within the packet, it needs to clear the selection.  Fix #8269
 2022-02-11 18:21:35 +00:00
John Thacker 0011bb6a4c Qt: Allow omitting secondary data sources when printing 
Add a checkbox to the packet format group box to allow the
hexdump to only have the main frame instead of secondary data
sources as well, so that Print and Export Packet Dissections can
be used for input to text2pcap.
 2022-02-10 23:28:53 -05:00
David Perry fc3f061829 Differentiate `-c` from `-a packets:` 2022-02-11 01:54:53 +00:00