Commit Graph

51415 Commits

Author SHA1 Message Date
Guy Harris 9374ede4ff Don't cast away constness.
svn path=/trunk/; revision=54818
2014-01-15 08:38:14 +00:00
Guy Harris 2f0ddb96d0 Fun and games with const.
svn path=/trunk/; revision=54817
2014-01-15 08:36:09 +00:00
Guy Harris 9228c72ef0 Explain casting away const.
svn path=/trunk/; revision=54816
2014-01-15 08:35:55 +00:00
Anders Broman 1f8d2e25d2 Update to version V12.3.0 (2013-12).
svn path=/trunk/; revision=54815
2014-01-15 07:13:23 +00:00
Guy Harris d15a6d0add Don't cast away constness.
svn path=/trunk/; revision=54814
2014-01-15 03:37:06 +00:00
Guy Harris ada9dafdf0 Don't cast away constness.
svn path=/trunk/; revision=54813
2014-01-15 03:35:44 +00:00
Evan Huus dae86605b6 Reject pcap files that claim on-the-wire packet sizes > 64MB. This fixes many
heuristic cases broken in r49999 when we permitted packets > 64KB, since that
relaxed so severely the definition of a valid packet header.

64MB is an arbitrary and perhaps suboptimal number, but it seems to do the right
thing in all the examples I have handy.

Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9634

svn path=/trunk/; revision=54812
2014-01-15 02:09:11 +00:00
Guy Harris 61867d0b2f Eliminate fvalue_set() in favor of routines that take arguments
appropriate for particular FT_ types.  This lets us do some more type
checking and lets us use const pointers when appropriate.

Constify a bunch of stuff, and don't cast away constness.

svn path=/trunk/; revision=54811
2014-01-15 01:05:03 +00:00
Gerald Combs 04b18f44c1 Make it more clear that we're faking a git description for now.
svn path=/trunk/; revision=54810
2014-01-15 00:52:27 +00:00
Gerald Combs d7e93e99c7 Copy over recent changes from trunk-1.8 along with some local
modifications.

  ------------------------------------------------------------------------
  r54807 | gerald | 2014-01-14 16:35:34 -0800 (Tue, 14 Jan 2014) | 2 lines

  Start using the output of 'git describe'.
  ------------------------------------------------------------------------
  r54805 | gerald | 2014-01-14 15:38:16 -0800 (Tue, 14 Jan 2014) | 2 lines

  Start adding support for plain git.
  ------------------------------------------------------------------------

svn path=/trunk/; revision=54809
2014-01-15 00:51:38 +00:00
Alexis La Goutte 62aef67720 Fix typo (Direcly => Directly)
svn path=/trunk/; revision=54804
2014-01-14 20:48:30 +00:00
Alexis La Goutte 4ed44704d2 Add filetap/abi* to .gitignore
svn path=/trunk/; revision=54803
2014-01-14 20:37:23 +00:00
Guy Harris 32da185ed5 Don't cast away constness.
svn path=/trunk/; revision=54802
2014-01-14 18:42:54 +00:00
Guy Harris a48d06df11 We have to cast away constness here, because C doesn't have
parameterized types.

svn path=/trunk/; revision=54801
2014-01-14 18:42:16 +00:00
Guy Harris f862fc40ba Don't cast away constness.
svn path=/trunk/; revision=54800
2014-01-14 18:35:36 +00:00
Guy Harris d99e0b13d4 Regenerate ANSI TCAP dissector from the changes in r54499.
svn path=/trunk/; revision=54799
2014-01-14 18:34:01 +00:00
Guy Harris afc159eaf3 Don't cast away constness.
svn path=/trunk/; revision=54798
2014-01-14 18:19:31 +00:00
Guy Harris 11220f625c Don't cast away constness.
svn path=/trunk/; revision=54797
2014-01-14 18:16:12 +00:00
Guy Harris 834c79a07e Don't cast away constness.
svn path=/trunk/; revision=54796
2014-01-14 18:12:14 +00:00
Guy Harris 570a36436c Consistently use "guint8" for "8-bit byte".
Constify.

For routines that manipulate sequences of 8-bit bytes, have them take
guint8 pointers rather than void pointers.

Don't cast away constness.

svn path=/trunk/; revision=54795
2014-01-14 18:03:54 +00:00
Guy Harris 7a559d2876 Don't cast away constness.
svn path=/trunk/; revision=54794
2014-01-14 17:49:50 +00:00
Guy Harris 13176da15b Don't cast away constness.
svn path=/trunk/; revision=54793
2014-01-14 17:47:31 +00:00
Guy Harris 0a99ee25d5 Don't make claims of constness that can't be guaranteed in terms the C
compiler can verify.

svn path=/trunk/; revision=54792
2014-01-14 17:45:03 +00:00
Alexis La Goutte 85ab202c08 Fix -Wsometimes-uninitialized found by Clang
packet-pdcp-lte.c:1397:9: error: variable 'decrypted_data' is used uninitialized whenever 'if' condition is false
packet-pdcp-lte.c:1469:50: note: uninitialized use occurs here
    decrypted_tvb = tvb_new_child_real_data(tvb, decrypted_data, payload_length, payload_length);
packet-pdcp-lte.c:1353:27: note: initialize the variable 'decrypted_data' to silence this warning

packet-pdcp-lte.c:1397:9: error: variable 'payload_length' is used uninitialized whenever 'if' condition is false
packet-pdcp-lte.c:1469:66: note: uninitialized use occurs here
    decrypted_tvb = tvb_new_child_real_data(tvb, decrypted_data, payload_length, payload_length);
packet-pdcp-lte.c:1354:24: note: initialize the variable 'payload_length' to silence this warning

svn path=/trunk/; revision=54791
2014-01-14 17:44:21 +00:00
Alexis La Goutte 6b6d709afc Fix unused const variable found by Clang 3.4
svn path=/trunk/; revision=54790
2014-01-14 17:44:07 +00:00
Pascal Quantin a48b6f4aac Upgrade LTE RRC dissector to v11.6.0
svn path=/trunk/; revision=54789
2014-01-14 16:51:10 +00:00
Pascal Quantin 330654baf8 SNOW3G is not available on default Wireshark
svn path=/trunk/; revision=54788
2014-01-14 16:48:43 +00:00
Pascal Quantin eabf15f80a Fix dissection of 3GPP2 SMS encoded in UCS2
svn path=/trunk/; revision=54787
2014-01-14 16:23:38 +00:00
Martin Mathieson 293f8ca247 Make sure we allocate bytes for snow3g at least rounded up to next 4 byte boundary
svn path=/trunk/; revision=54786
2014-01-14 16:22:44 +00:00
Martin Mathieson b948c75dfe Update a comment
svn path=/trunk/; revision=54785
2014-01-14 15:11:35 +00:00
Martin Mathieson 58e8800136 Add snow3g integrity (not quite working for me), but rework how integrity and ciphering functions and conditional compilation is done
svn path=/trunk/; revision=54784
2014-01-14 15:07:20 +00:00
Pascal Quantin b0d4e7a34b UCS2 encoded SMS is directly read from data -> remove PROTO_ITEM_SET_GENERATED()
svn path=/trunk/; revision=54783
2014-01-14 14:01:03 +00:00
Martin Mathieson b01a99c385 Provide hook for calling EEA1 implementation (Snow3G). Implementation not supplied due to licensing conditions. TODO: EIA1.
svn path=/trunk/; revision=54782
2014-01-14 11:09:47 +00:00
Guy Harris e2b668efe7 Whoever in GLibland was responsible for defining the signature of
g_snprintf() owes the world a huge apology.  They *could* have just used
size_t, or they *could* at least have, if they insisted on having GLib
types to mirror regular types, made gsize an alias for size_t and,
whatever they did with gsize, they *could* have used it as the argument
for the size of the buffer for g_snprintf(), but no, they had to use
gulong.

svn path=/trunk/; revision=54781
2014-01-14 10:50:26 +00:00
Guy Harris ecdc864656 Don't cast away constness.
svn path=/trunk/; revision=54780
2014-01-14 08:32:50 +00:00
Guy Harris e1b57afbc9 Don't cast away constness.
svn path=/trunk/; revision=54779
2014-01-14 08:30:45 +00:00
Guy Harris 9232db14c7 But *do* cast const void * to the appropriate type.
svn path=/trunk/; revision=54778
2014-01-14 08:30:24 +00:00
Guy Harris 1ec9417a43 Don't cast away constness.
svn path=/trunk/; revision=54777
2014-01-14 08:26:24 +00:00
Guy Harris 6aa49e37e0 Don't assign away constness.
svn path=/trunk/; revision=54776
2014-01-14 08:22:38 +00:00
Guy Harris bd165ab19a Don't cast away constness.
svn path=/trunk/; revision=54775
2014-01-14 08:14:28 +00:00
Guy Harris 4a82c3b60b Don't cast away constness.
svn path=/trunk/; revision=54774
2014-01-14 08:12:45 +00:00
Guy Harris dc71034565 Don't cast away constness.
svn path=/trunk/; revision=54773
2014-01-14 08:09:33 +00:00
Guy Harris 382e2c895c gsize, not gusize. Whatever.
svn path=/trunk/; revision=54772
2014-01-14 07:59:58 +00:00
Guy Harris 8b2aced72c Glib, gotta love it. No, gusize isn't the same as size_t, it's long,
which is Too Damn Short on Windows.  (Microsoft, gotta love 'em.  I
guess even more Windows programmers than UN*X programmers thought long
was 32 bits, now and forever, world without end, amen.)

svn path=/trunk/; revision=54771
2014-01-14 07:58:18 +00:00
Guy Harris aaeb6a467b Don't cast away constness.
svn path=/trunk/; revision=54770
2014-01-14 07:56:43 +00:00
Guy Harris dd152d81af Don't cast away constness.
svn path=/trunk/; revision=54769
2014-01-14 05:49:04 +00:00
Guy Harris 4a7636a6f8 Don't cast away constness.
svn path=/trunk/; revision=54768
2014-01-14 05:47:50 +00:00
Guy Harris c6c1887a0b Have ip6_to_str() and tvb_ip6_to_str() return const pointers, as the
ip_to_str equivalents do.

Don't cast away constness, and don't make it necessary to do so.

svn path=/trunk/; revision=54767
2014-01-14 05:39:57 +00:00
Guy Harris e1f6ad8387 Don't cast away constness.
svn path=/trunk/; revision=54766
2014-01-14 05:29:02 +00:00
Guy Harris 0f40fd837c Don't cast away constness.
svn path=/trunk/; revision=54765
2014-01-14 05:25:51 +00:00