osmith/wireshark
1
0
Fork 0
forked from osmocom/wireshark
Code Pull requests Releases Wiki Activity
51467 commits 23 branches 0 tags 1.3 GiB
Commit graph

19526 commits

Author SHA1 Message Date
Bill Meier
0bc06ee3ab - Remove unneeded #includes; 
- "Once-only" test not needed in proto_reg_handoff..();
- Set COL_PROTOCOL, clear COL_INFO at the begining of the dissector
   before fetching data from the tvb;
- Use tvb_reported_length;
- Use col_set_str/col_append_str where appropriate;
- Zigbee --> lwm;
- Fix typo;
- Reformat some whitespace for consistency.

ToDo:
- Review use of col_...() and expert...() under 'if (tree)';
- Review use of col_clear(..., COL_INFO) after text already added to COL_INFO;
- Review certain tvb fetches to ensure  no fetches using a negative offset;

svn path=/trunk/; revision=54871
 2014-01-21 02:32:48 +00:00
Bill Meier
c540e33c49 Add properties .... 
svn path=/trunk/; revision=54869
 2014-01-21 01:24:13 +00:00
Martin Kaiser
6517e3ba4b don't use tvb_get_string(..., len) to get exactly len raw bytes 
from a tvbuff

svn path=/trunk/; revision=54867
 2014-01-20 23:30:01 +00:00
Martin Kaiser
ae82a1cafe make MMI strings filterable 
svn path=/trunk/; revision=54866
 2014-01-20 22:06:19 +00:00
Guy Harris
1d27123ab1 Longs are not guaranteed to be 64-bit. Use G_GINT64_MODIFIER to format 
64-bit quantities.

svn path=/trunk/; revision=54863
 2014-01-20 21:37:32 +00:00
Anders Broman
3a96d94c50 From Michal Labedzki: 
Bluetooth/Ubertooth: Improvements: Support for new btsnoop format, almost finished btle and minor fixes.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9606

svn path=/trunk/; revision=54862
 2014-01-20 20:36:42 +00:00
Anders Broman
5fc0904093 packet-bootp.c: In function 'dissect_vendor_generic_suboption': 
packet-bootp.c:3293: warning: unused parameter 'pinfo'
packet-bootp.c:3293: warning: unused parameter 'v_ti'
packet-bootp.c:3294: warning: unused parameter 'optend'

svn path=/trunk/; revision=54861
 2014-01-20 20:30:41 +00:00
Anders Broman
f0fb43a621 From alexeyv: 
Add decryption for resumed TLS sessions with a session ticket.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5963

svn path=/trunk/; revision=54860
 2014-01-20 20:26:04 +00:00
Anders Broman
6402d8590e Add generic dissection of unknown vendor sub options. 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9594

svn path=/trunk/; revision=54859
 2014-01-20 20:03:49 +00:00
Evan Huus
77e4a2f09c Fix 32/64 casting and add a note where the loss of precision might actually be a 
problem for 32-bit platforms.

svn path=/trunk/; revision=54858
 2014-01-20 19:32:43 +00:00
Evan Huus
f5931c7559 From Pavel Moravec via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9612 
AMQP 1.0 Dissector

svn path=/trunk/; revision=54857
 2014-01-20 19:13:42 +00:00
Alexis La Goutte
d2410336b8 From Lubos via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9638 
New Dissector For Lightweight Mesh protocol

A dissector for ATMEL Lightweight Mesh protocol (lwm).
The protocol is carried on the top of 802.15.4 frame.

From me:
* Add Modelines info
* Fix indent (use 4 spaces)
* Remove trailing whitespace

svn path=/trunk/; revision=54856
 2014-01-20 18:35:45 +00:00
Anders Broman
95ed1b4977 As spotted by Joerg; make a HFILL_INIT(hf) macro and use it to init the private part of the hf structure. 
svn path=/trunk/; revision=54843
 2014-01-19 09:40:04 +00:00
Pascal Quantin
6429497015 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9649 : 
SMPP: source_telematics_id value length is 1 byte

svn path=/trunk/; revision=54837
 2014-01-17 22:18:50 +00:00
Pascal Quantin
f63d80c2e4 From Fabio Tarabelloni via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9650 : 
ZigBee ZCL Appliance Identification: fix endianness of Company ID, Brand ID and Product Type ID

svn path=/trunk/; revision=54836
 2014-01-17 21:52:55 +00:00
Anders Broman
493ba3e367 Try to fix warning: initializer element is not computable at load time. 
svn path=/trunk/; revision=54832
 2014-01-17 18:58:50 +00:00
Anders Broman
a49fee443b Fix a bug intrduced in http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=54820 
svn path=/trunk/; revision=54831
 2014-01-17 18:55:49 +00:00
Martin Mathieson
62249477b6 Remove #include and make the situation with snow3g clearer in a comment. May need further removal, depending upon concensus on wireshark-dev 
svn path=/trunk/; revision=54827
 2014-01-16 12:02:30 +00:00
Evan Huus
60045cae1c Implement basic support for SPXII decoding (at least we get the payload offsets 
right now).

Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9552

svn path=/trunk/; revision=54823
 2014-01-15 23:56:41 +00:00
Evan Huus
1c6679c5ec Dissect SPXII flag bits. 
First part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9552

svn path=/trunk/; revision=54822
 2014-01-15 23:09:36 +00:00
Evan Huus
622d9cb953 Add modelines and fix one indentation issue. 
svn path=/trunk/; revision=54821
 2014-01-15 23:00:07 +00:00
Anders Broman
efbecb3e9a Fix a couple of 
warning: initializer element is not computable at load time

svn path=/trunk/; revision=54820
 2014-01-15 19:29:03 +00:00
Anders Broman
1f8d2e25d2 Update to version V12.3.0 (2013-12). 
svn path=/trunk/; revision=54815
 2014-01-15 07:13:23 +00:00
Guy Harris
d15a6d0add Don't cast away constness. 
svn path=/trunk/; revision=54814
 2014-01-15 03:37:06 +00:00
Guy Harris
f862fc40ba Don't cast away constness. 
svn path=/trunk/; revision=54800
 2014-01-14 18:35:36 +00:00
Guy Harris
d99e0b13d4 Regenerate ANSI TCAP dissector from the changes in r54499. 
svn path=/trunk/; revision=54799
 2014-01-14 18:34:01 +00:00
Guy Harris
570a36436c Consistently use "guint8" for "8-bit byte". 
Constify.

For routines that manipulate sequences of 8-bit bytes, have them take
guint8 pointers rather than void pointers.

Don't cast away constness.

svn path=/trunk/; revision=54795
 2014-01-14 18:03:54 +00:00
Guy Harris
7a559d2876 Don't cast away constness. 
svn path=/trunk/; revision=54794
 2014-01-14 17:49:50 +00:00
Guy Harris
13176da15b Don't cast away constness. 
svn path=/trunk/; revision=54793
 2014-01-14 17:47:31 +00:00
Guy Harris
0a99ee25d5 Don't make claims of constness that can't be guaranteed in terms the C 
compiler can verify.

svn path=/trunk/; revision=54792
 2014-01-14 17:45:03 +00:00
Alexis La Goutte
85ab202c08 Fix -Wsometimes-uninitialized found by Clang 
packet-pdcp-lte.c:1397:9: error: variable 'decrypted_data' is used uninitialized whenever 'if' condition is false
packet-pdcp-lte.c:1469:50: note: uninitialized use occurs here
    decrypted_tvb = tvb_new_child_real_data(tvb, decrypted_data, payload_length, payload_length);
packet-pdcp-lte.c:1353:27: note: initialize the variable 'decrypted_data' to silence this warning

packet-pdcp-lte.c:1397:9: error: variable 'payload_length' is used uninitialized whenever 'if' condition is false
packet-pdcp-lte.c:1469:66: note: uninitialized use occurs here
    decrypted_tvb = tvb_new_child_real_data(tvb, decrypted_data, payload_length, payload_length);
packet-pdcp-lte.c:1354:24: note: initialize the variable 'payload_length' to silence this warning

svn path=/trunk/; revision=54791
 2014-01-14 17:44:21 +00:00
Alexis La Goutte
6b6d709afc Fix unused const variable found by Clang 3.4 
svn path=/trunk/; revision=54790
 2014-01-14 17:44:07 +00:00
Pascal Quantin
a48b6f4aac Upgrade LTE RRC dissector to v11.6.0 
svn path=/trunk/; revision=54789
 2014-01-14 16:51:10 +00:00
Pascal Quantin
330654baf8 SNOW3G is not available on default Wireshark 
svn path=/trunk/; revision=54788
 2014-01-14 16:48:43 +00:00
Pascal Quantin
eabf15f80a Fix dissection of 3GPP2 SMS encoded in UCS2 
svn path=/trunk/; revision=54787
 2014-01-14 16:23:38 +00:00
Martin Mathieson
293f8ca247 Make sure we allocate bytes for snow3g at least rounded up to next 4 byte boundary 
svn path=/trunk/; revision=54786
 2014-01-14 16:22:44 +00:00
Martin Mathieson
b948c75dfe Update a comment 
svn path=/trunk/; revision=54785
 2014-01-14 15:11:35 +00:00
Martin Mathieson
58e8800136 Add snow3g integrity (not quite working for me), but rework how integrity and ciphering functions and conditional compilation is done 
svn path=/trunk/; revision=54784
 2014-01-14 15:07:20 +00:00
Pascal Quantin
b0d4e7a34b UCS2 encoded SMS is directly read from data -> remove PROTO_ITEM_SET_GENERATED() 
svn path=/trunk/; revision=54783
 2014-01-14 14:01:03 +00:00
Martin Mathieson
b01a99c385 Provide hook for calling EEA1 implementation (Snow3G). Implementation not supplied due to licensing conditions. TODO: EIA1. 
svn path=/trunk/; revision=54782
 2014-01-14 11:09:47 +00:00
Guy Harris
e2b668efe7 Whoever in GLibland was responsible for defining the signature of 
g_snprintf() owes the world a huge apology.  They *could* have just used
size_t, or they *could* at least have, if they insisted on having GLib
types to mirror regular types, made gsize an alias for size_t and,
whatever they did with gsize, they *could* have used it as the argument
for the size of the buffer for g_snprintf(), but no, they had to use
gulong.

svn path=/trunk/; revision=54781
 2014-01-14 10:50:26 +00:00
Guy Harris
ecdc864656 Don't cast away constness. 
svn path=/trunk/; revision=54780
 2014-01-14 08:32:50 +00:00
Guy Harris
e1b57afbc9 Don't cast away constness. 
svn path=/trunk/; revision=54779
 2014-01-14 08:30:45 +00:00
Guy Harris
9232db14c7 But *do* cast const void * to the appropriate type. 
svn path=/trunk/; revision=54778
 2014-01-14 08:30:24 +00:00
Guy Harris
1ec9417a43 Don't cast away constness. 
svn path=/trunk/; revision=54777
 2014-01-14 08:26:24 +00:00
Guy Harris
6aa49e37e0 Don't assign away constness. 
svn path=/trunk/; revision=54776
 2014-01-14 08:22:38 +00:00
Guy Harris
bd165ab19a Don't cast away constness. 
svn path=/trunk/; revision=54775
 2014-01-14 08:14:28 +00:00
Guy Harris
4a82c3b60b Don't cast away constness. 
svn path=/trunk/; revision=54774
 2014-01-14 08:12:45 +00:00
Guy Harris
dc71034565 Don't cast away constness. 
svn path=/trunk/; revision=54773
 2014-01-14 08:09:33 +00:00
Guy Harris
382e2c895c gsize, not gusize. Whatever. 
svn path=/trunk/; revision=54772
 2014-01-14 07:59:58 +00:00