Cast away some implicit 64-bit-to-32-bit conversion errors due to use of
sizeof.
Cast away some implicit 64-bit-to-32-bit conversion errors due to use of
strtol() and strtoul().
Change some data types to avoid those implicit conversion warnings.
When assigning a constant to a float, make sure the constant isn't a
double, by appending "f" to the constant.
Constify a bunch of variables, parameters, and return values to
eliminate warnings due to strings being given const qualifiers. Cast
away those warnings in some cases where an API we don't control forces
us to do so.
Enable a bunch of additional warnings by default. Note why at least
some of the other warnings aren't enabled.
randpkt.c and text2pcap.c are used to build programs, so they don't need
to be in EXTRA_DIST.
If the user specifies --enable-warnings-as-errors, add -Werror *even if
the user specified --enable-extra-gcc-flags; assume they know what
they're doing and are willing to have the compile fail due to the extra
GCC warnings being treated as errors.
svn path=/trunk/; revision=46748
Improvements to BitTorrent DHT dissector
Fixed filtering on protocol "bt-dht".
Improved heuristics. Can probably be enabled by default now (but I'll let someone else make that decision).
Unexpected IP address (first packet in capture file) and binary "tokens" (packet 17) were incorrectly printed as UTF-8 strings.
Moved duplicate code into bencoded_string_length().
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8044
svn path=/trunk/; revision=46396
are like the non-TVB versions except that they take a TVB and an offset
instead of (frequently) a pointer into the TVB.
Calling tvb_get_ptr() before modifying the rest of the fields should help fix
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7960 (though I can't
reproduce that problem).
Replace a bunch of calls like:
SET_ADDRESS(..., AT_XXX, length, tvb_get_ptr(tvb, offset, length));
with:
TVB_SET_ADDRESS(..., AT_XXX, tvb, offset, length);
svn path=/trunk/; revision=46324
Also (for a few files):
- create/use some extended value strings;
- remove unneeded #include files;
- remove unneeded variable initialization;
- re-order fcns slightly so prefs_reg_handoff...() at end, etc
svn path=/trunk/; revision=44438
"bt-dht [...] should also be common dissectors while not only heuristic
ones. So we can use them with 'Decode As...' command."
Essentially:
-Register dissector handle so the dissector can be accessed via "decode-as".
From me:
1. Given that the current heuristic is much too weak and
causes 'false positives':
Add a preference to allow enabling/disabling of heuristic dissection.
The default is 'disabled' since the current heuristic is quite weak.
(For example: The heuristic incorrectly dissects about 40
files in menagerie/public as being the BT-DHT protocol).
Note: only heuristic dissection is disabled; 'decode-as' remains
enabled.
Also:
1. Fix some bugs wherein bytes in the hex pane were not highlighted
when a field was selected in the details pane.
2. Do some minor re-formatting of the source code.
svn path=/trunk/; revision=40603
BitTorrent DHT dissector for wireshark
From me :
* Fix encoding attribut for proto_tree_add_item (with fix-encodings-args script)
svn path=/trunk/; revision=39653
Guy Harris