The problem was that configure_event() is called each time the window size
changes, and each time the pixmap buffer is recreated and a new signal added
to the save button.
svn path=/trunk/; revision=24145
in the packet details view is selected. I suppose unselecting the field is
more correct. The previous behaviour lead to some strange errors:
Select a packet and an entry in the packet details. Add a new column
and change a protocol preference. Observe the selected package is
unselected and packet 1 is selected, which I think is wrong.
Do the same as above with one of the following exceptions:
- without selecting an entry in the packet details.
- without adding a new column.
- without changing a protocol preference.
Observe the selected package is still selected, which is correct.
The correct behaviour here happens because of the cf_goto_frame call in
redraw_hex_dump_all, which causes the field to be unselected before
packet_list_set_sel_browse is called, and then the cf_unselect_package
is never called.
Maybe someone with a deeper knowledge should have a look at this...
svn path=/trunk/; revision=24135
This patch provides a new RTP Player preferences dialog. It allows one to
select the maximum number of visable channels in the RTP Player window. The
default is four (4) channels which is the maximum number of usable channels
that the RTP Player can display and still have access to the bottom row buttons
on a 1024*768 resolution display. Specifying a value less than 1 or greater than
10 will be result in the RTP Player displaying the default 4 channels.
svn path=/trunk/; revision=24112
- Give initial focus to the profiles list
- Enter in the profiles list selects the profile
- Give focus to the profile name when creating a new profile
svn path=/trunk/; revision=24091
configure and use more than one set of preferences and configuration files.
This can be found in the "Configuration Profiles..." menu item from the Edit
menu, or by pressing Shift-Ctrl-A. It's also possible to start wireshark
and tshark with a named profile by using the "-C ProfileName" option.
A new status pane in the main window will show the current profile.
The configuration files currently stored in the Profiles are:
- Preferences
- Capture Filters
- Display Filters
- Coloring Rules
- Disabled Protocols
- User Accessible Tables
The recent data are by design not added to the profile.
Planned future enhancements:
- make a more convenient function to switch between profiles
- add a "clone profile" button to copy an existing profile
- make the profiles list active and accept return as OK
- save users "Decode as" in the profile
- make new, clone and deletion of profiles more secure
- make some of the recent values available in the profile
This patch also fixes:
- setting default status pane sizes
- a bug setting status pane for packets when not having main lower pane.
svn path=/trunk/; revision=24089
two different variables for types voip_rtp_stream_info_t (strinfo) and
voip_calls_info_t (callsinfo) instead of using strinfo for both.
svn path=/trunk/; revision=24038
"View/Reset Coloring 1-10" and adds sensitivity to it so that
it will be greyed out when none of the temporary color filters
are used.
(as per discussion on wireshark-dev some time ago)
svn path=/trunk/; revision=23879
Register new tap listener (new filter) when going from advanced y axis.
Add parantheses to the filters to ensure they are correct when concatenated.
svn path=/trunk/; revision=23844
Change SVN #23487 patch to not use signal_connect each time the
the function of the save button is changed since that
results in multiple callbacks attached to the save button.
Intead: associate data with the save button which species its
current function.
(It sure would be nice if the original problem causing the
blank spot on the toolbar could be resolved; the work-around
is starting to get messy).
svn path=/trunk/; revision=23821
correctly reflect the auto scroll state. Re-enable the ability to use
the auto scroll toolbar button and menu item during a live capture.
svn path=/trunk/; revision=23777
- retrieving the list of remote PCAP interfaces
- password authentication support
- UDP data fransfer
- packet sampling (available in WinPcap 4.x)
etc.
fix problem if non-default rpcap port is used
svn path=/trunk/; revision=23750
either because of a bad URL string or a failure to allocate memory, and
that we can't easily determine which of those happened.
svn path=/trunk/; revision=23740
With default window size the limit for this wrap is ~27 seconds when having
0-50 seconds on the y axis, and decreases greatly on higher window size.
svn path=/trunk/; revision=23708
file-name to the window title and not change the rest of the name.
(the graph window is both used from "Flow Graph" and from "VoIP calls")
svn path=/trunk/; revision=23695
- Don't hide columns in the GUI
- Show Packets count first
- Always show values in Packets count
- Don't show Avg. packet size if 1 packet
- Don't show time between packets if 1 packet
svn path=/trunk/; revision=23684
(it makes easier change from GList to GTree as we have many modules now and GList implementation is slow for searching)
svn path=/trunk/; revision=23669
- Added traffic statistics for marked packages.
- Do not show Displayed column unless using it.
- Removed Marked packets line, as this info is in the marked packets column.
Will add documentation changes if keeping this feature.
svn path=/trunk/; revision=23633
est. Use g_ascii_strcasecmp() and g_ascii_strncasecmp(), and supply our
own versions if they're missing from GLib (as is the case with GLib
1.x).
In the code to build the list of named fields for Diameter, don't use
g_strdown(); do our own g_ascii_-style upper-case to lower-case mapping
in the hash function and use g_ascii_strcasecmp() in the compare
function.
We do this because there is no guarantee that toupper(), tolower(), and
functions that use them will, for example, map between "I" and "i" in
all locales; in Turkish locales, for example, there are, in both
upper case and lower case, versions of "i" with and without a dot, and
the upper-case version of "i" is "I"-with-a-dot and the lower-case
version of "I" is "i"-without-a-dot. This causes strings that should
match not to match.
This finishes fixing bug 2010 - an earlier checkin prevented the crash
(as there are other ways to produce the same crash, e.g. a bogus
dictionary.xml file), but didn't fix the case-insensitive string matching.
svn path=/trunk/; revision=23623
implicitly by calling "color_filters_init()". This should probably
fix the crashes experienced when pressing ctrl-space a couple of times
svn path=/trunk/; revision=23583
quit. Temporary coloring filters can be set by:
- pressing <ctrl>-<digit> will create a conversation coloring filter based on the
addresses of the currently selected packet (order TCP/UDP/IP/Ethernet)
This can also be achieved from the "View|Colorize Conversation" menu.
- Rightclicking on a packet in the packet-list will give the option to
"Colorize Conversation" just as "Conversation Filter" does.
- Rightclicking on an item in the packet-detail-list will give the option to
"Colorize with filter" which works similar to "Apply as filter"
Temporary filters can be cleared from the same menus or by pressing <ctrl>-<space>.
This patch also adds an item to the above mentioned menu's to add a permanent color filter
in the same way.
The colors for the temporary coloring rules are now hardcoded as I do not know
how to change the color of menu-items and therefore I chose to use icons to
show the actual color of each of the ten temporary coloring rules. Is it at all
possible to have different menu items in different colors?
One other way of solving this is to recreate the icons on the fly after changing
the colors. I will have a look into that once it is clear whether I can use
different colors within the menu structure.
svn path=/trunk/; revision=23560
to the conversation lists. Move the "copy" button down to the button bar
in order to free up some real estate. Add an nstime_cmp() function. Clean
up code in a few places.
svn path=/trunk/; revision=23516
save as button would disappear (leaving a blank spot on the toolbar) after
starting & stopping a capture session more than once.
This fix gets rid of the second save_as_button when using GTK 2.4+ in favor
of converting the stock id / tooltip text of the save_button to that of
the save as button when necessary and reverting it back to just save when
necessary.
svn path=/trunk/; revision=23487
- Don't call tree_view_select on first button click event, it's already done by the tree widget.
- Factorize slow gtk_text_buffer_insert_with_tags_by_name() calls
svn path=/trunk/; revision=23477
the selection. There is a little difference between the behaviour
in GTK1 and GTK2 (As long as either one row or a block of rows with
the same status is selected, GTK1 and GTK2 behave the same way):
GTK1:
- if the last selected row is disabled, grey out the disable button
- if the last selected row is enabled, grey out the enable button
GTK2:
- grey out both buttons when no rule is selected
- grey out the enable button when *all* selected rules are enabled
- grey out the disable button when *all* selected rules are disabled
- leave both buttons active if there is a mix of disabled and enabled
rules
svn path=/trunk/; revision=23426
without having to delete them. The patch has been tested on
Fedora-7 with GTK+ 1.2.10 and GTK+ 2.10.11.
Since I don't know how to use "strikethrough" in clists in GTK1
there is a little difference in how the disabled coloring rules
are displayed. In GTK2 they are striked through and in GTK1
they are shown in lightgrey on a white background.
Any info on how to use strikthrough in clists within GTK1 is more
than welcome :-)
svn path=/trunk/; revision=23421
H.225
- change RysMessage_vals to h225_Rasmessage_vals
- use #.PDU directive for H323-UserInformation and RasMessage instead of implementing it by hands
- register RasMessage_PDU as "h225.ras" dissector for calling it from H.460
asn2wrs make PDUs exportable
svn path=/trunk/; revision=23226
- Draw an empty graph if no items in given tick interval.
- Initialize interval_delta so we don't get overlaping x-scale labels.
- Some whitespace cleanup.
svn path=/trunk/; revision=22992
button that goes from insensitive to sensitive, the button won't respond
to mouse clicks.
This caused the Coloring Rules dialog behavior reported in bug 699. Work
around it by not making the up/down buttons insensitive while we're moving
a rule.
Fixup whitespace.
svn path=/trunk/; revision=22946
I fixed a bug in packet_unistim.c which was causing a 'malformed packet' to
appear when an open stream command is read with no endpoint ip (as is sometimes
done) I added a simple msg_len check to avoid this.
I also added UFTP to the unistim dissector and adjusted the unistim call-detection
in voip-info.c to start on an open stream as well as keypresses..
svn path=/trunk/; revision=22929
packets in the Packet Details View.
This "appendix" bytes are not copied with the Copy functions or in the
Export Selected Packet Bytes.
svn path=/trunk/; revision=22887
fetch the major OS version. If we're running Windows >= 6 (Vista)
_and_ npf.sys isn't running, warn the user in Wireshark and TShark.
Add a recent prefs item to disable the warning in Wireshark.
svn path=/trunk/; revision=22877
which resulted in a GtkCritcal msg and in disabling the "(Fore|Back)ground Color"
button when esc used to close the widget.
svn path=/trunk/; revision=22840
RTP analysis' jitter values are thrown off by RTP events
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1076
a) Ephemeral string (packet duration) was inserted into long-term hash of
dynamic payloads
b) There was no clock_rate mapping for MIME type "telephone-event".
svn path=/trunk/; revision=22780
configure is run with "--without-plugins"
cc1: warnings being treated as errors
about_dlg.c: In function ‘about_wireshark_cb’:
about_dlg.c:426: warning: unused variable ‘plugins_page’
make[2]: *** [about_dlg.o] Error 1
editcap.c: In function ‘main’:
editcap.c:663: error: ‘check_ts’ undeclared (first use in this function)
editcap.c:663: error: (Each undeclared identifier is reported only once
editcap.c:663: error: for each function it appears in.)
make[2]: *** [editcap.o] Error 1
svn path=/trunk/; revision=22761
setuid instead of Wireshark. Remove the "DANGEROUS" notices, but leave it
disabled by default. Whine if the user runs Wireshark or TShark as root.
Add a preference to disable the whining. Add a "setuid-root" script that
can be used to switch dumpcap and TShark's setuid-ness on and off for
development and testing. Update the release notes and README.packaging.
svn path=/trunk/; revision=22733
some strange justifications when having high "tick values" in the graph.
Simplified this to fix a problem with scrolling to X Axis zero and a
problem with interval values printed in the wrong time position.
svn path=/trunk/; revision=22645
Print zero label string in the X Axis (not centered).
Always start the graph with the first interval, not at zero x value.
svn path=/trunk/; revision=22644
Try to call get_interface_descriptive_name() as little as possible (storing
the result in capture_opts) to avoid a performance hit during live capture
(especially if you have lots of interfaces) and to avoid leaking memory.
One issue with this is that capture_opts.c cannot (without adding significant
dependencies) set the iface_descr so readers of that field (only gtk/main.c
and tshark.c) use a macro to (set if not already set and) get the value of
that field.
svn path=/trunk/; revision=22587
different ways, add a set of common conversion routines. Add a
"Frequency/Channel" column and fill it in where we can. Fix RSSI column
printing in PPI.
Fix up whitespace along the way.
svn path=/trunk/; revision=22538
add the possibility, that a dissector writer can provide (usually non-trivial) display filters specific for the protocol in question (with an example in packet-dcerpc-pn-io.c), that will appear in the GUI
svn path=/trunk/; revision=22530
this in the GUI rather than calling pcap_stats() directly. This gets rid
of the last pcap_open_live() call in the GUI code. Update
README.packaging.
svn path=/trunk/; revision=22443
I did load an k12 file (.rf5), and want to save the selected frames in a new file.
I got the error "Wireshark can't save this capture in that format"
I think this is due to this correction: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=22214
I have got a patch to force the type of file to libpcap, only if no other format is available. It should solve both problems.
svn path=/trunk/; revision=22403
that "-D" and "-L" should produce machine-readable output. Use this to
move an indirect get_pcap_linktype() call from the GUI to dumpcap.
svn path=/trunk/; revision=22367
"Automatic scrolling in live capture" are both enabled, make the scroll
bar behavior more natural. If the packet list is scrolled to the
bottom, scroll automatically. If the user scrolls back, keep the packet
list scrolled at that point instead of jumping back to the end.
svn path=/trunk/; revision=22277
Wireshark doesn't support writing to. The default in the drop-down menu
was libpcap, but since gtk_option_menu_set_history() doesn't send the
activate signal we set up earlier, you would have to manually click on the
drop-down and reselect libpcap for it to work. Now it works as expected.
svn path=/trunk/; revision=22214
the "OK," "Apply," or "Cancel" buttons are pressed. Remove some duplicate
code. Add a comment about "Cancel" not working as expected.
svn path=/trunk/; revision=22211
This new code adds a save button to the Statistics IO Graphs window and
is also reusable by any other code that uses GDK Pixmaps to draw graphs.
The Gdk-pixbuf library included in GTK is used for this save function.
svn path=/trunk/; revision=22166
filter dialog's add expression dialog when going to it through file->open
or file->merge (because dialogs in between are set to modal).
svn path=/trunk/; revision=22115
Add a capture_interface_list(), which works similar to
get_interface_list() except that it forks dumpcap instead of calling
the pcap routines directly. Use it in the GUI.
Add a "-I" flag to dumpcap, which prints out verbose interface
information.
Tested under Windows and Linux.
svn path=/trunk/; revision=22071
These changes allow the packet list clist to be destroyed and recreated
with the new column titles/values/order that the user changed in the
preferences without restarting Wireshark.
svn path=/trunk/; revision=22038
find attached several trivial diffs for viewing RTP SSRC values in Hex
rather than Dec at various places in the UI.
Also includes change from BASE_DEC to BASE_HEX_DEC for corresponding RTP
and RTCP dissector header fields.
svn path=/trunk/; revision=22017
created it is closed.
The fix is to close the graph analysis window when the flow graph setup
window is closed since closing the flow graph window first destroys all
of the data structures.
svn path=/trunk/; revision=21994
routines and routines using those routines. GLib might use different
modifiers for 64-bit quantities than the platform's C library does.
svn path=/trunk/; revision=21990
In all the places where a cast to "long long" or "unsigned long long"
was done, use G_GINT64_MODIFIER and get rid of the cast, as
1) there's no guarantee that "%ll" works
and
2) there's no guarantee that "long long" works
(the latter definitely does *NOT* work with MSVC++; the former doesn't
work with regular printf in MSVC++, but it might work with the GLib
printf-based functions).
svn path=/trunk/; revision=21978
Fix compilation failures when building wireshark-0.99.6-SVN-21916 on an
x86_64-unknown-linux-gnu target with gcc version 4.1.2 20070403 (Red Hat
4.1.2-8).
The failures fall into two categories:
(1) Casts between pointers and 32-bit integers without an intermediary cast
via 'long' or 'unsigned long'. This results in a compiler warning complaining
about casts between a pointer and an integer of a different size.
(2) Passing values to "%lld" or similar printf-style format options that the
compiler thinks are a different size. Such values need to be cast to 'long
long' or 'unsigned long long'.
svn path=/trunk/; revision=21975
epan/filesystem.c
have get_plugin_dir() calling init_plugin_dir() if necessary
epan/epan.c and epan/report_err.c
move the report_failure family into the new report_err.c file, have epan_init() calling the initializer
epan/plugins.h and epan/proto.c
do not have init_plugins() calling the proto_reg functions instead do it in init_proto()
gtk/main.c and tshark.c
init_plugin_dir() has become suprefluous
capinfos.c and editcap.c
load the wiretap plugins
Makefiles
do what's needed to build withe the above changes.
svn path=/trunk/; revision=21935
- packet-user_encap.c: use the new UAT_PROTO_DEF
- gtk/uat_gui.c: change the order of "containment" of the widgets to have the clist fields sized to the scrolledwindow instead of the whole window
svn path=/trunk/; revision=21934
state to "no packets", "file open", or "live capture in progress".
Instead, to update the main window title when the user-specified prefix
for the title changes:
save the un-decorated title as a data value attached to the main
window in set_main_window_name();
have a new routine to update the title, which fetches the
un-decorated title, decorates it, and sets the title to the
decorated value.
This fixes bug 1608.
svn path=/trunk/; revision=21876
WIRESHARK_RUN_FROM_BUILD_DIRECTORY is set and, if so and we weren't run
with special privileges, set the running_in_build_directory_flag. Have
it do the same if it finds ".libs" in the pathname of the program and we
weren't run with special privileges, as that means it was probably run
from the libtool wrapper script and presumably thus isn't an installed
binary.
This means that get_credential_info() has to be called before
init_progfile_dir().
Clean up some indentation.
svn path=/trunk/; revision=21866
early on, and use the converted versions.
#if 0 out the error dialog for CANT_GET_AIRPCAP_INTERFACE_LIST, rather
than commenting it out - it's a bit easier to un-out the code, and you
don't have to worry about whether there's a comment in the stuff being
xxx-outed.
svn path=/trunk/; revision=21838
- Update the wireless/AirPcap GUI code to support 802.11n as well as
some related upcoming code changes.
- Remove airpcap.h from the repository, since it exists in the AirPcap
devpack (and will be superseded Real Soon Now).
- Show the individual channel flag bits in radiotap.
Fix the 802.11n MCS set display.
This is a partial checkin, so hopefully nothing is broken.
svn path=/trunk/; revision=21831
wrong timestamp. Place a cap on the amount of silence that we do
insert. This should fix bug 1580.
Update the release notes.
svn path=/trunk/; revision=21818
Jeff Morriss