Commit graph

9129 commits

Author SHA1 Message Date
Bill Meier
8d9c5d9b2b Cleanup related to prefs & proto_reg_handoff
svn path=/trunk/; revision=26124
2008-09-02 21:40:46 +00:00
Anders Broman
80b87dfaf3 Try to fix unused code warnings.
svn path=/trunk/; revision=26122
2008-09-02 19:42:30 +00:00
Bill Meier
40bd43db83 Minor cleanup (mostly related to proto_reg_handoff...)
svn path=/trunk/; revision=26121
2008-09-02 19:08:29 +00:00
Anders Broman
6c7b56081c Handle extension header.
svn path=/trunk/; revision=26119
2008-09-02 18:27:33 +00:00
Gerald Combs
b9fac8aa8a Fetch the key length using pntohs. Initialize and check its length.
svn path=/trunk/; revision=26115
2008-09-02 17:26:24 +00:00
Bill Meier
afd857957a Fix a few Emacs "file variables" to have "safe" values.
That is: indent-tabs-mode: tabs --> indent-tabs-mode: t
Also: fix a typo: set-tabs-mode --> indent-tabs-mode

svn path=/trunk/; revision=26113
2008-09-02 11:17:03 +00:00
Guy Harris
dd190f38e5 OK, let's see if the x509sat dissector is clean.
svn path=/trunk/; revision=26112
2008-09-02 06:44:41 +00:00
Anders Broman
8970b4524d Try to fix unused code warnings.
svn path=/trunk/; revision=26111
2008-09-02 06:04:25 +00:00
Anders Broman
9d0a401a12 Try to fix unused code warnings.
svn path=/trunk/; revision=26110
2008-09-02 05:43:28 +00:00
Anders Broman
a517a46fa7 Try to fix unused code warnings.
svn path=/trunk/; revision=26109
2008-09-01 21:10:28 +00:00
Anders Broman
1a109ff02c Update to use unchanged asn1 files and X.501:08/2005.
Hopefullly without breaking to many things.

svn path=/trunk/; revision=26108
2008-09-01 20:29:01 +00:00
Anders Broman
3d07d2bee8 Try to fix "defined but not used" warnings.
svn path=/trunk/; revision=26107
2008-08-31 21:37:16 +00:00
Anders Broman
c7b010d246 Remove test code for depreciated OID.
svn path=/trunk/; revision=26106
2008-08-31 21:11:32 +00:00
Anders Broman
47d612ccc9 Update to X.509:08/2005.
svn path=/trunk/; revision=26105
2008-08-31 21:00:06 +00:00
Anders Broman
48dbffeda4 OID 1.3.6.1.5.5.7.8.5 (id-on-xmppAddr) not recognized by BER dissector.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2835

svn path=/trunk/; revision=26104
2008-08-31 12:55:45 +00:00
Guy Harris
56ae1ea2f7 Give "initialized" the right data type.
svn path=/trunk/; revision=26101
2008-08-27 22:46:03 +00:00
Bill Meier
32dc6c98e4 If port pref changed, delete registration for previous port
svn path=/trunk/; revision=26099
2008-08-27 19:47:21 +00:00
Guy Harris
317201b985 Give macros and libraries names that imply that clean dissectors are the
normal case, and dissectors with warnings are the exception; the
ultimate goal is to have only clean dissectors.

Move a bunch of now-cleaned-up dissectors into the "clean" category.

Fix a comment.

svn path=/trunk/; revision=26096
2008-08-26 03:45:42 +00:00
Bill Meier
224b638586 #include <emem.h> not req'd
svn path=/trunk/; revision=26093
2008-08-26 02:38:57 +00:00
Guy Harris
f0acec0696 Fix some macro name errors.
svn path=/trunk/; revision=26092
2008-08-26 01:32:15 +00:00
Bill Meier
b52d95d591 #include <emem.h> not req'd
svn path=/trunk/; revision=26091
2008-08-26 01:28:50 +00:00
Guy Harris
d7a51fc7de Get rid of an unused variable in the P7 dissector.
Create a set of warning-clean ASN.1 dissectors and build them with
-Werror, to try to prevent errors creeping back in.  Put the P7
dissector there.

svn path=/trunk/; revision=26090
2008-08-26 01:04:39 +00:00
Bill Meier
77b81b391b #include <prefs.h> not req'd
svn path=/trunk/; revision=26089
2008-08-25 22:06:20 +00:00
Anders Broman
74efeaae80 Add Answer or Request to the Command name in the info column depending on
if the R bit is set or not.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2828

svn path=/trunk/; revision=26088
2008-08-25 21:15:55 +00:00
Bill Meier
aac2a36133 #include <prefs.h> not req'd; Fix indentation to be conistent
svn path=/trunk/; revision=26086
2008-08-25 20:41:05 +00:00
Anders Broman
798fe6acca From Andrei Slavoiu:
TS 29.060 v7.8.0 and later specify new flags in the Common Flags IE:
bit 5 - No QoS Negotiation
bit 6 - NRSN
bit 7 - Upgrade QoS Supported

The current Wireshark implementation has bits 5 and 6 reversed. Attached patch
fixes this issue.

svn path=/trunk/; revision=26084
2008-08-25 20:05:26 +00:00
Bill Meier
5f26848657 prefs_register_protocol not req'd since no prefs; simplify reg_handoff & do minor cleanup
svn path=/trunk/; revision=26081
2008-08-25 19:53:32 +00:00
Bill Meier
9c250392d8 prefs_register_protocol not req'd since no prefs; simplify reg_handoff & do minor cleanup
svn path=/trunk/; revision=26080
2008-08-25 19:25:40 +00:00
Bill Meier
c249da955c Remove unnecessary registration of a prefs callback
svn path=/trunk/; revision=26079
2008-08-25 18:42:30 +00:00
Bill Meier
acbbc43f2e Remove unnecessary registration of a prefs callback & do minor cleanup
svn path=/trunk/; revision=26078
2008-08-25 18:37:18 +00:00
Bill Meier
1b85a4b1e9 prefs.h not req'd; cleanup reg_handoff;
svn path=/trunk/; revision=26077
2008-08-25 17:36:24 +00:00
Bill Meier
129145495e remove unnecessary registration of a prefs callback; minor cleanup
svn path=/trunk/; revision=26076
2008-08-25 17:26:26 +00:00
Bill Meier
2ac68fb78a remove unnecessary prefs registration since no prefs; minor cleanup
svn path=/trunk/; revision=26075
2008-08-25 17:14:20 +00:00
Bill Meier
e6334320c5 Remove unnecessary prefs callback; simplify reg_handoff; minor cleanup
svn path=/trunk/; revision=26074
2008-08-25 16:59:38 +00:00
Bill Meier
be5a1aa111 Move a buffer from the stack & do some minor cleanup
svn path=/trunk/; revision=26073
2008-08-25 16:42:09 +00:00
Guy Harris
a1fb6f2e8c If HAVE_KERBEROS isn't defined, enc_authorization_data_etype isn't
defined; make it a local variable in that case.

svn path=/trunk/; revision=26072
2008-08-25 16:13:48 +00:00
Gerald Combs
ab689cc334 Add another buffer length check to group key decryption.
svn path=/trunk/; revision=26071
2008-08-25 15:26:15 +00:00
Gerald Combs
f31f3f6d14 Fix a couple of crashes in WPA group key decryption.
svn path=/trunk/; revision=26070
2008-08-25 15:22:48 +00:00
Ronnie Sahlberg
640e4d4025 implement pac info type #12 UPN_DNS_INFO
svn path=/trunk/; revision=26069
2008-08-25 03:46:51 +00:00
Ronnie Sahlberg
8d98fcd177 start adding support to decrypt and dissect the enc-authorization-data
of TGS_REQ


svn path=/trunk/; revision=26068
2008-08-25 02:55:04 +00:00
Ronnie Sahlberg
ed83f835e6 add a preference and code for tracking how many un-acked bytes are in
flight on a tcp connection.

this is quite useful toghether with io-grapgs to track how much of the 
tcp window that an application actually uses



svn path=/trunk/; revision=26067
2008-08-25 02:15:36 +00:00
Anders Broman
ae07b1708a From Stefan Monhof:
Fix a bug in the previous patch.

svn path=/trunk/; revision=26065
2008-08-24 19:25:33 +00:00
Anders Broman
2226bccd44 From Neil Piercy:
1 new split file (GMM & SM in one file) and diff patches for the others. The RR, RP and BSSMAP patches are really a tidy-up: now they are split it becomes clear what was redundant code.

svn path=/trunk/; revision=26064
2008-08-24 17:42:30 +00:00
Anders Broman
924894e617 From: Stefan Monhof:
changes:
- fixed: display of kademlia hash (bug #2348)
- added: information on the meaning of the values of kad version, parameter of
message types KADEMLIA_REQ and KADEMLIA2_REQ, metatag sourcetype and metatag
encryption
- added: peer id, target id, recipients id, file id, keyword hash as variants
of kademlia hash (searchable as string now)
- added: xor between target id and recipients id
- fixed: ip adresses in taglist now displayed in dotted-decimal (instead of
int)
- fixed: some values in taglist were displayed in octal, it's hex now
- fixed: message type KADEMLIA2_BOOTSTRAP_REQ was wrongly marked as malformed
- added: differences in dissecting peer list 1.0 and peer list 2.0
- fixed: dissection of KADEMLIA2_SEARCH_KEY_REQ and KADEMLIA2_SEARCH_RES
- added: source-publishing and keyword-publishing in KADEMLIA_PUBLISH_REQ
- fixed: decompressed data are not displayed in a subtree anymore

svn path=/trunk/; revision=26063
2008-08-24 15:15:36 +00:00
Guy Harris
6f9b405534 One set of tests for whether a packet looks like a STUN2 packet
suffices; have the heuristic dissector call the message dissector and
return FALSE if the message dissector returns 0 (meaning it's not a
STUN2 packet) and TRUE otherwise.

New-style dissectors don't return a Boolean, they return 0 if the packet
isn't a packet for that protocol and the number of bytes dissected
otherwise.  (Yes, that's a problem if the length of the tvbuff handed to
the dissector is 0; that's why new-style dissectors aren't yet the
default.)

svn path=/trunk/; revision=26060
2008-08-22 22:17:37 +00:00
Stig Bjørlykke
7cf79249e0 Only use one IP address for seq/ack analysis.
Use correct length for dest entry and ack info entry.
Print correct id list for acks.

svn path=/trunk/; revision=26059
2008-08-22 15:15:56 +00:00
Bill Meier
d13bc6c7f4 Fix a (probably benign) case where it appears that && should be &
svn path=/trunk/; revision=26058
2008-08-22 14:28:03 +00:00
Bill Meier
50fc84d329 Fix a case of && which should be &; add some parentheses for clarity
svn path=/trunk/; revision=26057
2008-08-22 14:02:05 +00:00
Jeff Morriss
2acffab343 Add an expert info noting an a_rwnd of 0.
svn path=/trunk/; revision=26055
2008-08-21 20:29:27 +00:00
Bill Meier
1391addb5a Modified version of a fix from Christopher Maynard as reported in bug 2822.
svn path=/trunk/; revision=26054
2008-08-21 18:51:17 +00:00