Gerald Combs
73f5cb2503
From non-customers via bug 5530: Fix a buffer overflow in the MAC LTE
...
dissector. From me: Add a define, ep_allocate the buffer.
svn path=/trunk/; revision=35292
2010-12-28 20:47:48 +00:00
Martin Mathieson
ee714ffac4
Only a new transmission grant should end a Scheduling Request.
...
svn path=/trunk/; revision=35268
2010-12-26 23:40:22 +00:00
Martin Mathieson
7cd3ff263b
Add more PHY attributes to MAC frames.
...
svn path=/trunk/; revision=35125
2010-12-05 23:34:11 +00:00
Martin Mathieson
a8b6aca90c
From Pascal Quantin:
...
- Set a default RNTI value for each type, in case optional RNTI value isn't supplied.
- Improve range checking of given type against acceptable range of values
- fix misplaced return (this fixed bug 5392)
svn path=/trunk/; revision=34859
2010-11-13 15:32:29 +00:00
Martin Mathieson
a067c3bb8a
Check given RNTI value is consistent with given RNTI-type.
...
As suggested in bug 5382. The reported crash didn't happen for me...
svn path=/trunk/; revision=34852
2010-11-12 16:59:22 +00:00
Martin Mathieson
fb0bfc17da
Show some reserved bits as hex, not decimal.
...
svn path=/trunk/; revision=34792
2010-11-05 16:47:22 +00:00
Martin Mathieson
829ee8752b
Add 'ndi' and 'harq-id' as new MAC-PHY DL attributes.
...
svn path=/trunk/; revision=34753
2010-11-02 15:20:38 +00:00
Jeff Morriss
f5d3a16225
Make tvb_strneql()'s size parameter be a size_t. Remove some now-unnecessary casts.
...
svn path=/trunk/; revision=34725
2010-10-30 18:18:12 +00:00
Guy Harris
17d4d51b7d
Make the third argument to a UAT copy callback a size_t (not that any of
...
the callbacks we have use that argument - is it really needed?).
svn path=/trunk/; revision=34694
2010-10-29 21:11:33 +00:00
Martin Mathieson
81a49eec81
In heuristic dissector, don't check/allocate struct until/unless signature pattern matches.
...
svn path=/trunk/; revision=34582
2010-10-20 09:58:40 +00:00
Martin Mathieson
7e938c7071
Don't clear info column when showing MAC or RLC-level info.
...
svn path=/trunk/; revision=34559
2010-10-18 17:02:19 +00:00
Martin Mathieson
1077ec28f6
Improve info column when showing PHY info for MAC frames.
...
svn path=/trunk/; revision=34529
2010-10-15 21:32:35 +00:00
Martin Mathieson
62e6b6aceb
Add more CRC failure codes.
...
svn path=/trunk/; revision=34401
2010-10-07 14:44:00 +00:00
Jeff Morriss
0ff5638f37
Replace blurbs that match the name (case insensitive) with NULL.
...
svn path=/trunk/; revision=34227
2010-09-23 21:46:31 +00:00
Jeff Morriss
381664535b
As suggested by Kovarththanan Rajaratnam in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3548 :
...
Clean up hf fields some more: mostly removing leading and trailing spaces from names and blurbs.
svn path=/trunk/; revision=34165
2010-09-21 03:14:49 +00:00
Martin Mathieson
4b5c69c0d9
Add bandwidth figures per UE.
...
svn path=/trunk/; revision=34061
2010-09-03 16:45:05 +00:00
Martin Mathieson
c642bae035
From Pascal Quantin:
...
The decoder expects to do not have any extra byte after the RAR bodies.
But according to 3GPP 36.321 8.8.0 chapter 6.1.5, the eNodeB is allowed to put padding at the end of the RAR PDU:
" A MAC PDU consists of a MAC header and zero or more MAC Random Access Responses (MAC RAR) and optionally padding as described in figure 6.1.5-4.
[...]
Padding may occur after the last MAC RAR. Presence and length of padding is implicit based on TB size, size of MAC header and number of RARs."
svn path=/trunk/; revision=33783
2010-08-12 09:03:05 +00:00
Jörg Mayer
8c03a4472a
Updading opensuse 11.2 -> 11.3 updated gcc to 4.5.0, which created
...
a few warnings that needed fixing when compiling with -Werror.
svn path=/trunk/; revision=33587
2010-07-20 08:27:34 +00:00
Martin Mathieson
703635b979
Give up dissecting a MAC PDU if we see control LCIDs after data ones.
...
This saves us getting into a mess trying to keep track of PDU sizes in an array...
svn path=/trunk/; revision=33582
2010-07-19 14:14:47 +00:00
Martin Mathieson
db478debbd
Allocate tap structs rather than using one static struct.
...
svn path=/trunk/; revision=33503
2010-07-13 16:25:34 +00:00
Martin Mathieson
b2a872cd9f
Show grant-subframe from context info.
...
svn path=/trunk/; revision=33437
2010-07-05 16:45:36 +00:00
Martin Mathieson
b7f136ae41
Check range of supplied subframe number. If out, set back to max (9) and
...
add expert info error. Should fix bug 4970.
svn path=/trunk/; revision=33432
2010-07-05 10:50:27 +00:00
Martin Mathieson
735ec2d6d2
For DL HARQ retx, support knowing result or not.
...
svn path=/trunk/; revision=33431
2010-07-05 10:35:17 +00:00
Martin Mathieson
97df849b98
Add new strings/dissector function for signalling RRC messages that will add
...
lte_rrc root to the protocol tree. Makes filtering on call signalling easier.
TODO: same for other RRC entry points...
svn path=/trunk/; revision=33251
2010-06-18 07:07:55 +00:00
Martin Mathieson
4fcd48495f
Add the direction to so expert info texts.
...
svn path=/trunk/; revision=33207
2010-06-10 15:28:41 +00:00
Martin Mathieson
98c68fc8ec
Check that the PDU isn't bigger than the reported grant size. Thought I was already doing this...
...
svn path=/trunk/; revision=32934
2010-05-24 16:28:34 +00:00
Martin Mathieson
5ed2e2f914
Trivial: Update AUTHORS entry, remove out-of-date comments, minor formatting
...
svn path=/trunk/; revision=32611
2010-04-30 17:15:59 +00:00
Martin Mathieson
0d7425872e
Set TA control element expert info based on improved understanding of spec.
...
svn path=/trunk/; revision=32539
2010-04-22 17:46:12 +00:00
Martin Mathieson
5a39a9ef39
- Lower severity on expert items about Timing Advance if <= 31
...
- Detect original frame for DL HARQ retx also 9 SFs ago (have even seen 10...)
- Getting ready to log 'grant subframe' for UL frames (only interesting for TDD)
svn path=/trunk/; revision=32538
2010-04-22 13:54:30 +00:00
Bill Meier
09764dd969
Remove unneeded #include <stdio.h>
...
svn path=/trunk/; revision=32367
2010-04-03 21:55:23 +00:00
Martin Mathieson
cfb6f1531a
Improve reporting of Scheduling Request failure.
...
svn path=/trunk/; revision=32272
2010-03-23 13:24:01 +00:00
Martin Mathieson
90b1fb287d
Show oob items outside of context tree.
...
svn path=/trunk/; revision=32269
2010-03-22 19:20:37 +00:00
Martin Mathieson
64d949c97e
Trivial reformatting
...
svn path=/trunk/; revision=32226
2010-03-17 19:40:34 +00:00
Martin Mathieson
b3a29fcb32
Add some extra (optional) physical layer attributes to logged MAC frames.
...
svn path=/trunk/; revision=32190
2010-03-14 17:56:37 +00:00
Martin Mathieson
5aaf90b753
Put context info in own subtree.
...
Use common function to append text to info column and tree items
svn path=/trunk/; revision=32151
2010-03-09 01:41:36 +00:00
Stig Bjørlykke
2f8830b4d0
From LEGO via bug 3459:
...
Add a callback to UAT to be called after the table has being updated,
use it to renew the snmp_ue_cache.
svn path=/trunk/; revision=32112
2010-03-04 12:50:18 +00:00
Martin Mathieson
5baac1de18
Fix crash where was overwriting buffer for large PDUs when tracking retxs.
...
svn path=/trunk/; revision=32095
2010-03-03 16:04:12 +00:00
Martin Mathieson
eba3b41978
Fix a test.
...
svn path=/trunk/; revision=32092
2010-03-03 15:38:37 +00:00
Martin Mathieson
80d7644409
Its convenient to be able to filter on mac-lte.ulsch or mac-lte.dlsch.
...
svn path=/trunk/; revision=32088
2010-03-03 11:57:21 +00:00
Martin Mathieson
ebd8c30044
When looking at time differences between frames, round to nearest number of ms.
...
svn path=/trunk/; revision=32086
2010-03-02 18:41:35 +00:00
Martin Mathieson
862dd48d35
Improve RLC AM sequence analysis by taking MAC retx into account.
...
svn path=/trunk/; revision=32071
2010-03-01 22:52:34 +00:00
Martin Mathieson
360077ae74
Calculate/show time between Msg3 and Msg4
...
svn path=/trunk/; revision=31970
2010-02-23 22:28:42 +00:00
Martin Mathieson
6a0c3ecaaf
Include detected DL retx in stats.
...
Each row is now a uniqe RNTI/UEId pair.
Added a filter button to filter by selected RNTI + UEId
svn path=/trunk/; revision=31931
2010-02-20 16:58:48 +00:00
Martin Mathieson
7b2a3c26e6
Recognise update string for SR failure, and show ueid in MAC if set.
...
svn path=/trunk/; revision=31916
2010-02-18 21:24:47 +00:00
Martin Mathieson
2e08a73235
Add preference that allows RLC PDUs embedded inside MAC info to be seen nicely in the info column
...
svn path=/trunk/; revision=31828
2010-02-08 15:01:08 +00:00
Martin Mathieson
35a4c0b3d6
Add UEId to MAC tap struct and stats window.
...
svn path=/trunk/; revision=31788
2010-02-04 16:30:43 +00:00
Martin Mathieson
1146a40844
From Pascal Quantin: show decoding of the Power Headroom Level field as specified in 3GPP 36.133 table 9.1.8.4-1.
...
svn path=/trunk/; revision=31705
2010-01-27 18:42:40 +00:00
Martin Mathieson
61c6c08861
Undo previous change to avoid crashing.
...
The test for NULL was to see whether struct had ever been allocated,
not for detecting a failed allocation...
svn path=/trunk/; revision=31681
2010-01-26 14:55:26 +00:00
Martin Mathieson
f1f528deeb
From Pascal Quantin: fid some LTE MAC and PDCP typos
...
svn path=/trunk/; revision=31661
2010-01-25 16:45:46 +00:00
Stig Bjørlykke
c198fc6546
From Didier Gautheron via bug 4419:
...
se_alloc and ep_alloc never return NULL and se_alloc0 already initialized
data with 0.
svn path=/trunk/; revision=31654
2010-01-25 11:47:39 +00:00