Commit graph

13 commits

Author SHA1 Message Date
Guy Harris
a8bc4a0d13 Rename the routines that handle dissector tables with unsigned integer
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys.  (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)

svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
Jaap Keuter
b7920c07c5 From Alexis La Goutte:
Replace all *_min()/*_max() by MIN() and MAX().

svn path=/trunk/; revision=34767
2010-11-04 06:36:33 +00:00
Stephen Fisher
034f2739d2 Add "(BE)" to the big endian representations of the ICMP identifier and
sequence number fields to match the "(LE)" ones.


svn path=/trunk/; revision=34136
2010-09-16 18:22:45 +00:00
Stephen Fisher
0583c64d8f Clean up the icmp info column per discussion in bug #4014.
Change to using new ENC_[BIG|LITTLE]_ENDIAN instead of FALSE and TRUE
in the proto_tree_add_item() calls for the identifier and sequence numbers.


svn path=/trunk/; revision=34119
2010-09-14 21:38:54 +00:00
Stephen Fisher
139d2e3af2 Clarify that the "Sequence number" is given in big endian representation and the "Sequence number (LE)" is little endian.
svn path=/trunk/; revision=33822
2010-08-16 22:28:23 +00:00
Gerald Combs
1bac7c2610 From Chris Maynard via bug 4014:
This trivial patch merely displays the ICMP ID and sequence # in the Info
column.

svn path=/trunk/; revision=33056
2010-06-02 18:13:00 +00:00
Bill Meier
055dd62063 #include <string.h> not needed.
svn path=/trunk/; revision=32410
2010-04-06 21:14:01 +00:00
Bill Meier
09764dd969 Remove unneeded #include <stdio.h>
svn path=/trunk/; revision=32367
2010-04-03 21:55:23 +00:00
Kovarththanan Rajaratnam
82778b3f86 Use val_to_str_const() since we intend on passing the string to col_set_str (which expects a constant string)
svn path=/trunk/; revision=30112
2009-09-24 13:36:02 +00:00
Stig Bjørlykke
99fbe23445 Cleanup code for type and code, do not show empty "()" when code is unused.
Use hex values for bitmasks in header_field_info.

svn path=/trunk/; revision=29790
2009-09-08 13:44:34 +00:00
Kovarththanan Rajaratnam
8b515e9340 Switch a bunch of dissectors over to using tvb_new_subset_remaining()
svn path=/trunk/; revision=29446
2009-08-16 12:36:22 +00:00
Stig Bjørlykke
8af0d42c47 Cleanup handling of ICMP type and code:
- Use value_string to convert strings
- Added more types and codes from IANA

Removed use of check_col()
Check checksum also if no tree
Some white space cleanup

svn path=/trunk/; revision=29050
2009-07-10 09:09:11 +00:00
Stig Bjørlykke
046a329a66 Split packet-ip into packet-ip and packet-icmp.
Some cleanup in handles and ett entries.

svn path=/trunk/; revision=29035
2009-07-09 11:32:50 +00:00