Commit graph

66 commits

Author SHA1 Message Date
Anders Broman
660d827706 Enhance IE dissection.
svn path=/trunk/; revision=35378
2011-01-05 16:46:40 +00:00
Jeff Morriss
f94b75c658 Give a couple of fields abbreviations.
svn path=/trunk/; revision=35362
2011-01-04 18:41:25 +00:00
Anders Broman
95397594c9 Maeke use of dissect_e212_mcc_mnc_ep_str().
svn path=/trunk/; revision=35361
2011-01-04 16:58:55 +00:00
Anders Broman
9eb2d42bac Add more info to the tree.
svn path=/trunk/; revision=35354
2011-01-04 07:14:11 +00:00
Anders Broman
da59924551 Prettify dissection of User Location Info (ULI). (Complete)
svn path=/trunk/; revision=35352
2011-01-03 23:21:49 +00:00
Anders Broman
5045d66232 Prettify dissection of User Location Info (ULI).
svn path=/trunk/; revision=35351
2011-01-03 22:13:11 +00:00
Anders Broman
24550de720 Mark unused parameters as such.
svn path=/trunk/; revision=35341
2011-01-03 17:32:15 +00:00
Anders Broman
288d47d1f2 Mark unused parameters as such.
svn path=/trunk/; revision=35340
2011-01-03 17:30:35 +00:00
Anders Broman
56c1d1569c Comment out a faulty line.
svn path=/trunk/; revision=35339
2011-01-03 17:26:12 +00:00
Anders Broman
9794ffb051 Enhance IE dissection and a number of bug fixes.
svn path=/trunk/; revision=35338
2011-01-03 17:22:02 +00:00
Anders Broman
f27aa6297a Extend IE dissetcion.
svn path=/trunk/; revision=35307
2010-12-30 14:09:09 +00:00
Guy Harris
a8bc4a0d13 Rename the routines that handle dissector tables with unsigned integer
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys.  (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)

svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
Bill Meier
7219ee2a49 Use val_to_str_ext() & friends to access sminmpec_values[];
Also: packet-nhrp.c: #include sminmpec.h not req'd;

svn path=/trunk/; revision=34143
2010-09-17 04:51:21 +00:00
Anders Broman
187baa00fa GTPv2: IMSI is decoded improperly.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5179

svn path=/trunk/; revision=34062
2010-09-03 17:10:52 +00:00
Martin Mathieson
21ec91d326 Fix warnings as seen in gcc 3.4.6
svn path=/trunk/; revision=33604
2010-07-21 12:29:32 +00:00
Stig Bjørlykke
a731837323 From KATAOKA Toshihiro via bug 5033:
3GPP GTPv2 header Update:
- piggybacked flag
- sequence number

From me:
Updated the comments for sequence number.

svn path=/trunk/; revision=33603
2010-07-21 10:28:46 +00:00
Anders Broman
2903a17305 Dissect one F-container
svn path=/trunk/; revision=33372
2010-06-29 14:56:39 +00:00
Stig Bjørlykke
51ef439176 Mark an unused argument.
svn path=/trunk/; revision=33357
2010-06-28 21:05:31 +00:00
Anders Broman
7ba4ce1983 Dissect more GTPV2 IE's
svn path=/trunk/; revision=33351
2010-06-28 15:31:41 +00:00
Anders Broman
5cdc63be46 Remove C++ style comment.
svn path=/trunk/; revision=33159
2010-06-08 10:37:03 +00:00
Anders Broman
92c247bf70 Fix packet-gtpv2.c:945:1: error: "/*" within comment
svn path=/trunk/; revision=33158
2010-06-08 08:55:07 +00:00
Anders Broman
7f9a9231dd From Tamás Regõs:
Change dissection of  User Location Info (ULI) to show the spare bits
in the protocol tree and don't show ECI as a bitfield.

svn path=/trunk/; revision=33157
2010-06-08 08:36:22 +00:00
Anders Broman
6d64725ae5 ECI (E-UTRAN Cell Identifier) wrongly decoded.
Spotted by Tamás Regõs.

svn path=/trunk/; revision=33128
2010-06-07 14:29:03 +00:00
Anders Broman
2fdf04a43e Update value_strings with IE names.
svn path=/trunk/; revision=33043
2010-06-02 06:17:02 +00:00
Anders Broman
c58a769956 Remove the now unused value_strings.
svn path=/trunk/; revision=33038
2010-06-01 22:23:22 +00:00
Anders Broman
875240d59e - Traffic flow template miss dissected, use de_sm_tflow_temp()
insted.
- Dissect vendor id of private message.

svn path=/trunk/; revision=33037
2010-06-01 22:22:09 +00:00
Bill Meier
10ffd14b8f Indentation & whitespace cleanup (including: "4 space tabs" ==> spaces)
svn path=/trunk/; revision=32735
2010-05-10 15:54:57 +00:00
Bill Meier
69df32fb11 #include <string.h> not needed.
svn path=/trunk/; revision=32411
2010-04-06 22:09:47 +00:00
Anders Broman
b3607a98ae From Toshihiro KATAOKA:
The decoded MSISDN AVP in 3GPP diameter AVP and the decoded MSISDN IE in 3GPP
GTPv2 IE are not correct. 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4638

svn path=/trunk/; revision=32377
2010-04-05 07:37:04 +00:00
Bill Meier
09764dd969 Remove unneeded #include <stdio.h>
svn path=/trunk/; revision=32367
2010-04-03 21:55:23 +00:00
Gerasimos Dimitriadis
dfde72f247 Fix for Bug 4588:
RANAP and friends want the MNC encoded in big endian form.

svn path=/trunk/; revision=32257
2010-03-20 23:53:22 +00:00
Gerasimos Dimitriadis
b7261fe2e4 Expert info when E.212 MCC/MNC contain non-decimal digits
svn path=/trunk/; revision=31102
2009-11-27 22:57:50 +00:00
Anders Broman
d9a86550c2 Remove debug printout.
svn path=/trunk/; revision=29968
2009-09-17 13:53:06 +00:00
Martin Mathieson
9467ccee2c Also mark tree as an unmarked parameter.
svn path=/trunk/; revision=29928
2009-09-15 17:07:54 +00:00
Anders Broman
70fabd5881 Remove now unused variables.
svn path=/trunk/; revision=29925
2009-09-15 16:46:30 +00:00
Anders Broman
6a5a9b2174 Bearer Context not dissected correctly.
Use the built in IE decoding by calling dissect_gtpv2_ie_common() for
the grouped IE:s.

svn path=/trunk/; revision=29924
2009-09-15 15:54:06 +00:00
Anders Broman
eeb1f0df18 From swapnil:
Bug in Traffic Aggregate Description (TAD) IE in Packet-gtpv2.c fixed.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3940

svn path=/trunk/; revision=29556
2009-08-26 04:36:14 +00:00
Anders Broman
7945bf1bc9 From Harald Welte :
Connect RRLP to GSM A DTAP application info message.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3919

From me try to fix missuse of pinfo.

svn path=/trunk/; revision=29482
2009-08-20 07:26:16 +00:00
Jaap Keuter
a4e174b7f8 From Swapnil Barai:
Minor Bug in Bearer Context in Packet-gtpv2.c fixed.

svn path=/trunk/; revision=29460
2009-08-18 06:41:12 +00:00
Kovarththanan Rajaratnam
5bd6d8eaaf From William Preston via. 3549:
A typo in 2 of the field names causes the apn not to be displayed.

svn path=/trunk/; revision=29394
2009-08-12 15:12:19 +00:00
Gerald Combs
1f3776bf8b Add some length checks.
svn path=/trunk/; revision=29388
2009-08-11 23:29:21 +00:00
Anders Broman
07900e7a1a From swapnil:
Small Bug in TFT (Flow label) and ULI.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3876

svn path=/trunk/; revision=29386
2009-08-11 21:27:36 +00:00
Anders Broman
bae780d14b From swapnil:
Bugs Fixed in ULI in packet-gtpv2.c
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3860

svn path=/trunk/; revision=29376
2009-08-11 10:32:46 +00:00
Anders Broman
a8fbd4577f From swapnil:
Another Minor Bug for ULI in Packet-gtpv2.c
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3862

svn path=/trunk/; revision=29374
2009-08-11 07:41:46 +00:00
Kovarththanan Rajaratnam
0a5b014cec Don't guard col_clear with col_check
svn path=/trunk/; revision=29344
2009-08-09 07:36:13 +00:00
Kovarththanan Rajaratnam
e971354a54 Don't guard col_set_str (COL_PROTOCOL) with col_check
svn path=/trunk/; revision=29340
2009-08-09 06:26:46 +00:00
Guy Harris
99bd70035d Completely remove an unused variable, don't just comment it out
(especially with a C++/C99-style comment that not all compilers used to
compile Wireshark accept).

svn path=/trunk/; revision=29255
2009-07-31 20:13:53 +00:00
Guy Harris
db0698fd0a Fix warnings:
the behavior of x = x++ is undefined by the ANSI C standard -
	they obviously just meant x++;

	get rid of unused variables.

svn path=/trunk/; revision=29248
2009-07-30 21:40:22 +00:00
Anders Broman
532f424f33 From swapnil:
Packet-gtpv2.c dissector extended to support more IE's.

svn path=/trunk/; revision=29247
2009-07-30 21:11:26 +00:00
Stig Bjørlykke
b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00