Anders Broman
b124071369
From Vincent Helfre:
...
fixed the conversions for utran and eutran threshold which are used for Enhanced Measurement Report.
svn path=/trunk/; revision=35199
2010-12-16 12:26:49 +00:00
Anders Broman
5a0e550686
From Vincent Helfre:
...
I have fixed some issue in the measurement information decoding in packet-gsm_a_rr.c.
svn path=/trunk/; revision=35061
2010-11-29 13:12:35 +00:00
Anders Broman
5f1b6a507b
From Alex Badea:
...
gsm_a_rr: System Information Type 4 / CBCH mobile allocation dissected incorrectly
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5436
svn path=/trunk/; revision=35054
2010-11-28 20:58:26 +00:00
Anders Broman
b91ed78bcc
Add a value_string_ext.
...
svn path=/trunk/; revision=34825
2010-11-09 17:24:45 +00:00
Anders Broman
348e0bc54b
Use value_string_ext for gsm_a_rr_rxlev_vals.
...
svn path=/trunk/; revision=34818
2010-11-09 07:28:04 +00:00
Anders Broman
5bf4fc3116
From Vincent Helfre:
...
Some improvements for the presentations.
svn path=/trunk/; revision=34620
2010-10-22 13:35:03 +00:00
Anders Broman
64d4b08a82
From Vincent Helfre:
...
various bug fix and enhancement for Release 8 additionnal parameters.
svn path=/trunk/; revision=34585
2010-10-20 12:40:13 +00:00
Anders Broman
0d4a4542ba
From Vincent Helfre:
...
Display the bits for
.... .00. = PCID_Pattern: 0
svn path=/trunk/; revision=34262
2010-09-27 12:53:42 +00:00
Anders Broman
a498b71098
Initialize subtree.
...
svn path=/trunk/; revision=34261
2010-09-27 10:11:40 +00:00
Anders Broman
415691da9d
From Vincent Helfre:
...
Release 8 june 2010 parameters decoding for SI2quater and Measurement Information messages.
svn path=/trunk/; revision=34260
2010-09-27 08:45:16 +00:00
Anders Broman
14b9a4c56a
From Vincent Helfre:
...
Incorrect decoding of List of ARFCN in BCCH frequency list.
When the range 1024 is selected, it can happen that 2 bytes need to be read for
W1, and also for W2. In the current version, when W1 ends on a byte boundary,
W2 will get an incorrect value, since it will be truncated by 1 bit.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5214
svn path=/trunk/; revision=34113
2010-09-14 14:24:39 +00:00
Bill Meier
dac0bf77ed
Fix cases where the type of a for loop variable is smaller than the type of the "end" variable.
...
In some cases the usage may have been benign since it can be seen by code inspection that the maximum value of the end variable can't exceed the maximum value of the loop variable.
However, on general principles, all the usages have been fixed.
svn path=/trunk/; revision=33692
2010-08-02 13:09:01 +00:00
Anders Broman
f9d6b18de7
from Sylvain Munaut:
...
SDCCH8 subchannel decoding error in GSM RR dissector
Summary: SDCCH8 subchannel decoding error in GSM RR dissector
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4910
svn path=/trunk/; revision=33312
2010-06-24 10:42:13 +00:00
Bill Meier
e79dddc257
Add an if-test to fix a fuzz-test crash;
...
See Bug #4897 : https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4897
svn path=/trunk/; revision=33280
2010-06-21 14:24:34 +00:00
Bill Meier
10ffd14b8f
Indentation & whitespace cleanup (including: "4 space tabs" ==> spaces)
...
svn path=/trunk/; revision=32735
2010-05-10 15:54:57 +00:00
Anders Broman
447faa6082
From Mike Morrin:
...
Dissection of BSSMAP IEs: Old BSS to New BSS Info and New BSS to Old BSS Info
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4712
svn path=/trunk/; revision=32606
2010-04-29 20:45:53 +00:00
Bill Meier
09764dd969
Remove unneeded #include <stdio.h>
...
svn path=/trunk/; revision=32367
2010-04-03 21:55:23 +00:00
Gerald Combs
b3a1cd8859
Temporary (?) fix for bug 4623.
...
svn path=/trunk/; revision=32327
2010-03-30 21:12:52 +00:00
Bill Meier
de4c6ff515
Fix a number of gcc _Wshadow warnings
...
svn path=/trunk/; revision=31557
2010-01-18 21:49:47 +00:00
Gerasimos Dimitriadis
809477b66e
Fix for Bug 4197:
...
Neighbour Cell Description 2 decode error
svn path=/trunk/; revision=31177
2009-12-04 20:27:16 +00:00
Gerasimos Dimitriadis
c840cdd5a0
Remove the address operator from value_string arrays fed to VALS()
...
svn path=/trunk/; revision=30995
2009-11-17 18:35:27 +00:00
Gerasimos Dimitriadis
79cf9b5f45
Erroneously ommitted from the patch of Bug 4219:
...
bit_offset used instead of curr_bit_offset
svn path=/trunk/; revision=30974
2009-11-16 16:20:49 +00:00
Gerasimos Dimitriadis
9b36fc784e
From yy:
...
About GSM system information type 2quater
Modified to use newly defined tvb_get_bits() in tvbuff.c
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4219
svn path=/trunk/; revision=30962
2009-11-14 20:13:43 +00:00
Jaap Keuter
75f1e13c12
Cleanup header fields.
...
svn path=/trunk/; revision=30394
2009-10-07 23:08:22 +00:00
Bill Meier
6c545e0d79
Save some memory: Don't statically allocate ett[] arrays used "dynamically".
...
svn path=/trunk/; revision=29929
2009-09-15 17:37:54 +00:00
Anders Broman
d41058065f
From Mike Morrin:
...
The GSM L3 part of the BSSMAP CipherModeComplete message is not being decoded.
Sligtly modified.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3983
svn path=/trunk/; revision=29776
2009-09-07 17:17:07 +00:00
Anders Broman
e99983ab3a
From Vincent Helfre:
...
Dissect_ccch does not dissect sys info content.
Me: Remove check_col.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3901
svn path=/trunk/; revision=29693
2009-09-04 11:06:52 +00:00
Anders Broman
4e87c254f0
From Mike Morrin:
...
Minor errors in gsm rr dissectors
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3889
Modified accoring to comments from Pascal Quantin(I hope I got it right).
svn path=/trunk/; revision=29549
2009-08-25 17:22:32 +00:00
Anders Broman
7945bf1bc9
From Harald Welte :
...
Connect RRLP to GSM A DTAP application info message.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3919
From me try to fix missuse of pinfo.
svn path=/trunk/; revision=29482
2009-08-20 07:26:16 +00:00
Anders Broman
87da96be52
From Jan Lübbe:
...
packet-gsm_a_rr.c: flip gsm_a_rr_mv_vals, 0 means vaild.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3915
svn path=/trunk/; revision=29472
2009-08-19 09:32:56 +00:00
Kovarththanan Rajaratnam
97fda7386c
Make sure that we find the "data" dissector during handoff else we might crash if the received payload was less than 2 bytes.
...
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3893
svn path=/trunk/; revision=29403
2009-08-13 12:17:20 +00:00
Jaap Keuter
7267ec9782
Complete the fix in r29389.
...
svn path=/trunk/; revision=29390
2009-08-11 23:52:04 +00:00
Gerald Combs
4bfcd5993a
Instead of calling DISSECTOR_ASSERT_NOT_REACHED, just say the subchannel
...
is unknown. Fixes bug 3864.
svn path=/trunk/; revision=29389
2009-08-11 23:44:22 +00:00
Bill Meier
3c1bc8f251
Fix some individual cases of 'if (unsigned) < 0'
...
svn path=/trunk/; revision=29320
2009-08-06 23:51:45 +00:00
Bill Meier
21d8e2d3e1
Prevent possible (benign ?) array references with an array index of -1.
...
svn path=/trunk/; revision=29312
2009-08-06 18:44:38 +00:00
Bill Meier
eba5297683
Remove inadvertantly committed comments re issue yet to be fixed ...
...
svn path=/trunk/; revision=29311
2009-08-06 16:13:31 +00:00
Bill Meier
7f7161f819
Register ett[] subtree array only once.
...
svn path=/trunk/; revision=29309
2009-08-06 16:06:11 +00:00
Jaap Keuter
c9e3f66d14
Optimize empty strings to NULL pointers.
...
svn path=/trunk/; revision=29298
2009-08-04 21:05:38 +00:00
Stig Bjørlykke
b228488bc0
From Kovarththanan Rajaratnam via bug 3548:
...
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero
svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Bill Meier
ab291b9c00
FT_BOOLEAN fields with bitmask: Display is 'parent bitfield width' not BASE...
...
Also: Change FT_BOOLEAN with no bitmask from BASE_DEC to BASE_NONE.
svn path=/trunk/; revision=28312
2009-05-08 19:42:58 +00:00
Bill Meier
0274ef3673
Use NULL instead of repeated identical text if hf[] blurbs;
...
Use #if 0 ... #endif instead of /* ... */ to comment out code;
Reformat some long lines;
Use consistent indentation.
svn path=/trunk/; revision=28301
2009-05-08 15:03:11 +00:00
Bill Meier
3c11319ea4
Adjust some indentation
...
svn path=/trunk/; revision=27323
2009-01-28 21:22:30 +00:00
Anders Broman
b631b88d61
Implement TLV-E and LV-E type IE dissection (2 byte length value).
...
svn path=/trunk/; revision=27100
2008-12-23 20:49:15 +00:00
Bill Meier
c544c20956
Fix various typos and spelling errors (mostly in text strings)
...
svn path=/trunk/; revision=27050
2008-12-18 19:08:49 +00:00
Bill Meier
a8f30cbca1
Fix some typos and spelling (mostly in text strings)
...
svn path=/trunk/; revision=27037
2008-12-17 17:23:37 +00:00
Anders Broman
05fa33881c
From Pascal Quantin:
...
Improve 3GPP 44.018 RR dissection.
svn path=/trunk/; revision=26779
2008-11-15 11:36:49 +00:00
Anders Broman
d943c93a0b
From Pascal Quantin:
...
Proper Fix for "'subtree' may be used uninitialized in this function" error (SVN revision 26730)
svn path=/trunk/; revision=26745
2008-11-10 20:21:04 +00:00
Anders Broman
3d7baf2c9f
Try to pacify the buildbot.
...
svn path=/trunk/; revision=26732
2008-11-07 18:13:10 +00:00
Anders Broman
04f9b031ef
From Pascal Quantin:
...
Add 3GPP 44.018 RR Short Protocol Discriminator dissection.
svn path=/trunk/; revision=26730
2008-11-07 17:37:22 +00:00
Guy Harris
c7d0c67e3d
Mark the reduced frame number field as generated.
...
svn path=/trunk/; revision=26690
2008-11-04 20:20:33 +00:00