Commit graph

63 commits

Author SHA1 Message Date
Guy Harris
a8bc4a0d13 Rename the routines that handle dissector tables with unsigned integer
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys.  (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)

svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
Jaap Keuter
fb1390652b Fix for bug 5475:
Track dissection properly of Packet Flow Identifier IE to 
avoid Extraneous Data reporting.

svn path=/trunk/; revision=35194
2010-12-16 07:25:01 +00:00
Anders Broman
58308341bd From Pascal Quantin:
[NAS EPS] Display explicitly the spare bits when decoding a TFT
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5371

svn path=/trunk/; revision=34781
2010-11-05 06:19:57 +00:00
Bill Meier
c256942255 Use value_string_ext fcns to access various value_string arrays.
Also: use value_string_const() instead of value_string() where apropriate;
      minor reformatting & whitespace cleanup.

svn path=/trunk/; revision=34745
2010-11-01 18:26:34 +00:00
Anders Broman
fe71cbcc99 From Pascal Quantin:
[NAS EPS] Fix TFT decoding in case of "delete packet filters from existing TFT" operation

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5347

svn path=/trunk/; revision=34666
2010-10-28 15:06:48 +00:00
Anders Broman
23c4983424 From Pascal Quantin:
[NAS EPS] Fix TFT decoding when having several Packet Filters defined
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5274

svn path=/trunk/; revision=34385
2010-10-05 17:58:58 +00:00
Anders Broman
b596b69f66 From Pascal Quantin:
[NAS EPS] Use Request Type IE defined in 3GPP 24.008

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5246

svn path=/trunk/; revision=34179
2010-09-22 10:38:45 +00:00
Anders Broman
f80f4ae05f From Pascal Quantin:
[NAS EPS] Traffic Flow Template IE dissection bugs.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5243

svn path=/trunk/; revision=34177
2010-09-22 07:06:15 +00:00
Anders Broman
b2f660f0d3 Add missing break, should fix bug
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5110

svn path=/trunk/; revision=33794
2010-08-13 11:57:18 +00:00
Bill Meier
dac0bf77ed Fix cases where the type of a for loop variable is smaller than the type of the "end" variable.
In some cases the usage may have been benign since it can be seen by code inspection that the maximum value of the end variable can't exceed the maximum value of the loop variable.
However, on general principles, all the usages have been fixed.

svn path=/trunk/; revision=33692
2010-08-02 13:09:01 +00:00
Anders Broman
b5753ef3fc Add a field for "Revision Level Indicator" in the "MS Radio Access Capability IE".
svn path=/trunk/; revision=33518
2010-07-14 12:01:05 +00:00
Anders Broman
2707d0ddde Set pinfo->link_dir when protocol configuration options is in the message.
svn path=/trunk/; revision=33366
2010-06-29 05:40:45 +00:00
Bill Meier
7b85f43d0e Do some constifying [or other] based upon gcc -Wwrite-strings warnings.
svn path=/trunk/; revision=33198
2010-06-09 18:12:17 +00:00
Anders Broman
875240d59e - Traffic flow template miss dissected, use de_sm_tflow_temp()
insted.
- Dissect vendor id of private message.

svn path=/trunk/; revision=33037
2010-06-01 22:22:09 +00:00
Bill Meier
10ffd14b8f Indentation & whitespace cleanup (including: "4 space tabs" ==> spaces)
svn path=/trunk/; revision=32735
2010-05-10 15:54:57 +00:00
Gerasimos Dimitriadis
dfde72f247 Fix for Bug 4588:
RANAP and friends want the MNC encoded in big endian form.

svn path=/trunk/; revision=32257
2010-03-20 23:53:22 +00:00
Gerasimos Dimitriadis
0b13ca1a48 Decode GPRS SM Messages related to MBMS Context handling
svn path=/trunk/; revision=32176
2010-03-12 21:30:54 +00:00
Anders Broman
342a3ca712 From Vladimir Kazansky:
Wrong offset returned by de_sm_pdp_addr().
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4568

svn path=/trunk/; revision=32156
2010-03-10 06:39:14 +00:00
Anders Broman
18202ab0ed from Pascal Quantin:
Update that enhance a little bit the display of the Parameters List IE

svn path=/trunk/; revision=32153
2010-03-09 16:57:24 +00:00
Anders Broman
334210d3db From Pascal Quantin:
[NAS EPS] Fixes for the Traffic Flow Template IE.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4564

svn path=/trunk/; revision=32145
2010-03-08 20:46:30 +00:00
Anders Broman
016530ba0f From Pascal Quantin:
[NAS EPS] Various small bug fixes.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4562

svn path=/trunk/; revision=32130
2010-03-06 20:32:27 +00:00
Gerasimos Dimitriadis
00c4b361e2 Decoding support for GPRS Session Management 'Activate MBMS
Context Request' message and related IEs

svn path=/trunk/; revision=32126
2010-03-06 00:06:27 +00:00
Bill Meier
de4c6ff515 Fix a number of gcc _Wshadow warnings
svn path=/trunk/; revision=31557
2010-01-18 21:49:47 +00:00
Gerasimos Dimitriadis
976be95b98 Fixes/enhancements/updates for 24.008 IEs:
MS Network Capability, LLC SAPI, Tear Down Indicator,
Packet Flow Identifier

svn path=/trunk/; revision=31352
2009-12-22 20:36:20 +00:00
Gerasimos Dimitriadis
ec5cd4d450 Update SM Cause IE; Decode SM Cause 2 IE; Update
Activate PDP Context Accept msg

svn path=/trunk/; revision=31330
2009-12-20 23:17:40 +00:00
Gerasimos Dimitriadis
309d920eb8 Fix/enhacement of Quality of Service IE
svn path=/trunk/; revision=31295
2009-12-17 16:56:56 +00:00
Gerasimos Dimitriadis
acd70335d1 More NULL entries in dtap_msg_sm_fcn[] to avoid out of bounds access
svn path=/trunk/; revision=31279
2009-12-15 22:09:32 +00:00
Gerasimos Dimitriadis
af4c9216ce Fix/update for PDP Address IE
svn path=/trunk/; revision=31278
2009-12-15 21:48:05 +00:00
Gerasimos Dimitriadis
5de2fed9aa PS LCS Capability IE updated according to 24.008 V8.6.0;
Change printing of values according to standard style.

svn path=/trunk/; revision=31127
2009-11-29 23:23:27 +00:00
Gerasimos Dimitriadis
8a70d722d9 Explicitly show LAC and RAC when dissecting Routing Area
Identification; print LAC/RAC parts as decimals in RAI;
remove unneeded #include.

svn path=/trunk/; revision=31103
2009-11-27 23:55:32 +00:00
Gerasimos Dimitriadis
b7261fe2e4 Expert info when E.212 MCC/MNC contain non-decimal digits
svn path=/trunk/; revision=31102
2009-11-27 22:57:50 +00:00
Gerasimos Dimitriadis
b77caf13a9 More uniform printing of field values: Interpretation first, actual
value second.

svn path=/trunk/; revision=31092
2009-11-26 22:37:43 +00:00
Gerasimos Dimitriadis
299d64d458 Use range_string for the decoding of the CN specific DRX
cycle length coefficient; fixed the decoding of unknown 
values for Split PG Cycle Code; updated function for
Identity Type 2, now spare bit is explicitly shown; Reuse
the definition of the Switch-Measure-Switch values from
packet-gsm_a_common.c

svn path=/trunk/; revision=31060
2009-11-23 23:02:02 +00:00
Gerasimos Dimitriadis
5664dac535 Analyze GPRS Timer in its two subfields, unit and value
svn path=/trunk/; revision=31056
2009-11-23 19:59:40 +00:00
Gerasimos Dimitriadis
518995a4d8 No need for decoding function for a Tag-only IE
svn path=/trunk/; revision=31055
2009-11-23 19:15:58 +00:00
Gerasimos Dimitriadis
36b1cc8e77 Updated GPRS TMSI Status and Update Type IEs
svn path=/trunk/; revision=31009
2009-11-18 22:41:08 +00:00
Gerasimos Dimitriadis
bb3447c6b1 GPRS Attach Type IE updated according to 24.008 v8.6.0
svn path=/trunk/; revision=31008
2009-11-18 22:05:16 +00:00
Gerasimos Dimitriadis
55b982b031 - Use the spare_bits hf from packet_gsm_a_common.c in
packet-gsm_a_dtap.c and packet-gsm_a_gm.c
- Update a number of GPRS IEs according to 24.008 v8.6.0
- Rewrite parts of GPRS IEs so that it is shown which octet parts
  contribute to which header fields


svn path=/trunk/; revision=31006
2009-11-18 20:39:14 +00:00
Gerasimos Dimitriadis
e92c2e17da GPRS Attach Result IE updated according to 24.008 v8.6.0
svn path=/trunk/; revision=30977
2009-11-16 18:22:43 +00:00
Anders Broman
40447d1c12 Updated decoding of GMM Cause to V8.6.0, i.e. added cause code 0x19 - "Not authorized for this CSG". Changed to use a range_string.
Based on 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4132

svn path=/trunk/; revision=30627
2009-10-20 03:13:56 +00:00
Bill Meier
8790ed892f Define a global variable as static;
#include <stdio.h> & <stdlib.h>  not req'd.

svn path=/trunk/; revision=30101
2009-09-23 18:20:06 +00:00
Bill Meier
9310f13f19 Change gchar foo[mm][nn] = {"xxx", "yyy", ...} to static const gchar *foo[mm] = {...}
Add a comment about a possible bug: some strings in array are never used ?
Do some minor reformatting.

svn path=/trunk/; revision=30097
2009-09-23 17:55:37 +00:00
Bill Meier
81444cdda0 Quick fix for Bug #4040.
See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4040

ToDo: Fix usage of
 gchar xxx[..][..] = {"aaa", "bbb", ...};

svn path=/trunk/; revision=30094
2009-09-23 16:06:39 +00:00
Anders Broman
2cacda1823 From Vincent Helfre:
MS network capability enhancement.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4039

svn path=/trunk/; revision=30075
2009-09-22 19:15:30 +00:00
Bill Meier
6c545e0d79 Save some memory: Don't statically allocate ett[] arrays used "dynamically".
svn path=/trunk/; revision=29929
2009-09-15 17:37:54 +00:00
Anders Broman
7945bf1bc9 From Harald Welte :
Connect RRLP to GSM A DTAP application info message.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3919

From me try to fix missuse of pinfo.

svn path=/trunk/; revision=29482
2009-08-20 07:26:16 +00:00
Anders Broman
43cbf13ad4 Minor clean up.
svn path=/trunk/; revision=29466
2009-08-18 14:39:32 +00:00
Jaap Keuter
c9e3f66d14 Optimize empty strings to NULL pointers.
svn path=/trunk/; revision=29298
2009-08-04 21:05:38 +00:00
Anders Broman
1464f7ca84 Introduce decode_bits_in_field() and use it.
clean up some left owers from previous checkin.

svn path=/trunk/; revision=28373
2009-05-15 18:38:13 +00:00
Anders Broman
2289fa0d21 Fix:
GSM DTAP: Incorrect decoding of MS Radio Access Capability Switch-Measure*
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3461

svn path=/trunk/; revision=28361
2009-05-14 18:26:18 +00:00