Commit graph

47 commits

Author SHA1 Message Date
Anders Broman
735709bee6 Add tvb_bcd_dig_to_ep_str()
/*
 * Given a tvbuff, an offset into the tvbuff, and a length that starts
 * at that offset (which may be -1 for "all the way to the end of the
 * tvbuff"), fetch BCD encoded digits from a tvbuff starting from either 
 * the low or high half byte, formating the digits according to an input digit set, 
 * if NUll a default digit set of 0-9 returning "?" for overdecadic digits will be used.
 * A pointer to the EP allocated string will be returned.
 * Note a tvbuff content of 0xf is considered a 'filler' and will end the conversion.
 */

svn path=/trunk/; revision=35286
2010-12-28 12:36:26 +00:00
Anders Broman
790ba15666 move the enum to packet-gsm_a_common to
make it possible to use element dissecton from this dissector
in other dissectors.
It is left in packet-nas_EPS.c as a comment for easier reference.

svn path=/trunk/; revision=35269
2010-12-27 05:33:58 +00:00
Anders Broman
356aced5bf Start of a SGSAP (TS 29.118) dissector for LTE.
svn path=/trunk/; revision=35266
2010-12-26 21:06:08 +00:00
Anders Broman
348e0bc54b Use value_string_ext for gsm_a_rr_rxlev_vals.
svn path=/trunk/; revision=34818
2010-11-09 07:28:04 +00:00
Anders Broman
c522f01e2b From Pascal Quantin:
[NAS EPS] Add dissection of special conformance testing functions

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5278

svn path=/trunk/; revision=34394
2010-10-06 14:33:27 +00:00
Anders Broman
875240d59e - Traffic flow template miss dissected, use de_sm_tflow_temp()
insted.
- Dissect vendor id of private message.

svn path=/trunk/; revision=33037
2010-06-01 22:22:09 +00:00
Anders Broman
447faa6082 From Mike Morrin:
Dissection of BSSMAP IEs: Old BSS to New BSS Info and New BSS to Old BSS Info
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4712

svn path=/trunk/; revision=32606
2010-04-29 20:45:53 +00:00
Gerasimos Dimitriadis
00c4b361e2 Decoding support for GPRS Session Management 'Activate MBMS
Context Request' message and related IEs

svn path=/trunk/; revision=32126
2010-03-06 00:06:27 +00:00
Gerasimos Dimitriadis
ec5cd4d450 Update SM Cause IE; Decode SM Cause 2 IE; Update
Activate PDP Context Accept msg

svn path=/trunk/; revision=31330
2009-12-20 23:17:40 +00:00
Gerasimos Dimitriadis
8a70d722d9 Explicitly show LAC and RAC when dissecting Routing Area
Identification; print LAC/RAC parts as decimals in RAI;
remove unneeded #include.

svn path=/trunk/; revision=31103
2009-11-27 23:55:32 +00:00
Gerasimos Dimitriadis
299d64d458 Use range_string for the decoding of the CN specific DRX
cycle length coefficient; fixed the decoding of unknown 
values for Split PG Cycle Code; updated function for
Identity Type 2, now spare bit is explicitly shown; Reuse
the definition of the Switch-Measure-Switch values from
packet-gsm_a_common.c

svn path=/trunk/; revision=31060
2009-11-23 23:02:02 +00:00
Gerasimos Dimitriadis
55b982b031 - Use the spare_bits hf from packet_gsm_a_common.c in
packet-gsm_a_dtap.c and packet-gsm_a_gm.c
- Update a number of GPRS IEs according to 24.008 v8.6.0
- Rewrite parts of GPRS IEs so that it is shown which octet parts
  contribute to which header fields


svn path=/trunk/; revision=31006
2009-11-18 20:39:14 +00:00
Anders Broman
b8af7c77c8 From Gerasimos Dimitriadis:
Change of IEs in DTAP MODIFY msg.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4032

svn path=/trunk/; revision=30064
2009-09-22 06:42:10 +00:00
Anders Broman
d41058065f From Mike Morrin:
The GSM L3 part of the BSSMAP CipherModeComplete message is not being decoded.
Sligtly modified.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3983

svn path=/trunk/; revision=29776
2009-09-07 17:17:07 +00:00
Anders Broman
7945bf1bc9 From Harald Welte :
Connect RRLP to GSM A DTAP application info message.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3919

From me try to fix missuse of pinfo.

svn path=/trunk/; revision=29482
2009-08-20 07:26:16 +00:00
Bill Meier
4acb789917 'if (curr_len <= 0)' won't work as desired when curr_len is declared as unsigned.
The fix: change to 'if ((signed)curr_len <= 0)'.
This is a bit of a hack but I think it works.
See the comment in this file (packet-gsm_a_common.h).

svn path=/trunk/; revision=29319
2009-08-06 23:47:21 +00:00
Jaap Keuter
c9e3f66d14 Optimize empty strings to NULL pointers.
svn path=/trunk/; revision=29298
2009-08-04 21:05:38 +00:00
Anders Broman
1b5af9ff1f Updates to Jun spec. version.
svn path=/trunk/; revision=28706
2009-06-11 16:26:31 +00:00
Anders Broman
fb1f3f0825 More IE decoding and bug fixes.
svn path=/trunk/; revision=28156
2009-04-26 16:17:00 +00:00
Anders Broman
0d2fb53b74 - Fix APDU dissection.
- NAS EPS bugfixes and enhancements.

svn path=/trunk/; revision=27778
2009-03-18 19:40:54 +00:00
Anders Broman
2db386dfd4 - Use correct length in TLV-E and LV-E.
- Update PD values to the latest spec.
- Remove some non ASCII chars.
- Start dissecton of LTE NAS ESM EPS messages and IE's.

svn path=/trunk/; revision=27605
2009-03-04 19:51:55 +00:00
Anders Broman
fea7018ed8 Add dissection of some IE's, reworked input from Zakia Karim.
svn path=/trunk/; revision=27467
2009-02-16 21:21:11 +00:00
Anders Broman
5e2ccb0ecd Some more NAS updates.
svn path=/trunk/; revision=27147
2009-01-01 22:54:30 +00:00
Anders Broman
b631b88d61 Implement TLV-E and LV-E type IE dissection (2 byte length value).
svn path=/trunk/; revision=27100
2008-12-23 20:49:15 +00:00
Anders Broman
ec3b36c304 Add the base for a LTE NAS PDU dissector.
svn path=/trunk/; revision=26869
2008-11-27 21:45:42 +00:00
Anders Broman
ad41b9667f Move some of the BSSMAP LE stuff to packet-gsm_bssmap_le.c
svn path=/trunk/; revision=26832
2008-11-23 21:08:46 +00:00
Anders Broman
f42db62a55 From Johnny Mitrevski:
Add new Bssap dissectors for the Lb interface.

svn path=/trunk/; revision=26814
2008-11-20 07:57:24 +00:00
Anders Broman
e9ad3ced49 Add some comments.
svn path=/trunk/; revision=26794
2008-11-16 22:51:49 +00:00
Anders Broman
05fa33881c From Pascal Quantin:
Improve 3GPP 44.018 RR dissection.

svn path=/trunk/; revision=26779
2008-11-15 11:36:49 +00:00
Anders Broman
04f9b031ef From Pascal Quantin:
Add 3GPP 44.018 RR Short Protocol Discriminator dissection.

svn path=/trunk/; revision=26730
2008-11-07 17:37:22 +00:00
Anders Broman
e95a3f43c8 From Pascal Quantin:
Add 3GPP Special Conformance Testing Procedures to GSM statistics

svn path=/trunk/; revision=26716
2008-11-06 21:49:21 +00:00
Anders Broman
07dadee5dd From Pascal Quantin:
The attached patch adds the following enhancements:
- remove duplicated code for Reduced Frame Number computation, and solve
guint64 issue in the same time (see bug 3028 for details)
- BA Range IE decoding
- BA List Pref IE decoding
- UTRAN Frequency List IE decoding
- Cell Selection Indicator after Release of all TCH and SDCCH IE decoding
- UTRAN Classmark Change message decoding (with a call to RRC dissector to
decode the INTER RAT HANDOVER INFO message)
- add Inter System To UTRAN Handover Command message decoding

As usual it compiles fine on Windows but I could not check on Linux.

svn path=/trunk/; revision=26688
2008-11-04 20:03:19 +00:00
Anders Broman
c0dd6c4ca9 From Pascal Quantin:
Various enhancements to 3GPP 44.018 Radio Resource dissection.

svn path=/trunk/; revision=26682
2008-11-03 21:16:18 +00:00
Anders Broman
e3d3b73a96 From Pascal Quantin:
Add 3GPP 44.018 SI5bis, SI5ter, SI6 and SI13 decoding
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3014

svn path=/trunk/; revision=26623
2008-10-30 19:30:08 +00:00
Anders Broman
dd18d39f92 Move dissect_geographical_description() from gsm_map to gsm_a_common to make it easier to use it in other dissectors including it from gsm_map makes in neccesarry to include asn1.h.
Fix some bugs in the code, use it from bssmap.

svn path=/trunk/; revision=26603
2008-10-28 19:16:10 +00:00
Anders Broman
38e28295cd Update towards 48.008 8.4.0
svn path=/trunk/; revision=26589
2008-10-27 21:07:52 +00:00
Anders Broman
f47b645008 From Pascal Quantin:
Add 3GPP 44.018 SI1, SI2bis, SI2ter and SI2quater full decoding

svn path=/trunk/; revision=26559
2008-10-26 19:46:46 +00:00
Anders Broman
799b8635f3 Update towards 48.008 8.4.0
svn path=/trunk/; revision=26558
2008-10-26 19:44:06 +00:00
Anders Broman
41b70e3a96 Some further updates.
svn path=/trunk/; revision=26517
2008-10-22 20:56:26 +00:00
Anders Broman
a4c3055bbb Update bssap le and BSS MAP.
svn path=/trunk/; revision=26514
2008-10-22 16:32:24 +00:00
Anders Broman
fdb832cf1b Dissect Bearer cap in Signal info.
svn path=/trunk/; revision=26396
2008-10-09 17:51:51 +00:00
Anders Broman
ebc8f1f8bf From Niel Percy:
Much as I hate white space changes, I got fed up of the huge variation of styles within these files, and tried to get to a much smaller range of variation. Also a few comment tidies, and use of _U_ for unused args rather than "arg = arg" lines.

svn path=/trunk/; revision=26140
2008-09-05 05:49:39 +00:00
Anders Broman
2226bccd44 From Neil Piercy:
1 new split file (GMM & SM in one file) and diff patches for the others. The RR, RP and BSSMAP patches are really a tidy-up: now they are split it becomes clear what was redundant code.

svn path=/trunk/; revision=26064
2008-08-24 17:42:30 +00:00
Anders Broman
bafcc127f8 From Neil Piercy:
RR has been split from DTAP, with common stuff going to the common files (plus a few minor knock-on consequences).
Fix the broken tap:
I had not realised that the register_tap call in the dissector registration actually _created_ the tap entry (not the register_tap_listener), and not just associated the tap_id returned with the tap registered by the listener. The use of separate statics by the split lead to 3 taps called "gsm_a", but only the first of which was ever found in the tap_queue_packet. Added (yet another) global for now to cope.

Also attached is a patch to tap.c which simply returns the same tap_id if the register_tap is called twice with the same name - I can't see any downside to this, can you? Anyway it seemed to work with deliberately keeping multiple calls.

svn path=/trunk/; revision=26039
2008-08-19 08:05:04 +00:00
Bill Meier
9ef15c9aa4 temp fix (until the proper fix) to handle buildbot errs;
svn path=/trunk/; revision=25922
2008-08-04 23:15:51 +00:00
Anders Broman
082a5aec04 From Neil Piercy:
All I've done in these is to split the 3 obviously distinct protocols (BSSMAP & RP) from the still-large (and wrongly-named) DTAP (really the whole of layer 3 - it includes RR and packet parts too).

So far I've only split in a "minimum change" manner - there is clearly some tidying and structure enhancement of how the common bits are used, removing the globals just added, and great scope for consistency of white space, improved naming etc. - but I thought it best to keep it very close to the original initially to establish the split.

With some changes to make it compile on Windows.

svn path=/trunk/; revision=25917
2008-08-04 19:44:03 +00:00
Anders Broman
96aa45646d First step to split the gsm_a dissector into several smaller ones ( done by Neil Piercy)
rename the "old" one to gsm_a_common.

svn path=/trunk/; revision=25915
2008-08-04 16:11:17 +00:00
Renamed from epan/dissectors/packet-gsm_a.h (Browse further)