Commit graph

159 commits

Author SHA1 Message Date
Anders Broman
d2099a52a2 Add time stamp to the list.
svn path=/trunk/; revision=28649
2009-06-06 17:08:01 +00:00
Guy Harris
cf91fdf16b Have tap listeners specify whether the "packet" routine requires
a protocol tree;

	the column values.

This includes stats-tree listeners.

Have the routines to build the packet list, and to retap packets, honor
those requirements.  This means that cf_retap_packets() no longer needs
an argument to specify whether to construct the column values or not, so
get rid of that argument.

This also means that there's no need for a tap to have a fake filter
to ensure that the protocol tree will be built, so don't set up a fake
"frame" filter.

While we're at it, clean up some cases where "no filter" was represented
as a null string rather than a null pointer.

Have a routine to return an indication of the number of tap listeners
with filters; use that rather than the global num_tap_filters.

Clean up some indentation and some gboolean vs. gint items.

svn path=/trunk/; revision=28645
2009-06-05 22:42:47 +00:00
Anders Broman
75af067043 Calculate skew and clock drift, make it possible to copy the label.
svn path=/trunk/; revision=28606
2009-06-02 19:05:20 +00:00
Stig Bjørlykke
97f65cd644 Fix a printf to make the label correct.
svn path=/trunk/; revision=28569
2009-06-01 17:52:14 +00:00
Anders Broman
ae260ddd2b Show max and mean Jitter.
svn path=/trunk/; revision=28560
2009-06-01 16:44:05 +00:00
Bill Meier
134fd85fc6 Fix a few more memory leaks & do a few other minor changes
svn path=/trunk/; revision=28553
2009-06-01 12:32:02 +00:00
Anders Broman
2b962a1134 Copy the changes from:
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=28534

User: wmeier
Date: 2009/05/30 11:07 AM

Log:
 Fix the save_as functions so they work (including work-around  when save-as raises an alert box). 
 Also:
 - save_as_csv: don't skip over first line of output;
 - save_as_csv: Fix some (probably significant) memory leaks
   associated with the use of gtk_tree_view;
 - Prevent tendency for IAX2 stream window and graph window 
   to get lost behind other windows;
 - Minor save_as dialog window reformatting;
 - Misc source code cleanup & reformatting.

To RTP Analysis.

svn path=/trunk/; revision=28551
2009-05-31 19:55:30 +00:00
Anders Broman
5ed6a83dff Calculate jitter and delta in ms.
svn path=/trunk/; revision=28546
2009-05-31 17:06:04 +00:00
Anders Broman
25329d1427 Don't skipp the first entry.
svn path=/trunk/; revision=28393
2009-05-18 16:43:48 +00:00
Guy Harris
54c159cb41 Turn on -Wshorten-64-to-32 by default, and fix some issues that turned
up (99 44/100% of which were assignments of double-precision
floating-point constants to floats).  Hopefully this will catch at least
some P64 issues on UN*X.

svn path=/trunk/; revision=28108
2009-04-21 16:57:52 +00:00
Bill Meier
3224dc5d7a Remove unnecessary use of (deprecated) gtk_button_box_set_child_ipadding();
(In each case the arg values used [4,0] were the same as the defaults).
checkAPIs.pl: gtk_button_box_set_child_ipadding: 'W' --> 'E'

svn path=/trunk/; revision=28030
2009-04-10 18:31:01 +00:00
Bill Meier
27024a1d5a As suggested by Jakub Zawadzki: actually use sizeof(...) rather than a numeric constant in various places;
svn path=/trunk/; revision=27800
2009-03-19 17:49:11 +00:00
Stig Bjørlykke
18c5caa3d4 From Jakub Zawadzki:
Use non-formatting functions when appropriate.

svn path=/trunk/; revision=27709
2009-03-12 07:56:42 +00:00
Anders Broman
4175480de6 Get rid of a Clist and move the functon to display floats with two decimals to gui_utils.
svn path=/trunk/; revision=27621
2009-03-06 17:16:56 +00:00
Anders Broman
2c1c572d08 Code cleanup.
svn path=/trunk/; revision=27576
2009-03-02 07:31:06 +00:00
Anders Broman
25e8795a06 gtk_list_store_insert_with_values() requires GTK+ 2.6 or later.
From Jakub Zawadzki further optimisations.

svn path=/trunk/; revision=27555
2009-02-26 20:55:19 +00:00
Anders Broman
0d0d6c6621 Another small performance boost.
svn path=/trunk/; revision=27554
2009-02-26 16:46:00 +00:00
Stephen Fisher
a0b1dcb2a1 Fix (private) bug #3278: When first opening the RTP stream analysis window,
it  hangs for a while before allowing the user to interact with the window.

Fixed by setting columns to fixed height and fixed width.

Also: Don't display columns we were hiding in the CList version of this
window.


svn path=/trunk/; revision=27551
2009-02-26 07:55:09 +00:00
Anders Broman
52d4a85e21 Use gtk_file_chooser_dialog_new().
svn path=/trunk/; revision=27509
2009-02-22 15:23:06 +00:00
Stephen Fisher
01c821cd67 Mark two unused variables
svn path=/trunk/; revision=27490
2009-02-20 17:53:39 +00:00
Anders Broman
590bc1122c Replace the clists with gtk_list_store
Should fix bug https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3246

svn path=/trunk/; revision=27489
2009-02-20 17:13:44 +00:00
Gerald Combs
3bb0df12f5 From babi: Fix three overflows (bugs 3150 and 3151).
From me: Use a #define for the RTP analysis field name lengths.

svn path=/trunk/; revision=27064
2008-12-20 00:07:21 +00:00
Tomas Kukosa
608e51ef4c explicit cast to avoid warning which stops Windows build
svn path=/trunk/; revision=26737
2008-11-10 13:22:18 +00:00
Guy Harris
aa81efc51c Use the standard I/O routines to write out audio files, rather than
doing 1-byte, 2-byte, and 4-byte read() and write() calls.

svn path=/trunk/; revision=26735
2008-11-08 23:36:12 +00:00
Stig Bjørlykke
8608c8f1de Fix some "format not a string literal and no format arguments" warnings.
svn path=/trunk/; revision=26641
2008-10-31 09:53:56 +00:00
Jaap Keuter
d6df3a1f1c Fix for bug 2780:
Correct reverse direction payload save.

svn path=/trunk/; revision=25961
2008-08-08 19:57:50 +00:00
Jeff Morriss
dd6a15e1c7 Don't put (non-extern'd) prototypes for protect_thread_critical_region() and
unprotect_thread_critical_region() in every module in gtk/: instead have those
modules include main.h (which has the properly extern'd prototype).

This should fix the link error on HP-UX described in
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2702

svn path=/trunk/; revision=25933
2008-08-05 17:33:14 +00:00
Bill Meier
d3fc3b6c3e Fix some simple cases of GTK2 deprecated API usage by using a renamed or equivalent API
gtk_button_box_set_spacing()  ==> gtk_box_set_spacing()

svn path=/trunk/; revision=25673
2008-07-08 02:43:40 +00:00
Bill Meier
56206e0002 Fix some simple cases of GTK2 deprecated API usage by using a renamed or equivalent API
gtk_container_border_width()          ==> gtk_container_set_border_width()
  gtk_container_children()              ==> gtk_container_get_children()
  gtk_entry_new_with_max_length()       ==> gtk_entry_new(); gtk_entry_set_max_length()
  gtk_menu_append()                     ==> gtk_menu_shell_append()
  gtk_menu_prepend()                    ==> gtk_menu_shell_prepend()
  gtk_notebook_set_page()               ==> gtk_notebook_set_current_page()
  gtk_paned_gutter_size()               ==> gtk_paned_set_gutter_size()
  gtk_radio_button_group()              ==> gtk_radio_button_get_group()
  gtk_signal_connect()                  ==> g_signal_connect()
  gtk_signal_disconnect()               ==> g_signal_handler_disconnect()
  gtk_signal_emit_by_name()             ==> g_signal_emit_by_name()
  gtk_signal_handler_block_by_data()    ==> g_signal_handlers_block_matched()
  gtk_signal_handler_block_by_func()    ==> g_signal_handlers_block_by_func()
  gtk_signal_handler_unblock_by_data()  ==> g_signal-handlers_unblock_matched()
  gtk_signal_handler_unblock_by_func()  ==> g_signal-handlers_unblock_by_func()
  gtk_spin_button_get_value_as_float()  ==> gtk_spin_button_get_value()
  gtk_toggle_button_set_state()         ==> gtk_toggle_button_set_active()

svn path=/trunk/; revision=25634
2008-06-29 15:51:43 +00:00
Jeff Morriss
a5cee04fad Move the file utility functions from wiretap to libwsutil so that
libwireshark (and the plugins using those functions) do not depend on
wiretap on Windows.

While doing that, rename the eth_* functions to ws_*.

svn path=/trunk/; revision=25354
2008-05-22 15:46:27 +00:00
Stig Bjørlykke
b6de8df503 Force foreground when background is forced in RTP analysis and VOIP calls.
svn path=/trunk/; revision=25212
2008-05-01 18:26:01 +00:00
Ulf Lamping
644a474c95 sort #includes by directories
svn path=/trunk/; revision=24969
2008-04-13 03:32:24 +00:00
Ulf Lamping
d4ccf577a8 where it's not necessary, remove #include "compat_macros.h"
svn path=/trunk/; revision=24922
2008-04-12 01:02:59 +00:00
Ulf Lamping
8e58ec7085 last round to replace SIGNAL_CONNECT with g_signal_connect
svn path=/trunk/; revision=24918
2008-04-11 23:16:06 +00:00
Ulf Lamping
c6d13dc2c8 replace WIDGET_SET_SIZE with gtk_widget_set_size_request
svn path=/trunk/; revision=24910
2008-04-11 20:31:05 +00:00
Ulf Lamping
ae5f841083 replace all appearances of BUTTON_NEW_FROM_STOCK with GTK2's gtk_button_new_from_stock
svn path=/trunk/; revision=24904
2008-04-11 18:58:19 +00:00
Bill Meier
42acebd42c OBECT_..._DATA --> g_object_..._data
svn path=/trunk/; revision=24893
2008-04-11 16:04:54 +00:00
Anders Broman
c973aa3830 Remove:
#ifdef NEED_G_ASCII_STRCASECMP_H
#include "g_ascii_strcasecmp.h"
#endif

svn path=/trunk/; revision=24868
2008-04-09 19:39:58 +00:00
Ulf Lamping
3b7fe5fc6c remove GTK1 code
svn path=/trunk/; revision=24823
2008-04-07 00:42:04 +00:00
Michael Tüxen
4306c7037d Include epan/strutil.h for gtk-1.2 builds.
svn path=/trunk/; revision=24513
2008-03-01 10:23:57 +00:00
Stig Bjørlykke
7deec480ff Next attempt to cleanup some string functions, including:
strncpy -> g_strlcpy, strncat -> g_strlcat

svn path=/trunk/; revision=24504
2008-02-29 13:33:37 +00:00
Sake Blok
c8276a5c91 From Balint Reczey (bug 2233):
The attached patch makes the Statistics -> RTP -> Show All Streams feature of
wireshark accessible via tshark.

I found it helpful in dealing with tons of RTP captures.


svn path=/trunk/; revision=24252
2008-02-03 10:31:55 +00:00
Stig Bjørlykke
10a8f59e03 Rewrote some prohibited APIs in gtk/ (sprintf, strcpy, strcat).
If we get some truncated strings we probably overwrote some buffers...

svn path=/trunk/; revision=24239
2008-02-01 01:07:58 +00:00
Tomas Kukosa
487792b348 save RTP in 16-bit linear PCM instead of 8-bit G.711 u-Law
(preparation for more codecs support via codec plugins)

svn path=/trunk/; revision=23961
2007-12-28 13:01:55 +00:00
Ronnie Sahlberg
e6ed260aca some more path fixes for g_ascii_strcasecmp.h
svn path=/trunk/; revision=23638
2007-11-28 01:31:23 +00:00
Guy Harris
9c89cdaaa3 strcasecmp(), strncasecmp(), g_strcasecmp(), and g_strncasecmp() delenda
est.  Use g_ascii_strcasecmp() and g_ascii_strncasecmp(), and supply our
own versions if they're missing from GLib (as is the case with GLib
1.x).

In the code to build the list of named fields for Diameter, don't use
g_strdown(); do our own g_ascii_-style upper-case to lower-case mapping
in the hash function and use g_ascii_strcasecmp() in the compare
function.

We do this because there is no guarantee that toupper(), tolower(), and
functions that use them will, for example, map between "I" and "i" in
all locales; in Turkish locales, for example, there are, in both
upper case and lower case, versions of "i" with and without a dot, and
the upper-case version of "i" is "I"-with-a-dot and the lower-case
version of "I" is "i"-without-a-dot.  This causes strings that should
match not to match.

This finishes fixing bug 2010 - an earlier checkin prevented the crash
(as there are other ways to produce the same crash, e.g. a bogus
dictionary.xml file), but didn't fix the case-insensitive string matching.

svn path=/trunk/; revision=23623
2007-11-27 18:52:51 +00:00
Jaap Keuter
3f8ffe514f Fix for bug 2000. Make sure that both datalink layer and application layer agree that information is missing before refusing to write a payload.
svn path=/trunk/; revision=23618
2007-11-27 06:49:48 +00:00
Anders Broman
8f1d357618 From Stas Maximov:
RTP analysis' jitter values are thrown off by RTP events
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1076
a) Ephemeral string (packet duration) was inserted into long-term hash of
dynamic payloads
b) There was no clock_rate mapping for MIME type "telephone-event".

svn path=/trunk/; revision=22780
2007-09-04 05:22:43 +00:00
Stephen Fisher
2745f06d96 From Lars Ruoff:
find attached several trivial diffs for viewing RTP SSRC values in Hex
rather than Dec at various places in the UI.
Also includes change from BASE_DEC to BASE_HEX_DEC for corresponding RTP
and RTCP dissector header fields.


svn path=/trunk/; revision=22017
2007-05-31 18:41:25 +00:00
Sebastien Tandel
76729e5d0f From David Howells :
Fix compilation failures when building wireshark-0.99.6-SVN-21916 on an
x86_64-unknown-linux-gnu target with gcc version 4.1.2 20070403 (Red Hat
4.1.2-8).

The failures fall into two categories:
  (1) Casts between pointers and 32-bit integers without an intermediary cast
via 'long' or 'unsigned long'.  This results in a compiler warning complaining
about casts between a pointer and an integer of a different size.
  (2) Passing values to "%lld" or similar printf-style format options that the
compiler thinks are a different size.  Such values need to be cast to 'long
long' or 'unsigned long long'.

svn path=/trunk/; revision=21975
2007-05-29 02:43:18 +00:00