Commit graph

56 commits

Author SHA1 Message Date
Bill Meier
03b57df5a0 Fix various typos and spelling errors.
svn path=/trunk/; revision=35126
2010-12-06 01:34:58 +00:00
Stig Bjørlykke
0ca8c586d3 Use UTF8_HORIZONTAL_ELLIPSIS instead of "..." in menus.
svn path=/trunk/; revision=34346
2010-10-03 16:09:25 +00:00
Anders Broman
9b8d6c102c Remove the depricated GtkItemFactory code.
svn path=/trunk/; revision=34040
2010-09-02 06:22:12 +00:00
Jeff Morriss
8016df02f1 Include stdio.h. Fixup indent some.
svn path=/trunk/; revision=34025
2010-08-30 19:14:54 +00:00
Jeff Morriss
b4c2ed1b86 Remove some unnecessary includes: a lot of things don't need globals.h and register.h
svn path=/trunk/; revision=34017
2010-08-30 16:10:01 +00:00
Anders Broman
21107dff38 Switch to GTK UIManager.
svn path=/trunk/; revision=34002
2010-08-29 19:37:15 +00:00
Bill Meier
9451aa90a7 (Trivial/Cosmetic) Fix signatures of some signal callback functions;
Also:Add some missing G_CALLBACKs (even in commented out code)

svn path=/trunk/; revision=33890
2010-08-23 15:58:48 +00:00
Bill Meier
25c0d9a667 (Trivial) Whitespace cleanup.
svn path=/trunk/; revision=33723
2010-08-05 22:34:59 +00:00
Bill Meier
80fee5052b From Cal Turney: Need 6 dec places of SRT precision in WS SRT dialogs and the values should be rounded to the nearest 1us.
From me: 
 -Slight revision of the patch to prevent overflows 
   when time_t is 32 bits (eg: on 32 bit Linux);
 -Other minor changes.

See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4956

svn path=/trunk/; revision=33721
2010-08-05 22:14:16 +00:00
Anders Broman
2bd73944ff From Didier Gautheron:
Sorting wasn't working right for time columns.

svn path=/trunk/; revision=30336
2009-10-05 17:19:39 +00:00
Anders Broman
e7948dc626 From : Didier Gautheron
A gtk tree view version of service response time.
Tested with AFP and SMB, variable size columns don't look great with SMB though.

svn path=/trunk/; revision=30227
2009-10-01 09:04:23 +00:00
Guy Harris
f844990596 And again.
svn path=/trunk/; revision=28644
2009-06-05 19:12:30 +00:00
Guy Harris
94af3f079e Use time_stat_init() to initialize the statistics for procedures.
svn path=/trunk/; revision=28643
2009-06-05 19:04:05 +00:00
Stig Bjørlykke
7da4ad0c47 - Use the common function for applying a selected filter.
svn path=/trunk/; revision=25314
2008-05-17 23:01:28 +00:00
Ulf Lamping
644a474c95 sort #includes by directories
svn path=/trunk/; revision=24969
2008-04-13 03:32:24 +00:00
Ulf Lamping
d4ccf577a8 where it's not necessary, remove #include "compat_macros.h"
svn path=/trunk/; revision=24922
2008-04-12 01:02:59 +00:00
Ulf Lamping
8e58ec7085 last round to replace SIGNAL_CONNECT with g_signal_connect
svn path=/trunk/; revision=24918
2008-04-11 23:16:06 +00:00
Ronnie Sahlberg
154e8f0892 add missing braces to unbreak the build
svn path=/trunk/; revision=24916
2008-04-11 23:12:24 +00:00
Ulf Lamping
a471e1af90 replace ITEM_FACTORY_ENTRY and ITEM_FACTORY_STOCK_ENTRY with their required data values to build the menus
svn path=/trunk/; revision=24909
2008-04-11 20:21:05 +00:00
Guy Harris
d4672d13f5 Add macros for various filter actions and types, and to combine them
into a callback argument and split a callback argument up.

svn path=/trunk/; revision=23816
2007-12-09 09:04:58 +00:00
Stig Bjørlykke
d3c4d1b221 Do not create an illegal filter when having an empty display filter and
selecting Apply/Prepare "and/or (not) Selected" in Conversations, Endpoints
and Service Response Time.

svn path=/trunk/; revision=23756
2007-12-04 23:47:30 +00:00
Guy Harris
d226610d55 Add a break statement - not necessary in this case, but cleaner, and
matches similar code in other files.

svn path=/trunk/; revision=23744
2007-12-04 07:50:18 +00:00
Stephen Fisher
9d83eb39fc Fix bug #954 for LDAP SRT stats along with the same problem in all the other
SRT code.


svn path=/trunk/; revision=23640
2007-11-28 03:04:09 +00:00
Guy Harris
5a43799a17 Use G_GINT64_MODIFIER, rather than the PRI[douxX]64 macros, for GLib
routines and routines using those routines.  GLib might use different
modifiers for 64-bit quantities than the platform's C library does.

svn path=/trunk/; revision=21990
2007-05-29 18:52:42 +00:00
Sebastien Tandel
76729e5d0f From David Howells :
Fix compilation failures when building wireshark-0.99.6-SVN-21916 on an
x86_64-unknown-linux-gnu target with gcc version 4.1.2 20070403 (Red Hat
4.1.2-8).

The failures fall into two categories:
  (1) Casts between pointers and 32-bit integers without an intermediary cast
via 'long' or 'unsigned long'.  This results in a compiler warning complaining
about casts between a pointer and an integer of a different size.
  (2) Passing values to "%lld" or similar printf-style format options that the
compiler thinks are a different size.  Such values need to be cast to 'long
long' or 'unsigned long long'.

svn path=/trunk/; revision=21975
2007-05-29 02:43:18 +00:00
Ronnie Sahlberg
89f022b12b name change
svn path=/trunk/; revision=18197
2006-05-21 05:12:17 +00:00
Anders Broman
ac54c854d4 From Greg Morris:
epan/dissectors/ncp2222.py - Fixes the NCP group values for all NCP's. Also fixes some additional return values and cleanup.

gtk/ncp_stat.c - Fixes the NCP group values for SRT.

 gtk/service_response_time_table.c:

The SRT is broken if you hit the reload button or apply a filter. The table isn't cleared so each item in the list is duplicated and the second entries remain with initial values. This patch clears the GTK_CLIST so that the redundant entries no longer appear.


svn path=/trunk/; revision=17139
2006-02-01 06:09:55 +00:00
Ulf Lamping
6f43fbb2f0 EVERYTHING IN THE BUILDBOT IS GOING TO BE RED!!! Sorry!
I've done more than a day to change the timestamp resolution from microseconds to nanoseconds. As I really don't want to loose those changes, I'm going to check in the changes I've done so far. Hopefully someone else will give me a helping hand with the things left ...

What's done: I've changed the timestamp resolution from usec to nsec in almost any place in the sources. I've changed parts of the implementation in nstime.s/.h and a lot of places elsewhere.

As I don't understand the editcap source (well, I'm maybe just too tired right now), hopefully someone else might be able to fix this soon.

Doing all those changes, we get native nanosecond timestamp resolution in Ethereal. After fixing all the remaining issues, I'll take a look how to display this in a convenient way...

As I've also changed the wiretap timestamp resolution from usec to nsec we might want to change the wiretap version number...

svn path=/trunk/; revision=15520
2005-08-24 21:31:56 +00:00
Guy Harris
86ea8b88f3 Add a "time_stat_init()" routine to initialize the fields of a
"timestat_t".

Move "nstime_to_msec()" to "epan/nstime.c", as it has nothing to do with
a "timestat_t".

Use structure assignment when possible.

Fix the "addtime()" macro and use it in "time_stat_update()".

Use "timestat_t"s, and the routines to manipulate them, in the service
response time table code.

svn path=/trunk/; revision=15509
2005-08-22 07:12:20 +00:00
Guy Harris
50ed5c9159 Use "g_strdup_printf()" rather than formatting into a fixed-length
buffer and "g_strdup()"ing it.

Use the nstime.c routines to compute time deltas and to add up times.

Don't add rows to the CList until a procedure gets a non-zero call
count, so only the ones with non-zero call counts are displayed (and
especially so that procedure numbers not corresponding to real
procedures aren't displayed!).

Ethereal requires 64-bit integer support, so don't bother checking
whether we have it.

Use the right format for 64-bit integers.

svn path=/trunk/; revision=15506
2005-08-21 21:50:49 +00:00
Ulf Lamping
eafbbbcabb renamed ui_util.c/.h to gui_utils.c/.h to prevent confusion with identical named ui_util.h in / dir
svn path=/trunk/; revision=15465
2005-08-20 12:09:48 +00:00
Jörg Mayer
4e1f4b18ab More char -> const char warning fixes.
Removed (very few) casts that only change the warning message
  but don't remove it (with gcc-4).

svn path=/trunk/; revision=15227
2005-08-05 20:59:08 +00:00
Anders Broman
06067ecc7c Add som more const qualifiers.
svn path=/trunk/; revision=14795
2005-06-27 08:13:41 +00:00
Guy Harris
76258fe8e3 Constify a bunch of structure members and function arguments, to squelch
compiler warnings.

Clean up indentation.

svn path=/trunk/; revision=14739
2005-06-24 01:32:42 +00:00
Guy Harris
71217a8007 As we've made the tap_specific_data field of a tap_packet_t structure a
const pointer (so that we don't get complaints when we make the
tap-specific data argument to "tap_queue_packet()" a const pointer,
allowing dissectors to hand const data to a tap without a complaint), we
should make the tap per-packet function take a const pointer as an
argument as well.  Do so.

In some taps, use _U_, or actually use the argument, rather than
sticking in dummy "X = X" assignments to fake use of parameters.  (This
means that the tap functions in question no longer have the notion that
they act on a particular static structure wired in.)

svn path=/trunk/; revision=12910
2005-01-01 02:57:02 +00:00
Guy Harris
e75910e7cb In column sort routines, make the row pointers "const" pointers, as the
arguments passed in corresponding to those pointers are gconstpointers.

svn path=/trunk/; revision=12884
2004-12-31 00:33:54 +00:00
Guy Harris
8a8b883450 Set the svn:eol-style property on all text files to "native", so that
they have LF at the end of the line on UN*X and CR/LF on Windows;
hopefully this means that if a CR/LF version is checked in on Windows,
the CRs will be stripped so that they show up only when checked out on
Windows, not on UN*X.

svn path=/trunk/; revision=11400
2004-07-18 00:24:25 +00:00
Ulf Lamping
92ddb18b8c move "extern GtkWidget *main_display_filter_widget" from
various stats files to gtkglobals.h

svn path=/trunk/; revision=11073
2004-06-02 07:12:11 +00:00
Ulf Lamping
bd96071d8c rename context menu items:
Match -> Apply as Filter
Prepare -> Prepare a Filter
and prepended a ... at appropriate submenu items

svn path=/trunk/; revision=10814
2004-05-07 12:15:24 +00:00
Ronnie Sahlberg
55aab5b071 make service response time statistics work for "unknown" rpc programs.
all proicedures will however get "interesting" names such as "proc-1" etc
except procedure 0 which is ALWAYS "NULL"

svn path=/trunk/; revision=10557
2004-04-07 04:31:32 +00:00
Ulf Lamping
7b62a629e8 replaced sprintf / snprintf by g_snprintf,
various other string related changes

svn path=/trunk/; revision=10373
2004-03-13 15:15:26 +00:00
Guy Harris
6064ef84c2 Add a "force" argument to "filter_packets()" and
"main_filter_packets()", to force the filtering to be done even if the
filter is the same as the current one; this is necessary in order to
make sure "Follow TCP Stream" gets the packets processed even if you're
filtering the stream that's currently filtered in.

svn path=/trunk/; revision=10209
2004-02-23 22:48:52 +00:00
Ulf Lamping
5297f06717 replaced every appearance of gtk_scrolled_window_new() with
scrolled_window_new().
added gtk_scrolled_window_set_policy(AUTOMATIC,AUTOMATIC) to
scrolled_window_new()
added GTK2's gtk_scrolled_window_set_shadow(GTK_SHADOW_IN)
to every place needed

svn path=/trunk/; revision=9999
2004-02-06 19:19:12 +00:00
Guy Harris
1980fa5dbf Pass ESD_BTN_OK rather than NULL as a second argument to
"simple_dialog()"; NULL might be #defined to be a pointer expression on
some platforms, causing compiler warnings (and, on platforms where a
null pointer doesn't have all its bits 0, possibly causing misbehavior,
although I don't think there are any such platforms on which Ethereal
runs).

Don't allow 0 as button mask argument to "simple_dialog()".

Squelch a compiler warning.

Report fatal problems as errors, not warnings.

Report file I/O errors with "file_open_error_message()".

Report file write errors (including those reported by "close()", e.g.
some errors writing to an NFS server) when saving raw packet data to a
file.

svn path=/trunk/; revision=9915
2004-01-31 03:22:42 +00:00
Ulf Lamping
c890e29a99 apply automatically generated filters strings to the recent dropdown list,
e.g. when applying a "Follow TCP stream",
fix a bug in the recent function, discarding the newest entries when
saving a full list (now discarding the oldest).

svn path=/trunk/; revision=9849
2004-01-25 18:51:26 +00:00
Guy Harris
64bc566ea8 In GTK+ 2.x, "gtk_entry_get_text()" returns a "const gchar *"; assign
its value to pointer-to-const variables.

svn path=/trunk/; revision=9161
2003-12-04 00:45:39 +00:00
Ronnie Sahlberg
f16f83b154 update for LDAP
measure the response time for some LDAP commands and
add a service response time dialog for it

svn path=/trunk/; revision=8885
2003-11-05 09:04:17 +00:00
Ronnie Sahlberg
e75b86fab1 Add a ColorizeProcedure menu option to the ServiceResponseTime statistics dialog
svn path=/trunk/; revision=8659
2003-10-10 08:59:17 +00:00
Ronnie Sahlberg
8969b36861 Add a Find Next/Previous menu option to the ServiceResponseTimeStatistics dialog
svn path=/trunk/; revision=8658
2003-10-10 08:52:19 +00:00
Ronnie Sahlberg
95b3b8ca6d Add a popup to the ServicveResponseTime tables where the user can select
Prepare/Match/FindFrame similar to chat the ConversationList has.

Only enabled for SMB and ONC-RPC at this point

svn path=/trunk/; revision=8391
2003-09-05 10:26:44 +00:00