Commit Graph

57 Commits

Author SHA1 Message Date
Guy Harris 1bc049906a Add some GCC warnings to the standard set, and add some others to the
--enable-extra-gcc-checks set.

If we turn on -pedantic, try turning on -Wno-long-long as well, so that
it's not *so* pedantic that it rejects the 64-bit integral data types
that we explicitly require.

Constify a bunch of stuff, and make some other changes, to get rid of
warnings.

Clean up some indentation.

svn path=/trunk/; revision=21526
2007-04-23 10:59:26 +00:00
Jeff Morriss 3f68c1395b Fix a couple warnings
svn path=/trunk/; revision=21446
2007-04-16 08:37:39 +00:00
Jeff Morriss 755698ebcf Fix bug 1508:
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1508

Dissect ISUP CIC as 14 bits in ANSI (instead of 12 bits like in ITU)


svn path=/trunk/; revision=21310
2007-04-03 06:27:18 +00:00
Gerald Combs 063621f11b Fix potential buffer overruns in address_to_str_buf() found by Andrej
Mikus.  Add a buf_len parameter to ip_to_str_buf(), and make sure it's 
enforced.  Copy the release notes over from the 0.99.5 trunk and add a
note about the ISUP dissector (which is affected by the overrun).

svn path=/trunk/; revision=20607
2007-01-29 20:25:26 +00:00
Anders Broman dc10ba22e6 Fix Event dissection which was broken when going to V3.
and add a few parameters.

svn path=/trunk/; revision=19544
2006-10-15 22:11:26 +00:00
Anders Broman ed0cf1e0bb H248:
Lost a line in last commit.

ISUP Export a value string.

svn path=/trunk/; revision=19454
2006-10-08 20:57:20 +00:00
Anders Broman 1785428d4c Add a few packages and fix dissecton of a_codecs and handle the case when
hf_param = -1.

svn path=/trunk/; revision=19445
2006-10-06 19:48:00 +00:00
Anders Broman 2c39ec122c From Jeff Morriss:
- changes the ISUP dissector preference to follow MTP3's preference 
rather than having its own (similar to SCCP, M3UA, etc.).  I did not 
obsolete the old preference because it was never put out in a release 
(only SVN users would have seen it).  I can change that if desired.

- add dissection of ANSI CRM message

svn path=/trunk/; revision=18661
2006-07-05 05:11:22 +00:00
Ronnie Sahlberg feab79e328 change a whole bunch of ethereal into wireshark
svn path=/trunk/; revision=18196
2006-05-21 04:49:01 +00:00
Anders Broman 7c4b8c8b88 Fix Bug 938 ISUP IAM message marked as Malformed packet - Location number without address digits
wrongly decoded.

svn path=/trunk/; revision=18138
2006-05-11 20:32:43 +00:00
Anders Broman 0167df6139 col_append_str() instead of col_set_str() by mistake.
svn path=/trunk/; revision=18087
2006-05-03 19:32:27 +00:00
Anders Broman f9468fe33f Add some more ANSI Message types and Parameters dissect ANSI cause.
svn path=/trunk/; revision=18000
2006-04-25 19:12:08 +00:00
Anders Broman 75b44d4de7 Preparations to include ANSI ISUP dissection.
svn path=/trunk/; revision=17981
2006-04-24 19:11:33 +00:00
Jaap Keuter ada5c36ff3 From: Shashidhar Bhandare
I have added ISUP dissector support for decoding four ANSI ISUP messages for decoding: CRM, CRA, CVT and CVR

svn path=/trunk/; revision=17939
2006-04-20 21:17:18 +00:00
Jaap Keuter b21337192c From Olivier Jacques:
- to_str.c: add support of "AT_NONE" address type in address_to_str_buf (avoid the assert failed later on
when messages have address type of AT_NONE - which can be the case for an MTP2 capture with FISU messages)
- packet-isup.c: changed source and destination addresses from (net_src and net_dst) to (src and dst) so 
that addresses taken into account in the statistics are the SS7 point codes

svn path=/trunk/; revision=17720
2006-03-24 14:26:01 +00:00
Anders Broman ee72a05d9c Fix bug 786
There is error when ethereal dissects UMTS AMR codec info.
The "Initial Codec Mode" does not exist in 3GPP TS 26.103(v4.a.0)
but OM(Optimization Mode) is correct parameter.

svn path=/trunk/; revision=17458
2006-03-04 10:07:19 +00:00
Anders Broman 47b86c517e Bugfix: Dissect BAT ASE Signal IE properly.
svn path=/trunk/; revision=17428
2006-02-28 17:01:29 +00:00
Jörg Mayer f9a57f08d1 Bill Meier:
Spelling fixes.

svn path=/trunk/; revision=16956
2006-01-05 13:01:08 +00:00
Anders Broman 8d05164bec Get rid of duplicted dissector tables for MTP3 Service indicator and SCCP ssn:s
svn path=/trunk/; revision=16815
2005-12-16 07:05:50 +00:00
Guy Harris 66c394806a "a & b == c" is, in C, parsed as "a & (b == c)" - and if b and c are the
same, and have only one bit set, "(a & b) == c", which is what is
intended, is the same as "a & b".

In addition, we don't want to do desegmentation if "isup_apm_desegment"
isn't set, so that test should be ANDed with the other two tests.

svn path=/trunk/; revision=16792
2005-12-14 07:33:07 +00:00
Anders Broman da8debc2ec Change reassembly to include first empty segment, check if SLR exists.
Change pinfo->src/dst to use SS7 address for reassembly to use the correct key.

svn path=/trunk/; revision=16781
2005-12-13 21:14:54 +00:00
Guy Harris 4ca1ee0a89 Fix some bit mask tests - & has lower priority than !=, so "a & b != c"
means "a & (b != c)", not "(a & b) != c".

Put in a comment noting a potential problem with defragmentation,
pointed out by a compiler warning that apm_Segmentation_local_ref might
not be set before it's used.

svn path=/trunk/; revision=16779
2005-12-13 10:59:33 +00:00
Anders Broman e8997a0478 Reassmble apm messages.
svn path=/trunk/; revision=16765
2005-12-12 15:17:53 +00:00
Anders Broman fa3b1f1424 Handle empty APM message
svn path=/trunk/; revision=16644
2005-12-01 20:29:24 +00:00
Anders Broman f082fe8ecf ISUP - Export functions used by INAP and Camel
Gsmmap - Export asn1 structs used by Camel
Camel - Use functions from GSMMAp and ISUP
INAP - Rewrite of the asn1 code to correspond more to CS1 data types
          Let ISUP and Q931 dissect apropriate stuff.

svn path=/trunk/; revision=16624
2005-11-29 17:23:50 +00:00
Anders Broman 7c8d0dad93 Decose APN messages correctly.
svn path=/trunk/; revision=16514
2005-11-16 20:03:09 +00:00
Anders Broman 260853d5b4 fix:
Malformed packet IAM, Calling party number 
Application transport -  some code clean up. 
bug 551 Nor Med PC ethereal-bugs@ethereal.com NEW SS7, ISUP, IAM-signal, malformed packet (not) 
Bug 554 Min Low PC ethereal-bugs@ethereal.com NEW ETSI codec dissection error in BICC 

svn path=/trunk/; revision=16476
2005-11-11 22:05:21 +00:00
Anders Broman b2ec8c9ca4 Bug fix to dissection of NSAP E164 Country codes
svn path=/trunk/; revision=16419
2005-11-07 19:39:02 +00:00
Anders Broman 7cfbacfb79 Handle a optional parameter length of zero.
svn path=/trunk/; revision=16382
2005-11-02 21:49:24 +00:00
Guy Harris b7b80d94be Move a pile of protocol-related headers from the top-level source
directory to the epan directory.  Some of them should perhaps ultimately
be moved to epan/dissectors, if they pertain only to stuff exported by a
particular dissector.

Fix Gerald's e-mail address in files we're moving.

svn path=/trunk/; revision=15844
2005-09-17 00:02:31 +00:00
Guy Harris 346e5e211c The previous checkin for packet-isup.c was accidentally checked in along
with some unrelated changes; it got rid of some calls to get IPv4/IPv6
addresses and add them to the protocol tree, replacing them with
proto_tree_add_item() calls, and fixed up the length of one protocol
tree item.

Note that we have (at least) three count 'em three different routines
for dissecting/displaying NSAPs (there might be more - I might have
missed some), and suggest that we might want to reduce that to one.

Update the URL for ICP values for IPv{4,6} addresses inside NSAPs.

Fix the offset in the call to add the IPv6 address part of an NSAP
containing such an address, and the length in the call adding the DSP
for an NSAP containing an IPv4 address.

Fix up indentation a bit.

svn path=/trunk/; revision=15766
2005-09-12 07:44:11 +00:00
Guy Harris 39fd819fb4 Don't collide with the "regular" IPv6 defintions in at least some
platforms in ipv6-utils.h.

svn path=/trunk/; revision=15764
2005-09-12 06:21:35 +00:00
Guy Harris 25c4bc9379 Replace tvb_memcpy() calls that extract IPv4 addresses into a guint32,
and that extract IPv6 addresses into a "struct e_in6_addr", with
tvb_get_ipv4() and tvb_get_ipv6() calls - except for some that we
remove, by using proto_tree_add_item(), rather than replacing.

Have epan/tvbuff.h include epan/ipv6-utils.h, to define "struct
e_in6_addr" (not necessary to declare the tvbuff routines, but including
it there means "struct e_in6_addr" is guaranteed to be defined before
those declarations, so we don't get compiler complaints if we define it
*after* those declarations).

svn path=/trunk/; revision=15758
2005-09-11 21:25:37 +00:00
Ulf Lamping 0dc9fb3d4a various code cleanup:
-use g_snprintf instead of sprintf and snprintf
-use g_strdup_printf where appropriate
-remove #include "snprintf.h" (as only g_snprintf should be used)
-replace some more alloc/realloc/calloc/free with their glib pendants

svn path=/trunk/; revision=15264
2005-08-08 18:50:39 +00:00
Jörg Mayer 7b2ff03d8c Fix more "no previous declaration" warnings
svn path=/trunk/; revision=15169
2005-08-02 04:31:42 +00:00
Luis Ontanon 411ab7fa9d fix a leak of tap info data by replacing g_strdup with ep_strdup
svn path=/trunk/; revision=15032
2005-07-24 03:05:08 +00:00
Anders Broman 98de72d588 Register the ISUP dissector to make it callable through
call_dissector()

svn path=/trunk/; revision=14541
2005-06-03 09:56:03 +00:00
Luis Ontanon 3f36640526 - add an isup stats_tree with statistics regarding message types and the directions in which they flow.
svn path=/trunk/; revision=14393
2005-05-18 13:51:49 +00:00
Luis Ontanon 5535853bf2 - export Audio Codec modes from isup/bicc
- detailed dissection of GSM/UMTS speech code list ETSI 126 103 (3gpp 26.103 v3.0.0)
- use it for H.248


svn path=/trunk/; revision=14343
2005-05-10 21:54:37 +00:00
Gerald Combs f8765a5a28 From Cvetan Ivanov:
1) dissect_isup_calling_party_number_parameter reported malformed packet
if the calling party number IE contains empty number (possibly with
presentation set to 'number not available')

I've basicly added if(length > 0) around the digits tree dissector,
which may not be obvious from the patch becase of the indenting of the
entire block.

2) As the tap_calling_number is static, if there is call with missing
calling_party_number IE, it gets assigned the calling party number of
the previuos call containing such IE.

fixed by adding tap_calling_number = NULL;
in the beginning of dissect_isup_message, and

tap_rec.calling_number=tap_calling_number?tap_calling_number:g_strdup("");

in the end to avoid segfault

Those things may not happen too often in the telecom world, but happen
all the time with VoIP.


svn path=/trunk/; revision=14268
2005-05-02 14:41:07 +00:00
Gerald Combs 89c4f03738 The previous changes were causing weird exception errors. Back them out,
and simply check the length of each buffer.

svn path=/trunk/; revision=14236
2005-04-30 00:28:05 +00:00
Gerald Combs d11d3d6f8d Use GStrings instead of character arrays, so that we don't overflow any
buffers.  Found during fuzz testing.

svn path=/trunk/; revision=14233
2005-04-29 16:39:20 +00:00
Anders Broman 87f8d7b412 From Jacques Olivier :
Export callingPartyNumber and CalledPartyNumber parameter dissection .

svn path=/trunk/; revision=14086
2005-04-15 08:14:44 +00:00
Ronnie Sahlberg f16afe28a9 From Cvetan Ivanov
Updates to Q931, SM and ISUP


svn path=/trunk/; revision=14013
2005-04-04 07:40:07 +00:00
Anders Broman 9645994141 Export q850_cause_code_vals as its's used by other dissector(s)
svn path=/trunk/; revision=13860
2005-03-22 15:33:50 +00:00
Guy Harris fa7eb4fdeb From Anders Broman: fix a fault in the CODEC LIST routine where offset
was wrongly calculated, and clean up some other miscellaneous stuff.

svn path=/trunk/; revision=13580
2005-03-03 10:23:29 +00:00
Anders Broman 72468bb0e5 From Francisco Alcoba:
Patch for graphing ISUP calls. It shows the type of message, 
in the first one the calling and called numbers, and in the second the SPs 
and CIC; in releases it shows the cause value.

svn path=/trunk/; revision=13263
2005-02-03 21:51:35 +00:00
Lars Roland 197ceddab1 From Alejandro Vaquero:
h323 taps support up to 5 messages per packet now.

VoIP call analysis:
      - Collect ISUP, SIP and H323 calls from a capture and show them in window with the following info:
      - Start and Stop time of the call
      - Init

svn path=/trunk/; revision=13225
2005-02-01 12:12:35 +00:00
Guy Harris 3404da87fd Just use the parameter type definitions, and value_string table, from
the ISUP dissector; if that's not the right thing to do, put the old
tables back and *don't* include "packet-isup.h".

svn path=/trunk/; revision=12688
2004-12-08 05:58:59 +00:00
Anders Broman 7e6f597dd5 From Martin Regner add the possibillity to disscet BICC over SCTP
svn path=/trunk/; revision=12539
2004-11-17 19:33:31 +00:00