Commit Graph

9504 Commits

Author SHA1 Message Date
Anders Broman 85b2749d36 From Mithun Roy:
DTN Dissector Bugs.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4500

svn path=/trunk/; revision=31929
2010-02-20 11:06:16 +00:00
Guy Harris 13c971dde3 We don't call assert() (and shouldn't - dissectors should use
DISSECTOR_ASSERT(), so the dissection stops, but the app continues to
run), so we don't need to include <assert.h>.

svn path=/trunk/; revision=31928
2010-02-19 23:45:31 +00:00
Jaap Keuter f7e082ad35 Add expert items for missing end option in:
- vendor option field
- overloaded sname field
- overloaded file name field

Improve the overload determination of sname and file name field.

svn path=/trunk/; revision=31927
2010-02-19 22:46:07 +00:00
Guy Harris 9a5521a819 Fix tpyo.
svn path=/trunk/; revision=31924
2010-02-19 17:51:36 +00:00
Guy Harris 1b59a2446f Clean up decryption; have it return various indications for whether it
was able to decrypt and, if it wasn't, why it wasn't, and put that
information into an expert information indication.

svn path=/trunk/; revision=31922
2010-02-19 10:24:13 +00:00
Jaap Keuter 4ab14bc71e Ditch the last direct indexed character array.
And some minor formatting updates.

svn path=/trunk/; revision=31921
2010-02-19 07:43:26 +00:00
Martin Mathieson 7b2a3c26e6 Recognise update string for SR failure, and show ueid in MAC if set.
svn path=/trunk/; revision=31916
2010-02-18 21:24:47 +00:00
Jaap Keuter 6e795990fb The evil bit IS a security issue.... ;)
svn path=/trunk/; revision=31915
2010-02-18 20:58:04 +00:00
Anders Broman 48746a9fe7 Add a protocol reference.
svn path=/trunk/; revision=31914
2010-02-18 06:32:23 +00:00
Anders Broman d8684d1d8d Cleanup of DECT dissector INFO column.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4502
- remove check_col()

svn path=/trunk/; revision=31913
2010-02-18 06:18:34 +00:00
Anders Broman 802b91ecdb A stab in the dark at deissecting IS-637-A decoding for the CDMA SMS data Message Body.
svn path=/trunk/; revision=31903
2010-02-17 16:47:02 +00:00
Bill Meier b9b7b1a57a Keep gcc happy.
svn path=/trunk/; revision=31901
2010-02-16 21:22:55 +00:00
Bill Meier 5b9cba54e3 Various relatively small changes:
- #include stdio, stdlib, string not req'd.
- Use less generic macro names for a few defines.
- Fix some gcc -Wshadow warnings.
- Use the "standard idiom" for handling port preferences;
  (Doing port add/delete via a registered_init routine is not req'd).
- fix a typo.


svn path=/trunk/; revision=31900
2010-02-16 21:17:26 +00:00
Bill Meier ae429401e6 Fix a (small) memory leak.
svn path=/trunk/; revision=31899
2010-02-16 20:44:39 +00:00
Bill Meier 0958c9f41b Do SVN #31896 in a (somewhat) better way.
svn path=/trunk/; revision=31897
2010-02-16 19:57:46 +00:00
Bill Meier ec023d7c92 Properly specify the IKE2 Decryption table default Encryption & Integrity Algorithms;
This ensures that the correct defaults are shown when creating a new entry 
in the IKEV2 Decryption Table.

svn path=/trunk/; revision=31896
2010-02-16 19:29:07 +00:00
Bill Meier a1149978bd From Yaniv Kaul: minor changes + smallest additions
See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4339#c5

From Me:
 - Use VNC_... as the initial part of various enum identifiers to
   ensure that they are unique since they are part of the global namespace;
 - Fix some indentatiom;

svn path=/trunk/; revision=31876
2010-02-13 16:42:01 +00:00
Bill Meier a8a673ef42 Fix some indentation.
svn path=/trunk/; revision=31875
2010-02-13 16:28:32 +00:00
Bill Meier 629a186c14 From Mike Sager: NFS: parse RECLAIM_COMPLETE op
See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4469

svn path=/trunk/; revision=31874
2010-02-13 16:25:30 +00:00
Jaap Keuter 3126f22a14 From Owen Kirby:
This patch fixes a bug in the 6LoWPAN dissectors that corrupts addresses when
multicast address compression is used. Testing this fix also uncovered a bug in
the computation of the length of the extension headers. And some typos.

svn path=/trunk/; revision=31870
2010-02-12 22:10:53 +00:00
Gerasimos Dimitriadis f8d7a4c4b4 Show the substrings of AUTN and AUTS. Expert info warnings
when their lengths is not the expected one.

svn path=/trunk/; revision=31869
2010-02-12 21:57:07 +00:00
Gerasimos Dimitriadis 448b9a5199 Fix for Bug 4480:
Octet containing first digit of IMEI(SV) highlighted
when IMEI(SV) selected

svn path=/trunk/; revision=31868
2010-02-12 20:52:54 +00:00
Gerasimos Dimitriadis fab0f16c18 Create FT_BYTES fields for the RAND, AUTN, SRES, XRES
and AUTS octet strings in DTAP

svn path=/trunk/; revision=31859
2010-02-10 22:34:34 +00:00
Jeff Morriss 8634f52025 Add SVN Id tag
svn path=/trunk/; revision=31855
2010-02-10 16:08:16 +00:00
Guy Harris deccd41b15 No need for cvse_reserved as a variable; getting rid of it squelches a
compiler warning.

svn path=/trunk/; revision=31854
2010-02-10 08:20:55 +00:00
Anders Broman 8f5b2d749b Define VENDOR_VERIZON in sminmpec.h
svn path=/trunk/; revision=31853
2010-02-10 07:21:51 +00:00
Anders Broman 047f688a5c From yi ren:
CVSE fields for MIP protocol is not correctly decoded.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4477
From me:
- Fixed hf blurbs.
- FT_BYTES, BASE_NONE
- Updated value_strings from IANA registery.

svn path=/trunk/; revision=31852
2010-02-10 06:59:26 +00:00
Bill Meier 9a3b1a78d1 Fix some memory leaks; Fix some indentation.
This is a re-submission of SVN #31838 this time
properly using g_list_free() instead of g_free().

svn path=/trunk/; revision=31848
2010-02-09 17:48:41 +00:00
Bill Meier 9fc016d8b9 Revert SVN #31838; It's NG.
svn path=/trunk/; revision=31847
2010-02-09 14:43:30 +00:00
Guy Harris 161c33aadb Don't trust the length field in a V5 sample to be valid.
This appears to fix bug 4473.

svn path=/trunk/; revision=31846
2010-02-09 10:17:53 +00:00
Guy Harris 07922081ff Do all the missing dissectors the same way.
Oh, and there's no dissector registered as "atm" - and, if there were,
it probably wouldn't be able to handle AAL5 packets by themselves, as
you'd probably have to supply pseudo-header information (where does the
VPI/VCI come from, for example?).

This fixes bug 4471.

svn path=/trunk/; revision=31845
2010-02-09 09:52:10 +00:00
Jaap Keuter 3c702d064b From Owen Kirby:
This patch fixes a bug in the 6LoWPAN dissector where link-local addresses
created from an EUI-64 address do not correctly invert the universal/local bit
as recommended by section 4 of RFC2464.

svn path=/trunk/; revision=31843
2010-02-09 08:40:40 +00:00
Ronnie Sahlberg 7d52b73e5d these two guys are actually range-strings and not value-string
so it is surprising we didnt catche these before.


gcc complains about strict alignment on these



svn path=/trunk/; revision=31842
2010-02-09 07:42:38 +00:00
Anders Broman 96bcad4ea8 Initialize sub_cfg_attr_type_tree.
svn path=/trunk/; revision=31841
2010-02-09 06:52:49 +00:00
Anders Broman bceda505c0 From Alexis La Goutte:
ISAKMP Enhancements.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2905

svn path=/trunk/; revision=31840
2010-02-09 06:15:49 +00:00
Anders Broman c2f165f2e0 Another BASE_NONE.
svn path=/trunk/; revision=31839
2010-02-09 05:55:39 +00:00
Bill Meier b3be21c93b Fix some memory leaks; Fix some indentation.
svn path=/trunk/; revision=31838
2010-02-08 23:45:10 +00:00
Guy Harris f329e32f09 Terminate a value_string, and get rid of a non-ASCII character.
(No ligatures, please.)

svn path=/trunk/; revision=31837
2010-02-08 22:40:27 +00:00
Ronnie Sahlberg 118377ca6b flag two unusued arguments with _U_ to prevent a compiler warning
svn path=/trunk/; revision=31836
2010-02-08 22:35:49 +00:00
Anders Broman b18d2bc900 Fix field base.
svn path=/trunk/; revision=31833
2010-02-08 21:15:54 +00:00
Anders Broman fde5ff4c56 From Yi Yu:
Enhanced sFlow dissector.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3543

svn path=/trunk/; revision=31832
2010-02-08 21:01:21 +00:00
Bill Meier 0880d9865c (Minor) Fix code so port pref change actually deletes the previous dissector port registration
svn path=/trunk/; revision=31831
2010-02-08 19:30:32 +00:00
Bill Meier 1a203c17b5 (Trivial): remove an incorrect _U_ in a few cases.
svn path=/trunk/; revision=31830
2010-02-08 18:54:31 +00:00
Bill Meier a2a0eb4767 (Trivial changes):
#include <stdio.h> not req'd; 
  localize two variables; 
  remove two unneeded forward reference declarations.

svn path=/trunk/; revision=31829
2010-02-08 18:32:20 +00:00
Martin Mathieson 2e08a73235 Add preference that allows RLC PDUs embedded inside MAC info to be seen nicely in the info column
svn path=/trunk/; revision=31828
2010-02-08 15:01:08 +00:00
Ronnie Sahlberg b4c02070e8 try autogenerate lsa in preparation for updates to the lsa idl file
svn path=/trunk/; revision=31827
2010-02-08 01:48:33 +00:00
Ronnie Sahlberg ba234c5206 add a macro to handle types that are 2 bytes in ndr and 4 bytes in
ndr64, i.e. enums.


svn path=/trunk/; revision=31826
2010-02-08 00:48:45 +00:00
Ronnie Sahlberg 9b5ed8bf3b Flag the arguments as _U_ so that we dont fail the build with "unusued
parameter" warnings if we build without libgcrypt



svn path=/trunk/; revision=31825
2010-02-08 00:14:40 +00:00
Bill Meier e74e2a598c Fix and rework some code a bit:
-No prefs so prefs calback not req'd;
-Remove (seemingly) not needed dissector registration on UDP port 0;
-Rework dissect_applemidi_heur() and related so that once dissect_applemidi_heur()
  determines that a pair of UDP addr/ports are being used for the AppleMIDI protocol,
  dissect_apple_midi() will always be called directly for UDP packets with that pair 
  (rather than dissect_applemidi_heur() always be called for every packet).

svn path=/trunk/; revision=31824
2010-02-07 23:51:56 +00:00
Guy Harris 7a4031e31d More uninitialized-variable warning squelching.
svn path=/trunk/; revision=31823
2010-02-07 20:45:49 +00:00