osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity
86,565 Commits 23 Branches 0 Tags 1.3 GiB
Commit Graph

14 Commits

Author SHA1 Message Date
João Valverde 8efad466c4 Tools: Fix fix-encoding-args.pl ASCII string validation 
Do not require a useless ENC_NA parameter for string encodings.
FT_STRING and FT_STRINGZ types don't have any ndianness.

Follow-up to 6ec429622c.
 2022-02-15 11:38:16 +00:00
Evan Huus d6d7dd1e56 First pass pinfo->pool conversion 
Automated find/replace of wmem_packet_scope() with pinfo->pool in all
files where it didn't cause a build failure.

I also tweaked a few of the docs which got caught up.
 2021-07-21 05:38:29 +00:00
Dario Lombardo 1eff9c8982 rbm: fix compiler warnings. 2020-12-28 10:00:46 +00:00
Anders Broman ebf3d6dbf1 Try to fix -Wpointer-sign warnings. 
Change-Id: I7ff23aeee13b8f42a2fa2e68db11fcfff9b0816e
Reviewed-on: https://code.wireshark.org/review/38141
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 2020-08-12 12:12:25 +00:00
Anders Broman dc42e2b1cb file-rbm: Fix -Wpointer-sign warnings. 
Change-Id: I53e84e172e1c03849158ba6df83aa2ff9cfb3054
Reviewed-on: https://code.wireshark.org/review/37766
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 2020-07-07 08:41:54 +00:00
Guy Harris 20800366dd HTTPS (almost) everywhere. 
Change all wireshark.org URLs to use https.

Fix some broken links while we're at it.

Change-Id: I161bf8eeca43b8027605acea666032da86f5ea1c
Reviewed-on: https://code.wireshark.org/review/34089
Reviewed-by: Guy Harris <guy@alum.mit.edu>
 2019-07-26 18:44:40 +00:00
Martin Kaiser e08937ac44 rbm: fix a bunch of used-but-marked-unused warnings 
file-rbm.c:143:34: error: 'tree' was marked unused but was used
        proto_tree_add_int_format_value(tree, hf_rbm_integer, tvb, *offset, len, value, "%d", value);
                                        ^
file-rbm.c:374:23: error: 'offset' was marked unused but was used
        gint offset_start = *offset;
                             ^
file-rbm.c:375:48: error: 'tree' was marked unused but was used
        proto_tree* drb_tree = proto_tree_add_subtree(tree, tvb, *offset, 0, ett_variable, NULL, "Objects");
                                                      ^
file-rbm.c:375:54: error: 'tvb' was marked unused but was used
        proto_tree* drb_tree = proto_tree_add_subtree(tree, tvb, *offset, 0, ett_variable, NULL, "Objects");
                                                            ^
file-rbm.c:375:60: error: 'offset' was marked unused but was used
        proto_tree* drb_tree = proto_tree_add_subtree(tree, tvb, *offset, 0, ett_variable, NULL, "Objects");
                                                                  ^
file-rbm.c:376:21: error: 'tvb' was marked unused but was used
        dissect_rbm_object(tvb, pinfo, drb_tree, offset, NULL, NULL);
                           ^
file-rbm.c:376:26: error: 'pinfo' was marked unused but was used
        dissect_rbm_object(tvb, pinfo, drb_tree, offset, NULL, NULL);
                                ^
file-rbm.c:376:43: error: 'offset' was marked unused but was used
        dissect_rbm_object(tvb, pinfo, drb_tree, offset, NULL, NULL);
                                                 ^
file-rbm.c:377:21: error: 'tvb' was marked unused but was used
        dissect_rbm_object(tvb, pinfo, drb_tree, offset, NULL, NULL);
                           ^
file-rbm.c:377:26: error: 'pinfo' was marked unused but was used
        dissect_rbm_object(tvb, pinfo, drb_tree, offset, NULL, NULL);
                                ^
file-rbm.c:377:43: error: 'offset' was marked unused but was used
        dissect_rbm_object(tvb, pinfo, drb_tree, offset, NULL, NULL);
                                                 ^
file-rbm.c:378:32: error: 'offset' was marked unused but was used
        proto_item_set_len(drb_tree, *offset - offset_start);
                                      ^
file-rbm.c:526:26: error: 'pinfo' was marked unused but was used
                expert_add_info_format(pinfo, tree, &ei_rbm_version_unsupported, "Version %u.%u is not supported (only %u.%u)",

Change-Id: Id255df237c43c313720797a46c0e877f0f7550e0
Reviewed-on: https://code.wireshark.org/review/33370
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
 2019-05-26 19:04:08 +00:00
Gerald Combs 108507e504 Rbm: Be more strict about unknown object types. 
Stop dissection if we encounter an unknown object type.

Update .editorconfig while we're here.

Bug: 15612
Change-Id: I91c0868c376c2b50645af997e0bf84e5c90a512b
Reviewed-on: https://code.wireshark.org/review/32523
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Dario Lombardo <lomato@gmail.com>
 2019-03-22 18:22:49 +00:00
Dario Lombardo 5404cbbc7f drb/rbm: fix indentation issues. 
Change-Id: I88833aa443534b54af7890afa257fd9a0f12ca9e
Reviewed-on: https://code.wireshark.org/review/28430
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 2018-06-25 17:55:14 +00:00
Dario Lombardo 8e270f854e rbm: remove unused ei field. 
Change-Id: I007d26f93e6c69d219200d743e1a1a3f8a32cd9d
Reviewed-on: https://code.wireshark.org/review/28324
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 2018-06-18 14:23:01 +00:00
Dario Lombardo 7fca68fb7c rbm: fix no previous prototype. 
Change-Id: If2af62e7284b53acd6a3258f1d60ee547f887b5f
Reviewed-on: https://code.wireshark.org/review/28323
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 2018-06-18 14:22:46 +00:00
Dario Lombardo 9055584dce rbm: improve fields layout and decode more types. 
Change-Id: Ib16118e9c0ce5b612ae1dcb6c678224a79889a93
Reviewed-on: https://code.wireshark.org/review/28287
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Dario Lombardo <lomato@gmail.com>
 2018-06-16 20:34:04 +00:00
Dario Lombardo 0ac8960b9f rbm: fix compilation with gcc-8. 
Change-Id: If9ce8f6c4c2145f332be9e8a95d720e6fe0c6304
Reviewed-on: https://code.wireshark.org/review/28082
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Dario Lombardo <lomato@gmail.com>
 2018-06-07 15:21:36 +00:00
Dario Lombardo 500102c265 add file dissector for ruby marshal objects. 
Documentation: https://ruby-doc.org/core-2.5.0/Marshal.html

Bug: 14730
Change-Id: If5d3bd2eaf261b4bc7a7df4ac15098503081dd9f
Reviewed-on: https://code.wireshark.org/review/27764
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 2018-06-07 08:20:14 +00:00