Commit graph

38842 commits

Author SHA1 Message Date
Chris Maynard
3db18f185e Fix some typos.
svn path=/trunk/; revision=40787
2012-02-01 02:05:19 +00:00
Chris Maynard
f88e871171 Fix some typos.
svn path=/trunk/; revision=40786
2012-02-01 01:41:11 +00:00
Guy Harris
afdf8061a1 Let's make all offsets within the packet guints. (In most of the API,
they're signed, but that's only to handle "offset from the end" - we
should probably get rid of that and make them unsigned.)

svn path=/trunk/; revision=40785
2012-01-31 23:36:52 +00:00
Jeff Morriss
0db7fc9dfc Heuristic standard tuning:
- Handle ERR and IT messages.
 - When checking variable parameter lengths, check that we have enough data
   remaining (by adding the current offset to the retrieved length).
 - Check the lengths of several more messages.
 - When checking the length, add up the values of the parameter length macros
   to make it obvious how we came to use that value.

svn path=/trunk/; revision=40784
2012-01-31 23:06:27 +00:00
Jeff Morriss
9e9553003d Use PINFO_FD_NUM and PINFO_FD_VISITED
svn path=/trunk/; revision=40783
2012-01-31 20:40:29 +00:00
Jeff Morriss
b0ab8e5df4 Improve heuristic standard detection:
- Make sccp_called_calling_looks_valid() static.
 - Reject GT-routed Class-2 (it's not used).
 - Handle UDTS.
 - Handle optional pointer on several messages.

svn path=/trunk/; revision=40782
2012-01-31 04:02:08 +00:00
Bill Meier
cf24e97617 Compile .cpp files with CXXFLAGS the same as CFLAGS used for compiling .c files.
svn path=/trunk/; revision=40781
2012-01-30 23:55:34 +00:00
Jeff Morriss
a3de46bf3e Heuristic standard tuning:
- Reject all Class-3 messages (it's never used)
 - Group Class-2 and Class-1 messages closer together
 - Some code cleanup (use macros where we have them)

svn path=/trunk/; revision=40780
2012-01-30 23:15:07 +00:00
Bill Meier
e61e93baae Rework optional generation of .sbr & .bsc files.
svn path=/trunk/; revision=40779
2012-01-30 22:57:09 +00:00
Anders Broman
d29d5bf966 Remove an unused parameter.
svn path=/trunk/; revision=40778
2012-01-30 20:03:29 +00:00
Anders Broman
80c5205b8e Reformat a section.
svn path=/trunk/; revision=40777
2012-01-30 19:54:39 +00:00
Anders Broman
ed5c6cfd71 Try to determine MTP3 Standard heuristically, original code
from Jeff Morris refactored a bit by me.

svn path=/trunk/; revision=40776
2012-01-30 19:47:35 +00:00
Anders Broman
0ee76da516 Minor updates to debug output.
svn path=/trunk/; revision=40775
2012-01-30 19:42:21 +00:00
Anders Broman
9f6bfbacdb From Andreas Heise:
Remove a debug line.

svn path=/trunk/; revision=40774
2012-01-30 19:41:29 +00:00
Jeff Morriss
509c2203eb Revert 40772: the abort() needs to be pushed higher (into packet.c?) so
checkapi remains happy; thus far my attempts at that aren't working.

svn path=/trunk/; revision=40773
2012-01-30 19:23:25 +00:00
Jeff Morriss
0a8b301218 If WIRESHARK_ABORT_ON_DISSECTOR_BUG is set, abort() out if we happened to
catch a DissectorError exception.

(I found this useful when debugging a "More than 1000000 items in the tree"
DissectorError.)

svn path=/trunk/; revision=40772
2012-01-30 17:51:22 +00:00
Jeff Morriss
f091005d3e Fix infinite loop reported in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6778 :
SDP_CRYPTO: Give up (and display an expert info) if we don't find the colon
separating the key-method and the key-info.

Reindent this area of code a bit.

Remove tabs in some places for consistency.

svn path=/trunk/; revision=40771
2012-01-30 17:39:15 +00:00
Stig Bjørlykke
44a9db54e1 No need to set new save icon if equal to previous icon.
svn path=/trunk/; revision=40770
2012-01-30 13:51:04 +00:00
Stig Bjørlykke
d86b90ce04 Disable the save-as button in the toolbar if we cannot save-as,
because this will assert.

svn path=/trunk/; revision=40769
2012-01-30 13:05:27 +00:00
Bill Meier
4308ba7dc5 Rework Windows Wireshark Qt build configuration a bit:
1. Compile and link with (almost exactly) the same options as used
   when building Windows Wireshark Gtk.
   The options used allow debugging of the exe using Visual Studio exactly
   as is done for Wireshark Gtk.
   Essentially: configure the "release" version to compile and link with
   symbols.  (See ui\qt\QtShark for the details).

2. Update QtShark.pro to create a Makefile only for 1 version of Wireshark Qt
   which is linked against the "release" Qt libraries.
   (IOW: don't create a "debug" Makefile).

3. Remove unused variable assignments from config.pri.
   (They can be added back if needed in the future).


svn path=/trunk/; revision=40768
2012-01-30 04:37:12 +00:00
Bill Meier
098725271f (Trivial) use same "Directory Separator" for dependency and target.
svn path=/trunk/; revision=40767
2012-01-30 00:57:44 +00:00
Bill Meier
cd4e301f06 Fix QtShark compile error.
(Quoting can be tricky ...)

svn path=/trunk/; revision=40766
2012-01-30 00:44:11 +00:00
Anders Broman
087e6087f0 Part of "Build Browse Information File per default" from
Kovarththanan Rajaratnam applied.

It's still not the default but easier to make it so.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3480

svn path=/trunk/; revision=40765
2012-01-29 21:56:35 +00:00
Anders Broman
00c0b9df7c Add dummy application for Ericsson Sy
svn path=/trunk/; revision=40764
2012-01-29 20:55:21 +00:00
Anders Broman
0179b7dc50 Add *.sbr files to the clean target.
svn path=/trunk/; revision=40763
2012-01-29 20:33:58 +00:00
Anders Broman
84370fffcb Add *.sbr files to the clean target.
svn path=/trunk/; revision=40762
2012-01-29 20:21:30 +00:00
Anders Broman
8e97665863 Add *.sbr files to the clean target.
svn path=/trunk/; revision=40761
2012-01-29 20:03:39 +00:00
Chris Maynard
c2eacb6f27 Fix some typos.
svn path=/trunk/; revision=40759
2012-01-29 15:51:21 +00:00
Gerald Combs
e564a427df [Automatic manuf, services and enterprise-numbers update for 2012-01-29]
svn path=/trunk/; revision=40757
2012-01-29 15:03:23 +00:00
Michael Tüxen
f011eca8c1 Don't register ett_ssl_keyex_params twice.
This bug was introduced in
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=40748

svn path=/trunk/; revision=40756
2012-01-28 22:22:01 +00:00
Anders Broman
c05cf29916 From Tyson Key:
Update the CCID dissector's filter/handler names.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6752

svn path=/trunk/; revision=40755
2012-01-28 17:19:25 +00:00
Anders Broman
997b768069 From Tom Brezinski:
includes radio data from the capture.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6746

svn path=/trunk/; revision=40754
2012-01-28 17:10:50 +00:00
Anders Broman
20881c49bb From Claudio:
linear white space (LWS) not ignored after HTTP header field content.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6591

svn path=/trunk/; revision=40753
2012-01-28 17:04:48 +00:00
Anders Broman
855289862a From Andreas Heise:
option ssl_ignore_mac_failed.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6748

svn path=/trunk/; revision=40752
2012-01-28 16:48:06 +00:00
Anders Broman
638ae058f4 From Tobias Witek:
Add support for a new dissector (MTP2) to the 'meta' dissector.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6717

svn path=/trunk/; revision=40751
2012-01-28 16:37:50 +00:00
Anders Broman
6dbeabfc6f From Tobias Witek:
Allow dissectors to indicate that an ATM AAL5 frame contains SSCOP.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6717

svn path=/trunk/; revision=40750
2012-01-28 16:34:22 +00:00
Anders Broman
95c9d2c52f From Michal Labedzki:
Fix:Wrong bluetooth PSM detected when parse the L2CAP packet.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6619

svn path=/trunk/; revision=40749
2012-01-28 16:24:12 +00:00
Anders Broman
cde63b2001 From Michael:
Enhance SSL Key Exchange dissection.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6716

svn path=/trunk/; revision=40748
2012-01-28 15:50:59 +00:00
Anders Broman
6be62cd753 From Martin Kaiser:
Unused variable in rtp_analysis.c

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6776

svn path=/trunk/; revision=40747
2012-01-28 15:13:28 +00:00
Anders Broman
86b6c80128 Add the Qt files to the tarball.
svn path=/trunk/; revision=40745
2012-01-28 09:18:26 +00:00
Guy Harris
25125ae369 Well, we *did* go to a widget that invokes callback to get the text for
the columns, so we *can* clean up the exporting of col_set_fmt_time() by
not exporting it any more.

svn path=/trunk/; revision=40743
2012-01-28 02:21:03 +00:00
Jeff Morriss
98d51466e5 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6712 :
Since SMPP knows the time zone of its (absolute) times and since we don't
have access to a mktime() routine that doesn't take into account the local
time zone (and since I don't think repeatedly setting the TZ environment
variable is a healthy choice):

1) subtract the 'timezone' (or '_timezone' on Windows) back out after calling
   mktime()
2) then adjust the time to take into the protocol-specified time zone
3) and (finally) display the time in UTC (since we don't have the
   infrastructure to display it in the protocol-specified time zone).

(I *think* (1) is portable: POSIX says that variable should exist...)

svn path=/trunk/; revision=40742
2012-01-27 22:59:25 +00:00
Alexis La Goutte
d307494e07 Fix
main_window.cpp: In function ‘QStringList build_file_open_type_list()’:
main_window.cpp:249:50: error: cannot call constructor ‘QString::QString’ directly [-fpermissive]
main_window.cpp:249:50: error:   for a function-style cast, remove the redundant ‘::QString’ [-fpermissive]


svn path=/trunk/; revision=40741
2012-01-27 16:49:54 +00:00
Chris Maynard
6d213e71bd Since we know the version of WinPcap we're compiling against, go ahead and display it instead of displaying "version unknown".
svn path=/trunk/; revision=40740
2012-01-27 03:41:20 +00:00
Chris Maynard
17885e4130 Per https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6765#c3, don't display "(version unknown)" anymore.
svn path=/trunk/; revision=40739
2012-01-27 03:00:47 +00:00
Anders Broman
48f70baa03 From Mike Morrin:
The gsmtap patch related to
Add dissectors for GSM and UMTS Cell Broadcast protocols.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6770

svn path=/trunk/; revision=40738
2012-01-26 23:13:31 +00:00
Gerald Combs
9c0005cd7e Add a format string and remove a couple of unused variables.
svn path=/trunk/; revision=40737
2012-01-26 22:14:19 +00:00
Gerald Combs
3080352f4f make-dissector-reg.py doesn't always open its cache file.
svn path=/trunk/; revision=40736
2012-01-26 21:38:53 +00:00
Anders Broman
e1d434ee6a From Mike Morrin:
Add dissectors for GSM and UMTS Cell Broadcast protocols.
( - the patch for gsmtap )

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6770

svn path=/trunk/; revision=40735
2012-01-26 19:51:48 +00:00
Gerald Combs
6981aa2c2a Apply changes from the "2to3" conversion utility. Print cache information.
svn path=/trunk/; revision=40734
2012-01-26 19:38:27 +00:00