Commit Graph

82158 Commits

Author SHA1 Message Date
João Valverde 18c155a3ca wsutil: Remove ip6_to_str_buf_with_pfx()
Writing a string prefix shouldn't require a specialized function here.
2021-09-17 00:08:41 +01:00
João Valverde 364df939ea wsutil: Rewrite ip6_to_str_buf() 2021-09-17 00:08:40 +01:00
João Valverde d4c7978f68 wsutil: Add ip_to_str() 2021-09-16 23:18:53 +01:00
João Valverde 8c4a479c52 Move more numerical functions to wsutil/to_str.h 2021-09-16 20:55:03 +01:00
João Valverde cc1e5b8334 Reformat and cleanup epan/to_str.h header 2021-09-16 20:15:28 +01:00
João Valverde 8208c68b49 Debian: Add missing wsutil symbols 2021-09-16 18:23:47 +01:00
João Valverde 8304ced0e6 wsutil: Add some tests for word_to_hex() 2021-09-16 18:21:14 +01:00
João Valverde 24fd8c6740 Move more numerical epan/*to_str() routines to wsutil 2021-09-16 18:21:14 +01:00
Chuck Craft 5b4c7e1c46 NEWS: multiple list indentation levels (nested lists) 2021-09-16 16:27:11 +00:00
João Valverde 0019723b14 Debian: Add missing wsutil symbols 2021-09-16 15:53:15 +00:00
João Valverde 44538f6e4d wsutil: Add tests for to_str_back() 2021-09-16 15:53:14 +00:00
João Valverde 8b70e24889 wsutil/to_str: Rename some functions for consistency 2021-09-16 15:53:14 +00:00
João Valverde 8a584222f1 Move epan/*to_str_back() functions to wsutil 2021-09-16 15:53:14 +00:00
Uli Heilmeier 2de4d40e22 setup-macos-brew: Extend to build dmg
Extend the script to be able to build a dmg bundle
2021-09-16 09:56:36 +00:00
Joakim Karlsson 45398ad333 PFCP: Additional improved Rule ID visibility 2021-09-16 11:19:47 +02:00
David Fort b81192d312 rdp: keep track of UDP and TCP connection links
As dynamic channel data can be transported on top of TCP or UDP, we need to keep track
of the link between UDP and TCP connections so that the associated data can be shared
between the two transports.
2021-09-16 07:37:18 +00:00
Evan Huus e4b8a58513 ptvcursor: add explicit memory scope
I was hoping to avoid this, since the ptvcursor should already be
implicitly scoped to the tree it is working on. But there are a bunch of
call sites where the passed tree can be NULL (?) and a few places where
the tree is explicitly set/reset after creation, so requiring an
explicit scope is safer.

Avoids global memory pools in favour of ones the compiler can verify.
2021-09-16 07:12:20 +00:00
Evan Huus f4aa108913 tvbparse: explicitly memory-scope parser
Avoids the use of the global memory pool in favour of one the compiler
actually knows must be in scope.

Also delete a few-hundred lines of if-0ed code that hadn't been active
in 15+ years.
2021-09-16 06:54:42 +00:00
João Valverde 2cb1eb955f epan: Rename SMI dependency to "libsmi" 2021-09-16 00:42:03 +01:00
Guy Harris bfc7708f63 SV / IEC 61850: Accommodate Ethernet trailers
IEC 61850 is directly over Ethernet, so use set_actual_length
like other such protocols so that the Ethernet dissector has a
chance to detect and dissect trailers / FCS.

And do it in the template from which packet-sv.c is generated, rather
than in packet-sv.c, so that it doesn't get overwritten if somebody
regenerates the sv dissector.
2021-09-15 14:27:29 -07:00
Erik Rigtorp 4ebd927ccd Support LZ4 versions earlier than 1.8.0 2021-09-15 19:09:30 +00:00
João Valverde bd33320521 wslog: Add macro to validate arguments and return
Similar to g_return_if_fail(), etc.
2021-09-15 18:19:07 +00:00
João Valverde 20dc422550 wsutil: Add test for bytes_to_str_punct() 2021-09-15 18:38:57 +01:00
Vivek Mangala 6c066adad7 twamp: improved decoding of Request-Session
Added decoding and display of "Number of Schedule Slots"
and "Number of Packets" parameters contained in Request-Session
message in TWAMP Control protocol, in accordance with RFC-4656.
2021-09-15 13:21:12 +00:00
Joakim Karlsson 24af672884 PFCP: Improved Rule ID visibility
In PFCP message multiple create/update/remove IE can be included,
displaying the Rule ID on top of the group will make finding wanted rule
easier. Rule ID is mandatory in these groups.
From:
    Create FAR : [Grouped IE]:
    Create FAR : [Grouped IE]:
    Create QER : [Grouped IE]:
    Create URR : [Grouped IE]:
    Create URR : [Grouped IE]:
    Create URR : [Grouped IE]:
    Create URR : [Grouped IE]:
    Create URR : [Grouped IE]:
    Create URR : [Grouped IE]:
    Create PDR : [Grouped IE]:
    Create PDR : [Grouped IE]:
    Create PDR : [Grouped IE]:
    Create PDR : [Grouped IE]:

To:
    Create FAR : [Grouped IE]: FAR ID: 1
    Create FAR : [Grouped IE]: FAR ID: 2
    Create QER : [Grouped IE]: QER ID: 1
    Create URR : [Grouped IE]: URR ID: 1
    Create URR : [Grouped IE]: URR ID: 2
    Create URR : [Grouped IE]: URR ID: 3
    Create URR : [Grouped IE]: URR ID: 4
    Create URR : [Grouped IE]: URR ID: 5
    Create URR : [Grouped IE]: URR ID: 6
    Create PDR : [Grouped IE]: PDR ID: 1
    Create PDR : [Grouped IE]: PDR ID: 2
    Create PDR : [Grouped IE]: PDR ID: 3
    Create PDR : [Grouped IE]: PDR ID: 4
2021-09-15 11:35:10 +00:00
Nardi Ivan cda79cb819 QUIC: fix "Follow QUIC stream" crashes when encryption keys are not available
Reported by @chuckcraft in
https://gitlab.com/wireshark/wireshark/-/issues/17453#note_676545721
2021-09-15 09:46:03 +02:00
Vivek Mangala aceb1aea10 twamp: improved decoding of Request-Session
Added decoding and display of Conf-Sender and Conf-Receiver
parameters contained in Request-Session message in TWAMP
Control protocol, in accordance with RFC-4656 (OWAMP RFC
which is baseline for TWAMP).
2021-09-15 06:04:42 +00:00
Joerg Mayer 8567f657aa MPLS: Some systems display labels (mostly) in HEX
E.g. EXOS
2021-09-15 05:43:24 +00:00
Taisuke Sasaki 806599b923 BGP: Add BGP-LS Flex Algorithm (draft-ietf-idr-bgp-ls-flex-algo-07) 2021-09-15 05:42:44 +00:00
Joel Helling a72df64a60 Fixed Mode S Interrogator Identifier type check.
Changed the Mode S Interrogator Identifier summary info to check the type instead of the code.
2021-09-14 23:32:50 +00:00
Joel Helling 0844c0862a Fixed typo in Mode S Interrogator Identifier. 2021-09-14 23:32:50 +00:00
GBLCA\amrobles bf18882a42 DD-14 Made changes to Mode S interrogator layout. 2021-09-14 23:32:50 +00:00
GBLCA\amrobles a804547019 DD-14 Added Mode S Interrogator Identifier Information Column.
Created checks in order to appropiately display mode S and its different values.
2021-09-14 23:32:50 +00:00
GBLCA\amrobles ca83fbcf42 DD-14 Added Mode S Interroator Identifier Record.
Created a check to determine if mode S would be displayed in place of Mode 4.
2021-09-14 23:32:50 +00:00
GBLCA\amrobles a0600993a1 DD-14 Added RRB Trandponder Code Record. 2021-09-14 23:32:50 +00:00
GBLCA\amrobles 2fd0c3a976 DD-6 Added System Designator and System Specific Information
Updated call to dissect_DIS_PARSER_IFF_PDU so that it contains the DIS version.
Updated info column so that it appends text in the right order. Added
System Designator and System Specific Information to DIS v7 IFF PDUs.
2021-09-14 23:32:50 +00:00
GBLCA\amrobles 1c3729a9fd DD-6 Updated Layer 1 Dissection with DIS v7 IFF Layer 1
Added fields that are new to DIS v7. Updated fields to use
add_item instead of add_bits.  Changed the bit_mask of header
field declarations.
2021-09-14 23:32:50 +00:00
GBLCA\amrobles 7c59dd00c2 DD-6 Updated Dissection of PDU Header
Updated records in correspondence to 1278.1-2012
2021-09-14 23:32:50 +00:00
GBLCA\amrobles 2a2fbf3921 DD-6 Updated Enums with SISO 2019
Updated the UIDs to have the new values added in SISO Ref 2019. New Message
2021-09-14 23:32:50 +00:00
Evan Huus 8b194a924f osi: avoid global memory scopes
Add scope arguments to the OSI helper methods which allocate buffers to
avoid the use of the global wmem_packet_scope().
2021-09-14 19:05:11 +00:00
Evan Huus b39fc2aafc wslua: avoid global memory scopes
Use pinfo->pool when available, or allocate/free directly in paths that
don't raise exceptions.
2021-09-14 18:48:56 +00:00
Martin Mathieson 65bfe0ccd6 ORAN FH CUS: check dissected extension length against extlen 2021-09-14 12:27:57 +01:00
Roland Knall f82535d645 Docbook: Add changed behavior for byteview
Add the changed hover behavior for the byteview to the
documentation
2021-09-14 10:56:39 +02:00
Juha Takala 8bc52f542b Add tshark ringbuffer option '-b nametimenum:value'
This is used to select ringbuffer savefile name template.  Choose one of two
savefile name templates:

If value is 1, make running file number part before start time part; this is
the original and default behaviour (e.g. log_00001_20210828164426.pcap).

If value is greater than 1, make start time part before running number part
(e.g. log_20210828164426_00001.pcap).

The latter makes alphabetical sortig order equal to creation time order, and
keeps related multiple file sets in same directory close to each other (e.g.
while browsing in wireshark "Open file" dialog).

Signed-off-by: Juha Takala <juha.takala+rauta@iki.fi>
2021-09-14 04:52:09 +00:00
Alexis La Goutte 6cf6794e37 GitLab Ci: Fix duplicate apt cmd for daily run 2021-09-13 18:47:35 +00:00
Gerald Combs 55a67fd66a Tools: Migrate compress-pngs.sh to Python.
Migrate compress-pngs from a Bash script that ran Make to a Python
script, which should be usable on more platforms.

Add Efficient Compression Tool (ect) to the list of compressors.

Add the compressors to the various *-setup.sh scripts, but comment them
out for now.
2021-09-13 11:00:04 -07:00
Developer Alexander 77e6110c59 websocket: Enable websocket as heuristic dissector for TCP
Add a new option to use websocket as heuristic dissector for TCP.

This is useful when the connection setup of a HTTP connection which got
upgraded to a websocket was not recorded.

If this option is disabled via preference the resulting behaviour should be
the same as prior. It is disabled by default.
2021-09-13 16:18:11 +00:00
Roland Knall 19f3a82ff8 Qt: ByteView make hover configurable
Allow the hover selection to be either configured via context menu
or by pressing the Ctrl key while moving the mouse. The configuration
is stored via profile
2021-09-13 15:33:46 +00:00
Nardi Ivan 3cb302f05b HTTP2, QUIC: fix "Follow Stream"
"Follow Stream" functionality assumes that all data in a single packet
belongs to the same stream. That is not true for HTTP2 and QUIC, where
we end up having data from unrelated streams.

Filter out the unwanted data directly in the protocol dissector code with
a custom `tap_handler` (as TCP already does).

Close #16093
2021-09-13 15:13:10 +00:00
Joakim Karlsson a7a7849259 Qt: Enable Edit Name Resolution for EXPORTED_PDU 2021-09-13 14:22:16 +00:00