Commit Graph

23 Commits

Author SHA1 Message Date
Guy Harris ce5039c522 Add some additional sanity checks.
svn path=/trunk/; revision=46745
2012-12-25 22:39:11 +00:00
Guy Harris 8dbe2af621 Check whether something's too big before subtracting it from another
variable.

Adjust offset and len in parallel.

svn path=/trunk/; revision=46665
2012-12-21 11:12:23 +00:00
Jeff Morriss 2552c750e5 We always HAVE_CONFIG_H so don't bother checking whether we have it or not.
svn path=/trunk/; revision=45017
2012-09-20 02:03:38 +00:00
Bill Meier 638d74d43f Use val_to_str_const() where appropriate;
Also (for a few files):
- create/use some extended value strings;
- remove unneeded #include files;
- remove unneeded variable initialization;
- re-order fcns slightly so prefs_reg_handoff...() at end, etc

svn path=/trunk/; revision=44438
2012-08-10 22:55:02 +00:00
Jakub Zawadzki bf81b42e1e Update Free Software Foundation address.
(COPYING will be updated in next commit)

svn path=/trunk/; revision=43536
2012-06-28 22:56:06 +00:00
Anders Broman e01d3b549e From "oss.2nerds":
IEEE P802.1aq/D3.6 and the corresponding IETF draft
(http://tools.ietf.org/html/draft-ietf-isis-ieee-aq-05) defines a series of new
ISIS TLVs for the shortest-path-bridging protocol.

The attached patch file contains a simple dissector for one such TLV (the
MT-Port-Cap TLV) and several corresponding sub-TLVs (mcid, aux_mcid, digest,
and b-vid).  The digest sub-TLV dissector has not been exercised because no
suitable capture files are available (the digest sub-TLV seems not to be widely
implemented at this point in time).

Note that the codepoints mentioned in the IETF draft have changed.  The
IANA-assigned codepoints are further described in these pages:

http://www.ietf.org/mail-archive/web/spb-isis/current/msg00007.html
http://www.iana.org/assignments/isis-tlv-codepoints/isis-tlv-codepoints.xml#tlv-143

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7154

svn path=/trunk/; revision=42385
2012-05-02 14:23:35 +00:00
Bill Meier c4b63360dc Fix proto_tree_add_item( encoding args;
Do whitespace cleanup (for a few files).

svn path=/trunk/; revision=39640
2011-10-27 20:30:38 +00:00
Chris Maynard 9059904629 Don't assign the return value of proto_tree_add_text() if it's not going to be used. Fixes Coverity CID 1232.
svn path=/trunk/; revision=39056
2011-09-19 20:41:17 +00:00
Bill Meier 82ffa86cd3 Mark a function arg as _U_
svn path=/trunk/; revision=37246
2011-05-18 17:19:42 +00:00
Bill Meier 5a243ce86f Don't assign to an unused 'proto_item *': Coverity 939 [UNUSED];
Don't create a subtree which is never used: Coverity 940 [UNUSED].

svn path=/trunk/; revision=37243
2011-05-18 16:52:45 +00:00
Jeff Morriss d553df218e Use tvb_memeql().
Use tvb_ip_to_str().

There's no need to pass the result of tvb_get_ptr() as the 'value' in
proto_tree_add_*(): just use proto_tree_add_item().

Replace some tvb_get_ptr()s with tvb_get_ephemeral_string()s to ensure the
return string is NULL terminated.

svn path=/trunk/; revision=35547
2011-01-16 03:46:16 +00:00
Bill Meier 69df32fb11 #include <string.h> not needed.
svn path=/trunk/; revision=32411
2010-04-06 22:09:47 +00:00
Bill Meier 09764dd969 Remove unneeded #include <stdio.h>
svn path=/trunk/; revision=32367
2010-04-03 21:55:23 +00:00
Bill Meier b52d95d591 #include <emem.h> not req'd
svn path=/trunk/; revision=26091
2008-08-26 01:28:50 +00:00
Guy Harris 83fc9d5e09 Constify a bunch of stuff, to squelch -Wwrite-strings warnings.
epan/dissectors/packet-ncp2222.inc is a bit hard to fix, so we're not
ready to enable that warning by default yet.

Throw in some casts to handle GLib routines that take arbitrary
non-const pointers (they can later return the pointers, and some
callers might want to modify or free up those pointers in cases where
they're known to be writable or allocated).

Use ep_tvb_memdup() rather than a combination of ep_alloc() and
tvb_memcpy().

Clean up some indentation.

svn path=/trunk/; revision=25601
2008-06-25 09:12:35 +00:00
Gerald Combs 106968d7e8 From Hariharan Ananthakrishnan:
I have added two new display filters to support filtering based on LSP-ID and
hostname for ISIS protocol. 

svn path=/trunk/; revision=24621
2008-03-13 23:45:48 +00:00
Ronnie Sahlberg feab79e328 change a whole bunch of ethereal into wireshark
svn path=/trunk/; revision=18196
2006-05-21 04:49:01 +00:00
Guy Harris b7b80d94be Move a pile of protocol-related headers from the top-level source
directory to the epan directory.  Some of them should perhaps ultimately
be moved to epan/dissectors, if they pertain only to stuff exported by a
particular dissector.

Fix Gerald's e-mail address in files we're moving.

svn path=/trunk/; revision=15844
2005-09-17 00:02:31 +00:00
Guy Harris 802dc99d45 Use "proto_item_append_text()" rather than filling up an allocated
buffer.  This fixes one place where the "NLPID(s):" wasn't being put
into the protocol tree item.

svn path=/trunk/; revision=15658
2005-09-01 11:34:10 +00:00
Ronnie Sahlberg d4c04e3c57 move an array off the stack into emem allocated memory
svn path=/trunk/; revision=15619
2005-08-30 08:47:25 +00:00
Ronnie Sahlberg 4d2b9df7e0 change g_string_sprintf() into g_snprintf()
svn path=/trunk/; revision=15618
2005-08-30 08:41:18 +00:00
Gerald Combs 1906593816 Fix a buffer overflow in isis_dissect_nlpid_clv().
svn path=/trunk/; revision=14161
2005-04-22 04:07:56 +00:00
Gilbert Ramirez 669db206cb Move dissectors to epan/dissectors directory.
Also move ncp222.py, x11-fields, process-x11-fields.pl,
make-reg-dotc, and make-reg-dotc.py.

Adjust #include lines in files that include packet-*.h
files.

svn path=/trunk/; revision=11410
2004-07-18 18:06:47 +00:00