Commit Graph

63 Commits

Author SHA1 Message Date
Stig Bjørlykke 28ae535b00 Removed even more "statement not reached" warnings.
svn path=/trunk/; revision=24286
2008-02-07 15:44:45 +00:00
Anders Broman e5f48395f1 Move the routines tvb_skip_wsp() to tvbuff.c
svn path=/trunk/; revision=23818
2007-12-09 17:41:16 +00:00
Guy Harris 9c89cdaaa3 strcasecmp(), strncasecmp(), g_strcasecmp(), and g_strncasecmp() delenda
est.  Use g_ascii_strcasecmp() and g_ascii_strncasecmp(), and supply our
own versions if they're missing from GLib (as is the case with GLib
1.x).

In the code to build the list of named fields for Diameter, don't use
g_strdown(); do our own g_ascii_-style upper-case to lower-case mapping
in the hash function and use g_ascii_strcasecmp() in the compare
function.

We do this because there is no guarantee that toupper(), tolower(), and
functions that use them will, for example, map between "I" and "i" in
all locales; in Turkish locales, for example, there are, in both
upper case and lower case, versions of "i" with and without a dot, and
the upper-case version of "i" is "I"-with-a-dot and the lower-case
version of "I" is "i"-without-a-dot.  This causes strings that should
match not to match.

This finishes fixing bug 2010 - an earlier checkin prevented the crash
(as there are other ways to produce the same crash, e.g. a bogus
dictionary.xml file), but didn't fix the case-insensitive string matching.

svn path=/trunk/; revision=23623
2007-11-27 18:52:51 +00:00
Gerald Combs 7bed7953f6 Keep the MEGACO dissector from looping on a malformed events descriptor.
svn path=/trunk/; revision=23449
2007-11-14 19:28:29 +00:00
Anders Broman 0b4529008d Implement some of the minor possible speed improvment patches.
svn path=/trunk/; revision=23150
2007-10-11 21:23:14 +00:00
Anders Broman 1cf1f16391 Split out common asn1 stuff to asn1.h and include that where needed.
svn path=/trunk/; revision=21635
2007-05-01 22:05:11 +00:00
Luis Ontanon a1120493e2 Megaco improvements:
- Verify that we have a ber sequence before handing over to H.248
- Make the dissector more case insensitive (Fixes http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1517)


svn path=/trunk/; revision=21337
2007-04-04 21:23:55 +00:00
Stephen Fisher 8fd3ee0560 Remove almost all of the casts I committed recently and in place of
them, add -Wno-pointer-sign to CFLAGS when gcc will accept it.


svn path=/trunk/; revision=21253
2007-03-28 21:55:11 +00:00
Luis Ontanon 8c6ad121d8 megaco
- replace #pragma for #include
- move register function and remove prototype

h248
- have dissector being called through megaco instead of registering to the same sctp.ppi


svn path=/trunk/; revision=21234
2007-03-27 22:56:07 +00:00
Ulf Lamping a66bf7f559 as Gisle Vanem noted that MingW doesn't "like" the #pragmas:
change #ifdef _WIN32 -> #ifdef _MSC_VER around pragma warnings

svn path=/trunk/; revision=21228
2007-03-27 21:09:34 +00:00
Ulf Lamping c2408435bc fix the remaining MSVC warnings by setting individual #pragma(warning:disable) settings - this is very certainly not the way to go, but the way to prevent additional warnings rushing in ...
svn path=/trunk/; revision=21221
2007-03-27 02:14:56 +00:00
Luis Ontanon 395f48b869 add context tracing and tap to packet-megaco.c
(have to fix the matching of wildcarded terminations as it doesn't work as it should)

svn path=/trunk/; revision=21212
2007-03-26 21:10:58 +00:00
Luis Ontanon 296a77efdc migrate packet-megaco.c from plugins/megaco to epan/dissectors
svn path=/trunk/; revision=21191
2007-03-25 21:59:16 +00:00