Commit Graph

51 Commits

Author SHA1 Message Date
Bill Meier f93b82079b Fix some indentation ....
svn path=/trunk/; revision=27313
2009-01-27 21:46:58 +00:00
Stig Bjørlykke 94e9e2b1ec Fix some "format not a string literal and no format arguments" warnings.
svn path=/trunk/; revision=26652
2008-10-31 17:27:51 +00:00
Bill Meier ffa7320de2 Minor cleanup related to proto_register & proto_reg_handoff
svn path=/trunk/; revision=26280
2008-09-26 20:06:40 +00:00
Bill Meier 38eb4d6ce3 Use const with value_string array definitions
svn path=/trunk/; revision=26028
2008-08-14 23:51:52 +00:00
Bill Meier 67559b7dfe Add NULL termination element to value_string arrays
svn path=/trunk/; revision=25793
2008-07-22 18:27:13 +00:00
Bill Meier 44af6ef887 Fix some of the Errors/warnings detected by checkapi.
svn path=/trunk/; revision=25290
2008-05-14 01:47:41 +00:00
Stig Bjørlykke 5acf099bd2 From Roberto Morro (bug 2416):
Added support for Ethernet SENDER_TSPEC and FLOWSPEC objects according to
draft-ietf-ccamp-ethernet-traffic-parameters-02.
Added support for enhancements in the LSP_TUNNEL_INTERFACE_ID object according
to draft-ietf-ccamp-lsp-hierarchy-bis-02.
Added support for NOTIFY_REQUEST and RECOVERY_LABEL objects.
Added display filters for some fields of the GENERALIZED_UNI and CALL_ID
objects.

svn path=/trunk/; revision=25023
2008-04-14 19:43:39 +00:00
Stig Bjørlykke 428703d8ad From Giodi Giorgi (bug 2201):
Fix dumping of PROTECTION INFO and GENERALIZED UNI according to RFC3471.

svn path=/trunk/; revision=25002
2008-04-13 21:57:04 +00:00
Stig Bjørlykke 28ae535b00 Removed even more "statement not reached" warnings.
svn path=/trunk/; revision=24286
2008-02-07 15:44:45 +00:00
Gerald Combs c2d537141a Fix a buffer overflow in the PPP dissector. Try to fix uninitialized
variable warnings turned up by Valgrind.

svn path=/trunk/; revision=23475
2007-11-16 23:56:18 +00:00
Anders Broman 1950ffc214 Apply the small performance enhancment patches for:
- if offset is 0, tvb_length is the same as tvb_length_remaining, just faster.
Replace 
- col_append_fstr() with faster  col_append_str() 
- col_add_str() with col_set_str()
when it's safe

svn path=/trunk/; revision=23252
2007-10-23 05:50:00 +00:00
Guy Harris 5a43799a17 Use G_GINT64_MODIFIER, rather than the PRI[douxX]64 macros, for GLib
routines and routines using those routines.  GLib might use different
modifiers for 64-bit quantities than the platform's C library does.

svn path=/trunk/; revision=21990
2007-05-29 18:52:42 +00:00
Stephen Fisher 8724d742a2 Fix for bug #1598 - add support for PRSVP (RSVP encapsulated in UDP port 3455)
svn path=/trunk/; revision=21896
2007-05-22 22:55:09 +00:00
Stephen Fisher 8fd3ee0560 Remove almost all of the casts I committed recently and in place of
them, add -Wno-pointer-sign to CFLAGS when gcc will accept it.


svn path=/trunk/; revision=21253
2007-03-28 21:55:11 +00:00
Stephen Fisher 2896811274 Fix about 150 warnings new to gcc 4.0 in the error on warning directories.
Comment out -Werror in plugins/asn1/ until warnings can be fixed.


svn path=/trunk/; revision=21158
2007-03-23 22:49:23 +00:00
Jaap Keuter 1d60ad8ce7 From Morro Roberto:
Please find attached a patch to the RSVP dissector that fixes a small inaccuracy when printing the SENDER TSPEC object.
Substantially, it changes the string
"C-type: 1 - Integrated Services" into the correct one
"C-type: 2 - Integrated Services"

svn path=/trunk/; revision=20900
2007-02-23 15:22:24 +00:00
Anders Broman d12138839a From Cyril Margaria:
Patch to support RSVP notify and added a few error codes, with some more objectcodes
added.

svn path=/trunk/; revision=19960
2006-11-22 23:20:11 +00:00
Ashok Narayanan 06d1297a6b Add support for IPv4-Aggregate session/template/filter types.
svn path=/trunk/; revision=19884
2006-11-13 17:30:38 +00:00
Ashok Narayanan 3d40131d07 Add support for dissecting RSVP E2E IGNORE proto packets (RFC3175)
svn path=/trunk/; revision=19665
2006-10-23 17:32:15 +00:00
Jörg Mayer 162d87a516 Muthu Krishnan V <muthukrishnanv@gmail.com>
As per RFC 4090, In the FAST_REROUTE Object, Include-any starts
at the 12th byte and Exclude-any starts at the 16th byte.

Ethereal has inter-changed these two fields in its display.

*Ethereal* bug 1043.

svn path=/trunk/; revision=18938
2006-08-17 11:56:35 +00:00
Anders Broman 917bdbc877 Francesco Fondelli:
Protocol Extensions for Support of Diffserv-aware MPLS Traffic Engineering
(DSTE) as per RFC 4124.

svn path=/trunk/; revision=18727
2006-07-13 05:57:20 +00:00
Ronnie Sahlberg feab79e328 change a whole bunch of ethereal into wireshark
svn path=/trunk/; revision=18196
2006-05-21 04:49:01 +00:00
Guy Harris b7b80d94be Move a pile of protocol-related headers from the top-level source
directory to the epan directory.  Some of them should perhaps ultimately
be moved to epan/dissectors, if they pertain only to stuff exported by a
particular dissector.

Fix Gerald's e-mail address in files we're moving.

svn path=/trunk/; revision=15844
2005-09-17 00:02:31 +00:00
Ulf Lamping 11dc88286a MSVC don't like empty structs, add a dummy element to rsvp_session_ipv6_info
svn path=/trunk/; revision=15717
2005-09-07 20:50:03 +00:00
Ronnie Sahlberg ac5f9b239f From Manu Pathak
Make RSVP tappable

add hostlist and conversation listing for RSVP conversations



svn path=/trunk/; revision=15714
2005-09-07 19:52:44 +00:00
Gerald Combs e06c37bc45 Correct an eariler infinite loop fix. Fixes bug 382.
svn path=/trunk/; revision=15600
2005-08-28 20:15:08 +00:00
Ronnie Sahlberg 6caf6d5d1c add missing value_string termination
svn path=/trunk/; revision=15584
2005-08-28 03:01:37 +00:00
Ronnie Sahlberg ec3ab9ec3e rename ep_tvb_get_string() to tvb_get_ephemeral_string() asnd update the documentation in README.developer
svn path=/trunk/; revision=15270
2005-08-10 13:41:13 +00:00
Ulf Lamping 0dc9fb3d4a various code cleanup:
-use g_snprintf instead of sprintf and snprintf
-use g_strdup_printf where appropriate
-remove #include "snprintf.h" (as only g_snprintf should be used)
-replace some more alloc/realloc/calloc/free with their glib pendants

svn path=/trunk/; revision=15264
2005-08-08 18:50:39 +00:00
Guy Harris 4c20433d0b Centralize the code to create the subtree for RSVP objects and to put
the length and object class items into that tree.  Put the object class
item into the tree as a visible item, rather than as a hidden item and
as a text entry.

Add some additional length checks.

svn path=/trunk/; revision=15258
2005-08-08 07:27:14 +00:00
Jörg Mayer 69dcb66cd9 More char -> const char warning fixes
svn path=/trunk/; revision=15218
2005-08-05 00:23:22 +00:00
Gerald Combs 04e2d2d5e6 Increase the size of some variables, so that we don't overflow them. Fixes
the infinite loops in bugs 311 and 314.

svn path=/trunk/; revision=15206
2005-08-04 17:11:32 +00:00
Anders Broman 415359db46 From Morro Roberto :
- bug fixes to the dissectors for the GENERALIZED_UNI and
 LABEL objects
 - improved dissector of flag field for the ERROR object
 - improved LABEL_SET object dissector
 - support for the new (proposed) ASSOCIATION object (see 
 draft-ietf-ccamp-gmpls-recovery-e2e-signaling).
 Moveover find also attached a patch to OSPF that fixes a line 
 of source code lost in the TNA TLV (the code compiled anyway).

svn path=/trunk/; revision=15066
2005-07-25 19:52:08 +00:00
Ronnie Sahlberg 9ef6568c56 some more dissectors converted to ep_tvb_get_string
again   at least one obvious memleak was found in the old code



svn path=/trunk/; revision=15031
2005-07-24 03:01:41 +00:00
Ulf Lamping 2c30357c48 checksum messages: use "[correct]" instead of "(correct)" and other "alike" messages
svn path=/trunk/; revision=14880
2005-07-08 22:11:13 +00:00
Guy Harris ab797734dd Get rid of the private "my_match_strval()" routine in many dissectors;
add a "match_strval_idx()" routine that does the same thing, and have
"match_strval()" call it.

Make those routines, and "val_to_str()", return a "const" pointer. 
Update dissectors as necessary to squelch compiler warnings produced by
that.

Use "val_to_str()" rather than using "match_strval()" and then, if the
result is null, substituting a specific string.  Clean up some other
"match_strval()"/"val_to_str()" usages.

Add a null pointer check in the NDPS dissector's "attribute_value()"
routine, as it's not clear that "global_attribute_name" won't be null at
that point.

Make some global variables in the AFS4INT dissector local.

Make some routines not used outside the module they're in static.

Make some tables "static const".

Clean up white space.

Fix Gerald's address in some files.

svn path=/trunk/; revision=14786
2005-06-26 19:56:52 +00:00
Gerald Combs 3a6c9ab134 Fix a format string vulneratility in the AFP dissector identified
by iDEFENSE.  Add constant format strings to proto_item_append_text()
in a bunch of other dissectors.  Copy a comment from proto.c to proto.h.

svn path=/trunk/; revision=14713
2005-06-20 19:35:58 +00:00
Anders Broman 0d7fce8c7d From Richard Rabbat:
a patch for a couple of fixes to rsvp sub-objects.

svn path=/trunk/; revision=14555
2005-06-06 13:55:47 +00:00
Gerald Combs 949a9da364 Break out of an infinite loop. Fixes bug 154.
svn path=/trunk/; revision=14277
2005-05-02 20:30:56 +00:00
Gerald Combs e8730eab95 Fix for the previous fix.
svn path=/trunk/; revision=14168
2005-04-22 18:06:39 +00:00
Gerald Combs f2695565b4 Fix an infinite loop in dissect_rsvp_gen_uni(). Fixes bug 90. Fix up a
previous infinite loop fix.

svn path=/trunk/; revision=14165
2005-04-22 14:55:27 +00:00
Gerald Combs 190057e036 Fix an infinite loop discovered during fuzz-testing.
svn path=/trunk/; revision=14153
2005-04-20 19:52:23 +00:00
Gerald Combs 8e0186b2da Detect an infinite loop in dissect_rsvp_ero_rro_subobjects(). Fixes bug 71.
svn path=/trunk/; revision=14128
2005-04-18 16:29:54 +00:00
Ashok Narayanan 778c9abaea Minor change to Call-ID dissector to set up object line.
svn path=/trunk/; revision=13960
2005-03-28 19:32:39 +00:00
Guy Harris eaadcc4c62 Move various tables into the epan directory.
svn path=/trunk/; revision=12130
2004-09-29 00:52:45 +00:00
Guy Harris ac98f225a8 Move various checksum routines and headers to epan.
svn path=/trunk/; revision=12117
2004-09-28 00:06:32 +00:00
Guy Harris 2b64897a27 We don't need a variable to hold the sequence number any more - just
directly pass the result of "tvb_get_ntoh64()" to "proto_tree_add_text()".

svn path=/trunk/; revision=11803
2004-08-22 03:16:05 +00:00
Guy Harris c68f62210f Add "tvb_get_ntoh64()" and "tvb_get_letoh64()" routines to fetch 64-bit
integers.

Make FT_INT64 and FT_UINT64 add numerical values, rather than byte-array
values, to the protocol tree, and add routines to add specified 64-bit
integer values to the protocol tree.

Use those routines in the RSVP dissector.

svn path=/trunk/; revision=11796
2004-08-22 00:31:58 +00:00
Jörg Mayer e869dbb17d Trivial warning fixes:
- comma at end of enum
- function declarations with empty args instead of void
- c++ style comments

svn path=/trunk/; revision=11492
2004-07-23 23:28:08 +00:00
Guy Harris 0a4380f19e From Roberto Morro: support for GMPLS UNI and E-NNI objects/TLVs.
svn path=/trunk/; revision=11452
2004-07-21 05:57:30 +00:00