Commit Graph

37968 Commits

Author SHA1 Message Date
Guy Harris 8281a7d28e Support nanosecond-resolution time for NetMon 2.x format (it's only
100-nanosecond resolution, but that's still better than microsecond
resolution).

For NetMon 1.x format, only claim to support millisecond resolution, as
that's all you get.

Fix handling of negative time deltas in NetMon 2.x format.

When writing a NetMon file, trim the time of the first packet to
millisecond precision to get the capture start time, so that the start
time written to the file (which has millisecond precision) is the same
as the start time used to calculate the deltas written to the packet
headers.

svn path=/trunk/; revision=39886
2011-11-16 17:54:44 +00:00
Guy Harris 234d0b9614 OK, this should do it.
svn path=/trunk/; revision=39885
2011-11-16 17:13:37 +00:00
Guy Harris 8be474f776 Fix build on Windows.
svn path=/trunk/; revision=39884
2011-11-16 17:12:47 +00:00
Guy Harris 163edbb507 Another place where we have to protect against MSVC's time-conversion
routines blowing up if handed a too-large time_t.

While we're at it, also check for dates that can't be represented in DOS
format (pre-1980 dates).

svn path=/trunk/; revision=39883
2011-11-16 17:08:00 +00:00
Guy Harris 5ceeb22529 Another place where we have to protect against MSVC's time-conversion
routines blowing up if handed a too-large time_t.

svn path=/trunk/; revision=39882
2011-11-16 16:48:02 +00:00
Martin Mathieson 43bf2f8ba6 Show more sequence numbers in info column, and in root nodes.
svn path=/trunk/; revision=39881
2011-11-16 16:32:40 +00:00
Tomas Kukosa bc5301e114 Fix handling of empty OpenType at the end of PDU
svn path=/trunk/; revision=39880
2011-11-16 08:55:02 +00:00
Anders Broman f3c5620c3b - Resorted the IEs in numerical order for easier comparison with the list of constants.
- Added two missing IEs

Solves LPPa embedded payloads not shown within LCS-AP
 https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6478

svn path=/trunk/; revision=39879
2011-11-16 05:54:44 +00:00
Guy Harris 741432d483 Handle ctime() and localtime() returning NULL and localtime() on Windows
blowing up when handed a bad value.

svn path=/trunk/; revision=39878
2011-11-16 03:13:02 +00:00
Guy Harris c73c44cf4b Get rid of unnecessary assignment (the code below it always assigns a
value to the variable).  Praise be to Clang Cat.

svn path=/trunk/; revision=39877
2011-11-16 02:43:58 +00:00
Guy Harris 46575653fd Don't set variables if we don't look at them later. All praise Clang
Cat.

svn path=/trunk/; revision=39876
2011-11-16 02:18:30 +00:00
Bill Meier b7b3df505c Add Jakob Hirsch; Fix bad formatting which screwed up AUTHORS display.
svn path=/trunk/; revision=39875
2011-11-16 02:13:56 +00:00
Bill Meier 1941fd1680 Cleanup & reformatting: whitespace & long-lines.
svn path=/trunk/; revision=39874
2011-11-16 01:59:15 +00:00
Guy Harris 017c9eff05 Thou shalt not use proto_tree_add_string() with an FT_BYTES field.
svn path=/trunk/; revision=39873
2011-11-16 01:56:58 +00:00
Chris Maynard 28e5ff6098 Delete pointless orig_offset variable, initialize speech_data_len[], use tvb_reported_length() instead of tvb_length(), and protect against a possible buffer overflow. This should fix the Clang warning, "packet-evrc.c:364:41: warning: The right operand of '>=' is a garbage value", among other things.
svn path=/trunk/; revision=39872
2011-11-16 01:37:32 +00:00
Guy Harris 225d9b98ef Fix indentation.
svn path=/trunk/; revision=39871
2011-11-16 01:25:49 +00:00
Bill Meier 2103e7f38a tvb_[reported_]length_remaining can return -1
svn path=/trunk/; revision=39870
2011-11-15 21:22:01 +00:00
Bill Meier 3b387d1b8e Remove unneeded #include
svn path=/trunk/; revision=39869
2011-11-15 21:07:37 +00:00
Bill Meier c8a2b19e2b (Trivial) Reformat some long lines & do some whitespace cleanup.
svn path=/trunk/; revision=39868
2011-11-15 20:49:40 +00:00
Anders Broman 8921bb17b5 Check the return value of dissect_sip_name_addr_or_addr_spec()
Should fix the recent fuzz failures.
Thanks Chris for isolating the offending packet.

svn path=/trunk/; revision=39867
2011-11-15 20:14:51 +00:00
Guy Harris 519b219ae8 Squelch a warning. (This code probably needs a review; we really need a
better general framework for parsing text-based protocols.)

svn path=/trunk/; revision=39866
2011-11-15 19:44:24 +00:00
Chris Maynard e7e9d3d8b7 Rename channel_type enums to avoid possible naming conflicts.
svn path=/trunk/; revision=39865
2011-11-15 19:37:16 +00:00
Guy Harris 6dd27d049e More indentation cleanup.
svn path=/trunk/; revision=39864
2011-11-15 19:35:13 +00:00
Guy Harris e102876289 Clean up indentation.
svn path=/trunk/; revision=39863
2011-11-15 19:33:14 +00:00
Anders Broman a586241e06 packet-sip.c:1469: warning: unused variable 'contact_param_end_offset'
svn path=/trunk/; revision=39862
2011-11-15 19:25:17 +00:00
Anders Broman f6f12af894 Restore dissection of contact parameters.
svn path=/trunk/; revision=39861
2011-11-15 19:03:39 +00:00
Bill Meier 36be9da221 Remove unneeded #includes;
Move proto_reg_handoff...() to the end of the file as per convention.

svn path=/trunk/; revision=39860
2011-11-15 19:00:08 +00:00
Bill Meier 199850a52b Move proto_reg_handoff...() to the end of the file as per convention;
Do other minor reformatting and cleanup.

svn path=/trunk/; revision=39859
2011-11-15 18:31:11 +00:00
Bill Meier 02c8228bd2 Add svn:executable to props
svn path=/trunk/; revision=39858
2011-11-15 17:44:14 +00:00
Bill Meier f6e8556a68 Set svn:mime-type to image/png
svn path=/trunk/; revision=39857
2011-11-15 17:41:41 +00:00
Bill Meier 9eba576d23 Set svn:mime-type to image/png
svn path=/trunk/; revision=39856
2011-11-15 17:33:59 +00:00
Bill Meier 804aa453c7 Set svn:mime-type to image/png
svn path=/trunk/; revision=39855
2011-11-15 17:29:27 +00:00
Bill Meier 4987cfd8d5 Set svn:mime-type to image/png
svn path=/trunk/; revision=39854
2011-11-15 17:26:04 +00:00
Bill Meier 1f54861260 Set svn:mime-type to image/png
svn path=/trunk/; revision=39853
2011-11-15 17:18:21 +00:00
Martin Mathieson ed5ac34224 Append important details from LI and SURI trees to root item.
Show some SNs in the info column.

svn path=/trunk/; revision=39852
2011-11-15 15:36:39 +00:00
Bill Meier 47b290c7f5 Fix some props
svn path=/trunk/; revision=39851
2011-11-15 15:28:20 +00:00
Bill Meier 49a47e9745 Fix some svn properties
svn path=/trunk/; revision=39850
2011-11-15 15:16:37 +00:00
Bill Meier 58d87a7230 Fix svn:keywords prop: 'svn:eol-style'->'Id'
svn path=/trunk/; revision=39849
2011-11-15 15:11:35 +00:00
Bill Meier 19e53850b6 Fix svn:keywords prop: 'svn:eol-style'->'Id'
svn path=/trunk/; revision=39848
2011-11-15 15:08:43 +00:00
Bill Meier c26221f6ad Fix props: svn:keyword->svn:keywords; remove svn:executable
svn path=/trunk/; revision=39847
2011-11-15 15:02:01 +00:00
Martin Mathieson 62d16f0fbb UMTS RLC:
- add lookup for "unknown" channel type dissector (mode is known)
- set length extent for SUFI root item
- show data frames in the info column (at least for AM...)

DCT:
- call RLCDCH with "unknown" channel type (as don't know whether IP or RRC)
- support R9

svn path=/trunk/; revision=39846
2011-11-15 12:03:52 +00:00
Alexis La Goutte 8f9b3c6435 Add svn:keywords and svn:eol-style properties
svn path=/trunk/; revision=39845
2011-11-15 08:05:42 +00:00
Alexis La Goutte 9edf24f1ef Enhance CPHA dissector
* Remove struct and sizeof
* Replace proto_tree_add_* by proto_tree_add_item
* Replace CPHA function (report2str, opcode2str...) by standard Wireshark functions
* and minor bug fix

svn path=/trunk/; revision=39844
2011-11-15 07:56:06 +00:00
Anders Broman 47bc2af5fd From Michael Mann:
Bugfixes for both Buildbot issues:
1. seg-fault with multiple_service_packet
2. infinite loop

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6519

svn path=/trunk/; revision=39843
2011-11-15 07:18:39 +00:00
Anders Broman f8467706ac From Michael Mann:
Make it possible to use TortoiseSVN's SubWCRev.exe to update svnversion.h

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5441

svn path=/trunk/; revision=39842
2011-11-15 07:12:19 +00:00
Guy Harris e600a12538 OK, *that's* what Clang Cat was going on about:
packet-dcerpc-pn-io.c:8438:17: warning: Although the value
	stored to 'prm_flag2' is used in the enclosing expression, the
	value is never actually read from 'prm_flag2'

OK, thanks for telling me that, technically,

	prm_flag1 = prm_flag2 = 0;

can be implemented by storing the 0 into prm_flag1 directly rather than
storing 0 into prm_flag2 and copying it to prm_flag1.  Yes, you can haz
cheeseburger.

I guess it would matter if we were actually depending on some
side-effect of fetching prm_flag2, but we're not.  Rewrite this one to
squelch the complaint.

svn path=/trunk/; revision=39841
2011-11-15 05:37:56 +00:00
Guy Harris c8283d1291 Rewrite some odd code. Clang Cat does not want:
packet-reload.c:2875:13: warning: Although the value stored to
	'local_offset' is used in the enclosing expression, the value is
	never actually read from 'local_offset'

although as I read the C90 spec the code is doing pretty much what it
should be doing and the rewritten code does the same thing.  However,
it's also a bit more complicated and harder to read than the rewritten
code.

svn path=/trunk/; revision=39840
2011-11-15 05:25:17 +00:00
Guy Harris 0c530d222a At least as I read the code, there can be up to 3 receive channels (the
number of channels is XXX & 0x03, hence in the range 0-3.

Thanks and a tip of the hat to Clang Cat for catching this.

svn path=/trunk/; revision=39839
2011-11-15 05:10:56 +00:00
Guy Harris 70a8b27948 Get rid of the depth argument to dfilter_macro_apply(); have an internal
routine that does all the work and that takes a depth argumen, and an
external routine that calls that internal routine with a depth argument
of 0.  The depth is only of use internally, to avoid infinite recursion.

When recursing with that routine, pass depth+1 as the depth value,
rather than passing depth and incrementing it afterwards; the latter
doesn't prevent infinite recursion.  (Thanks and a tip of the hat to
Clang Cat for catching this.)

Squelch some other (harmless) warnings from Clang Cat.

Clean up indentation.

svn path=/trunk/; revision=39838
2011-11-15 04:26:38 +00:00
Chris Maynard 91398db56b Append each op name to the operations sub-tree so you don't necessarily have to expand the tree to see which ops are present. I think it makes more sense to append the names here rather than at the top level which was done to resolve bug 6078, but for now, I leave them appended in both places.
svn path=/trunk/; revision=39837
2011-11-14 20:38:05 +00:00