Commit Graph

868 Commits

Author SHA1 Message Date
Guy Harris 81fc518ec6 From Nathan Jennings:
support for user-supplied interface descriptions;

	support for hiding interfaces in drop-down list in capture
	dialog.

Clean up comments written to preferences file.

svn path=/trunk/; revision=8419
2003-09-08 21:44:42 +00:00
Guy Harris 31bce668bd More int vs. uint.
svn path=/trunk/; revision=8409
2003-09-07 00:59:07 +00:00
Guy Harris f6c0519c0a Support string dissector tables in the Tethereal "decode as" stuff.
Make the Ethereal "decode as" stuff not blow up with string dissector
tables.

Selectors for uint dissector tables are unsigned, not signed.

svn path=/trunk/; revision=8408
2003-09-07 00:47:57 +00:00
Guy Harris d66f162b71 From Brian K. Teravskis: add an option to save the data in CSV form.
svn path=/trunk/; revision=8405
2003-09-06 08:30:26 +00:00
Guy Harris 807e75690b Include <string.h> to get "strcmp()" declared.
svn path=/trunk/; revision=8393
2003-09-05 20:00:02 +00:00
Ronnie Sahlberg 95b3b8ca6d Add a popup to the ServicveResponseTime tables where the user can select
Prepare/Match/FindFrame similar to chat the ConversationList has.

Only enabled for SMB and ONC-RPC at this point

svn path=/trunk/; revision=8391
2003-09-05 10:26:44 +00:00
Guy Harris dd2080a646 Don't try to align the field filter name and name - the font would
probably be variable-width, so that doesn't work.  Just put a dash
between them.

Boost the size of the buffer used for the field text to 256 characters.

In GTK+ 1.2[.x], put the entries for fields (rather than protocols) in
as leaf nodes.

svn path=/trunk/; revision=8388
2003-09-05 06:59:38 +00:00
Ronnie Sahlberg 764972414c Add a Find Frame item to the popup menu for the conversation list
that will open the find frame dialogue and preload the filter string
with the conversation and the direction the user selected from the menu.

svn path=/trunk/; revision=8386
2003-09-05 06:16:10 +00:00
Guy Harris a26f4d0682 If Belinda:
http://www.ethereal.com/lists/ethereal-dev/199910/msg00237.html

isn't there, don't try to display her.

svn path=/trunk/; revision=8385
2003-09-05 05:28:50 +00:00
Ronnie Sahlberg d633bccd2f Add some more text to the filter item description in the display filter add expression dialogue
It was very cnfusing where some protocols such as SMB had multiple items all called the same thing.   Now one can distinguish between them

svn path=/trunk/; revision=8383
2003-09-05 03:32:24 +00:00
Ronnie Sahlberg 509c97f79d For endpoint conversations change how Endpoint1 and Endpoint two are selected.
Make the selction of what is endpoint 1 and what is endpoint 2
first check the port (if a port is present it will be !=0) and if
the ports are present set the lowest port as endpoint2.

If the prots are not present or the ports are identical  then compare the addresses instead.

The idea is that low port numbers usually refer to server daemons
and this sorting thus usually puts the client as endpoint 1 and the server as endpoint 2.
It is much more intuitive and makes the table much more readable.

svn path=/trunk/; revision=8381
2003-09-05 01:11:12 +00:00
Ronnie Sahlberg 51b7e878f8 Update DCERPCSTAT, change the program menu to show the programs sorted in alphabetical order
svn path=/trunk/; revision=8380
2003-09-05 00:48:58 +00:00
Ronnie Sahlberg e3cde3715e Update to the conversations list.
Rename it from Endpoint Talkers to : Conversation List

Change command line arguments to both tethereal and ethereal
to be -z conv,<type>
to reflect the new name Conversations

This is the last time the tethereal cmd line arg is changed.  But now it has a
proper intuitive name at least.

io,users was weird
talkers was too close to names used in other tools

svn path=/trunk/; revision=8379
2003-09-04 23:37:45 +00:00
Ronnie Sahlberg 4f893552d0 fix our-of-bounds bug in teh port to string conversion routine
svn path=/trunk/; revision=8378
2003-09-04 23:12:46 +00:00
Ronnie Sahlberg b4f94f13b6 Update to endpoint talkers. move lots of duplicated code into teh helper endpoint_talkers_table.c
svn path=/trunk/; revision=8377
2003-09-04 23:11:03 +00:00
Ronnie Sahlberg 188a4e8d81 Uglify endpoint_talkers_table.c
make it know how to build the filter strings, address and port hf_ fields properly so TCP and UDP works and is agnostic on whether ipv4 or ipv6 is used as transport

svn path=/trunk/; revision=8368
2003-09-04 11:07:51 +00:00
Guy Harris d7c622e309 Check for "wtap_seek_read()" failing.
svn path=/trunk/; revision=8364
2003-09-03 23:32:40 +00:00
Ronnie Sahlberg b9ce30cd35 And for Cal,
Ethereal presents   a column to display culmulative bytes into the capture.

A new column type is added : Culmulative Bytes.
While PacketLength column type specifies the number of bytes in the current packet,
Culmulative Bytes specifies the culmulative number of bytes from the start of the capture.

svn path=/trunk/; revision=8359
2003-09-03 10:49:03 +00:00
Ronnie Sahlberg bb21d8c03c fix to various stats tables.
The code used to rely on min_time==0 to determine whether this was the first
packet or not and whereby we had to initialize min_time to the current value.

This obviously does not work for capture files with poor timestamp resolution
where the response time is actually, according to the capture file, 0
and we got all sorts of weird effects like average response time being less than the minimum response time.

note, the bug only affected the minimum response time in the tables and not max or average response time.
it would "miss" tose minimum response times that were ==0 and display the minumin response time in the capture that were >0

svn path=/trunk/; revision=8358
2003-09-03 10:10:18 +00:00
Guy Harris fdfd8b58af The code in an HTTP reply is a response code, not a response method.
svn path=/trunk/; revision=8346
2003-09-02 23:09:11 +00:00
Guy Harris 75ae0e30c7 From Jean-Michel Fayard: BOOTP/DHCP, HTTP, and WSP statistics taps.
svn path=/trunk/; revision=8345
2003-09-02 22:47:59 +00:00
Guy Harris 71034c5a3f From Jean-Michel Fayard: show in Tools:Summary window statistics about
packets that passed the current display filter, as well as about the
entire capture.

Document the Tools:Summary item in the man page.

Update Gerald's e-mail address.

svn path=/trunk/; revision=8344
2003-09-02 22:10:32 +00:00
Gerald Combs 9d603ccc2c Make sure the color selection dialog displays a color selection widget.
Tweak the button layout slightly.

svn path=/trunk/; revision=8332
2003-09-02 18:27:50 +00:00
Ronnie Sahlberg b0bec4d79a When putting the filename in the titlebar
just put the filename there and not the full path to the file.

svn path=/trunk/; revision=8329
2003-09-02 08:27:43 +00:00
Gerald Combs d87e75c585 Make the capitalization of the "Name Resolution" frame consistent with the
other frames.

svn path=/trunk/; revision=8327
2003-09-01 01:49:20 +00:00
Guy Harris f11ef57387 Include "tap.h" to get "remove_tap_listener()" declared.
svn path=/trunk/; revision=8322
2003-08-31 00:31:05 +00:00
Ronnie Sahlberg 82c1757345 Remove the individual reset functions and replace with a common one in the helpers file.
cleanup part 5?

svn path=/trunk/; revision=8320
2003-08-30 01:18:16 +00:00
Ronnie Sahlberg ce8477a3ed step 3 in endpoint talkers cleanup
get rid of the draw_packets wrapper in the individual endpoint files

svn path=/trunk/; revision=8319
2003-08-30 01:05:03 +00:00
Ronnie Sahlberg 1b81e773a7 step two in endpoint talkers cleanup
move the windows destroy function to the common helpers file

svn path=/trunk/; revision=8318
2003-08-30 00:53:15 +00:00
Ronnie Sahlberg 7789678033 step one in endpoint talkers cleanup
svn path=/trunk/; revision=8317
2003-08-30 00:47:43 +00:00
Ronnie Sahlberg 4135309cbd Add endpoint talkers support for FDDI to ethereal and tethereal
Welcome FDDI into the endpoint talkers family.

Nobody gets left behind!

svn path=/trunk/; revision=8310
2003-08-29 10:59:12 +00:00
Ronnie Sahlberg 19a99f8a34 Make the hex to string conversion code in find_dlg.c handle ':' characters
such as you might find when doing "prepare" on a FT_BYTES field.

So one need not delete the ':' characters manually

svn path=/trunk/; revision=8309
2003-08-29 09:32:16 +00:00
Guy Harris 56664b9b77 Make the CList of character sets non-editable, so you only get to choose
from what we offer.  (XXX - should it be an option menu, instead?)

svn path=/trunk/; revision=8308
2003-08-29 04:56:46 +00:00
Guy Harris 1cf6565adc Get rid of the EBCDIC stuff in the find dialog - it's not supported yet,
so we shouldn't torment the users by offering it.

Check the string type and convert it to an internal representation in
the GUI code; have the search code deal only with the internal
representation.

Save the case-sensitivity flag, and the indication of where string
searches look, along with other search parameters.

Upper-casify the string, for case-insensitive searches, in the GUI code;
don't save the upper-casified string, so it doesn't SHOUT at you when
you next pop up a "find" dialog.

Convert the hex value string to raw binary data in the GUI code, rather
than doing so in the search code.  Check that it's a valid string.

Connect the signals to the radio buttons after the pointers have been
attached to various GUI items - the signal handlers expect some of those
pointers to be attached, and aren't happy if they're not.

Have "find_packet()" contain a framework for searching, but not contain
the matching code; instead, pass it a pointer to a matching routine and
an opaque pointer to be passed to the matching routine.  Have all the
routines that do different types of searching have their own matching
routines, and use the common "find_packet()" code, rather than
duplicating that code.

Search for the Info column by column type, not by name (the user can
change the name).

When matching on the protocol tree, don't format the entire protocol
tree into a big buffer - just have a routine that matches the text
representation of a protocol tree item against a string, and, if it
finds a match, sets a "we found a match flag" and returns; have that
routine not bother doing any more work if that flag is set.
(Unfortunately, you can't abort "g_node_children_foreach()" in the
middle of a traversal.)

Free the generated display filter code after a find-by-display-filter
finishes.

svn path=/trunk/; revision=8306
2003-08-29 04:03:46 +00:00
Guy Harris 2af6770410 From Greg Morris: put borders around the options to delimit them and
indicate where they apply, and give tooltips to some of the options.
Disable the "Filter:" button unless we're searching with a display filter.

Use "Frame data" instead of "Hex" for the option to search the raw frame
data, use "Decoded packet" instead of "Decode" for the option to search
the strings in the protocol tree display, and use "Packet summary"
instead of "Summary" for the option to search the Info column in the
packet list display, to make it a bit clearer what's being searched.

svn path=/trunk/; revision=8303
2003-08-28 23:25:55 +00:00
Olivier Abad 0c678f74c7 Marking packets with the middle mouse button works now with GTK2.
svn path=/trunk/; revision=8301
2003-08-28 20:33:14 +00:00
Guy Harris 2d71f3589d Use "GPOINTER_TO_INT()" to convert the return value of
"gtk_clist_get_row_data()" to an "int", to squelch compiler warnings.

svn path=/trunk/; revision=8286
2003-08-27 23:01:10 +00:00
Guy Harris 115700bc62 From Richard Urwin:
use Export and Import for the buttons in GTK+ 2.x as well;

	get rid of a duplicate fclose;

	other fixes.

Update the description of color filters in the Ethereal man page to
reflect the change, clean up the formatting (use =item), and add the
global and personal color filters files to the FILES section; refer to
them as "color filters" files rather than "colorfilters" files, as the
FILES section gives the "colorfilters" file name so you don't have to
use that as the name.

Clean up white space.

svn path=/trunk/; revision=8285
2003-08-27 22:55:51 +00:00
Ronnie Sahlberg a7d0d4bf16 update to the talkers popup list.
hopefully it will now create the filter for the actual conversation
we selected.

add EP1 <-> ANY and EP2 <-> ANY fitlers

svn path=/trunk/; revision=8283
2003-08-27 21:54:36 +00:00
Gilbert Ramirez 52338a3baf Add a "contains" operator for byte-strings, strings, and tvbuffs (protocols).
The search uses a naive approach; more work is required to add a
Boyer-Moore Search algorithm.

svn path=/trunk/; revision=8280
2003-08-27 15:23:11 +00:00
Ronnie Sahlberg d3562c0480 Updates for the endpoint talkers thing
The table now has a popup menu with
   Match display filter
         Selected
               EP1 <-> EP2
               EP1 --> EP2
               EP1 <-- EP2
               EP1 --> ANY
               EP1 <-- ANY
               EP2 --> ANY
               EP2 <-- ANY
          Not Selected
               ...
          ...
    Prepare Display Filter
          ...

Self explanatory.

Now the bad news.
I set the display filter box in the main window and i call redissect_packet
which redissects the packet list   but the displayfilter does not take
or affect the main window until i click  the apply button.

Some signal needs to be raised to some object me thinks.

Please feel free to fix it if you know what is missing.

svn path=/trunk/; revision=8279
2003-08-27 12:10:21 +00:00
Guy Harris f91af72c55 All endpoint talkers table taps use "address_to_str()" as the routine to
use to translate addresses to strings - wire that into
"endpoint_talkers_table.c", don't pass the function as an argument to
"init_ett_table()".

svn path=/trunk/; revision=8263
2003-08-26 01:46:23 +00:00
Guy Harris e22b6afeb7 From Matthijs Melchior:
make the "Help" menu the rightmost menu item, as is done in

		recent versions of Windows;

		Mac OS X;

		recent versions of KDE;

		recent versions of GNOME;

	rather than making it an item on the far right side.

	Make the "Protocol" display in the help mention the number of
	entries, and give it has 3 columns, starting with the one that
	was used to sort this list.

	Make the "Display Filters" display mention the number of fields
	for each protocol and at the end the total number of fields.
	Give it 4 columns, including the 'blurb'.

	List all fields with the correct protocol.

svn path=/trunk/; revision=8253
2003-08-25 21:42:33 +00:00
Ronnie Sahlberg cd016e69a9 Update to IO-Stat to put the capture filename on the titlebar
to make it easier to navigate when having multiple instances of ethereal
and io-stat open
at the same time.

Updates to all endpoint talkers and service response time windows to do this as well.

Bonus, when the user opens a new capture file when having these windows open,
the title bar will be updated to reflect the name of the new capture file.

svn path=/trunk/; revision=8251
2003-08-25 11:06:32 +00:00
Guy Harris e4e0150ffa From Matthijs Melchior:
support for registering fields after all the protocol
	    registration routines are called (i.e., adding fields to the
	    named field tree as they're registered);

	fix the GTK 2.x version of the field list dialog to show the
	    correct name.

svn path=/trunk/; revision=8248
2003-08-25 00:15:02 +00:00
Guy Harris 7540493b20 Get rid of the wrappers around "address_to_str()".
svn path=/trunk/; revision=8245
2003-08-24 22:34:32 +00:00
Ronnie Sahlberg 0f9440cb55 The IPX endpoint talkers implementation
svn path=/trunk/; revision=8241
2003-08-24 05:39:05 +00:00
Ronnie Sahlberg 38e52de283 Add endpoint talker support for IPX
svn path=/trunk/; revision=8240
2003-08-24 05:38:23 +00:00
Ronnie Sahlberg bcfc2719b9 Update address_to_str to handle FC and ETH addresses as well.
Update the fc and eth and tr  endpoint talker list to use the new api

svn path=/trunk/; revision=8235
2003-08-24 03:00:11 +00:00
Ronnie Sahlberg 521db7b61f Add a new function address_to_str to to_str.c
Implement conersion from address to string for IPv4 and IPv6
and update the conversation tables to use the new interface.

svn path=/trunk/; revision=8234
2003-08-24 02:50:32 +00:00