Commit graph

20929 commits

Author SHA1 Message Date
Guy Harris
8093569ebe Add a couple more warnings to the standard set.
svn path=/trunk/; revision=21516
2007-04-23 00:28:50 +00:00
Guy Harris
3b884cb0df Propagate Joerg's fix to make --enable-extra-gcc-checks turn off
--enable-warnings-as-errors (if any tests enabled by
--enable-extra-gcc-checks are safe to treat as errors, they're safe to
turn on by default).

svn path=/trunk/; revision=21515
2007-04-22 23:52:38 +00:00
Guy Harris
aff8dc680d Turn on almost all warnings for Wiretap - if any of them cause problems
on some platforms due to unfixable problems (e.g., crappy vendor
headers), we can move them back to the "extra" list.

Put those warnings in the order in which they appear in the GCC man page
on my machine.

If we turn on -pedantic, try turning on -Wno-long-long as well, so that
it's not *so* pedantic that it rejects the 64-bit integral data types
that we explicitly require.

svn path=/trunk/; revision=21514
2007-04-22 23:47:56 +00:00
Jörg Mayer
8ff9801ec1 Fix regression: Automatically disable -Werror in case of extra gcc flags.
svn path=/trunk/; revision=21513
2007-04-22 23:01:49 +00:00
Bill Meier
cb92dd7019 Another fix to allow gtk1 to compile w/o warnings....
svn path=/trunk/; revision=21512
2007-04-22 22:23:19 +00:00
Sebastien Tandel
da8eba288d set #ifndef __USE_XOPEN instead of only #ifndef
should fix rev21508

svn path=/trunk/; revision=21511
2007-04-22 21:55:39 +00:00
Guy Harris
82583f9697 "struct sack_chunk_header" is presumably just a SACK chunk header
followed by zero or more gap start/end pairs; fix up the previous fix to
handle that correctly.

svn path=/trunk/; revision=21510
2007-04-22 20:43:01 +00:00
Guy Harris
a346e923b7 Don't play type-punning games - they cause compiler warnings (not that
anybody appears to ever *set* sack_header->gaps).

svn path=/trunk/; revision=21509
2007-04-22 20:29:31 +00:00
Jörg Mayer
b16106f89f Only #deinfe __USE_XOPEN if not already defined. On my Suse 10.2 it was
already #defined to 1, so this would create a warning/error.


svn path=/trunk/; revision=21508
2007-04-22 20:04:34 +00:00
Guy Harris
065be642f4 Get rid of some const warnings.
Use the "pnto" macros to fetch 16-bit quantities from a buffer - not
only do they have the right casts to avoid const warnings, they also
work even on platforms (such as SPARC) where you can't dereference
unaligned pointers without a trap.

Similarly, compare a possibly-unaligned (we make no alignment guarantees
in Wireshark) 16-bit quantity against 0 a byte at a time.

svn path=/trunk/; revision=21507
2007-04-22 18:26:45 +00:00
Guy Harris
6327554e6c Check the GLib version number, not the GTK+ version number; it's GLib we
care about, and this code doesn't use GTK+, so it doesn't include any
GTK+ headers and therefore doesn't get the GTK+ version number defined.

svn path=/trunk/; revision=21506
2007-04-22 18:04:52 +00:00
Ronnie Sahlberg
a4ae600125 move some headers so that the compile works on gtk1
svn path=/trunk/; revision=21505
2007-04-22 16:44:36 +00:00
Ronnie Sahlberg
a1131be153 move include of a few headers down a few lines so the compile works on
gtk1

svn path=/trunk/; revision=21504
2007-04-22 16:40:34 +00:00
Ronnie Sahlberg
40c806f54b compile fix for gtk1
svn path=/trunk/; revision=21503
2007-04-22 15:49:29 +00:00
Ronnie Sahlberg
416a353ee7 fix compiler warning for gtk1 builds
svn path=/trunk/; revision=21502
2007-04-22 15:48:18 +00:00
Ronnie Sahlberg
26ee9ac8ea dont include these headers under gtk1
svn path=/trunk/; revision=21501
2007-04-22 15:45:34 +00:00
Ronnie Sahlberg
872398a417 some updates to allow gtk1 to compile without warnings
svn path=/trunk/; revision=21500
2007-04-22 15:43:01 +00:00
Ronnie Sahlberg
7a97135752 GString.len has changed signednedd between gtk1 and gtk2
this will hopefully again compile under both gtk1 and 2


svn path=/trunk/; revision=21499
2007-04-22 15:22:53 +00:00
Sebastien Tandel
a265df648d update of AC_WIRESHARK_PCAP_CHECK to detect if pcap header version is
corresponding to the library version for pcap_breakloop. Issue a warning if the
pcap_breakloop is present but not usable.


svn path=/trunk/; revision=21498
2007-04-22 13:38:50 +00:00
Jörg Mayer
7b20d35047 Fix a signedness warning.
svn path=/trunk/; revision=21497
2007-04-22 11:51:36 +00:00
Jaap Keuter
647446dadf Fix for bug 1541. Adjust offset for long longs by 8, not by 4.
svn path=/trunk/; revision=21496
2007-04-22 10:29:47 +00:00
Michael Tüxen
18c6fbb379 From Irene Ruengeler: Fix a bug regading the handling of ABORT chunks.
svn path=/trunk/; revision=21495
2007-04-22 10:25:26 +00:00
Ronnie Sahlberg
99bc488535 fix the sign of a variable to prevent a singed/unsigned warning during
compiling


svn path=/trunk/; revision=21494
2007-04-22 09:58:12 +00:00
Sebastien Tandel
706627f882 adding AC_(WIRESHARK|WIRETAP)_GCC_CFLAGS_OPTION macro to test whether gcc
supports the options passed as arguments. If the options are supported, they
are added to CFLAGS.


svn path=/trunk/; revision=21493
2007-04-22 09:27:21 +00:00
Guy Harris
23faf81799 Use AC_HELP_STRING for the help strings for --with and --enable flags.
Add -Wpointer-arith to the GCC -W flags by default.

Make "extra-gcc-checks" and "warnings-as-errors" --enable flags rather
than --with flags - autoconf's model is that --enable is for turning
features on or off, --with is for enabling or disabling the use of
external packages (libpcap, Net-SNMP, GNU ADNS, etc.).

When testing whether the compiler is GCC, use the same style all the
time - check whether "x$GCC" equals "xyes".  (The "x" might be overkill
- if you don't quote the arguments, it avoids a missing argument to
"test"/"[", but if you do, it might not be needed.)

svn path=/trunk/; revision=21492
2007-04-22 07:22:37 +00:00
Guy Harris
464e5030ca Fix a comment to reflect reality - -Wcast-qual is added only with
--with-extra-gcc-checks.

Unconditionally add -Wpointer-arith to GCC flags, and, if
--with-extra-gcc-checks is specified, add -Wstrict-prototypes.

svn path=/trunk/; revision=21491
2007-04-21 23:04:36 +00:00
Guy Harris
3b120c2491 Match "%4x" with an unsigned value in sscanf.
Check for a case where, conceivably, the on-the-wire packet length (from
the IP header) could be shorter than the captured data length (due to
Ethernet padding), and handle it by making sure the on-the-wire length
is always >= the captured data length.

svn path=/trunk/; revision=21490
2007-04-21 22:59:52 +00:00
Guy Harris
48f03c7800 Get rid of a warning with at least some compilers.
svn path=/trunk/; revision=21489
2007-04-21 22:58:03 +00:00
Guy Harris
5713f53652 Explicitly mark new_k12_file_data() as taking no arguments - in C89, at
least, "int foo()" defines or declares an old-style function, not one
with no arguments.

svn path=/trunk/; revision=21488
2007-04-21 22:57:22 +00:00
Anders Broman
4960e68578 EXPORT DialoguePDU UniDialoguePDU and make them callable by OID.
svn path=/trunk/; revision=21487
2007-04-21 20:53:35 +00:00
Anders Broman
eab3eb5c68 Put some missing TAG:s in the tree if internal BER fields shown.
svn path=/trunk/; revision=21486
2007-04-21 20:27:05 +00:00
Stephen Fisher
94e4258172 Fix bug #1547: Expert Info Composite column "Count" is not sorting numerically
svn path=/trunk/; revision=21485
2007-04-20 23:10:03 +00:00
Gerald Combs
02926636da Move some data frame back out of the control frame scope, so Wireshark
will stop crashing.

More .11n additions and updates from Dustin:

  - Power Capability tag
  - Supported Channels tag
  - Block Ack/Block Ack Request

Fixup whitespace.

svn path=/trunk/; revision=21484
2007-04-20 22:29:11 +00:00
Gerald Combs
2c9c0f3651 Fix 64-bit integer handling and whitespace.
svn path=/trunk/; revision=21483
2007-04-20 18:09:31 +00:00
Gerald Combs
24b3b66ba8 More .11n-related updates and additions from Dustin Johnson and myself:
- MIMO Control frame support
  - Control Wrapper frame support
  - Measurement Pilot
  - Action No Ack
  - Block Ack Action
  - PCO Phase Control
  - PSMP Parameter Set
  - Antenna Selection
  - Extended Channel Switch Announcement
  - HT Information
  - HT Action
  - MIMO CSI Matrices Report
  - Fill in and update a bunch of hf strings
  
Fixup(?) whitespace.

svn path=/trunk/; revision=21482
2007-04-20 17:40:13 +00:00
Sebastien Tandel
def734249e Since code generated by lex may trigger gcc warnings, we are now generating two
libraries.  A single library is generated with the lex code without the barrier
"stop on warning". An other library is generated from the remaining source
files with the "stop on warning" barrier.


svn path=/trunk/; revision=21481
2007-04-20 14:30:48 +00:00
Sebastien Tandel
366716e31d get rid of some unused parameters in process_ssl_payload
svn path=/trunk/; revision=21480
2007-04-20 14:19:20 +00:00
Anders Broman
5954b97ac4 Add EXTERNAL to the value string and add comments about UNIVERSAL tags.
svn path=/trunk/; revision=21479
2007-04-20 13:54:56 +00:00
Jörg Mayer
31937c3b30 Add Recognition of ELRP (Extreme Loop Recognition Protocol) Elements.
I don't know how to decode them though.

Fix some typos.

Change some Element descriptions.

svn path=/trunk/; revision=21478
2007-04-20 09:26:59 +00:00
Richard van der Hoff
5c50b6f96f From Hannes Gredler:
attached a small bugfix that uses the correct bits
for determining if the ATM payload is a OAM cell.


svn path=/trunk/; revision=21477
2007-04-19 17:13:49 +00:00
Richard van der Hoff
e12cf1df47 fix typos
svn path=/trunk/; revision=21476
2007-04-19 17:03:58 +00:00
Tomas Kukosa
635171a4c0 added missing dependency in tagged type
svn path=/trunk/; revision=21475
2007-04-19 12:58:31 +00:00
Tomas Kukosa
1bf555aa2f export dissect_ber_tagged_type()
svn path=/trunk/; revision=21474
2007-04-19 12:57:23 +00:00
Tomas Kukosa
840b4e46a9 register the right dissector for SIP over SSL/TLS
svn path=/trunk/; revision=21473
2007-04-19 07:09:59 +00:00
Richard van der Hoff
674306a87d following advice from Gerald, Graham Bloice, and others, let's try copying the unit test executables into the wireshark-gtk2 directory before running them.
svn path=/trunk/; revision=21472
2007-04-18 22:31:47 +00:00
Anders Broman
e7e9a81155 Fix to BUG GSM CAMEL-3 GPRS InvokeInitialDPGPRS.APN decoded incorrectly
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1543

svn path=/trunk/; revision=21471
2007-04-18 21:52:11 +00:00
Stephen Fisher
4d0920e5d6 Remove a linebreak from an error message dialog so it wraps properly
svn path=/trunk/; revision=21470
2007-04-18 21:42:37 +00:00
Tomas Kukosa
cfc38cfdbd use new possibility to set #.EXPORTS flag for whole directive
svn path=/trunk/; revision=21469
2007-04-18 10:52:46 +00:00
Martin Mathieson
d01b682f52 Make specifier string match args
(may not be the intended formatting, but it builds...)

svn path=/trunk/; revision=21468
2007-04-18 09:23:27 +00:00
Tomas Kukosa
a6a0a76c45 usage of new #.MAKE_DEFINES asn2wrs directive in RNSAP
svn path=/trunk/; revision=21467
2007-04-18 08:58:48 +00:00