Commit Graph

241 Commits

Author SHA1 Message Date
Stephen Fisher 3e60203474 Fix a few more problems found by checkAPIs.pl
svn path=/trunk/; revision=26887
2008-12-01 07:31:07 +00:00
Stig Bjørlykke f9c07203cb Still support GTK 2.4.0. No separator in combo box for GTK 2.4.0 :(
svn path=/trunk/; revision=26748
2008-11-11 12:46:16 +00:00
Stig Bjørlykke 053dd12cbd Rewrote interface type option_menu to gtk_combo_box, this fixes the bug
showing the correct type on connect failure or cancel in the remote
interface dialog.

Added list of recent remote hosts to interface type combo box.
Save the recent remote hosts in the recent file.
Fixed some indents.

svn path=/trunk/; revision=26747
2008-11-11 11:37:53 +00:00
Stig Bjørlykke 0132b9a092 Save the remote interfaces list to be able to show the remote IP addresses
without fetching a new list each time the interface changes.

Catch the "activate" signal on the text boxes in the remote interfaces dialog.

svn path=/trunk/; revision=26727
2008-11-07 15:52:14 +00:00
Stig Bjørlykke 7d8a21da5a Initialize the interface type value key to fix updating the local interface
list when changing from remote to local interfaces.

svn path=/trunk/; revision=26720
2008-11-06 22:36:43 +00:00
Stig Bjørlykke 2e3656d31a Fixed a check button text.
svn path=/trunk/; revision=26709
2008-11-06 15:33:44 +00:00
Stig Bjørlykke 2207381990 Changes in the "Capture Options" window:
- Moved all RPCAP settings to a "Remote Settings" dialog
- Rearranged "Buffer size" and "Wireless Settings" on win32
- Fall back to local interfaces when error listing remote interfaces
- Fixed setting correct sampling type when reopening the capture dialog
- Aligned some widgets in the "Capture Options" frame 
- Added some tooltips

svn path=/trunk/; revision=26687
2008-11-04 18:50:34 +00:00
Stig Bjørlykke 32d411be1d Do not set buffer size for remote interfaces or when using default value.
Do not get link-layer for remote interfaces.

svn path=/trunk/; revision=26683
2008-11-03 21:38:53 +00:00
Stig Bjørlykke 1655ca17d0 Do not use functions for remote capture on local interfaces.
This makes it possible to compile with remote capture features on unix.

svn path=/trunk/; revision=26681
2008-11-03 20:04:01 +00:00
Stig Bjørlykke 32b542de4f Use invisible event boxes so the preferences looks good when using themes.
svn path=/trunk/; revision=26502
2008-10-20 19:18:12 +00:00
Guy Harris ce89de75da If capture_dlg_prep() finds an error, don't continue with the capture.
Get rid of an extra g_strdup() (get_if_name() doesn't mangle its
argument and doesn't modify prefs.capture_device).

If there's no interface on which to capture, pop up a dialog to indicate
that.

svn path=/trunk/; revision=25997
2008-08-13 08:15:47 +00:00
Jaap Keuter bfc12627c9 From Alexey Neyman:
Start Wireshark without a preference file saved. Open the capture options dialog, 
then click "Start" button without selecting any interface. Wireshark segfaults while
dereferencing NULL pointer in get_if_name() called from capture_start_cb().

svn path=/trunk/; revision=25987
2008-08-12 05:14:29 +00:00
Bill Meier 56206e0002 Fix some simple cases of GTK2 deprecated API usage by using a renamed or equivalent API
gtk_container_border_width()          ==> gtk_container_set_border_width()
  gtk_container_children()              ==> gtk_container_get_children()
  gtk_entry_new_with_max_length()       ==> gtk_entry_new(); gtk_entry_set_max_length()
  gtk_menu_append()                     ==> gtk_menu_shell_append()
  gtk_menu_prepend()                    ==> gtk_menu_shell_prepend()
  gtk_notebook_set_page()               ==> gtk_notebook_set_current_page()
  gtk_paned_gutter_size()               ==> gtk_paned_set_gutter_size()
  gtk_radio_button_group()              ==> gtk_radio_button_get_group()
  gtk_signal_connect()                  ==> g_signal_connect()
  gtk_signal_disconnect()               ==> g_signal_handler_disconnect()
  gtk_signal_emit_by_name()             ==> g_signal_emit_by_name()
  gtk_signal_handler_block_by_data()    ==> g_signal_handlers_block_matched()
  gtk_signal_handler_block_by_func()    ==> g_signal_handlers_block_by_func()
  gtk_signal_handler_unblock_by_data()  ==> g_signal-handlers_unblock_matched()
  gtk_signal_handler_unblock_by_func()  ==> g_signal-handlers_unblock_by_func()
  gtk_spin_button_get_value_as_float()  ==> gtk_spin_button_get_value()
  gtk_toggle_button_set_state()         ==> gtk_toggle_button_set_active()

svn path=/trunk/; revision=25634
2008-06-29 15:51:43 +00:00
Guy Harris f441b8941e Add gtk/capture_globals.h, to declare global_capture_opts, so files that
don't need global_capture_opts don't need to have it declared and thus
don't need capture_options defined.

Include gtk/capture_globals in the files in question.

Change some more capture_opts references to refer to
global_capture_opts.

Change some global_capture_opts references in routines with a
capture_opts argument to refer to capture_opts.

The structure type is capture_options, not capture_opts; fix some
references.

Include <sys/types.h>, if it's present, in capture_opts.h, so we get
gid_t defined.

Clean up indentation.

svn path=/trunk/; revision=25574
2008-06-24 03:38:15 +00:00
Guy Harris e53bf053f9 For now, just refer to global_capture_opts, replacing references to the
now-defult global capture_opts pointer; we eventually should try to
minimize the use of global variables.

Export global_capture_opts from gtk/main.h.

Clean up indentation.

svn path=/trunk/; revision=25571
2008-06-24 02:22:36 +00:00
Stig Bjørlykke 860028c634 Removed the usage of topic_available() as we now have all topics.
svn path=/trunk/; revision=25505
2008-06-21 13:36:31 +00:00
Stig Bjørlykke 4889fc41e9 Make storage-based and time-based "Next file every" checkboxes behave equal
in "Use multiple files".  Also default to storage-based if not time-based.

This fixes the initial problem in bug #2599.

svn path=/trunk/; revision=25489
2008-06-19 17:25:34 +00:00
Stig Bjørlykke 561f66c1b8 Added an option to set default link-layer header type for each interface.
Set linktype history for each interface so we don't mix them.
Fixed some indents.

svn path=/trunk/; revision=25411
2008-06-02 17:45:03 +00:00
Guy Harris b35278d5d4 ...but not with a comment inside a comment, as that might cause a
warning.

svn path=/trunk/; revision=25206
2008-05-01 07:21:15 +00:00
Guy Harris 2adb021211 Get rid of C++/C99 comment.
svn path=/trunk/; revision=25205
2008-05-01 07:18:58 +00:00
Ulf Lamping 0b97c4211e sort #includes by directories
svn path=/trunk/; revision=24967
2008-04-13 00:55:59 +00:00
Ulf Lamping b51da2eb77 rename menu -> main_menu
remove old (and unused and confusing) ../menu.h

svn path=/trunk/; revision=24947
2008-04-12 19:18:26 +00:00
Ulf Lamping b4f3c5fd40 compat_macros.h is gone now!!!
all GTK1 compatibility code was removed, so this file can simply be dropped

svn path=/trunk/; revision=24923
2008-04-12 01:41:53 +00:00
Ulf Lamping 55c2be83db move stock icon code from toolbar.c into specific stock_icons file(s)
svn path=/trunk/; revision=24921
2008-04-12 00:49:20 +00:00
Stephen Fisher 41654fe5e4 Start getting rid of the uses of compat_macro.h's macros.
svn path=/trunk/; revision=24860
2008-04-09 05:37:53 +00:00
Ulf Lamping 6bd3a882ee remove GTK1 code
svn path=/trunk/; revision=24810
2008-04-06 22:25:36 +00:00
Stig Bjørlykke ad5e6ad06b Removed some more "statement not reached" warnings.
svn path=/trunk/; revision=24283
2008-02-07 12:52:08 +00:00
Tomas Kukosa 08bbd29c71 Support for RPCAP features in GUI (from Boris Misenov, see Bug 1366)
- retrieving the list of remote PCAP interfaces
  - password authentication support
  - UDP data fransfer
  - packet sampling (available in WinPcap 4.x)
  etc.

fix problem if non-default rpcap port is used

svn path=/trunk/; revision=23750
2007-12-04 11:19:29 +00:00
Gerald Combs 92802883a6 Change the "--enable-setuid-install" option to install dumpcap and TShark
setuid instead of Wireshark.  Remove the "DANGEROUS" notices, but leave it
disabled by default.  Whine if the user runs Wireshark or TShark as root.
Add a preference to disable the whining.  Add a "setuid-root" script that
can be used to switch dumpcap and TShark's setuid-ness on and off for
development and testing.  Update the release notes and README.packaging.

svn path=/trunk/; revision=22733
2007-08-30 00:24:40 +00:00
Jeff Morriss 2f77efce7d Fix bug http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1757 :
Try to call get_interface_descriptive_name() as little as possible (storing
the result in capture_opts) to avoid a performance hit during live capture
(especially if you have lots of interfaces) and to avoid leaking memory.

One issue with this is that capture_opts.c cannot (without adding significant
dependencies) set the iface_descr so readers of that field (only gtk/main.c
and tshark.c) use a macro to (set if not already set and) get the value of
that field.

svn path=/trunk/; revision=22587
2007-08-22 16:30:16 +00:00
Gerald Combs c02e0c7b4a Remove the "-I" flag from dumpcap, and add a "-M" flag used to specify
that "-D" and "-L" should produce machine-readable output.  Use this to
move an indirect get_pcap_linktype() call from the GUI to dumpcap.

svn path=/trunk/; revision=22367
2007-07-20 21:43:07 +00:00
Gerald Combs e9f1a0b692 One more step in privilege separation.
Add a capture_interface_list(), which works similar to
get_interface_list() except that it forks dumpcap instead of calling
the pcap routines directly.  Use it in the GUI.

Add a "-I" flag to dumpcap, which prints out verbose interface
information.

Tested under Windows and Linux.

svn path=/trunk/; revision=22071
2007-06-11 03:58:58 +00:00
Gerald Combs 55d2b928c2 From Dustin Johnson:
- Update the wireless/AirPcap GUI code to support 802.11n as well as
    some related upcoming code changes.
  - Remove airpcap.h from the repository, since it exists in the AirPcap
    devpack (and will be superseded Real Soon Now).
  - Show the individual channel flag bits in radiotap.
  
Fix the 802.11n MCS set display.

This is a partial checkin, so hopefully nothing is broken.

svn path=/trunk/; revision=21831
2007-05-18 21:06:20 +00:00
Sebastien Tandel 2371ad2eb0 fix gcc warning about qualifier types (const) which are discarded when arriving
at the pcap interface.

svn path=/trunk/; revision=21417
2007-04-13 20:59:20 +00:00
Stephen Fisher e99aa2fe23 Update to revision 21038 - line up the IP address label with the
rest of the items in that part of the capture dialog.


svn path=/trunk/; revision=21039
2007-03-17 00:10:48 +00:00
Stephen Fisher c1132d9a4b Fix bug #1375: Capture Options with many IP addresses scrolls off
screen

Changed IP address label to fit into an event box which is in the ip
address hbox.  This allows the label to expand to fit the capture dialog
window, but no further.  Expanding the capture dialog window will show 
more IP addresses.  Left align the label.  Add ... in the middle of a
long list of IP addresses to show the first few and the last few with
the gtk_label_set_ellipsize() function in GTK 2.6 and up. 


svn path=/trunk/; revision=21038
2007-03-16 22:05:57 +00:00
Gerald Combs ed12aa0cb1 Propagate the recent interface list changes (r20521) to the AirPcap code.
Fix a mismatched declaration found by Gisle Vanem.

svn path=/trunk/; revision=20535
2007-01-23 20:12:09 +00:00
Guy Harris cc22748169 Have the routines to get interface lists take a pointer to a "gchar *"
as an argument, and, on an error, if they have an error message, have
them set that "gchar *" to point to a g_malloc()ed string containing the
error message, rather than taking a pointer to a buffer for that message
as an argument.  That's more like what's done in Wiretap, and doesn't
impose an upper limit on the lengths of those error messages.  If that
pointer is null, don't allocate the message string and return it.

Have that error message already have the "cant_get" processing applied
to it, so nobody other than those routines need to call the "cant_get"
routines to process the error messages.

Have get_airpcap_interface_list() explicitly set "*err" to the
appropriate error code.

Clean up indentation.

svn path=/trunk/; revision=20521
2007-01-21 23:45:36 +00:00
Jaap Keuter 2375c0e96a Make fix for bug 771 compatible with GTK1
svn path=/trunk/; revision=20201
2006-12-22 20:09:09 +00:00
Jaap Keuter 46139edb6b From Florent Drouin:
Here is a patch for Bug 771.
It solves the problem of datalink header selection, when the interface has more than one.

svn path=/trunk/; revision=20186
2006-12-21 22:01:09 +00:00
Ulf Lamping fdfd0be5bd remove some warnings
svn path=/trunk/; revision=20116
2006-12-11 19:43:19 +00:00
Gerald Combs a980d04783 From Davide Schiera and Giorgio Tino: Add initial WPA/WPA2 decryption
support.

WEP key preferences have been overloaded to allow WPA keys.  The
decryption code currently uses Windows-specific data types, but can be
converted to use glib equivalents.

Add a few text and whitespace fixups.

svn path=/trunk/; revision=20049
2006-12-05 19:24:25 +00:00
Jörg Mayer dd26a7021b nikai@nikai.net:
Remaining fixes from:
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1225

svn path=/trunk/; revision=19895
2006-11-14 20:32:29 +00:00
Gerald Combs 2649d26145 Fix WEP key bug in the AirPcap code that could cause a crash. Enable
AirPcap by default. Add initial support for the "Any" device in AirPcap
(more to come).

svn path=/trunk/; revision=19401
2006-10-02 23:44:10 +00:00
Guy Harris b65c263be5 Get rid of unused variable.
svn path=/trunk/; revision=19039
2006-08-26 00:07:13 +00:00
Ulf Lamping 21d2ffaaa4 don't show the "Wireless Settings" button if HAVE_AIRPCAP isn't defined
svn path=/trunk/; revision=19031
2006-08-25 19:19:21 +00:00
Gerald Combs f9661850d1 Add support for AirPcap, an upcoming wireless product from CACE. Support
is disabled by default, and can be enabled by setting AIRPCAP_CONFIG
in config.nmake.  The code is currently limited to Windows, but should
be adaptable to other platforms.

The official announcement won't come until next week, so you'll have to
read the source for details.  :)

svn path=/trunk/; revision=18928
2006-08-16 18:01:25 +00:00
Anders Broman 05448fcc3d Ethereal->Wireshark
svn path=/trunk/; revision=18232
2006-05-28 17:19:08 +00:00
Guy Harris 92552c2d76 Get rid of a bunch of "Ethereal"s and "ethereal"s in comments, GUI
strings, and function names.

svn path=/trunk/; revision=18205
2006-05-22 07:29:40 +00:00
Ronnie Sahlberg 89f022b12b name change
svn path=/trunk/; revision=18197
2006-05-21 05:12:17 +00:00